[ovs-dev] [PATCH] python/ovs/poller.py: workaround an eventlet bug

2013-04-15 Thread YAMAMOTO Takashi
Signed-off-by: YAMAMOTO Takashi --- python/ovs/poller.py | 13 + 1 file changed, 13 insertions(+) diff --git a/python/ovs/poller.py b/python/ovs/poller.py index 7d15f3e..ffd6a39 100644 --- a/python/ovs/poller.py +++ b/python/ovs/poller.py @@ -18,6 +18,15 @@ import ovs.vlog import s

Re: [ovs-dev] [PATCH] sparse: Support recent distributions

2013-04-15 Thread Ben Pfaff
I misunderstood. Thanks, I'm happy with it as is then. On Apr 15, 2013 5:17 PM, "Andy Zhou" wrote: > This patch does the way you recommended already. > > > On Mon, Apr 15, 2013 at 1:00 PM, Ben Pfaff wrote: > >> On Fri, Apr 05, 2013 at 04:56:52PM -0700, Andy Zhou wrote: >> > sparse support seems

Re: [ovs-dev] [PATCH] sparse: Support recent distributions

2013-04-15 Thread Andy Zhou
This patch does the way you recommended already. On Mon, Apr 15, 2013 at 1:00 PM, Ben Pfaff wrote: > On Fri, Apr 05, 2013 at 04:56:52PM -0700, Andy Zhou wrote: > > sparse support seems to be broken on some recent Linux distributions. > > For example, ubuntu 12.04 with Linux 3.5 kernel, and Debi

Re: [ovs-dev] [PATCH net-next] openvswitch: Use generic struct pcpu_tstats.

2013-04-15 Thread Jesse Gross
On Mon, Apr 15, 2013 at 1:30 PM, Pravin B Shelar wrote: > Rather than defining ovs specific stats struct (vport_percpu_stats), > we can use existing pcpu_tstats to achieve exactly same functionality. > > Signed-off-by: Pravin B Shelar Also applied. ___

Re: [ovs-dev] [PATCH net-next] openvswitch: Simplify datapath locking.

2013-04-15 Thread Jesse Gross
On Mon, Apr 15, 2013 at 1:23 PM, Pravin B Shelar wrote: > Currently OVS uses combination of genl and rtnl lock to protect > datapath state. This was done due to networking stack locking. > But this has complicated locking and there are few lock ordering > issues with new tunneling protocols. > Fo

Re: [ovs-dev] [PATCH] list: Style fixes.

2013-04-15 Thread Ansis Atteka
Looks good. On Mon, Apr 15, 2013 at 2:48 PM, Ben Pfaff wrote: > Signed-off-by: Ben Pfaff > --- > lib/list.c |8 +--- > 1 files changed, 5 insertions(+), 3 deletions(-) > > diff --git a/lib/list.c b/lib/list.c > index fd06b81..227546e 100644 > --- a/lib/list.c > +++ b/lib/list.c > @@ -

[ovs-dev] [PATCH] list: Style fixes.

2013-04-15 Thread Ben Pfaff
Signed-off-by: Ben Pfaff --- lib/list.c |8 +--- 1 files changed, 5 insertions(+), 3 deletions(-) diff --git a/lib/list.c b/lib/list.c index fd06b81..227546e 100644 --- a/lib/list.c +++ b/lib/list.c @@ -1,5 +1,5 @@ /* - * Copyright (c) 2008, 2009, 2010, 2011, 2012 Nicira, Inc. + * Copyr

Re: [ovs-dev] [PATCH v2] datapath: Fix stale comment in flow.c.

2013-04-15 Thread Jesse Gross
On Mon, Apr 15, 2013 at 11:32 AM, Pravin B Shelar wrote: > Signed-off-by: Pravin B Shelar Acked-by: Jesse Gross ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

[ovs-dev] [PATCH] Correctly implement the OpenFlow 1.2+ OXM_OF_IP_DSCP field.

2013-04-15 Thread Ben Pfaff
NXM puts the DSCP value in bits 2-7 of NXM_OF_IP_TOS. OXM puts the DSCP value in bits 0-6 of OXM_OF_IP_DSCP. Before this commit, Open vSwitch incorrectly implemented OXM_OF_IP_DSCP with the same format as NXM_OF_IP_TOS. This commit fixes the problem and adds a test (previously missing but I don't

[ovs-dev] [PATCH net-next] openvswitch: Use generic struct pcpu_tstats.

2013-04-15 Thread Pravin B Shelar
Rather than defining ovs specific stats struct (vport_percpu_stats), we can use existing pcpu_tstats to achieve exactly same functionality. Signed-off-by: Pravin B Shelar --- net/openvswitch/vport.c | 22 +++--- net/openvswitch/vport.h | 11 ++- 2 files changed, 13 in

[ovs-dev] [PATCH net-next] openvswitch: Simplify datapath locking.

2013-04-15 Thread Pravin B Shelar
Currently OVS uses combination of genl and rtnl lock to protect datapath state. This was done due to networking stack locking. But this has complicated locking and there are few lock ordering issues with new tunneling protocols. Following patch simplifies locking by introducing new ovs mutex and n

Re: [ovs-dev] [PATCH v2 1/2] rhel: Remove the firewall hole that we create for GRE.

2013-04-15 Thread Ben Pfaff
On Mon, Apr 15, 2013 at 11:12:53AM -0700, Gurucharan Shetty wrote: > Till now, by default, we add firewall holes for > gre traffic. There may be users that do not use GRE tunnels > and they may be surprised with this behavior. So, don't add > the firewall rules by default and update the documentati

Re: [ovs-dev] [PATCH] sparse: Support recent distributions

2013-04-15 Thread Ben Pfaff
On Fri, Apr 05, 2013 at 04:56:52PM -0700, Andy Zhou wrote: > sparse support seems to be broken on some recent Linux distributions. > For example, ubuntu 12.04 with Linux 3.5 kernel, and Debian latest test > distribution, running Linux 3.2 kernel. > > On both systems that sparse was broken, It was

[ovs-dev] [PATCH v2 1/2] rhel: Remove the firewall hole that we create for GRE.

2013-04-15 Thread Gurucharan Shetty
Till now, by default, we add firewall holes for gre traffic. There may be users that do not use GRE tunnels and they may be surprised with this behavior. So, don't add the firewall rules by default and update the documentation to mention the same. This patch does not remove the default GRE firewal

[ovs-dev] [PATCH v2 2/2] INSTALL.XenServer: Add a note for tunnel firewall rules.

2013-04-15 Thread Gurucharan Shetty
Signed-off-by: Gurucharan Shetty --- INSTALL.XenServer | 13 - 1 file changed, 12 insertions(+), 1 deletion(-) diff --git a/INSTALL.XenServer b/INSTALL.XenServer index 7a4dd76..e31788a 100644 --- a/INSTALL.XenServer +++ b/INSTALL.XenServer @@ -158,7 +158,10 @@ command. The plugin

[ovs-dev] [PATCH v2] datapath: Fix stale comment in flow.c.

2013-04-15 Thread Pravin B Shelar
Signed-off-by: Pravin B Shelar --- datapath/flow.c |6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git a/datapath/flow.c b/datapath/flow.c index 841e8be..dce237e 100644 --- a/datapath/flow.c +++ b/datapath/flow.c @@ -1265,9 +1265,9 @@ int ovs_flow_from_nlattrs(struct sw_fl

Re: [ovs-dev] [PATCH 1/2] INSTALL.XenServer, INSTALL.RHEL: Add a note for tunnel firewall rules.

2013-04-15 Thread Lori Jakab
The wording looks good to me, thanks! On 04/15/2013 08:18 PM, Gurucharan Shetty wrote: > Signed-off-by: Gurucharan Shetty > --- > INSTALL.RHEL |6 ++ > INSTALL.XenServer | 13 - > 2 files changed, 18 insertions(+), 1 deletion(-) > > diff --git a/INSTALL.RHEL b/INSTALL

Re: [ovs-dev] [PATCH 1/2] INSTALL.XenServer, INSTALL.RHEL: Add a note for tunnel firewall rules.

2013-04-15 Thread Gurucharan Shetty
On Mon, Apr 15, 2013 at 11:07 AM, Ben Pfaff wrote: > On Mon, Apr 15, 2013 at 10:18:03AM -0700, Gurucharan Shetty wrote: > > Signed-off-by: Gurucharan Shetty > > It looks to me like these documentation updates are necessary as a > consequence of changes that we make in other commits. Usually it

Re: [ovs-dev] [PATCH 1/2] INSTALL.XenServer, INSTALL.RHEL: Add a note for tunnel firewall rules.

2013-04-15 Thread Ben Pfaff
On Mon, Apr 15, 2013 at 10:18:03AM -0700, Gurucharan Shetty wrote: > Signed-off-by: Gurucharan Shetty It looks to me like these documentation updates are necessary as a consequence of changes that we make in other commits. Usually it is better to do a code change and the corresponding documentat

[ovs-dev] [PATCH 2/2] NEWS: Add a note about the removal of GRE firewall rule in RHEL.

2013-04-15 Thread Gurucharan Shetty
Signed-off-by: Gurucharan Shetty --- NEWS |5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/NEWS b/NEWS index 39e6e5d..f23b366 100644 --- a/NEWS +++ b/NEWS @@ -13,7 +13,10 @@ post-v1.10.0 - ovs-dpctl: * New debugging commands "add-flow", "mod-flow", "del-flow"

[ovs-dev] [PATCH 1/2] INSTALL.XenServer, INSTALL.RHEL: Add a note for tunnel firewall rules.

2013-04-15 Thread Gurucharan Shetty
Signed-off-by: Gurucharan Shetty --- INSTALL.RHEL |6 ++ INSTALL.XenServer | 13 - 2 files changed, 18 insertions(+), 1 deletion(-) diff --git a/INSTALL.RHEL b/INSTALL.RHEL index eaa2e7c..a698fae 100644 --- a/INSTALL.RHEL +++ b/INSTALL.RHEL @@ -101,6 +101,12 @@ RHEL.

Re: [ovs-dev] [PATCH 2/2] rhel: Remove the firewall hole that we create for gre.

2013-04-15 Thread Ben Pfaff
On Mon, Apr 15, 2013 at 10:16:53AM -0700, Gurucharan Shetty wrote: > On Mon, Apr 15, 2013 at 3:42 AM, Lori Jakab wrote: > > > On 04/13/2013 12:53 AM, Ben Pfaff wrote: > > > On Fri, Apr 12, 2013 at 01:50:43PM -0700, Gurucharan Shetty wrote: > > >> Till now, by default, we add firewall holes for >

Re: [ovs-dev] [PATCH v2 1/1] debian: build with debugging symbol

2013-04-15 Thread Ben Pfaff
On Mon, Apr 15, 2013 at 02:54:10AM -0400, Zang MingJie wrote: > > Signed-off-by: Zang MingJie Thanks, applied to master. ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

Re: [ovs-dev] [PATCH 2/2] rhel: Remove the firewall hole that we create for gre.

2013-04-15 Thread Gurucharan Shetty
On Mon, Apr 15, 2013 at 3:42 AM, Lori Jakab wrote: > On 04/13/2013 12:53 AM, Ben Pfaff wrote: > > On Fri, Apr 12, 2013 at 01:50:43PM -0700, Gurucharan Shetty wrote: > >> Till now, by default, we add firewall holes for > >> gre traffic. There may be users that do not use gre tunnels > >> and they

Re: [ovs-dev] [PATCH 1/1] [branch-1.4] [ofproto-dpif] Memory leak at specific PACKET_INs

2013-04-15 Thread Ben Pfaff
On Mon, Apr 15, 2013 at 03:59:52PM +0100, Zoltan Kiss wrote: > When the packet is sent to the controller due to an userspace rule (and not > a kernel-space flow), execute_controller_action is invoked with clone=true, > so handle_flow_miss retains ownership of the packet buffer. But if it returns >

[ovs-dev] [PATCH 1/1] [branch-1.4] [ofproto-dpif] Memory leak at specific PACKET_INs

2013-04-15 Thread Zoltan Kiss
When the packet is sent to the controller due to an userspace rule (and not a kernel-space flow), execute_controller_action is invoked with clone=true, so handle_flow_miss retains ownership of the packet buffer. But if it returns true (which means the packet had only a PACKET_IN action), nothing fr

Re: [ovs-dev] [PATCH] INSTALL: Admit that only GNU make works.

2013-04-15 Thread Ed Maste
On 15 March 2013 17:30, Ben Pfaff wrote: > I promised some time ago to take a look at fixing the behavior of the > Makefiles with non-GNU make, but it doesn't realistically seem that I will. > Thanks. Even if we addressed the current issues I wouldn't be surprised to find new failures appearing

Re: [ovs-dev] [PATCH 2/2] rhel: Remove the firewall hole that we create for gre.

2013-04-15 Thread Lori Jakab
On 04/13/2013 12:53 AM, Ben Pfaff wrote: > On Fri, Apr 12, 2013 at 01:50:43PM -0700, Gurucharan Shetty wrote: >> Till now, by default, we add firewall holes for >> gre traffic. There may be users that do not use gre tunnels >> and they may be surprised with this behavior. > > It would be nice to a