Re: [ovs-dev] [RFC PATCH 4/4] Add packet recirculation

2013-04-03 Thread Simon Horman
On Wed, Apr 03, 2013 at 05:55:46PM -0700, Jesse Gross wrote: > On Wed, Apr 3, 2013 at 5:24 PM, Simon Horman wrote: > > On Wed, Apr 03, 2013 at 01:29:53PM -0700, Jesse Gross wrote: > >> On Wed, Apr 3, 2013 at 6:05 AM, Simon Horman wrote: > >> > On Wed, Apr 03, 2013 at 10:59:11AM +0900, Simon Horma

Re: [ovs-dev] [PATCH 3/3] tests: Avoid race conditions, by letting the kernel choose ports to bind.

2013-04-03 Thread Ben Pfaff
On Wed, Apr 03, 2013 at 05:01:40PM -0700, Neil Mckee wrote: > "parse-listening-port" seems to return the port that the server was > told to listen on(?) Yes, it returns the port that the server is listening on. > But that bears no relation to the UDP port that sFlow or NetFlow might > be sent o

Re: [ovs-dev] [RFC PATCH 4/4] Add packet recirculation

2013-04-03 Thread Jesse Gross
On Wed, Apr 3, 2013 at 5:24 PM, Simon Horman wrote: > On Wed, Apr 03, 2013 at 01:29:53PM -0700, Jesse Gross wrote: >> On Wed, Apr 3, 2013 at 6:05 AM, Simon Horman wrote: >> > On Wed, Apr 03, 2013 at 10:59:11AM +0900, Simon Horman wrote: >> >> On Tue, Apr 02, 2013 at 05:24:40PM -0700, Jesse Gross

Re: [ovs-dev] [PATCH v2] MPLS: Add limited GSO support

2013-04-03 Thread Simon Horman
On Wed, Apr 03, 2013 at 05:44:17PM -0700, Jesse Gross wrote: > On Wed, Apr 3, 2013 at 5:28 PM, Simon Horman wrote: > > On Wed, Apr 03, 2013 at 04:51:38PM -0700, Jesse Gross wrote: > >> On Wed, Apr 3, 2013 at 2:11 AM, Simon Horman wrote: > >> > In the case where a non-MPLS packet is recieved and a

Re: [ovs-dev] [PATCH v2] MPLS: Add limited GSO support

2013-04-03 Thread Jesse Gross
On Wed, Apr 3, 2013 at 5:28 PM, Simon Horman wrote: > On Wed, Apr 03, 2013 at 04:51:38PM -0700, Jesse Gross wrote: >> On Wed, Apr 3, 2013 at 2:11 AM, Simon Horman wrote: >> > In the case where a non-MPLS packet is recieved and an MPLS stack is >> > added it may well be the case that the original

Re: [ovs-dev] [PATCH v2] MPLS: Add limited GSO support

2013-04-03 Thread Simon Horman
On Wed, Apr 03, 2013 at 04:51:38PM -0700, Jesse Gross wrote: > On Wed, Apr 3, 2013 at 2:11 AM, Simon Horman wrote: > > In the case where a non-MPLS packet is recieved and an MPLS stack is > > added it may well be the case that the original skb is GSO but the > > NIC used for transmit does not supp

Re: [ovs-dev] [RFC PATCH 4/4] Add packet recirculation

2013-04-03 Thread Simon Horman
On Wed, Apr 03, 2013 at 01:29:53PM -0700, Jesse Gross wrote: > On Wed, Apr 3, 2013 at 6:05 AM, Simon Horman wrote: > > On Wed, Apr 03, 2013 at 10:59:11AM +0900, Simon Horman wrote: > >> On Tue, Apr 02, 2013 at 05:24:40PM -0700, Jesse Gross wrote: > >> > On Fri, Mar 22, 2013 at 6:44 AM, Simon Horma

Re: [ovs-dev] [PATCH] MPLS: Add limited GSO support

2013-04-03 Thread Simon Horman
On Wed, Apr 03, 2013 at 04:59:40PM +0100, Ben Hutchings wrote: > I don't know anything about MPLS so this is a pretty superficial review. > > On Wed, 2013-04-03 at 14:24 +0900, Simon Horman wrote: > [...] > > --- a/include/linux/netdev_features.h > > +++ b/include/linux/netdev_features.h > > @@ -4

Re: [ovs-dev] [PATCH v2] MPLS: Add limited GSO support

2013-04-03 Thread Jesse Gross
On Wed, Apr 3, 2013 at 2:11 AM, Simon Horman wrote: > In the case where a non-MPLS packet is recieved and an MPLS stack is > added it may well be the case that the original skb is GSO but the > NIC used for transmit does not support GSO of MPLS packets. > > The aim of this code is to provide GSO i

Re: [ovs-dev] [PATCH 3/3] tests: Avoid race conditions, by letting the kernel choose ports to bind.

2013-04-03 Thread Ben Pfaff
I didn't notice that, but this commit actually removes choose-port.pl entirely so it presumably fixes that problem? I'll add a note to the commit message to mention that it fixes that problem too. On Wed, Apr 03, 2013 at 01:56:03PM -0700, Neil Mckee wrote: > You probably noticed this, but choose-

Re: [ovs-dev] [PATCH 3/3] tests: Avoid race conditions, by letting the kernel choose ports to bind.

2013-04-03 Thread Neil Mckee
You probably noticed this, but choose-port.pl is sometimes being used to return a free TCP port which is promptly used for UDP. Perhaps choose-port.pl should take an argument? Neil On Apr 3, 2013, at 12:02 PM, Ben Pfaff wrote: > An occasionally occurring problem with "make check", espec

Re: [ovs-dev] [RFC PATCH 4/4] Add packet recirculation

2013-04-03 Thread Jesse Gross
On Wed, Apr 3, 2013 at 6:05 AM, Simon Horman wrote: > On Wed, Apr 03, 2013 at 10:59:11AM +0900, Simon Horman wrote: >> On Tue, Apr 02, 2013 at 05:24:40PM -0700, Jesse Gross wrote: >> > On Fri, Mar 22, 2013 at 6:44 AM, Simon Horman wrote: >> > > On Tue, Mar 19, 2013 at 09:01:27AM -0700, Jesse Gros

Re: [ovs-dev] [PATCH net-next] openvswitch: Provide OVS_DP_ATTR_UPCALL_PID in datapath messages

2013-04-03 Thread Jesse Gross
On Wed, Apr 3, 2013 at 12:33 AM, Thomas Graf wrote: > On 04/02/13 at 04:30pm, Jesse Gross wrote: >> Can you describe the race condition some more? The kernel doesn't >> change the port ID on its own so even needing to request the value >> seems rare. > > The upcall nlport is changeable with OVS_V

[ovs-dev] [PATCH 1/3] tests: Make test-netflow, test-sflow accept all logging options.

2013-04-03 Thread Ben Pfaff
An upcoming patch will start using the --log-file option with these test programs, so they need to support it. Signed-off-by: Ben Pfaff --- tests/test-netflow.c | 12 +--- tests/test-sflow.c | 13 ++--- 2 files changed, 11 insertions(+), 14 deletions(-) diff --git a/tests/

[ovs-dev] [PATCH 0/3] Fix race conditions in choosing TCP ports in tests

2013-04-03 Thread Ben Pfaff
I've seen a number of test failures for this reason lately, so I've decided to finally fix the problem for real. Ben Pfaff (3): tests: Make test-netflow, test-sflow accept all logging options. socket-util: Log kernel-chosen bound ports in inet_open_passive(). tests: Avoid race conditions, by

[ovs-dev] [PATCH 3/3] tests: Avoid race conditions, by letting the kernel choose ports to bind.

2013-04-03 Thread Ben Pfaff
An occasionally occurring problem with "make check", especially when parallel tests are enabled, is that multiple tests try to bind the same TCP port and, of course, fail. This happens because the code to select a TCP port to bind just generates random numbers until it finds a port that is not cur

[ovs-dev] [PATCH 2/3] socket-util: Log kernel-chosen bound ports in inet_open_passive().

2013-04-03 Thread Ben Pfaff
Usually, for passive sockets, one wishes to bind a particular well-known port, so that clients can easily connect. But automated tests cannot necessarily bind a well-known port, because that would cause multiple concurrent tests to interfere with each other or with a real instance of the service r

[ovs-dev] [PATCH] vlog: extend syslog format to make OVS logs easier to filter

2013-04-03 Thread Romain Lenglet
Prepend "ovs|" to syslog logs to make them easier to filter out of all LOG_DAEMON logs. Signed-off-by: Romain Lenglet --- NEWS | 1 + lib/vlog.h | 2 +- python/ovs/vlog.py | 2 +- 3 files changed, 3 insertions(+), 2 deletions(-) diff --git a/NEWS b/NEWS index cbbe06b..39e6

Re: [ovs-dev] [PATCH] MPLS: Add limited GSO support

2013-04-03 Thread Ben Hutchings
I don't know anything about MPLS so this is a pretty superficial review. On Wed, 2013-04-03 at 14:24 +0900, Simon Horman wrote: [...] > --- a/include/linux/netdev_features.h > +++ b/include/linux/netdev_features.h > @@ -43,6 +43,7 @@ enum { > NETIF_F_FSO_BIT,/* ... FCoE segme

Re: [ovs-dev] request for review: protection against kernel flow trashing

2013-04-03 Thread George Shuklin
03.04.2013 18:48, Jesse Gross пишет: On Wed, Apr 3, 2013 at 6:29 AM, George Shuklin wrote: If it's possible I'd like to hear comments on these changes. Thanks. I'm not sure what you're hoping to hear. The solution is obviously specific to your situation and not something that we can apply. I'

Re: [ovs-dev] request for review: protection against kernel flow trashing

2013-04-03 Thread Jesse Gross
On Wed, Apr 3, 2013 at 6:29 AM, George Shuklin wrote: > Good day. > > Few weeks ago I have reported a serious flaw in OVS: specially crafted flood > or even a legal traffic with a large number of tcp connections from > different sources can cause a denial of service. > > Initially I thought it's s

[ovs-dev] request for review: protection against kernel flow trashing

2013-04-03 Thread George Shuklin
Good day. Few weeks ago I have reported a serious flaw in OVS: specially crafted flood or even a legal traffic with a large number of tcp connections from different sources can cause a denial of service. Initially I thought it's somehow caused by 'slow' normal mode rules, but further researc

[ovs-dev] [PATCH/RFCv3] Add packet recirculation

2013-04-03 Thread Simon Horman
Recirculation is a technique to allow a frame to re-enter frame processing. This is intended to be used after actions have been applied to the frame with modify the frame in some way that makes it possible for richer processing to occur. An example is and indeed targeted use case is MPLS. If an MP

Re: [ovs-dev] [RFC PATCH 4/4] Add packet recirculation

2013-04-03 Thread Simon Horman
On Wed, Apr 03, 2013 at 10:59:11AM +0900, Simon Horman wrote: > On Tue, Apr 02, 2013 at 05:24:40PM -0700, Jesse Gross wrote: > > On Fri, Mar 22, 2013 at 6:44 AM, Simon Horman wrote: > > > On Tue, Mar 19, 2013 at 09:01:27AM -0700, Jesse Gross wrote: > > >> On Mon, Mar 18, 2013 at 6:34 PM, Simon Hor

Re: [ovs-dev] [PATCH] tests/lacp.at: Fix comment.

2013-04-03 Thread Ben Pfaff
On Tue, Apr 02, 2013 at 04:52:43PM +0300, Jarno Rajahalme wrote: > Fix residue from an earlier patch. > > Signed-off-by: Jarno Rajahalme Applied, thanks. ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

[ovs-dev] [PATCH v2] MPLS: Add limited GSO support

2013-04-03 Thread Simon Horman
In the case where a non-MPLS packet is recieved and an MPLS stack is added it may well be the case that the original skb is GSO but the NIC used for transmit does not support GSO of MPLS packets. The aim of this code is to provide GSO in software for MPLS packets whose skbs are GSO. When an imple

[ovs-dev] Здравствуйте

2013-04-03 Thread Irina Erina
Здравствуйте. Заинтересованы предложить Вам принять участие в партнерской программе по показу рекламных материалов на Вашем интренет-ресурсе openvswitch.org. Готовы в самое короткое время предоставить необходимую информацию на все актуальные для Вас вопросы. Пожалуйста,сохраняйте текст,исход

Re: [ovs-dev] [PATCH net-next] openvswitch: Provide OVS_DP_ATTR_UPCALL_PID in datapath messages

2013-04-03 Thread Thomas Graf
On 04/02/13 at 04:30pm, Jesse Gross wrote: > Can you describe the race condition some more? The kernel doesn't > change the port ID on its own so even needing to request the value > seems rare. The upcall nlport is changeable with OVS_VPORT_CMD_SET and may be received between the OVS_DP_CMD_GET a

Re: [ovs-dev] [PATCH] MPLS: Add limited GSO support

2013-04-03 Thread Simon Horman
On Wed, Apr 03, 2013 at 06:36:29AM +, Rajahalme, Jarno (NSN - FI/Espoo) wrote: > > On Apr 3, 2013, at 8:24 , ext Simon Horman wrote: > > > In the case where a non-MPLS packet is recieved and an MPLS stack is > > added it may well be the case that the original skb is GSO but the > > NIC used