[ovs-dev] [PATCH] rhel: Add depmod.d conf file for rhel6 kmod package.

2013-03-30 Thread Gurucharan Shetty
It looks like for Centos6.4, there is an upstream openvswitch kernel module already installed. When we try to install kmod-openvswitch package from this tree's pre-1.10 branches, we get the following warning: "brcompat.ko needs unknown symbol ovs_dp_ioctl_hook". Also, after installing the kmod-ope

Re: [ovs-dev] [patch net-next] net: squash ->rx_handler and ->rx_handler_data into single rcu pointer

2013-03-30 Thread Eric Dumazet
On Sat, 2013-03-30 at 12:31 -0700, Eric Dumazet wrote: > By the way, only dev->rx_handler needs to be RCU protected. > > The patch send yesterday make the second rcu_dereference() (to get > rx_handler_data) totally irrelevant. I'll send patch when yesterday fix is merged into net-next. ___

Re: [ovs-dev] [patch net-next] net: squash ->rx_handler and ->rx_handler_data into single rcu pointer

2013-03-30 Thread Jiri Pirko
Sat, Mar 30, 2013 at 08:24:04PM CET, rost...@goodmis.org wrote: > > >Jiri Pirko wrote: > >>No need to have two pointers in struct netdevice for rx_handler func >>and >>priv data. Just embed rx_handler structure into driver port_priv and >>have ->func pointer there. This introduces no performance p

Re: [ovs-dev] [patch net-next] net: squash ->rx_handler and ->rx_handler_data into single rcu pointer

2013-03-30 Thread Eric Dumazet
On Sat, 2013-03-30 at 12:28 -0700, Eric Dumazet wrote: > On Sat, 2013-03-30 at 18:13 +0100, Jiri Pirko wrote: > > > Well, not entirely true, depends on arch. > > > > Are you really trying to obfuscate stack because of Alpha architecture ? By the way, only dev->rx_handler needs to be RCU protec

Re: [ovs-dev] [patch net-next] net: squash ->rx_handler and ->rx_handler_data into single rcu pointer

2013-03-30 Thread Eric Dumazet
On Sat, 2013-03-30 at 18:13 +0100, Jiri Pirko wrote: > Well, not entirely true, depends on arch. > Are you really trying to obfuscate stack because of Alpha architecture ? Really, a bit of stability in this code is welcome. Lets fix existing bugs instead of possibly add new ones. __

Re: [ovs-dev] [patch net-next] net: squash ->rx_handler and ->rx_handler_data into single rcu pointer

2013-03-30 Thread Steven Rostedt
Jiri Pirko wrote: >No need to have two pointers in struct netdevice for rx_handler func >and >priv data. Just embed rx_handler structure into driver port_priv and >have ->func pointer there. This introduces no performance penalty, >reduces struct netdevice by one pointer and reduces number of n

Re: [ovs-dev] ovs-vswitchd hang in sendmsg

2013-03-30 Thread Jesse Gross
On Fri, Mar 29, 2013 at 11:36 PM, Tianpeng Zhang (Gmail) wrote: > Yes, from following trace, DRBD and OVS block each other and enter into > deadlock. > It seems someone sent a patch years ago to refine genl global lock as family > granularity. So change the DRBD or OVS's genl family to different o

Re: [ovs-dev] [patch net-next] net: squash ->rx_handler and ->rx_handler_data into single rcu pointer

2013-03-30 Thread Jiri Pirko
Sat, Mar 30, 2013 at 05:23:08PM CET, eric.duma...@gmail.com wrote: >On Sat, 2013-03-30 at 16:57 +0100, Jiri Pirko wrote: >> No need to have two pointers in struct netdevice for rx_handler func and >> priv data. Just embed rx_handler structure into driver port_priv and >> have ->func pointer there.

Re: [ovs-dev] [patch net-next] net: squash ->rx_handler and ->rx_handler_data into single rcu pointer

2013-03-30 Thread Eric Dumazet
On Sat, 2013-03-30 at 16:57 +0100, Jiri Pirko wrote: > No need to have two pointers in struct netdevice for rx_handler func and > priv data. Just embed rx_handler structure into driver port_priv and > have ->func pointer there. This introduces no performance penalty, > reduces struct netdevice by o

[ovs-dev] [PATCH net-next 7/7] vxlan: export vxlan header length.

2013-03-30 Thread Pravin B Shelar
openvswitch needs vxlan header len. Signed-off-by: Pravin B Shelar --- drivers/net/vxlan.c |6 -- include/net/vxlan.h |8 2 files changed, 8 insertions(+), 6 deletions(-) diff --git a/drivers/net/vxlan.c b/drivers/net/vxlan.c index 11c1f69..3fc999e 100644 --- a/drivers/net/

[ovs-dev] [PATCH net-next 6/7] vxlan: export vxlan_build_header() function.

2013-03-30 Thread Pravin B Shelar
This is used by openvswitch for building vxlan packet. Signed-off-by: Pravin B Shelar --- drivers/net/vxlan.c | 72 +++--- include/net/vxlan.h |3 ++ 2 files changed, 48 insertions(+), 27 deletions(-) diff --git a/drivers/net/vxlan.c b/drivers/n

[ovs-dev] [PATCH net-next 5/7] vxlan: export tunnel_src_port() function.

2013-03-30 Thread Pravin B Shelar
openvswitch needs this function tunnel_src_port() to generate udp source port number for vxlan packet. Signed-off-by: Pravin B Shelar --- drivers/net/vxlan.c | 20 +--- include/net/ip_tunnels.h |1 + net/ipv4/ip_tunnel.c | 19 +++ 3 files changed,

[ovs-dev] [PATCH net-next 4/7] vxlan: Add vxlan protocol handler.

2013-03-30 Thread Pravin B Shelar
Add vxlan multiplexer for vxlan packet handler. This is required for openvswitch vxlan support. Signed-off-by: Pravin B Shelar --- drivers/net/vxlan.c | 208 ++- include/net/vxlan.h | 17 2 files changed, 172 insertions(+), 53 deletions(-)

[ovs-dev] [PATCH net-next 3/7] GRE: export gre_handle_offloads() function.

2013-03-30 Thread Pravin B Shelar
This is required for OVS GRE offloading. Signed-off-by: Pravin B Shelar --- include/net/gre.h |1 + net/ipv4/gre.c| 29 + net/ipv4/ip_gre.c | 34 ++ 3 files changed, 32 insertions(+), 32 deletions(-) diff --git a/include/ne

[ovs-dev] [PATCH net-next 2/7] GRE: export gre_build_header() function.

2013-03-30 Thread Pravin B Shelar
This is required for ovs gre module. Signed-off-by: Pravin B Shelar --- include/net/gre.h |2 ++ net/ipv4/gre.c| 32 net/ipv4/ip_gre.c | 41 + 3 files changed, 35 insertions(+), 40 deletions(-) diff --git a/inc

[ovs-dev] [PATCH net-next 1/7] GRE: Extend GRE registration for GRE-CISCO protocol.

2013-03-30 Thread Pravin B Shelar
Currently gre modules allows one handler per GRE protocol. Following patch extend gre module registration by adding api to register multiple handler for GRE protocol. This allows OVS and linux gre devices co-exist at same time. Signed-off-by: Pravin B Shelar --- include/net/gre.h | 24 ++

[ovs-dev] [PATCH net-next 0/7] tunneling: Extend tunneling interface for Openvswitch.

2013-03-30 Thread Pravin B Shelar
Following patches add functions to kernel tunneling modules so that there is better code sharing between OVS and kernel netdevice based tunneling. functions are added for protocol demultiplexer and for building packer for sending it over tunnel. Pravin B Shelar (7): GRE: Extend GRE registration

[ovs-dev] [patch net-next] net: squash ->rx_handler and ->rx_handler_data into single rcu pointer

2013-03-30 Thread Jiri Pirko
No need to have two pointers in struct netdevice for rx_handler func and priv data. Just embed rx_handler structure into driver port_priv and have ->func pointer there. This introduces no performance penalty, reduces struct netdevice by one pointer and reduces number of needed rcu_dereference calls