Re: [ovs-dev] [RFC PATCH 4/4] Add packet recirculation

2013-03-22 Thread Simon Horman
On Fri, Mar 22, 2013 at 10:44:23PM +0900, Simon Horman wrote: > On Tue, Mar 19, 2013 at 09:01:27AM -0700, Jesse Gross wrote: > > On Mon, Mar 18, 2013 at 6:34 PM, Simon Horman wrote: > > > On Mon, Mar 18, 2013 at 01:49:43PM -0700, Jesse Gross wrote: > > >> However, do we actually want to tie this d

Re: [ovs-dev] [PATCH] odp-util: Promote skb_mark in flow_key

2013-03-22 Thread Simon Horman
On Sat, Mar 23, 2013 at 12:24:42PM +0900, Simon Horman wrote: > On Fri, Mar 22, 2013 at 08:50:24AM -0700, Ben Pfaff wrote: > > On Fri, Mar 22, 2013 at 10:45:27PM +0900, Simon Horman wrote: > > > Re-order skb_mark in odp_flow_key_from_flow() so that it appears after the > > > in_port rather than bef

Re: [ovs-dev] [PATCH] odp-util: Promote skb_mark in flow_key

2013-03-22 Thread Simon Horman
On Fri, Mar 22, 2013 at 08:50:24AM -0700, Ben Pfaff wrote: > On Fri, Mar 22, 2013 at 10:45:27PM +0900, Simon Horman wrote: > > Re-order skb_mark in odp_flow_key_from_flow() so that it appears after the > > in_port rather than before. This is consistent with the order in > > ovs_flow_to_nlattrs(). >

[ovs-dev] [PATCH] odp-utils: Fix memory corruption while flow parsing.

2013-03-22 Thread Gurucharan Shetty
Currently, when flow attribute type is greater than OVS_KEY_ATTR_MAX, we can write into a random memory address causing corruption. Fix it. Bug #15702. Signed-off-by: Gurucharan Shetty --- lib/odp-util.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/odp-util.c b/lib/

[ovs-dev] [PATCH] ofproto-dpif: Keep track of exact-match flow info

2013-03-22 Thread Andy Zhou
This patch adds more flow related stats to the output of "ovs-appctl dpif/show". Specifically, the follow information are added per ofproto: - Max flow table size - Average flow table size - Average flow table add rate - Average flow table delete rate - Average flow entry life in milliseconds Fe

Re: [ovs-dev] [PATCH] ofproto-dpif: Keep track of exact-match flow info

2013-03-22 Thread Andy Zhou
Ben, Thanks for the review. I will send out the patch again after fixing all issues you mentioned in the review. On Fri, Mar 22, 2013 at 12:51 PM, Ben Pfaff wrote: > On Mon, Mar 18, 2013 at 05:28:04PM -0700, Andy Zhou wrote: > > This patch adds more flow related stats to the output of > > "ovs-

Re: [ovs-dev] [netdev 2/6] netdev: Remove netdev_is_open(), which has no users.

2013-03-22 Thread Ethan Jackson
Acked-by: Ethan Jackson On Fri, Mar 15, 2013 at 3:55 PM, Ben Pfaff wrote: > Signed-off-by: Ben Pfaff > --- > lib/netdev.c |8 > lib/netdev.h |2 -- > 2 files changed, 0 insertions(+), 10 deletions(-) > > diff --git a/lib/netdev.c b/lib/netdev.c > index 77080ea..156984a 1006

Re: [ovs-dev] [netdev 1/6] netdev: Remove netdev_exists(), which has no users.

2013-03-22 Thread Ethan Jackson
Acked-by: Ethan Jackson On Fri, Mar 15, 2013 at 3:55 PM, Ben Pfaff wrote: > Signed-off-by: Ben Pfaff > --- > lib/netdev.c | 21 - > lib/netdev.h |1 - > 2 files changed, 0 insertions(+), 22 deletions(-) > > diff --git a/lib/netdev.c b/lib/netdev.c > index e338d7c..

Re: [ovs-dev] [PATCH] (V2) build-aux: compliance with python 3

2013-03-22 Thread Ben Pfaff
On Fri, Mar 22, 2013 at 07:48:15PM +0100, Damien Millescamps wrote: > extract-ofp-errors doesn't work with python 3 for the > following reasons: > > - several "SyntaxError: invalid syntax": > print not a keyword anymore. As a function it requires '()' > - AttributeError: 'dict' object has no att

Re: [ovs-dev] [PATCH] FAQ: Explain why VMs on a VLAN can't access the Internet.

2013-03-22 Thread Ben Pfaff
On Fri, Mar 22, 2013 at 04:17:03PM +, Kyle Mestery (kmestery) wrote: > > On Mar 21, 2013, at 5:26 PM, Ben Pfaff wrote: > > > Signed-off-by: Ben Pfaff > > --- > > FAQ | 14 ++ > > 1 file changed, 14 insertions(+) > > > > diff --git a/FAQ b/FAQ > > index 90d0003..d9224fa 100644

Re: [ovs-dev] [PATCH] ofproto-dpif: Keep track of exact-match flow info

2013-03-22 Thread Ben Pfaff
On Mon, Mar 18, 2013 at 05:28:04PM -0700, Andy Zhou wrote: > This patch adds more flow related stats to the output of > "ovs-appctl dpif/show". Specifically, the follow information > are added per ofproto: > > - Max flow table size > - Average flow table size > - Average flow table add rate > - A

Re: [ovs-dev] [PATCH] automake: ofp-errors.inc is generated inside srcdir

2013-03-22 Thread Ben Pfaff
On Fri, Mar 22, 2013 at 05:39:22PM +0100, Damien Millescamps wrote: > On 03/22/2013 05:01 PM, Ben Pfaff wrote: > > This is about Automake, not Autoconf. > > Rules that update the source directory are appropriate to update files > > that are distributed. If you disagree, then feel free to report a

Re: [ovs-dev] [PATCH] FAQ: Explain why VMs on a VLAN can't access the Internet.

2013-03-22 Thread Kyle Mestery (kmestery)
On Mar 21, 2013, at 5:26 PM, Ben Pfaff wrote: > Signed-off-by: Ben Pfaff > --- > FAQ | 14 ++ > 1 file changed, 14 insertions(+) > > diff --git a/FAQ b/FAQ > index 90d0003..d9224fa 100644 > --- a/FAQ > +++ b/FAQ > @@ -714,6 +714,20 @@ A: It is to be expected that the VMs can't acc

Re: [ovs-dev] [PATCH] automake: ofp-errors.inc is generated inside srcdir

2013-03-22 Thread Ben Pfaff
On Fri, Mar 22, 2013 at 04:46:52PM +0100, Damien Millescamps wrote: > On 03/21/2013 08:44 PM, Ben Pfaff wrote: > > On Thu, Mar 21, 2013 at 10:52:37AM +0100, Damien Millescamps wrote: > >> On 03/20/2013 10:20 PM, Ben Pfaff wrote: > > The straightforward solution is to use a writable source directory

[ovs-dev] Promotion gift-keychain Supply与您共享了相册。

2013-03-22 Thread Promotion gift-keychain Supply
Dear Sir, How are you ! That"s "promotion gif Ltd" , a 14 years factory experience at local, it is famous with good quality & resonlable price. We are mainly produce promotion gift, such as:keychain;card holder;purse hanger and other kinds fancy gifts. OEM & customize logo are acceptable.

Re: [ovs-dev] [PATCH] odp-util: Promote skb_mark in flow_key

2013-03-22 Thread Ben Pfaff
On Fri, Mar 22, 2013 at 10:45:27PM +0900, Simon Horman wrote: > Re-order skb_mark in odp_flow_key_from_flow() so that it appears after the > in_port rather than before. This is consistent with the order in > ovs_flow_to_nlattrs(). > > Without this change update_stats() detects all flows with a non

Re: [ovs-dev] [PATCH] net: add ETH_P_802_3_MIN

2013-03-22 Thread Simon Horman
On Thu, Mar 21, 2013 at 11:56:08AM -0400, David Miller wrote: > From: Simon Horman > Date: Thu, 21 Mar 2013 17:29:28 +0900 > > > Add a new constant ETH_P_802_3_MIN, the minimum ethernet type for > > an 802.3 frame. Frames with a lower value in the ethernet type field > > are Ethernet II. > > > >

[ovs-dev] [PATCH] odp-util: Promote skb_mark in flow_key

2013-03-22 Thread Simon Horman
Re-order skb_mark in odp_flow_key_from_flow() so that it appears after the in_port rather than before. This is consistent with the order in ovs_flow_to_nlattrs(). Without this change update_stats() detects all flows with a non-zero skb_mark as unexpected flows as the flow key received from the ker

Re: [ovs-dev] [RFC PATCH 4/4] Add packet recirculation

2013-03-22 Thread Simon Horman
On Tue, Mar 19, 2013 at 09:01:27AM -0700, Jesse Gross wrote: > On Mon, Mar 18, 2013 at 6:34 PM, Simon Horman wrote: > > On Mon, Mar 18, 2013 at 01:49:43PM -0700, Jesse Gross wrote: > >> However, do we actually want to tie this directly to recirculation as > >> opposed to as a separate action? I s

[ovs-dev] newbie question

2013-03-22 Thread Vasiliy Tolstov
Hello. I'm try to use open vSwitch in my virtual environment that contains 100-200 kvm vm. Aech vm node contains is about 20-50 vm. Is that possible to control all vSwitches from single point? -- Vasiliy Tolstov, e-mail: v.tols...@selfip.ru jabber: v...@selfip.ru __