Re: [ovs-dev] [PATCH 2/2] datapath: Add basic MPLS support to kernel

2013-03-18 Thread Simon Horman
On Mon, Mar 18, 2013 at 06:35:48PM -0700, Jesse Gross wrote: > On Mon, Mar 18, 2013 at 6:22 PM, Simon Horman wrote: > > On Mon, Mar 18, 2013 at 05:45:52PM -0700, Jesse Gross wrote: > >> I don't think that we want to allow an array of MPLS labels at this > >> point in time, since we'll just silentl

Re: [ovs-dev] [PATCH 2/2] datapath: Add basic MPLS support to kernel

2013-03-18 Thread Jesse Gross
On Mon, Mar 18, 2013 at 6:22 PM, Simon Horman wrote: > On Mon, Mar 18, 2013 at 05:45:52PM -0700, Jesse Gross wrote: >> I don't think that we want to allow an array of MPLS labels at this >> point in time, since we'll just silently ignore the ones that we don't >> expect, which isn't good. However

Re: [ovs-dev] [PATCH 1/2] mpls: Allow l3 and l4 actions to prior to a push_mpls action

2013-03-18 Thread Simon Horman
On Mon, Mar 18, 2013 at 08:54:49AM -0700, Jesse Gross wrote: > On Mon, Mar 18, 2013 at 12:37 AM, Simon Horman wrote: > > * Update the order in which actions are committed and thus > > appear in the datapath such that MPLS actions appear after > > l3 and l4 (nw and port) actions. > > > > In t

Re: [ovs-dev] [RFC PATCH 4/4] Add packet recirculation

2013-03-18 Thread Simon Horman
On Mon, Mar 18, 2013 at 01:49:43PM -0700, Jesse Gross wrote: > On Fri, Mar 15, 2013 at 7:27 AM, Simon Horman wrote: > > Recirculation is a technique to allow a frame to re-enter > > frame processing. This is intended to be used after actions > > have been applied to the frame with modify the frame

Re: [ovs-dev] [PATCH 2/2] datapath: Add basic MPLS support to kernel

2013-03-18 Thread Simon Horman
On Mon, Mar 18, 2013 at 05:45:52PM -0700, Jesse Gross wrote: > On Mon, Mar 18, 2013 at 12:37 AM, Simon Horman wrote: > > Allow datapath to recognize and extract MPLS labels into flow keys > > and execute actions which push, pop, and set labels on packets. > > > > Based heavily on work by Leo Alter

Re: [ovs-dev] [PATCH 2/2] datapath: Add basic MPLS support to kernel

2013-03-18 Thread Jesse Gross
On Mon, Mar 18, 2013 at 12:37 AM, Simon Horman wrote: > Allow datapath to recognize and extract MPLS labels into flow keys > and execute actions which push, pop, and set labels on packets. > > Based heavily on work by Leo Alterman and Ravi K. > > Cc: Ravi K > Cc: Leo Alterman > Reviewed-by: Isak

[ovs-dev] [PATCH] ofproto-dpif: Keep track of exact-match flow info

2013-03-18 Thread Andy Zhou
This patch adds more flow related stats to the output of "ovs-appctl dpif/show". Specifically, the follow information are added per ofproto: - Max flow table size - Average flow table size - Average flow table add rate - Average flow table delete rate - Average flow entry life in milliseconds Fe

Re: [ovs-dev] [PATCH] datapath: Remove checks for preinitialized flow.

2013-03-18 Thread Jesse Gross
On Mon, Mar 18, 2013 at 4:13 PM, Pravin Shelar wrote: > On Mon, Mar 18, 2013 at 2:20 PM, Jesse Gross wrote: >> Header caching used to store a precomputed flow along with the skb >> but no longer exists. There were a few remaining checks for those >> flows, which this removes. It simplifies the

Re: [ovs-dev] [PATCH] datapath: Remove checks for preinitialized flow.

2013-03-18 Thread Pravin Shelar
On Mon, Mar 18, 2013 at 2:20 PM, Jesse Gross wrote: > Header caching used to store a precomputed flow along with the skb > but no longer exists. There were a few remaining checks for those > flows, which this removes. It simplifies the code slightly and brings > us closer to upstream. > > Signed

[ovs-dev] [PATCH] datapath: Remove checks for preinitialized flow.

2013-03-18 Thread Jesse Gross
Header caching used to store a precomputed flow along with the skb but no longer exists. There were a few remaining checks for those flows, which this removes. It simplifies the code slightly and brings us closer to upstream. Signed-off-by: Jesse Gross --- datapath/datapath.c | 50

Re: [ovs-dev] [RFC PATCH 4/4] Add packet recirculation

2013-03-18 Thread Jesse Gross
On Fri, Mar 15, 2013 at 7:27 AM, Simon Horman wrote: > Recirculation is a technique to allow a frame to re-enter > frame processing. This is intended to be used after actions > have been applied to the frame with modify the frame in > some way that makes it possible for richer processing to occur.

Re: [ovs-dev] [PATCH] debian: Re-add --timeout option for ifupdown script.

2013-03-18 Thread Gurucharan Shetty
On Mon, Mar 18, 2013 at 1:40 PM, Ben Pfaff wrote: > On Mon, Mar 18, 2013 at 12:38:24PM -0700, Gurucharan Shetty wrote: >> Commit fba6bd1d3f(ovs-vsctl: Try connecting only once for active >> connections..) >> removed the timeout option from ifupdown.sh. Removing the "--timeout=" option >> can caus

Re: [ovs-dev] [PATCH] debian: Re-add --timeout option for ifupdown script.

2013-03-18 Thread Ben Pfaff
On Mon, Mar 18, 2013 at 12:38:24PM -0700, Gurucharan Shetty wrote: > Commit fba6bd1d3f(ovs-vsctl: Try connecting only once for active > connections..) > removed the timeout option from ifupdown.sh. Removing the "--timeout=" option > can cause ifupdown script to hang if ovs-vswitchd is not running

[ovs-dev] [PATCH] debian: Re-add --timeout option for ifupdown script.

2013-03-18 Thread Gurucharan Shetty
Commit fba6bd1d3f(ovs-vsctl: Try connecting only once for active connections..) removed the timeout option from ifupdown.sh. Removing the "--timeout=" option can cause ifupdown script to hang if ovs-vswitchd is not running and ifupdown script changes the OVSDB. So, re-add it. Signed-off-by: Guruch

Re: [ovs-dev] Fwd: Sebz: Qnzvra Zvyyrfpnzcf

2013-03-18 Thread Ben Pfaff
Would you mind trying "git send-email" again? IT says they've whitelisted you now. I still don't know why your emails in particular are getting dropped but I hope that that fixes it. On Mon, Mar 18, 2013 at 05:50:49PM +0100, Damien Millescamps wrote: > Sorry for this, since all my emails contain

Re: [ovs-dev] [PATCH 3/3] rhel: Remove timeouts from ifup and ifdown scripts.

2013-03-18 Thread Ben Pfaff
On Mon, Mar 18, 2013 at 12:39:33PM -0700, Gurucharan Shetty wrote: > On Mon, Mar 18, 2013 at 12:18 PM, Ben Pfaff wrote: > > On Mon, Mar 18, 2013 at 10:48:49AM -0700, Gurucharan Shetty wrote: > >> Previously, ovs-vsctl would wait for ever if ovsdb-server > >> was not running. In such a situation, i

Re: [ovs-dev] [PATCH 3/3] rhel: Remove timeouts from ifup and ifdown scripts.

2013-03-18 Thread Gurucharan Shetty
On Mon, Mar 18, 2013 at 12:18 PM, Ben Pfaff wrote: > On Mon, Mar 18, 2013 at 10:48:49AM -0700, Gurucharan Shetty wrote: >> Previously, ovs-vsctl would wait for ever if ovsdb-server >> was not running. In such a situation, it made sense to use >> a "--timeout" value to prevent a stuck startup scrip

Re: [ovs-dev] [PATCH 3/3] rhel: Remove timeouts from ifup and ifdown scripts.

2013-03-18 Thread Ben Pfaff
On Mon, Mar 18, 2013 at 10:48:49AM -0700, Gurucharan Shetty wrote: > Previously, ovs-vsctl would wait for ever if ovsdb-server > was not running. In such a situation, it made sense to use > a "--timeout" value to prevent a stuck startup script. But now, > ovs-vsctl by default returns an error if ov

Re: [ovs-dev] [PATCH] ipsec: unset IPSEC_MARK flag from skb_mark after tunnel packet is decapsulated

2013-03-18 Thread Jesse Gross
On Mon, Mar 18, 2013 at 10:02 AM, Ansis Atteka wrote: > On Fri, Mar 15, 2013 at 3:27 PM, Jesse Gross wrote: >> I'm somewhat worried about our use of skb mark conflicting with other >> uses but this doesn't really change that all that much. > > Agree. Do you think it would make sense to specify (e

Re: [ovs-dev] [PATCH 2/3] rhel: Set STP of a bridge during bridge creation.

2013-03-18 Thread Ben Pfaff
On Mon, Mar 18, 2013 at 10:48:48AM -0700, Gurucharan Shetty wrote: > This patch sets the value of STP (if provided) at the same > time of bridge creation. This eliminates an extra ovs-vsctl call > and does not let ovs-vswitchd run briefly with STP not enabled. > > Signed-off-by: Gurucharan Shetty

Re: [ovs-dev] [PATCH 1/3] rhel: Prevent duplicate ifup calls.

2013-03-18 Thread Ben Pfaff
On Mon, Mar 18, 2013 at 10:48:47AM -0700, Gurucharan Shetty wrote: > When we configure OVS using rhel ifupdown scripts, > we call ifup on a bridge twice. Once while configuring the > bridge and once while configuring the ports of the bridge. > This looks harmless but unnecessary. This patch fixes t

[ovs-dev] [PATCH 3/3] rhel: Remove timeouts from ifup and ifdown scripts.

2013-03-18 Thread Gurucharan Shetty
Previously, ovs-vsctl would wait for ever if ovsdb-server was not running. In such a situation, it made sense to use a "--timeout" value to prevent a stuck startup script. But now, ovs-vsctl by default returns an error if ovsdb-server is not running. So, we no longer need the timeout option. Signe

[ovs-dev] [PATCH 1/3] rhel: Prevent duplicate ifup calls.

2013-03-18 Thread Gurucharan Shetty
When we configure OVS using rhel ifupdown scripts, we call ifup on a bridge twice. Once while configuring the bridge and once while configuring the ports of the bridge. This looks harmless but unnecessary. This patch fixes the behavior. Signed-off-by: Gurucharan Shetty --- rhel/README.RHEL

[ovs-dev] [PATCH 2/3] rhel: Set STP of a bridge during bridge creation.

2013-03-18 Thread Gurucharan Shetty
This patch sets the value of STP (if provided) at the same time of bridge creation. This eliminates an extra ovs-vsctl call and does not let ovs-vswitchd run briefly with STP not enabled. Signed-off-by: Gurucharan Shetty --- rhel/etc_sysconfig_network-scripts_ifup-ovs |4 ++-- 1 file changed

Re: [ovs-dev] [PATCH] ovs-vsctl: Try connecting only once for active connections by default.

2013-03-18 Thread Ben Pfaff
On Mon, Mar 18, 2013 at 10:32:21AM -0700, Ansis Atteka wrote: > On Mon, Mar 18, 2013 at 10:26 AM, Ben Pfaff wrote: > > On Fri, Mar 15, 2013 at 04:13:37PM -0700, Ansis Atteka wrote: > >> I saw few other occurrences where ovs-vsctl is being called with > >> --timeout, Though, I am not sure how safe

Re: [ovs-dev] [PATCH] ovs-vsctl: Try connecting only once for active connections by default.

2013-03-18 Thread Ansis Atteka
On Mon, Mar 18, 2013 at 10:26 AM, Ben Pfaff wrote: > On Fri, Mar 15, 2013 at 04:13:37PM -0700, Ansis Atteka wrote: >> I saw few other occurrences where ovs-vsctl is being called with >> --timeout, Though, I am not sure how safe or necessary it would be to >> remove --timeout everywhere at this tim

Re: [ovs-dev] Fwd: Sebz: Qnzvra Zvyyrfpnzcf

2013-03-18 Thread Ben Pfaff
On Mon, Mar 18, 2013 at 05:50:49PM +0100, Damien Millescamps wrote: > Sorry for this, since all my emails containing anything related to a > patch are clearly dropped, the git-send-email was passed through a rot13... This is bizarre. Others post patches regularly without trouble. I'll pass this

Re: [ovs-dev] [PATCH] ovs-vsctl: Try connecting only once for active connections by default.

2013-03-18 Thread Ben Pfaff
On Fri, Mar 15, 2013 at 04:13:37PM -0700, Ansis Atteka wrote: > I saw few other occurrences where ovs-vsctl is being called with > --timeout, Though, I am not sure how safe or necessary it would be to > remove --timeout everywhere at this time. It seems entirely safe to me when --no-wait is in us

Re: [ovs-dev] [PATCH v3] rhel: Prevent duplicate ifup calls.

2013-03-18 Thread Gurucharan Shetty
On Mon, Mar 18, 2013 at 10:12 AM, Ben Pfaff wrote: > On Mon, Mar 18, 2013 at 08:32:17AM -0700, Gurucharan Shetty wrote: >> When we configure OVS using rhel ifupdown scripts, >> we call ifup on a bridge twice. Once while configuring the >> bridge and once while configuring the ports of the bridge.

Re: [ovs-dev] [PATCH v3] rhel: Prevent duplicate ifup calls.

2013-03-18 Thread Ben Pfaff
On Mon, Mar 18, 2013 at 08:32:17AM -0700, Gurucharan Shetty wrote: > When we configure OVS using rhel ifupdown scripts, > we call ifup on a bridge twice. Once while configuring the > bridge and once while configuring the ports of the bridge. > This looks harmless but unnecessary. This patch fixes t

Re: [ovs-dev] [PATCH] ipsec: unset IPSEC_MARK flag from skb_mark after tunnel packet is decapsulated

2013-03-18 Thread Ansis Atteka
On Fri, Mar 15, 2013 at 3:27 PM, Jesse Gross wrote: > On Fri, Mar 15, 2013 at 2:10 PM, Ansis Atteka wrote: >> On Thu, Mar 14, 2013 at 4:23 PM, Jesse Gross wrote: >>> On Thu, Mar 14, 2013 at 2:27 PM, Ansis Atteka wrote: After tunnel packet is unencapsulated we should unset IPsec flag from >

[ovs-dev] [PATCH] NEWS: Update release for ovs-vsctl changes from post-1.10 to 1.10.

2013-03-18 Thread Ben Pfaff
This feature was backported. Signed-off-by: Ben Pfaff --- I already pushed this. diff --git a/NEWS b/NEWS index 79fde29..cbbe06b 100644 --- a/NEWS +++ b/NEWS @@ -1,11 +1,5 @@ post-v1.10.0 - -- ovs-vsctl: - * Previously ovs-vsctl would retry connecting to the databa

[ovs-dev] Fwd: Sebz: Qnzvra Zvyyrfpnzcf

2013-03-18 Thread Damien Millescamps
Sorry for this, since all my emails containing anything related to a patch are clearly dropped, the git-send-email was passed through a rot13... Rot13 on this email should give the correct patch. Sorry again, -- Damien Millescamps Original Message Subject: [ovs-dev] Sebz: Qnzv

[ovs-dev] Sebz: Qnzvra Zvyyrfpnzcf

2013-03-18 Thread Damien Millescamps
Guvf cngpu svkrf n ohvyq reebe jura BIF vf ohvyg sebz n ernq-bayl ercbfvgbel. Gb ercebqhpr guvf vffhr eha: puzbq -E n-j . zxqve ../ohvyq-bif; pq ../ohvyq-bif ../bcraifjvgpu/pbasvther && znxr Fvtarq-bss-ol: Qnzvra Zvyyrfpnzcf --- yvo/nhgbznxr.zx |6 +++--- 1 svyrf punatrq, 3 vafregvbaf(+), 3

Re: [ovs-dev] [PATCH 1/2] mpls: Allow l3 and l4 actions to prior to a push_mpls action

2013-03-18 Thread Jesse Gross
On Mon, Mar 18, 2013 at 12:37 AM, Simon Horman wrote: > * Update the order in which actions are committed and thus > appear in the datapath such that MPLS actions appear after > l3 and l4 (nw and port) actions. > > In the case where an mpls_push action is present it should ensure > that l3

Re: [ovs-dev] [PATCH v3] rhel: Prevent duplicate ifup calls.

2013-03-18 Thread Gurucharan Shetty
On Mon, Mar 18, 2013 at 8:32 AM, Gurucharan Shetty wrote: > When we configure OVS using rhel ifupdown scripts, > we call ifup on a bridge twice. Once while configuring the > bridge and once while configuring the ports of the bridge. > This looks harmless but unnecessary. This patch fixes the > beh

[ovs-dev] [PATCH v3] rhel: Prevent duplicate ifup calls.

2013-03-18 Thread Gurucharan Shetty
When we configure OVS using rhel ifupdown scripts, we call ifup on a bridge twice. Once while configuring the bridge and once while configuring the ports of the bridge. This looks harmless but unnecessary. This patch fixes the behavior. Signed-off-by: Gurucharan Shetty --- rhel/README.RHEL

Re: [ovs-dev] [PATCH 2/4] Remove encal_dl_type from struct flow

2013-03-18 Thread Simon Horman
On Mon, Mar 18, 2013 at 03:13:13PM +0900, Simon Horman wrote: > On Fri, Mar 15, 2013 at 03:07:33PM -0700, Jesse Gross wrote: > > On Fri, Mar 15, 2013 at 7:27 AM, Simon Horman wrote: > > > There were plans to use this in conjunction with inner/outer flows, > > > however that plan has been changed i

[ovs-dev] [PATCH 0/2 v2.21] MPLS actions and matches

2013-03-18 Thread Simon Horman
Hi, This series implements MPLS actions and matches based on work by Ravi K, Leo Alterman and Yamahata-san. This series provides two changes * Tweaks to the generation of odp actions when MPLS actions are present and; * Adding basic MPLS action and match support to the kernel datapath Future W

[ovs-dev] [PATCH 2/2] datapath: Add basic MPLS support to kernel

2013-03-18 Thread Simon Horman
Allow datapath to recognize and extract MPLS labels into flow keys and execute actions which push, pop, and set labels on packets. Based heavily on work by Leo Alterman and Ravi K. Cc: Ravi K Cc: Leo Alterman Reviewed-by: Isaku Yamahata Signed-off-by: Simon Horman --- TODO: * Enhance core k

[ovs-dev] [PATCH 1/2] mpls: Allow l3 and l4 actions to prior to a push_mpls action

2013-03-18 Thread Simon Horman
* Update the order in which actions are committed and thus appear in the datapath such that MPLS actions appear after l3 and l4 (nw and port) actions. In the case where an mpls_push action is present it should ensure that l3 and l4 actions occur first, which seems logical as once a mpls_