Re: [ovs-dev] Validation of Facts for Recirculation

2013-03-11 Thread Simon Horman
On Mon, Mar 11, 2013 at 06:28:35PM -0700, Jesse Gross wrote: > On Mon, Mar 11, 2013 at 7:22 AM, Simon Horman wrote: > > Hi Jesse, Hi Ben, Hi All, > > > > I have been working on reimplementing packet recirculation, > > however I am a little unsure how to make facet revalidation work > > for facets

Re: [ovs-dev] [PATCH] AUTHORS: Add Andy Zhou.

2013-03-11 Thread Ben Pfaff
I already applied it (as mentioned below). On Mon, Mar 11, 2013 at 06:45:55PM -0700, Ethan Jackson wrote: > Looks good to me. Perhaps Andy should review it? > > Ethan > > > On Thu, Feb 28, 2013 at 9:56 AM, Ben Pfaff wrote: > > > CC: Andy Zhou > > Signed-off-by: Ben Pfaff > > --- > > I alre

Re: [ovs-dev] question about openvswitch

2013-03-11 Thread Andy Zhou
Yes, the first option will be easier to implement. For the second option, yes you are right. Implementing a dpif provider as Justin suggested is also be a very good choice. Really depends on your design goals. On Mon, Mar 11, 2013 at 12:54 AM, 王国栋 wrote: > i think the first option may be impl

Re: [ovs-dev] [PATCH 2/2] ovsdb: Fix memory leak.

2013-03-11 Thread Ethan Jackson
Acked-by: Ethan Jackson On Mon, Feb 11, 2013 at 3:17 PM, Ben Pfaff wrote: > --- > ovsdb/jsonrpc-server.c |5 + > 1 files changed, 5 insertions(+), 0 deletions(-) > > diff --git a/ovsdb/jsonrpc-server.c b/ovsdb/jsonrpc-server.c > index 6d07c45..16c4a76 100644 > --- a/ovsdb/jsonrpc-ser

Re: [ovs-dev] [PATCH 1/2] connmgr: Fix memory leak in ofconn monitor table.

2013-03-11 Thread Ethan Jackson
Acked-by: Ethan Jackson On Mon, Feb 11, 2013 at 3:17 PM, Ben Pfaff wrote: > Signed-off-by: Ben Pfaff > --- > ofproto/connmgr.c |1 + > 1 files changed, 1 insertions(+), 0 deletions(-) > > diff --git a/ofproto/connmgr.c b/ofproto/connmgr.c > index b94c337..3200660 100644 > --- a/ofproto/

Re: [ovs-dev] [PATCH] vswitch.xml: Document iface-status behavior for intra-hypervisor migration.

2013-03-11 Thread Ethan Jackson
Acked-by: Ethan Jackson On Wed, Feb 27, 2013 at 10:29 AM, Ben Pfaff wrote: > Based on a face-to-face discussion. > > CC: Natasha Gude > CC: Andrew Lambeth > Signed-off-by: Ben Pfaff > --- > vswitchd/vswitch.xml |5 + > 1 files changed, 5 insertions(+), 0 deletions(-) > > diff --gi

Re: [ovs-dev] [PATCH] AUTHORS: Add Andy Zhou.

2013-03-11 Thread Ethan Jackson
Looks good to me. Perhaps Andy should review it? Ethan On Thu, Feb 28, 2013 at 9:56 AM, Ben Pfaff wrote: > CC: Andy Zhou > Signed-off-by: Ben Pfaff > --- > I already applied this to master. > > diff --git a/AUTHORS b/AUTHORS > index 4b5e6fe..9613142 100644 > --- a/AUTHORS > +++ b/AUTHORS >

Re: [ovs-dev] Validation of Facts for Recirculation

2013-03-11 Thread Jesse Gross
On Mon, Mar 11, 2013 at 7:22 AM, Simon Horman wrote: > Hi Jesse, Hi Ben, Hi All, > > I have been working on reimplementing packet recirculation, > however I am a little unsure how to make facet revalidation work > for facets of recirculated packets. > > The problem that I am seeing is that as face

Re: [ovs-dev] [PATCH branch-1.7] meta-flow: Fix mf_set_wild() on ip_frag field.

2013-03-11 Thread Ethan Jackson
Acked-by: Ethan Jackson On Fri, Mar 1, 2013 at 8:11 AM, Ben Pfaff wrote: > Fixes behavior of > utilities/ovs-ofctl parse-flow 'ip,ip_frag=any,actions=drop' > and other cases that invoke this function on the ip_frag field. > > Reported-by: love you > Signed-off-by: Ben Pfaff > --- > AUT

Re: [ovs-dev] [PATCH] ovsdb: Allow recovery from transient write errors in log implementation.

2013-03-11 Thread Ethan Jackson
Seems fine to me, I don't know this code well though. Acked-by: Ethan Jackson On Fri, Mar 1, 2013 at 11:16 AM, Ben Pfaff wrote: > Until now, the OVSDB data journaling implementation has made write errors > "sticky", so that a single write error persists as long as ovsdb-server is > alive. H

Re: [ovs-dev] [PATCH] ofproto: Remove unnecessary struct forward declaration.

2013-03-11 Thread Ethan Jackson
Acked-by: Ethan Jackson On Tue, Mar 5, 2013 at 4:25 PM, Ben Pfaff wrote: > Signed-off-by: Ben Pfaff > --- > ofproto/ofproto.h |1 - > 1 files changed, 0 insertions(+), 1 deletions(-) > > diff --git a/ofproto/ofproto.h b/ofproto/ofproto.h > index 3a66d1b..a217e0a 100644 > --- a/ofproto/o

Re: [ovs-dev] [PATCH] bridge: Minor style fix.

2013-03-11 Thread Ethan Jackson
Acked-by: Ethan Jackson On Tue, Mar 5, 2013 at 4:25 PM, Ben Pfaff wrote: > Signed-off-by: Ben Pfaff > --- > vswitchd/bridge.c |3 +-- > 1 files changed, 1 insertions(+), 2 deletions(-) > > diff --git a/vswitchd/bridge.c b/vswitchd/bridge.c > index ab0ecd6..993e4da 100644 > --- a/vswitch

Re: [ovs-dev] [PATCH] NEWS: Fix release for table ID in NXM flow_removed feature.

2013-03-11 Thread Ethan Jackson
Acked-by: Ethan Jackson On Fri, Mar 8, 2013 at 10:54 AM, Ben Pfaff wrote: > I forgot that I was planning to backport this to branch-1.10. > > Signed-off-by: Ben Pfaff > --- > I already applied this to master. > > diff --git a/NEWS b/NEWS > index 90c01a6..b6800bc 100644 > --- a/NEWS > +++ b/N

Re: [ovs-dev] [PATCH] NEWS: Note tunneling feature removals in the correct release.

2013-03-11 Thread Jesse Gross
Thanks, applied to master and branch-1.10. On Mon, Mar 11, 2013 at 5:35 PM, Pravin Shelar wrote: > On Mon, Mar 11, 2013 at 4:02 PM, Jesse Gross wrote: >> Signed-off-by: Jesse Gross > Looks good, > > Thanks. >> --- >> NEWS |3 ++- >> 1 file changed, 2 insertions(+), 1 deletion(-) >> >> diff

Re: [ovs-dev] [PATCH] NEWS: Note tunneling feature removals in the correct release.

2013-03-11 Thread Pravin Shelar
On Mon, Mar 11, 2013 at 4:02 PM, Jesse Gross wrote: > Signed-off-by: Jesse Gross Looks good, Thanks. > --- > NEWS |3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/NEWS b/NEWS > index b6800bc..36fbf6f 100644 > --- a/NEWS > +++ b/NEWS > @@ -2,7 +2,6 @@ post-v1.10.0 >

[ovs-dev] [PATCH] NEWS: Note tunneling feature removals in the correct release.

2013-03-11 Thread Jesse Gross
Signed-off-by: Jesse Gross --- NEWS |3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/NEWS b/NEWS index b6800bc..36fbf6f 100644 --- a/NEWS +++ b/NEWS @@ -2,7 +2,6 @@ post-v1.10.0 - - Stable bond mode has been removed. - The autopath action has

[ovs-dev] Betreff: GLUCKWUNSCHE! GLUCKWUNSCHE!! [ IHRE E-mail HAT GEWONNEN $450, 000.00 USD in USA LOTTERIE 2013 {REF NR , 575061725 } Show Details From * Don

2013-03-11 Thread usa . lotterie-gewinnes
UNITED STATES OF AMERICA LOTTO INC. ADRESSE: OSTWESTLANDSTRASSE 1325 STADT: SILBERNER FRUHLING STATE/PROVINCE: MARYLAND POSTCODE: 20110 LAND: USA INC. REF NR: .364758679 STAPEL NR: .6485769789/646

[ovs-dev] [PATCH] ovs-appctl: dpif/show display per bridge stats

2013-03-11 Thread Andy Zhou
This is to fix the fallout of single datapath change. ovs-appctl dpif/show displays per bridge miss, hit and flow counts on the screen, but the backend is obtaining those information from the datapath. With a single datapath, all bridges of the same datapath would all display the same (global) cou

Re: [ovs-dev] [PATCH] ovs-ctl.in: Set hard limit for core files created.

2013-03-11 Thread Ben Pfaff
On Mon, Mar 11, 2013 at 01:18:11PM -0700, Gurucharan Shetty wrote: > Currently we set a soft limit while defining the maximum size of > core files. If there is already a hard limit set that is lesser > than the soft limit we are setting, it will fail. > > Since our startup scripts start with root

[ovs-dev] [PATCH] ovs-ctl.in: Set hard limit for core files created.

2013-03-11 Thread Gurucharan Shetty
Currently we set a soft limit while defining the maximum size of core files. If there is already a hard limit set that is lesser than the soft limit we are setting, it will fail. Since our startup scripts start with root permissions, it looks fine to set the hard limit directly instead. Reported-

Re: [ovs-dev] ingress and egress rate limiting and QoS policies

2013-03-11 Thread Ben Pfaff
On Mon, Mar 11, 2013 at 06:00:21PM +0530, Jagadish Nadimpalli wrote: > In openvswitch, an interface is nothing but a "netdev". A port can have a > single interface associated with it or multiple interfaces in case of > bonding. Now, when it comes to applying QoS policies, the ingress policing > is

Re: [ovs-dev] [PATCH] ofproto-dpif: Remove unnecessary ofp_port to odp_port mapping.

2013-03-11 Thread Ben Pfaff
On Mon, Mar 11, 2013 at 03:27:41PM +0200, Jarno Rajahalme wrote: > > Signed-off-by: Jarno Rajahalme Thank you! I applied this to master. ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

Re: [ovs-dev] Kernel Crash with VXLAN source code

2013-03-11 Thread Jagadish Nadimpalli
Hi All, There is an un-closed socket as I was experimenting without restarting the machine. So, this issue got resolved after I restart the machine. Now, the VXLAN code works without any crashes. I have taken the master git. Thanks a lot for all of your help. Thanks & Regards, Jagadish On Sat,

Re: [ovs-dev] [PATCH 3/3] datapath: Add basic MPLS support to kernel

2013-03-11 Thread Jesse Gross
On Mon, Mar 11, 2013 at 6:02 AM, Rajahalme, Jarno (NSN - FI/Espoo) wrote: > > On Mar 9, 2013, at 16:54 , ext Simon Horman wrote: > >> It is not obvious to me how the behaviour relating to get_priority() as >> described above can sensibly be reconciled with a desire to preserve the >> order of acti

[ovs-dev] Validation of Facts for Recirculation

2013-03-11 Thread Simon Horman
Hi Jesse, Hi Ben, Hi All, I have been working on reimplementing packet recirculation, however I am a little unsure how to make facet revalidation work for facets of recirculated packets. The problem that I am seeing is that as facets are intended to be applied to packets that have been recirculat

[ovs-dev] [PATCH] ofproto-dpif: Remove unnecessary ofp_port to odp_port mapping.

2013-03-11 Thread Jarno Rajahalme
Signed-off-by: Jarno Rajahalme --- ofproto/ofproto-dpif.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ofproto/ofproto-dpif.c b/ofproto/ofproto-dpif.c index 5323626..742 100644 --- a/ofproto/ofproto-dpif.c +++ b/ofproto/ofproto-dpif.c @@ -5786,7 +5786,6 @@ compose_o

[ovs-dev] Betreff: GLUCKWUNSCHE! GLUCKWUNSCHE!! [ IHRE E-mail HAT GEWONNEN $450, 000.00 USD in USA LOTTERIE 2013 {REF NR , 575061725 } Show Details From * Don

2013-03-11 Thread usa . lotterie-gewinnes
UNITED STATES OF AMERICA LOTTO INC. ADRESSE: OSTWESTLANDSTRASSE 1325 STADT: SILBERNER FRUHLING STATE/PROVINCE: MARYLAND POSTCODE: 20110 LAND: USA INC. REF NR: .364758679 STAPEL NR: .6485769789/646

Re: [ovs-dev] [PATCH 3/3] datapath: Add basic MPLS support to kernel

2013-03-11 Thread Rajahalme, Jarno (NSN - FI/Espoo)
On Mar 9, 2013, at 16:54 , ext Simon Horman wrote: > It is not obvious to me how the behaviour relating to get_priority() as > described above can sensibly be reconciled with a desire to preserve the > order of actions. Or even reconciled with a looser constraint that actions > that need l3+ data

Re: [ovs-dev] [PATCH 3/3] datapath: Add basic MPLS support to kernel

2013-03-11 Thread Rajahalme, Jarno (NSN - FI/Espoo)
On Mar 9, 2013, at 16:54 , ext Simon Horman wrote: > On Thu, Mar 07, 2013 at 11:12:31AM -0800, Ben Pfaff wrote: >> On Thu, Mar 07, 2013 at 04:12:22AM +0100, Simon Horman wrote: >>> Perhaps Ben has some ideas, but it seems to me that the >>> way that execute_* and compose_* interact needs to be ch

[ovs-dev] ingress and egress rate limiting and QoS policies

2013-03-11 Thread Jagadish Nadimpalli
Hi All, In openvswitch, an interface is nothing but a "netdev". A port can have a single interface associated with it or multiple interfaces in case of bonding. Now, when it comes to applying QoS policies, the ingress policing is applied to an interface where as the port level QoS has the egress Q

Re: [ovs-dev] question about openvswitch

2013-03-11 Thread 王国栋
i think the first option may be implemented more easily, in which i just implement the datapath kernel module. and in the second option, do you means that the whole project can be ported to SE mode(including ofproto and vswitch)? 2013/3/10 Andy Zhou > If you simply want a faster datapath impleme