[ovs-dev] [PATCH] ovs-appctl: dpif/show display per bridge stats

2013-03-08 Thread Andy Zhou
This is to fix the fallout of single datapath change. ovs-appctl dpif/show displays per bridge miss, hit and flow counts on the screen, but the backend is obtaining those information from the datapath. With a single datapath, all bridges of the same datapath would all display the same (global) cou

Re: [ovs-dev] [PATCH] ofproto-dpif: GOTO_TABLE recursion removal.

2013-03-08 Thread Rajahalme, Jarno (NSN - FI/Espoo)
Ben, Thanks for fixing that up, looks good :-) Jarno On Mar 8, 2013, at 18:52 , ext Ben Pfaff wrote: > On Fri, Mar 08, 2013 at 03:50:12PM +0200, Jarno Rajahalme wrote: >> Remove recursion from GOTO_TABLE processing in do_xlate_actions(). >> This allows packet processing pipelines built with g

Re: [ovs-dev] [PATCH] ofpbuf: Remove OFPBUF_STACK_BUFFER.

2013-03-08 Thread Ben Pfaff
On Fri, Mar 08, 2013 at 04:06:41PM -0500, Ed Maste wrote: > On 27 February 2013 20:03, Ben Pfaff wrote: > > Its alleged convenience just doesn't outweigh the syntactical ugliness, and > > so it didn't have any users. > > Not entirely true: there's a consumer in lib/netdev-bsd.c. I don't > have a

Re: [ovs-dev] [PATCH] ofpbuf: Remove OFPBUF_STACK_BUFFER.

2013-03-08 Thread Ed Maste
On 8 March 2013 16:06, Ed Maste wrote: > On 27 February 2013 20:03, Ben Pfaff wrote: >> Its alleged convenience just doesn't outweigh the syntactical ugliness, and >> so it didn't have any users. > > Not entirely true: there's a consumer in lib/netdev-bsd.c. I don't > have any time right now to

Re: [ovs-dev] [PATCH] ofpbuf: Remove OFPBUF_STACK_BUFFER.

2013-03-08 Thread Ed Maste
On 27 February 2013 20:03, Ben Pfaff wrote: > Its alleged convenience just doesn't outweigh the syntactical ugliness, and > so it didn't have any users. Not entirely true: there's a consumer in lib/netdev-bsd.c. I don't have any time right now to look at it, but will try if nobody gets to it fir

Re: [ovs-dev] [PATCH] nicira-ext: Document that nx_flow_mod_table_id applies to nx_flow_mod too.

2013-03-08 Thread Ben Pfaff
Thanks, I applied this to master. On Fri, Mar 08, 2013 at 10:27:20AM -0800, Justin Pettit wrote: > Looks good. Thank you! > > --Justin > > > On Mar 8, 2013, at 10:24 AM, Ben Pfaff wrote: > > > It wasn't clear from the comments that nx_flow_mod_table_id applies to > > nx_flow_mod as well as o

[ovs-dev] [PATCH] NEWS: Fix release for table ID in NXM flow_removed feature.

2013-03-08 Thread Ben Pfaff
I forgot that I was planning to backport this to branch-1.10. Signed-off-by: Ben Pfaff --- I already applied this to master. diff --git a/NEWS b/NEWS index 90c01a6..b6800bc 100644 --- a/NEWS +++ b/NEWS @@ -11,8 +11,6 @@ post-v1.10.0 1.1 and later are now implemented. * New "stack

Re: [ovs-dev] [PATCH] Add table_id to NXM flow_removed messages.

2013-03-08 Thread Ben Pfaff
The things we sacrifice for compatibility! I'll apply this to master and branch-1.10 in a minute. On Fri, Mar 08, 2013 at 10:11:58AM -0800, Justin Pettit wrote: > I'll hold my nose on the "table_id + 1", but otherwise looks good. :-) > > --Justin > > > On Mar 6, 2013, at 9:13 AM, Ben Pfaff w

Re: [ovs-dev] [PATCH] ofproto-dpif: Fix up user specifying wrong bridge on "ofproto/trace".

2013-03-08 Thread Ben Pfaff
It doesn't seem like a big deal to me one way or another. Anyway, if it's a problem I'm sure we'll get a report. I applied this to master and branch-1.10. Thanks for the review. On Fri, Mar 08, 2013 at 10:20:24AM -0800, Justin Pettit wrote: > I wonder if it would be better to only print the bri

Re: [ovs-dev] [PATCH] nicira-ext: Document that nx_flow_mod_table_id applies to nx_flow_mod too.

2013-03-08 Thread Justin Pettit
Looks good. Thank you! --Justin On Mar 8, 2013, at 10:24 AM, Ben Pfaff wrote: > It wasn't clear from the comments that nx_flow_mod_table_id applies to > nx_flow_mod as well as ofp10_flow_mod, but it does and always has. This > commit makes it clear. > > Reported-by: Justin Pettit > Signed-

[ovs-dev] [PATCH] nicira-ext: Document that nx_flow_mod_table_id applies to nx_flow_mod too.

2013-03-08 Thread Ben Pfaff
It wasn't clear from the comments that nx_flow_mod_table_id applies to nx_flow_mod as well as ofp10_flow_mod, but it does and always has. This commit makes it clear. Reported-by: Justin Pettit Signed-off-by: Ben Pfaff --- include/openflow/nicira-ext.h | 13 - 1 file changed, 8 in

Re: [ovs-dev] [PATCH] ofproto-dpif: Fix up user specifying wrong bridge on "ofproto/trace".

2013-03-08 Thread Justin Pettit
I wonder if it would be better to only print the bridge name when there was a mismatch along with a warning. I'm not a heavy user of "ofproto/trace", so I don't have a good sense for which way would be better. Looks good, though. --Justin On Mar 5, 2013, at 4:49 PM, Ben Pfaff wrote: > If t

Re: [ovs-dev] [PATCH] Add table_id to NXM flow_removed messages.

2013-03-08 Thread Justin Pettit
I'll hold my nose on the "table_id + 1", but otherwise looks good. :-) --Justin On Mar 6, 2013, at 9:13 AM, Ben Pfaff wrote: > Feature #15466. > Requested-by: Ronghua Zhang > Signed-off-by: Ben Pfaff > --- > NEWS |2 ++ > include/openflow/nicira-ext.h | 10

Re: [ovs-dev] question about openvswitch

2013-03-08 Thread Justin Pettit
Using SE, I would imagine you'd implement a datapath there. In the Linux core running ovs-vswitchd, I would imagine you'd implement a dpif provider that that spoke to the datapaths running in your simple executive cores. --Justin On Mar 8, 2013, at 12:16 AM, 王国栋 wrote: > In the SE mode, i m

Re: [ovs-dev] [PATCH] ofproto-dpif: GOTO_TABLE recursion removal.

2013-03-08 Thread Ben Pfaff
On Fri, Mar 08, 2013 at 03:50:12PM +0200, Jarno Rajahalme wrote: > Remove recursion from GOTO_TABLE processing in do_xlate_actions(). > This allows packet processing pipelines built with goto table be > longer and not interact with each other via the resubmit recursion limit. > > Signed-off-by: Ja

[ovs-dev] [PATCH] ofproto-dpif: GOTO_TABLE recursion removal.

2013-03-08 Thread Jarno Rajahalme
Remove recursion from GOTO_TABLE processing in do_xlate_actions(). This allows packet processing pipelines built with goto table be longer and not interact with each other via the resubmit recursion limit. Signed-off-by: Jarno Rajahalme --- ofproto/ofproto-dpif.c | 112 +

Re: [ovs-dev] question about openvswitch

2013-03-08 Thread 王国栋
In the SE mode, i must implement the datapath module, dpif provider and dpif as showed in the graph without other module changes, is this right? right now i'm on the stage of doing some research and experiments, i prepare to accelerate OVS. then, maybe used in campus network in future. what i want