Hi All,
I downloaded it and tried it for VXLAN. I am seeing the error "cannot
register vxlan protocol handler" and the tunnels doesn't get created. Looks
like the vxlan_socket_init() function is failing to create vxlan socket.
Any ideas on what is the issue?
Thanks & Regards,
Jagadish
On Fri, F
On Fri, Feb 15, 2013 at 05:36:00PM -0800, Jesse Gross wrote:
> On Fri, Feb 15, 2013 at 4:48 PM, Ben Pfaff wrote:
> > I tested this just now and found a bug: OVS_USERSPACE_ATTR_USERDATA in
> > the action has to be translated to OVS_PACKET_ATTR_USERDATA in the
> > kernel->user Netlink message, other
On Fri, Feb 15, 2013 at 4:48 PM, Ben Pfaff wrote:
> I tested this just now and found a bug: OVS_USERSPACE_ATTR_USERDATA in
> the action has to be translated to OVS_PACKET_ATTR_USERDATA in the
> kernel->user Netlink message, otherwise it gets interpreted as
> OVS_PACKET_ATTR_KEY. So I applied the
On Fri, Feb 15, 2013 at 08:58:52AM -0800, Ben Pfaff wrote:
> On Fri, Feb 15, 2013 at 06:55:55PM +0900, Simon Horman wrote:
> > When encoding MPLS information in ODP flow key data use encap()
> > for encap for frames. This seems to be in keeping with datapath/README.
> >
> > before: eth(...), eth_t
On Fri, Feb 15, 2013 at 04:17:21PM -0800, Jesse Gross wrote:
> On Mon, Feb 4, 2013 at 4:01 PM, Ben Pfaff wrote:
> > diff --git a/datapath/datapath.c b/datapath/datapath.c
> > index 04a5e7f..2a542da 100644
> > --- a/datapath/datapath.c
> > +++ b/datapath/datapath.c
> > @@ -678,7 +678,6 @@ static in
On Mon, Feb 4, 2013 at 4:01 PM, Ben Pfaff wrote:
> diff --git a/datapath/datapath.c b/datapath/datapath.c
> index 04a5e7f..2a542da 100644
> --- a/datapath/datapath.c
> +++ b/datapath/datapath.c
> @@ -678,7 +678,6 @@ static int validate_userspace(const struct nlattr *attr)
> {
> static con
On Mon, Feb 11, 2013 at 6:46 AM, Jarno Rajahalme
wrote:
> Store key_len and hash fields at the end of struct sw_flow_key, past the
> area being hashed.
> Rename functions operating on keys from "_flow_" to "_flow_key_".
> Shift the responsibility for key hashing from lookup and insert to key
> con
On Fri, Feb 15, 2013 at 10:34 AM, Lori Jakab wrote:
> On 02/15/13 01:32, Jesse Gross wrote:
>> On Wed, Feb 13, 2013 at 6:44 AM, Lorand Jakab wrote:
>>> diff --git a/datapath/vport-lisp.c b/datapath/vport-lisp.c
>>> new file mode 100644
>>> index 000..9ca851c
>>> --- /dev/null
>>> +++ b/datapa
On Feb 15, 2013, at 4:04 PM, Ben Pfaff wrote:
> On Fri, Feb 15, 2013 at 02:00:59PM -0800, Ethan Jackson wrote:
>>> I don't think so. If you look, the code which is assigning iter->odp_port
>>> first
>>> checks if node is NULL.
>>
>> Actually no I think he's right. In the condition where the nod
v3 Changes to main loop from Ethan along with comments from Ben.
v2 fixes error handling noticed by Ben.
---
Garbage collect tnl_backers during type_run(). Add new
tnl_backers if a VXLAN ports UDP port changes.
Signed-off-by: Kyle Mestery
---
ofproto/ofproto-dpif.c | 108
On Fri, Feb 15, 2013 at 02:00:59PM -0800, Ethan Jackson wrote:
> > I don't think so. If you look, the code which is assigning iter->odp_port
> > first
> > checks if node is NULL.
>
> Actually no I think he's right. In the condition where the node is in
> tmp_simap, we need to re-look it up after
Ignore this one, I had some issues on my end with sending it.
On Feb 15, 2013, at 4:01 PM, Kyle Mestery
wrote:
> v3 Changes to main loop from Ethan.
> v2 fixes error handling noticed by Ben.
> ---
> Garbage collect tnl_backers during type_run(). Add new
> tnl_backers if a VXLAN ports UDP port c
On Feb 15, 2013, at 3:56 PM, Kyle Mestery (kmestery) wrote:
> On Feb 15, 2013, at 3:51 PM, Ben Pfaff wrote:
>> On Fri, Feb 15, 2013 at 12:49:47PM -0800, Ethan Jackson wrote:
>>> I think the main loop of this version still has some bugs. It doesn't
>>> properly
>>> update 'iter''s odp_port, nor
> I don't think so. If you look, the code which is assigning iter->odp_port
> first
> checks if node is NULL.
Actually no I think he's right. In the condition where the node is in
tmp_simap, we need to re-look it up after we've put it into
tnl_backers. Otherwise later node will be non-null, but
v3 Changes to main loop from Ethan.
v2 fixes error handling noticed by Ben.
---
Garbage collect tnl_backers during type_run(). Add new
tnl_backers if a VXLAN ports UDP port changes.
Signed-off-by: Kyle Mestery
---
ofproto/ofproto-dpif.c | 107 +++--
1
On Feb 15, 2013, at 3:51 PM, Ben Pfaff wrote:
> On Fri, Feb 15, 2013 at 12:49:47PM -0800, Ethan Jackson wrote:
>> I think the main loop of this version still has some bugs. It doesn't
>> properly
>> update 'iter''s odp_port, nor do a tnl_port_reconfigure() when 'iter''s
>> backer
>> changes (in
On Fri, Feb 15, 2013 at 12:49:47PM -0800, Ethan Jackson wrote:
> I think the main loop of this version still has some bugs. It doesn't
> properly
> update 'iter''s odp_port, nor do a tnl_port_reconfigure() when 'iter''s backer
> changes (in some cases). What about something like the following?
On Mon, Feb 11, 2013 at 1:05 PM, Pravin B Shelar wrote:
> The CAPWAP implementation is just the encapsulation format and
> therefore really not the full protocol. While there were some
> uses of it (primarily hardware support and UDP transport). But
> these are most likely better provided by VXL
On Fri, Feb 8, 2013 at 3:29 PM, Rich Lane wrote:
> Before this patch, if an LLC/SNAP packet with OUI 00:00:00 had an ethertype
> less than 1536 the flow key given to userspace in the upcall would contain the
> invalid ethertype (for example, 3). If userspace attempted to insert a kernel
> flow for
On Fri, Feb 15, 2013 at 01:14:52PM -0800, Jesse Gross wrote:
> On Fri, Feb 15, 2013 at 11:24 AM, Ben Pfaff wrote:
> > OVS_TUNNEL_ATTR_DST_PORT expects a u16, tnl_cfg->dst_port is a be16, so
> > we want ntohs() instead of htons().
> >
> > In practice htons() and ntohs() perform the same operation,
On Fri, Feb 15, 2013 at 11:43 AM, Ansis Atteka wrote:
> The new ovs-monitor-ipsec implementation will use skb marks in
> IPsec policies. This patch will configure datapath to use these
> skb marks for IPsec tunnel packets.
>
> Issue: 14870
> Signed-off-by: Ansis Atteka
Looks good to me.
On Fri, Feb 15, 2013 at 11:24 AM, Ben Pfaff wrote:
> OVS_TUNNEL_ATTR_DST_PORT expects a u16, tnl_cfg->dst_port is a be16, so
> we want ntohs() instead of htons().
>
> In practice htons() and ntohs() perform the same operation, so this does
> not fix a real bug.
>
> Found by sparse.
>
> Signed-off-
On Feb 15, 2013, at 2:49 PM, Ethan Jackson wrote:
> I think the main loop of this version still has some bugs. It doesn't
> properly
> update 'iter''s odp_port, nor do a tnl_port_reconfigure() when 'iter''s backer
> changes (in some cases). What about something like the following? I think
> it
I think the main loop of this version still has some bugs. It doesn't properly
update 'iter''s odp_port, nor do a tnl_port_reconfigure() when 'iter''s backer
changes (in some cases). What about something like the following? I think
it's a little bit more straight forward. I haven't tested it at
The new ovs-monitor-ipsec implementation will use skb marks in
IPsec policies. This patch will configure datapath to use these
skb marks for IPsec tunnel packets.
Issue: 14870
Signed-off-by: Ansis Atteka
---
lib/odp-util.c | 11 +--
lib/odp-util.h |2 ++
ofproto/ofp
On Fri, Feb 15, 2013 at 9:20 AM, Kyle Mestery (kmestery)
wrote:
> On Feb 15, 2013, at 10:58 AM, Jesse Gross wrote:
>> On Thu, Feb 14, 2013 at 6:37 AM, Kyle Mestery wrote:
>>> In tnl_set_config(), when determining if a tunnel port
>>> already exists, make sure to also check the destination port.
OVS_TUNNEL_ATTR_DST_PORT expects a u16, tnl_cfg->dst_port is a be16, so
we want ntohs() instead of htons().
In practice htons() and ntohs() perform the same operation, so this does
not fix a real bug.
Found by sparse.
Signed-off-by: Ben Pfaff
---
lib/dpif-linux.c |2 +-
1 files changed, 1
On Fri, Feb 8, 2013 at 3:29 PM, Rich Lane wrote:
> Without genlmsg_end the upcall message ends (according to nlmsg_len) after the
> struct ovs_header.
>
> Signed-off-by: Rich Lane
Applied, thanks.
___
dev mailing list
dev@openvswitch.org
http://openvsw
On Fri, Feb 15, 2013 at 10:42 AM, Ansis Atteka wrote:
> The new ovs-monitor-ipsec implementation will use skb marks in
> IPsec policies. This patch will configure datapath to use these
> skb marks for IPsec tunnel packets.
>
> Issue: 14870
> Signed-off-by: Ansis Atteka
> ---
> lib/odp-util.c
On Fri, Feb 15, 2013 at 10:42 AM, Ansis Atteka wrote:
> The new ovs-monitor-ipsec implementation will use skb marks in
> IPsec policies. This patch will configure datapath to use these
> skb marks for IPsec tunnel packets.
>
> Issue: 14870
> Signed-off-by: Ansis Atteka
> ---
> lib/odp-util.c
The new ovs-monitor-ipsec implementation will use skb marks in
IPsec policies. This patch will configure datapath to use these
skb marks for IPsec tunnel packets.
Issue: 14870
Signed-off-by: Ansis Atteka
---
lib/odp-util.c | 12 ++--
lib/odp-util.h |2 ++
ofproto/of
On 02/15/13 01:32, Jesse Gross wrote:
> On Wed, Feb 13, 2013 at 6:44 AM, Lorand Jakab wrote:
>> LISP is an experimental layer 3 tunneling protocol, described in RFC
>> 6830. This patch adds support for LISP tunneling. Since LISP
>> encapsulated packets do not carry an Ethernet header, it is remo
On Mon, Feb 11, 2013 at 04:46:16PM +0200, Jarno Rajahalme wrote:
> This series tries to improve the kernel datapath - ofproto upcall processing
> code path. Some of these are local changes that may be easier to adopt,
> while others will require more discussion (i.e. modifications to the kernel
>
On Fri, Feb 15, 2013 at 08:31:23AM -0800, Gurucharan Shetty wrote:
> Currently we do not include ovs-bugtool in xenserver rpms.
> This is because xen-bugtool provides the information required
> to debug openvswitch. But xen-bugtool also provides a lot more
> data that is not required for openvswitc
On Feb 15, 2013, at 10:58 AM, Jesse Gross wrote:
> On Thu, Feb 14, 2013 at 6:37 AM, Kyle Mestery wrote:
>> In tnl_set_config(), when determining if a tunnel port
>> already exists, make sure to also check the destination port. For VXLAN, this
>> can be different and allows multiple VXLAN ports in
On Fri, Feb 15, 2013 at 06:55:55PM +0900, Simon Horman wrote:
> When encoding MPLS information in ODP flow key data use encap()
> for encap for frames. This seems to be in keeping with datapath/README.
>
> before: eth(...), eth_type(0x8847), mpls(...), encap(ip(...), tcp(...))
> after: eth(...), e
On Thu, Feb 14, 2013 at 6:37 AM, Kyle Mestery wrote:
> In tnl_set_config(), when determining if a tunnel port
> already exists, make sure to also check the destination port. For VXLAN, this
> can be different and allows multiple VXLAN ports in the datapath to be
> created.
>
> Signed-off-by: Kyle
Currently we do not include ovs-bugtool in xenserver rpms.
This is because xen-bugtool provides the information required
to debug openvswitch. But xen-bugtool also provides a lot more
data that is not required for openvswitch debugging. This makes
the debug bundle quite huge.
Also, xen-bugtool tak
Thanks Lori. I downloaded it from the git repo of openvswitch.
On Fri, Feb 15, 2013 at 6:45 PM, Lori Jakab wrote:
> Hi Jagadish,
>
> VXLAN has been accepted into the official Open vSwitch distribution, so
> you should use that repository instead. Justin referred to branch-1.10
> and master from
Hi Jagadish,
VXLAN has been accepted into the official Open vSwitch distribution, so
you should use that repository instead. Justin referred to branch-1.10
and master from there. To check out that repository, see
http://openvswitch.org/development/
-Lori
On 02/15/13 15:05, Jagadish Nadimpalli
Justin,
Thanks for your response.
Could you please let me know what is this branch-1.10. Is this openvswitch
version? Could you please let me know what is this tip of master. Is this a
git repo?
Thanks & Regards,
Jagadish
On Fri, Feb 15, 2013 at 1:24 PM, Justin Pettit wrote:
> The VXLAN chang
The ethernet type of an encapsulated frame may be obtained from
actions. If so it should be used to correct decoding of L3 and L4
packet data.
Signed-off-by: Simon Horman
---
v2.14 - v2.19
* No change
v2.13
* As suggested by Jarno Rajahalme
- Initialise encap_eth_type as 0 in ovs_dp_process_
This adds support for the OpenFlow 1.1+ set_mpls_ttl action.
And also adds an NX set_mpls_ttl action.
The handling of the TTL modification is entirely handled in userspace.
Reviewed-by: Isaku Yamahata
Signed-off-by: Simon Horman
---
v2.19
* If a SET_MPLS_TTL action can't be processed
then s
Allow datapath to recognize and extract MPLS labels into flow keys
and execute actions which push, pop, and set labels on packets.
Based heavily on work by Leo Alterman and Ravi K.
Cc: Ravi K
Cc: Leo Alterman
Reviewed-by: Isaku Yamahata
Signed-off-by: Simon Horman
---
v2.18 - v2.19
* No cha
The ethernet type of an encapsulated frame may be obtained from
actions. If so it should be used to allow a richer conversion
of a flow to nlattrs.
Signed-off-by: Simon Horman
---
v2.18 - v2.19
* No change
v2.17
* Rebase
v2.12 - v2.16
* No change
v2.11
* First post
---
datapath/datapath.c
This adds support for the OpenFlow 1.1+ dec_mpls_ttl action.
And also adds an NX dec_mpls_ttl action.
The handling of the TTL modification is entirely handled in userspace.
Reviewed-by: Isaku Yamahata
Signed-off-by: Simon Horman
---
v2.18 - v2.19
* No change
v2.17
* Rebase
* As suggested by
Allow a flow to be visible in two forms, an outer flow and an inner flow.
This may occur if the actions allow further decoding of a packet to
provide a more fine-grained match. In this case the first-pass
coarse-grained match will hit the outer-flow and the second-pass
fined-grained match will hit
This adds support for the OpenFlow 1.1+ copy_ttl_out action.
And also adds an NX copy_ttl_out action.
The implementation does not support copying in the case where the outermost
header is IP as it is unclear to me that Open vSwtich has a notion of an
inner IP header to copy the TLL from.
The hand
Allow repeated extraction of flow from packets
Split the L3 and above portion of ovs_flow_extract() out into
ovs_flow_extract_l3_onwards() and call ovs_flow_extract_l3_onwards()
from ovs_flow_extract().
This is to allow re-extraction of L3 and higher information using
an ethernet type supplied by
Allow copy_ttl_in to function in the case where:
a) The outer header is MPLS;
b) The next-outer header is IP and;
c) The resulting nw ttl will be different from its existing value
In this circumstance a set ipv4 action will be used to adjust the TTL
but the dl_type of the match will be ETH_P_MPLS_
This is the user-space datapath component of this change
Allow a flow to be visible in two forms, an outer flow and an inner flow.
This may occur if the actions allow further decoding of a packet to
provide a more fine-grained match. In this case the first-pass
coarse-grained match will hit the ou
When encoding MPLS information in ODP flow key data use encap()
for encap for frames. This seems to be in keeping with datapath/README.
before: eth(...), eth_type(0x8847), mpls(...), encap(ip(...), tcp(...))
after: eth(...), eth_type(0x8847), mpls(...), ip(...), tcp(...)
Suggested by Ben Pfaff
S
This adds support for the OpenFlow 1.1+ copy_ttl_in action.
And also adds an NX copy_ttl_out action.
The implementation does not support copying in the case where the outermost
header is IP as it is unclear to me that Open vSwtich has a notion of an
inner IP header to copy the TLL from.
The imple
This is in preparation for allowing do_xlate_actions to decode flow
information from a packet, thus updating the packet.
Signed-off-by: Simon Horman
---
v2.19
* Initial post
---
ofproto/ofproto-dpif.c | 14 +++---
1 file changed, 7 insertions(+), 7 deletions(-)
diff --git a/ofproto/
If the actions of a flow allow further decoding of L3 and L4 data to
provide a richer match then use this richer match.
For example:
In the case of MPLS, L3 and L4 information may not initially be decoded
from the frame as the ethernet type of the frame is an MPLS type and no
information is known
Actions may provide information to allow further decoding of a flow.
This allows decoding of encapsulated frames.
For example:
In the case of MPLS, L3 and L4 information may not initially be decoded
from the frame as the ethernet type of the frame is an MPLS type and no
information is
Hi,
This series implements MPLS actions and matches based on work by
Ravi K, Leo Alterman and Yamahata-san.
The main limitation of this implementation is that it only supports
manipulating the outer-most MPLS label.
It builds on the MPLS support present in master, extending the user-space
featur
57 matches
Mail list logo
