[ovs-dev] [PATCH 3/4] vswitchd: Add new configuration table for IPFIX collectors.

2013-01-18 Thread Romain Lenglet
Signed-off-by: Romain Lenglet --- ofproto/automake.mk | 2 + ofproto/ofproto-dpif-ipfix.c | 126 +++ ofproto/ofproto-dpif-ipfix.h | 28 ++ ofproto/ofproto-dpif.c | 25 + ofproto/ofproto-provider.h | 8 +++ ofproto/ofpr

[ovs-dev] updated IPFIX patches

2013-01-18 Thread Romain Lenglet
Hi Ben, Thanks for your comments! I updated all patches to address your comments: forbid sampling probability 0 in the sample_ipfix action, mention IPFIX in the documentation where NetFlow is mentioned, etc. -- Romain Lenglet ___ dev mailing list dev@open

[ovs-dev] [PATCH 2/4] ofproto: Translate NXAST_SAMPLE_IPFIX actions into SAMPLE dp actions

2013-01-18 Thread Romain Lenglet
Signed-off-by: Romain Lenglet --- lib/odp-util.c | 19 lib/odp-util.h | 9 +- ofproto/ofproto-dpif.c | 84 +- tests/odp.at | 1 + 4 files changed, 98 insertions(+), 15 deletions(-) diff --git a/lib/odp-u

[ovs-dev] [PATCH 1/4] ofp-actions: Add the NXAST_SAMPLE_IPFIX vendor action

2013-01-18 Thread Romain Lenglet
Define NXAST_SAMPLE_IPFIX OpenFlow vendor action and the corresponding OFPACT_SAMPLE_IPFIX OVS action. Signed-off-by: Romain Lenglet --- FAQ | 13 ++-- NEWS | 1 + WHY-OVS | 17 ++--- debian/control| 160

Re: [ovs-dev] [PATCH 3/4] vswitchd: Add new configuration table for IPFIX collectors.

2013-01-18 Thread Romain Lenglet
On Jan 17, 2013, at 4:08 PM, Jesse Gross wrote: > On Thu, Jan 17, 2013 at 3:07 PM, Ben Pfaff wrote: >> On Thu, Jan 17, 2013 at 03:00:20PM -0800, Jesse Gross wrote: >>> On Thu, Jan 17, 2013 at 2:49 PM, Ben Pfaff wrote: On Thu, Jan 17, 2013 at 02:19:45PM -0800, Ben Pfaff wrote: > On Fri,

Re: [ovs-dev] [PATCH 3/4] vswitchd: Add new configuration table for IPFIX collectors.

2013-01-18 Thread Romain Lenglet
On Jan 17, 2013, at 2:19 PM, Ben Pfaff wrote: > On Fri, Jan 11, 2013 at 09:55:43AM -0800, Romain Lenglet wrote: >> Signed-off-by: Romain Lenglet > > The schema limits each bridge to at most one IPFIX collector. Is > there an a priori reason why this is limited? It seems to me that one > could

Re: [ovs-dev] [PATCH 4/4] ofproto: Implement IPFIX exporter

2013-01-18 Thread Romain Lenglet
On Jan 17, 2013, at 2:45 PM, Ben Pfaff wrote: Thanks for your comments! I have updated patches 1/4, 2/4, and 4/4 according to your comments. I really appreciate your patch for the sparse warnings. [...] > /* Cf. IETF RFC 5101 Section 3.1. */ > struct ipfix_header { > -uint16_t version; /*

Re: [ovs-dev] [PATCH] v4 datapath: More flexible kernel/userspace tunneling attribute.

2013-01-18 Thread Pravin Shelar
Thanks, I pushed it to master and 1.9. On Fri, Jan 18, 2013 at 4:59 PM, Jesse Gross wrote: > On Fri, Jan 18, 2013 at 4:00 PM, Pravin B Shelar wrote: >> v3-v4: >> - Fixed action buffer alloc. >> - Fixed coding style. >> - Fixed ipv4-tunnel attr handling. >> v2-v3: >> - improved action buffer

[ovs-dev] [PATCH] bridge: Append the ovs_rundir to socket.

2013-01-18 Thread Pavithra Ramesh
If socket path specified in the set-controller command is relative to ovs_rundir(), append the directory name to target. Bug#14029 Signed-off-by: Pavithra Ramesh --- vswitchd/bridge.c | 38 +++--- 1 file changed, 23 insertions(+), 15 deletions(-) diff --git a/v

Re: [ovs-dev] [PATCH] v4 datapath: More flexible kernel/userspace tunneling attribute.

2013-01-18 Thread Jesse Gross
On Fri, Jan 18, 2013 at 4:00 PM, Pravin B Shelar wrote: > v3-v4: > - Fixed action buffer alloc. > - Fixed coding style. > - Fixed ipv4-tunnel attr handling. > v2-v3: > - improved action buffer alloc. > - Fixed netlinkattr names. > - Fixed error case. > - Fixed ttl checks. > v1-v2: > - Fixe

[ovs-dev] [PATCH] v4 datapath: More flexible kernel/userspace tunneling attribute.

2013-01-18 Thread Pravin B Shelar
v3-v4: - Fixed action buffer alloc. - Fixed coding style. - Fixed ipv4-tunnel attr handling. v2-v3: - improved action buffer alloc. - Fixed netlinkattr names. - Fixed error case. - Fixed ttl checks. v1-v2: - Fixed sample action. - Fixed set ipv4 - tunnel. - Converted flags to netlink flag

Re: [ovs-dev] [PATCH] v3 datapath: More flexible kernel/userspace tunneling attribute.

2013-01-18 Thread Jesse Gross
On Thu, Jan 17, 2013 at 8:06 PM, Pravin B Shelar wrote: > diff --git a/datapath/datapath.c b/datapath/datapath.c > index ed69af8..ab978f4 100644 > --- a/datapath/datapath.c > +++ b/datapath/datapath.c > +static struct nlattr *reserve_sfa_size(struct sw_flow_actions **sfa, int > attr_len) > +{ > +