Great, thanks for the reviews, I'll merge the series shortly.
Ethan
On Thu, Jan 3, 2013 at 5:11 PM, Jesse Gross wrote:
> On Thu, Jan 3, 2013 at 4:35 PM, Ethan Jackson wrote:
> > Oops thanks for pointing that out. This version moves the unassociated
> port
> > log message back to handle_miss_u
On Thu, Jan 3, 2013 at 4:35 PM, Ethan Jackson wrote:
> Oops thanks for pointing that out. This version moves the unassociated port
> log message back to handle_miss_upcall(). This turned out to be a bit awkward
> to implement, so I had to refactor the patch slightly. The main difference is
> th
On Thu, Jan 3, 2013 at 4:52 PM, Ben Pfaff wrote:
> Signed-off-by: Ben Pfaff
> ---
> FAQ |8
> 1 files changed, 4 insertions(+), 4 deletions(-)
Looks good.
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/de
Signed-off-by: Ben Pfaff
---
FAQ |8
1 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/FAQ b/FAQ
index dfe8242..a5c0cb9 100644
--- a/FAQ
+++ b/FAQ
@@ -133,10 +133,10 @@ Q: What Linux kernel versions does each Open vSwitch
release work with?
A: The following table lists
On Thu, Jan 03, 2013 at 04:45:14PM -0800, Ethan Jackson wrote:
> > This will cause the Ethernet address of vports to change randomly
> > whenever ovs-vswitchd is restarted. I don't know whether that is
> > important.
>
> I don't think this is a problem. The ethernet addresses are really only
> u
> This will cause the Ethernet address of vports to change randomly
> whenever ovs-vswitchd is restarted. I don't know whether that is
> important.
>
I don't think this is a problem. The ethernet addresses are really only
used in protocols (e.g. CFM) which will be pretty disrupted on restart
any
> I didn't notice this before but using sizeof mac here (and in the get
> function) is actually going to result in copying a pointer's worth of
> data so I think you want to explicitly use ETH_ADDR_LEN.
>
Good catch, changed.
Ethan
___
dev mailing list
This has annoyed me for a while too. Thanks.
Acked-by: Ethan Jackson
On Wed, Jan 2, 2013 at 5:10 PM, Ben Pfaff wrote:
> The customary parameter order in Open vSwitch is to put input parameters
> before output parameters, but vconn_open() and pvconn_open() had the 'dscp'
> input parameter at
Oops thanks for pointing that out. This version moves the unassociated port
log message back to handle_miss_upcall(). This turned out to be a bit awkward
to implement, so I had to refactor the patch slightly. The main difference is
that now ofproto_receive() returns an errno (as Ben suggested ea
On Thu, Jan 03, 2013 at 01:14:51PM -0800, Chris Wright wrote:
> * christopher barry (cba...@rjmetrics.com) wrote:
> > What will be the latest valid tag to build from to include brcompat?
>
> it's still there (just deprecated and gives a warning). so at least
> v1.9.x tags will have it (in depreca
On Thu, Jan 3, 2013 at 11:20 AM, Ben Pfaff wrote:
> On Thu, Jan 03, 2013 at 10:42:59AM -0800, Gurucharan Shetty wrote:
> > On Mon, Nov 26, 2012 at 10:11 AM, Ben Pfaff wrote:
> >
> > > From: Jarno Rajahalme
> > >
> > > Add OFPP_ANY to include/openflow/openflow-1.1.h, and allow it as a
> port in
* christopher barry (cba...@rjmetrics.com) wrote:
> What will be the latest valid tag to build from to include brcompat?
it's still there (just deprecated and gives a warning). so at least
v1.9.x tags will have it (in deprecated/warning form).
thanks,
-chris
_
On Thu, Jan 03, 2013 at 08:17:16PM +, Jing Ai wrote:
>
> Thanks Ben. You solution looks better.
>
> I have no further comments on your codes and tests. Also, I have
> tested it manually by running various combinations of
> instructions/actions and it works as intended.
Thanks for reviewing an
Thanks Ben. You solution looks better.
I have no further comments on your codes and tests. Also, I have tested it
manually by running various combinations of instructions/actions and it works
as intended.
One more question, do you think we should normalize any action specified after
resubmit ac
On Thu, Jan 03, 2013 at 10:42:59AM -0800, Gurucharan Shetty wrote:
> On Mon, Nov 26, 2012 at 10:11 AM, Ben Pfaff wrote:
>
> > From: Jarno Rajahalme
> >
> > Add OFPP_ANY to include/openflow/openflow-1.1.h, and allow it as a port in
> > queue stats request. Make ovs_ofctl use OFPP_ANY instead of O
What will be the latest valid tag to build from to include brcompat?
Thanks,
-C
On Thu, 2012-12-27 at 13:51 -0800, Pravin Shelar wrote:
> Thanks, Pushed to master and 1.9.
>
>
> On Wed, Dec 26, 2012 at 10:50 AM, Ben Pfaff wrote:
> On Wed, Dec 26, 2012 at 10:38:37AM -0800, Pravin B Shel
On Mon, Nov 26, 2012 at 10:11 AM, Ben Pfaff wrote:
> From: Jarno Rajahalme
>
> Add OFPP_ANY to include/openflow/openflow-1.1.h, and allow it as a port in
> queue stats request. Make ovs_ofctl use OFPP_ANY instead of OFPP_ALL for
> queue
> stats requests on OF 1.1+.
>
> This patch changes "none"
Thanks for confirming the fix. I'll take a look at the second patch
then.
On Thu, Jan 03, 2013 at 05:15:35PM +, Zoltan Kiss wrote:
> Hi,
>
> I've tested with your fix (865f22b3b3cb9), and it solves the problem
> indeed. My approach to fix the problem is based on the comment of
> the tag memb
Hi,
What do you thin about this another rebalance change? Even with the flow
tagging fix I've seen decreased performance as vswitchd shifts traffic
around all the time unnecessarily:
Jan 3 17:18:08 localhost ovs-vswitchd: 00083|bond|INFO|bond bond0:
shift 105838kB of load (with hash 3) from
Hi,
I've tested with your fix (865f22b3b3cb9), and it solves the problem
indeed. My approach to fix the problem is based on the comment of the
tag member:
/* A hash bucket for mapping a flow to a slave.
* "struct bond" has an array of (BOND_MASK + 1) of these. */
struct bond_entry {
stru
On Thu, Jan 03, 2013 at 06:41:37AM +, Jing Ai wrote:
> In the current codes, when running "ovs-ofctl add-flow br0 conditions>,actions=write_metadata:<64-bit
> metadata>,goto_table:", it gives the following
> error:2012-12-29T00:23:23Z|1|ofp_actions|WARN|write_metadata
> instruction must be
I'm not sure whether the original poster is asking the difference
between OVS and the Linux bridge or between a bridge and a switch. In
the latter case:
Q: I thought Open vSwitch was a virtual Ethernet switch, but the
documentation keeps talking about bridges. What's a bridge?
A: In networki
It's the same.
On Wed, Jan 2, 2013 at 9:36 PM, APURVA PATIL wrote:
> And how does that occur in Bridge networking ??
>
>
>
>
>
> On Thu, Jan 3, 2013 at 10:19 AM, Jesse Gross wrote:
>>
>> On Wed, Jan 2, 2013 at 7:48 PM, APURVA PATIL wrote:
>> >
>> > On establishing the open-vSwitch connection on
23 matches
Mail list logo
