Re: [ovs-dev] [PATCH 02/13] Upstream GRE : Refactor code GRE code.

On Sat, Dec 15, 2012 at 2:27 AM, Jesse Gross wrote: > On Fri, Dec 14, 2012 at 11:40 AM, Pravin Shelar > wrote: > > On Wed, Dec 12, 2012 at 8:04 AM, Jesse Gross wrote: > >> > >> Thanks and sorry that I took so long to get back to you. > >> > >> I thought about the layering a fair amount and am s

Re: [ovs-dev] [PATCH 12/19] datapath: Allow inner_flows

Found one typo. Minor comment. there are many eth_type == ETH_P_MPLS_UC || eth_type == ETH_P_MPLS_UC. So how about introducing helper function like bool eth_p_mpls(eth_type). On Mon, Dec 24, 2012 at 11:35:18AM +0900, Simon Horman wrote: > Allow a flow to be visible in two forms, an outer flow and

Re: [ovs-dev] [PATCH 09/19] datapath: Use NULL in skb_cb_mpls_bos

Although this can be merged into the 1st patch, the patch itself Looks good. On Mon, Dec 24, 2012 at 11:35:15AM +0900, Simon Horman wrote: > Use NULL instead of 0 to denote a NULL pointer. > > Signed-off-by: Simon Horman > --- > datapath/datapath.c |2 +- > 1 file changed, 1 insertion(+), 1

Re: [ovs-dev] [PATCH 08/19] datapath: Update skb transport and network headers on MPLS extraction

On Mon, Dec 24, 2012 at 11:35:14AM +0900, Simon Horman wrote: > When an MPLS header is extracted the skb is updated. > This should include updating the transport and network headers. > > Signed-off-by: Simon Horman > --- > datapath/flow.c |6 ++ > 1 file changed, 6 insertions(+) > > dif

Re: [ovs-dev] [PATCH 28/29] net/: rename net_random() to prandom_u32()

On Mon, Dec 24, 2012 at 11:14:15AM +0900, Akinobu Mita wrote: > Use more preferable function name which implies using a pseudo-random > number generator. > > Signed-off-by: Akinobu Mita > Cc: Jesse Gross > Cc: Venkat Venkatsubra > Cc: Vlad Yasevich > Cc: Sridhar Samudrala > Cc: Neil Horman >