Re: [ovs-dev] [PATCH 2/2] ofp-util: Check out_group on flow_mod only for "delete" commands.

2012-11-26 Thread Jarno Rajahalme
Here is the Signed-off-by line for this patch: Signed-off-by: Jarno Rajahalme On Nov 26, 2012, at 20:11 , ext Ben Pfaff wrote: > From: Jarno Rajahalme > > This conforms with OpenFlow 1.1+ wording. > --- > lib/ofp-util.c |4 +++- > 1 files changed, 3 insertions(+), 1 deletions(-) > > diff

Re: [ovs-dev] [PATCH 1/2] Fix handling of OFPP_ANY in OpenFlow 1.1 and later.

2012-11-26 Thread Jarno Rajahalme
On Nov 26, 2012, at 20:11 , ext Ben Pfaff wrote: > From: Jarno Rajahalme > > Add OFPP_ANY to include/openflow/openflow-1.1.h, and allow it as a port in > queue stats request. Make ovs_ofctl use OFPP_ANY instead of OFPP_ALL for queue > stats requests on OF 1.1+. > > This patch changes "none" por

Re: [ovs-dev] [PATCH 2/2] ofproto-dpif: Initialize odp_port to OVSP_NONE in port_construct().

2012-11-26 Thread Ben Pfaff
It would be an error for cleanup code to reference the odp_port, but I suppose that's part of your point. This is fine with me, feel free to commit it. On Mon, Nov 26, 2012 at 12:27:16PM -0800, Ethan Jackson wrote: > I'm worried about dpif_port_query_by_name() failing, returning an error, > and t

Re: [ovs-dev] [PATCH 1/2] ofproto-dpif: Properly handle ports with no datapath port number.

2012-11-26 Thread Ethan Jackson
> Does this fix a user-visible bug? It would be good to note that in the > commit log, if it does. > Nope, just noticed it reading the code. I'll add a "Found by inspection." to the log for clarity. Ethan ___ dev mailing list dev@openvswitch.org http:

Re: [ovs-dev] [PATCH 2/2] ofproto-dpif: Initialize odp_port to OVSP_NONE in port_construct().

2012-11-26 Thread Ethan Jackson
I'm worried about dpif_port_query_by_name() failing, returning an error, and then some cleanup code referencing the odp_port. I don't like the idea of uninitialized data leaving the port_construct() function, even if it's garbage that's intended to be destroyed. That said, I don't feel that stron

Re: [ovs-dev] [PATCH OF12+ 2/4] Initial OpenFlow 1.3 support

2012-11-26 Thread Ben Pfaff
On Mon, Nov 26, 2012 at 06:50:26PM +0200, Jarno Rajahalme wrote: > >Initial OpenFlow 1.3 support with new include/openflow/openflow-1.3.h. >Most of the messages that differ from 1.2 are implemented. OFPT_SET_ASYNC >is implemented via NX_SET_ASYNC_CONFIG, other new message types are >

Re: [ovs-dev] [PATCH OF12+ 1/4 v3] OpenFlow 1.2 fixes

2012-11-26 Thread Ben Pfaff
On Mon, Nov 26, 2012 at 06:17:08PM +0200, Jarno Rajahalme wrote: >OpenFlow 1.2 protocol fixes: Add OFPP_ANY to > include/openflow/openflow-1.1.h, >and allow it as a port in queue stats request. Make ovs_ofctl use OFPP_ANY >instead of OFPP_ALL for queue stats requests on OF 1.1+. >D

[ovs-dev] [PATCH 2/2] ofp-util: Check out_group on flow_mod only for "delete" commands.

2012-11-26 Thread Ben Pfaff
From: Jarno Rajahalme This conforms with OpenFlow 1.1+ wording. --- lib/ofp-util.c |4 +++- 1 files changed, 3 insertions(+), 1 deletions(-) diff --git a/lib/ofp-util.c b/lib/ofp-util.c index b7feff8..bab6b2c 100644 --- a/lib/ofp-util.c +++ b/lib/ofp-util.c @@ -1435,7 +1435,9 @@ ofputil_dec

[ovs-dev] [PATCH 1/2] Fix handling of OFPP_ANY in OpenFlow 1.1 and later.

2012-11-26 Thread Ben Pfaff
From: Jarno Rajahalme Add OFPP_ANY to include/openflow/openflow-1.1.h, and allow it as a port in queue stats request. Make ovs_ofctl use OFPP_ANY instead of OFPP_ALL for queue stats requests on OF 1.1+. This patch changes "none" ports print out. "none" is still accepted on input for backwards co

Re: [ovs-dev] [PATCH 13/13] Upstream VXLAN: Use UDP Tunnel segmention.

2012-11-26 Thread Stephen Hemminger
Thanks for cleaning up the tunnel infrastructure, it is long over due. Shouldn't this go to the upstream mailing list (net...@vger.kernel.org) instead of being on the OVS mailing list? If you get it submitted right now it could make it in for the 3.8 merge window. There are also the IPv6 tunnels

[ovs-dev] [PATCH OF12+ 1/4 v3] OpenFlow 1.2 fixes

2012-11-26 Thread Jarno Rajahalme
OpenFlow 1.2 protocol fixes: Add OFPP_ANY to include/openflow/openflow-1.1.h, and allow it as a port in queue stats request. Make ovs_ofctl use OFPP_ANY instead of OFPP_ALL for queue stats requests on OF 1.1+. Do not check out_group on flow_mod unless the command is DELETE*. As part of

[ovs-dev] From Mrs Gloria Imo

2012-11-26 Thread Gloria Imo
>From Mrs Gloria Imo Saudações.   Saudações a você e sua família em nome de Deus, agradeço-lhe muito para a sua aceitação para me adicionar na sua lista cnection e na minha busca por uma temendo confiável e Deus pessoa e ter obtido o seu contacto através de orações e as dores tomando esforços at