[ovs-dev] [of1.2 5/5] nicira-ext: Remove NXFF_OPENFLOW12.

2012-11-15 Thread Ben Pfaff
This was meant to splice OXM support into OpenFlow 1.0, in place of NXM, but I no longer see any value in it. Signed-off-by: Ben Pfaff --- include/openflow/nicira-ext.h |3 +-- lib/ofp-msgs.h|2 +- lib/ofp-util.c|9 +++-- 3 files changed, 5 inserti

[ovs-dev] [of1.2 4/5] ofp-util: Make ofputil_encode_set_protocol() able to return failure.

2012-11-15 Thread Ben Pfaff
Soon, it's not going to be possible to switch between every possible protocol on an established OpenFlow connection, yet ofputil_encode_set_protocol() didn't have a documented way to report such a problem. This commit adds a means for reporting and makes its callers able to handle the problem. Al

[ovs-dev] [of1.2 3/5] ofp-util: Allow use of OpenFlow 12 flow format

2012-11-15 Thread Ben Pfaff
This enables the use of the OpenFlow 12 flow format. Signed-off-by: Simon Horman Signed-off-by: Ben Pfaff --- lib/ofp-util.c | 58 ++-- lib/ofp-util.h |6 -- tests/learn.at |2 +- tests/ovs-ofctl.at | 12 +-- 4

[ovs-dev] [of1.2 2/5] ofp-util: Rename OFPUTIL_P_* constants and update comments for clarity.

2012-11-15 Thread Ben Pfaff
It wasn't clear to me, at least, whether an OFPUTIL_P_* constant indicated an OpenFlow version and a flow format or just a flow format. After some reflection, I think it's more useful if it indicates both, because otherwise it might be necessary to pass both an OpenFlow version and an OFPUTIL_P_* c

[ovs-dev] [of1.2 1/5] ovs-ofctl: Style fix.

2012-11-15 Thread Ben Pfaff
Signed-off-by: Ben Pfaff --- utilities/ovs-ofctl.c |3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/utilities/ovs-ofctl.c b/utilities/ovs-ofctl.c index 0c146a4..914be98 100644 --- a/utilities/ovs-ofctl.c +++ b/utilities/ovs-ofctl.c @@ -319,7 +319,8 @@ ofctl_exit(struct uni

[ovs-dev] [of1.2 0/5] enable oxm flow format

2012-11-15 Thread Ben Pfaff
See http://openvswitch.org/pipermail/dev/2012-November/022990.html for background. Ben Pfaff (5): ovs-ofctl: Style fix. ofp-util: Rename OFPUTIL_P_* constants and update comments for clarity. ofp-util: Allow use of OpenFlow 12 flow format ofp-util: Make ofputil_encode_set_protocol() ab

Re: [ovs-dev] [PATCH 1/9] ofp-util: Allow use of OpenFlow 12 flow format

2012-11-15 Thread Ben Pfaff
On Fri, Nov 16, 2012 at 11:22:41AM +0900, Simon Horman wrote: > This enables the use of the OpenFlow 12 flow format. > > Signed-off-by: Simon Horman I made some changes to this: * I don't really like OFPUTIL_P_NXM_ANY_OR_OF11_PLUS and similar names. * I think that "OX

Re: [ovs-dev] [PATCH 07/14] vswitchd: Configuration of allowed OpenFlow versions

2012-11-15 Thread Ben Pfaff
On Fri, Nov 16, 2012 at 10:43:39AM +0900, Simon Horman wrote: > On Mon, Nov 12, 2012 at 10:23:00AM -0800, Ben Pfaff wrote: > > On Wed, Nov 07, 2012 at 05:03:05PM +0900, Simon Horman wrote: > > > Versions may be configured using a comma delimited list as > > > the value for 'openflow-versions' the '

Re: [ovs-dev] [PATCHv2] datapath: add skb mark matching and set action

2012-11-15 Thread Jesse Gross
On Thu, Nov 15, 2012 at 11:07 AM, Ansis Atteka wrote: > diff --git a/datapath/datapath.c b/datapath/datapath.c > index e359ac0..778f8e3 100644 > --- a/datapath/datapath.c > +++ b/datapath/datapath.c > @@ -595,6 +595,12 @@ static int validate_set(const struct nlattr *a, > case OVS_KEY_ATTR

[ovs-dev] [PATCH 6/6] Add support for copy_ttl_in action

2012-11-15 Thread Simon Horman
This adds support for the OpenFlow 1.1+ copy_ttl_in action. And also adds an NX copy_ttl_out action. The implementation does not support copying in the case where the outermost header is IP as it is unclear to me that Open vSwtich has a notion of an inner IP header to copy the TLL from. The imple

[ovs-dev] [PATCH 5/6] Add support for copy_ttl_out action

2012-11-15 Thread Simon Horman
This adds support for the OpenFlow 1.1+ copy_ttl_out action. And also adds an NX copy_ttl_out action. The implementation does not support copying in the case where the outermost header is IP as it is unclear to me that Open vSwtich has a notion of an inner IP header to copy the TLL from. The hand

[ovs-dev] [PATCH 4/6] Add support for set_mpls_ttl action

2012-11-15 Thread Simon Horman
This adds support for the OpenFlow 1.1+ set_mpls_ttl action. And also adds an NX set_mpls_ttl action. The handling of the TTL modification is entirely handled in userspace. Reviewed-by: Isaku Yamahata Signed-off-by: Simon Horman --- v2.7 * Encode action as OFP11 action in OFP11+ messages v2.

[ovs-dev] [PATCH 3/6] Add support for dec_mpls_ttl action

2012-11-15 Thread Simon Horman
This adds support for the OpenFlow 1.1+ dec_mpls_ttl action. And also adds an NX dec_mpls_ttl action. The handling of the TTL modification is entirely handled in userspace. Reviewed-by: Isaku Yamahata Signed-off-by: Simon Horman --- v2.7 * Encode action as OFP11 action in OFP11+ messages v2.

[ovs-dev] [PATCH 1/6] datapath: Add basic MPLS support to kernel

2012-11-15 Thread Simon Horman
Allow datapath to recognize and extract MPLS labels into flow keys and execute actions which push, pop, and set labels on packets. Based heavily on work by Leo Alterman and Ravi K. Cc: Ravi K Cc: Leo Alterman Reviewed-by: Isaku Yamahata Signed-off-by: Simon Horman --- v2.7 * Rebase v2.6 *

[ovs-dev] [PATCH 0/6 v2.7] Basic MPLS actions and matches

2012-11-15 Thread Simon Horman
Hi, This series implements basic MPLS actions and matches based on work by Ravi K, Leo Alterman and Yamahata-san. The main limitation of this implementation is that it only supports manipulating the outer-most MPLS label. Key difference between the previous post, v2.6: * When encoding TTL actio

[ovs-dev] [PATCH 3/9] vswitchd: Configuration of allowed OpenFlow versions

2012-11-15 Thread Simon Horman
Versions may be configured using the protocols column of the bridge table. The protocols column is a set which accepts zero or more of the values: 'OpenFlow10' and 'OpenFlow12'. If the protocols column is empty, then OpenFlow10 is used. This default is consistent with the behaviour of ovs-vswtichd

[ovs-dev] [PATCH 4/9] lib: Add helpers for OpenFlow version command line options

2012-11-15 Thread Simon Horman
Signed-off-by: Simon Horman --- v4 * Rebase --- lib/automake.mk |3 +++ lib/ofp-version-opt.c | 42 ++ lib/ofp-version-opt.h | 28 lib/ofp-version.man | 26 ++ 4 files changed, 99 inse

[ovs-dev] [PATCH 9/9] test: add ofproto OpenFlow1.2 tests

2012-11-15 Thread Simon Horman
These were useful in isolating a number of bugs. Signed-off-by: Simon Horman --- The "ofproto - flow table configuration (OpenFlow 1.2)]" test will need to be updated for the MPLS changes that are outstanding as they change the following: wild=0xf -> wild=0x1f match=0xf

[ovs-dev] [PATCH 8/9] ofp-util: Flow Dump Protocol for OpenFlow 12

2012-11-15 Thread Simon Horman
Allow only OpenFlow 12 as a flow dump protocol for OpenFlow12. Allow OpenFlow10 and NXM as flow dump protocols for other OpenFlow versions. This only changes the behaviour prior to this patch in the case of OpenFlow12 which seemed broken as an attempt would be made to set NXM as the flow dump forma

[ovs-dev] [PATCH 5/9] ovs-ofctl: Add option to set allowed OpenFlow versions

2012-11-15 Thread Simon Horman
--allowed-ofp-versions allows configuration of the versions that may be used when establishing an OpenFlow connection. The default is 'OpenFlow10' which is consistent with the behaviour prior to this patch. The useful values at this time are: 'OpenFlow10', 'OpenFlow12' and 'OpenFlow10,OpenFlow12'

[ovs-dev] [PATCH 6/9] ovs-controller: Allow setting of allowed OpenFlow versions

2012-11-15 Thread Simon Horman
--allowed-ofp-versions allows configuration of the versions that may be used when establishing an OpenFlow connection. The default is 'OpenFlow10' which is consistent with the behaviour prior to this patch. The useful values at this time are: 'OpenFlow10', 'OpenFlow12' and 'OpenFlow10,OpenFlow12'

[ovs-dev] [PATCH 7/9] ovs-ofctl: By default, do not set flow format for OpenFlow 1.1+

2012-11-15 Thread Simon Horman
Only set the default format for ovs-ofctl monitor if OpenFlow 1.0 is the prevailing version. IMHO that is the only case where it makes sense. Signed-off-by: Simon Horman --- v4 * Rebase --- utilities/ovs-ofctl.c | 36 +++- 1 file changed, 23 insertions(+), 13

[ovs-dev] [PATCH v5 0/9] Run-Time Open Flow Version Configuration

2012-11-15 Thread Simon Horman
Hi, This series adds run-time configuration of allowed OpenFlow versions to ovs-vswtichd, ovs-ofctl and ovs-controller; and adds tests for Open Flow 1.2 messages that utilise the run-time configuration of allowed OpenFlow versions. Changes since v4: * Rebased, including dropping patches from v4

[ovs-dev] [PATCH 1/9] ofp-util: Allow use of OpenFlow 12 flow format

2012-11-15 Thread Simon Horman
This enables the use of the OpenFlow 12 flow format. Signed-off-by: Simon Horman --- v5 * As suggested by Ben Pfaff: - Fold "ofp-util: Open Flow 1.1 and 1.2 flow format capabilities" into this patch v4 * Rebase --- lib/ofp-util.c | 32 lib/ofp-util.

[ovs-dev] [PATCH 2/9] connmgr: Use version of underlying rconn

2012-11-15 Thread Simon Horman
Signed-off-by: Simon Horman --- v5 * Use #define for OFPUTIL_P_NONE * Ensure that if ofconn->rconn is connected that a valid value for ofconn->protocol is always used by fetching the value from the rconn in ofconn_get_protocol() as necessary and always using ofconn_get_protocol() to access

Re: [ovs-dev] [PATCH 05/14] ofp-util: Allow use of OpenFlow 12 flow format

2012-11-15 Thread Simon Horman
On Mon, Nov 12, 2012 at 09:57:26AM -0800, Ben Pfaff wrote: > On Wed, Nov 07, 2012 at 05:03:03PM +0900, Simon Horman wrote: > > This enables the use of the OpenFlow 12 flow format. > > > > Signed-off-by: Simon Horman > > Based on "grep", I'm nervous that we're missing important handling for > OFP

Re: [ovs-dev] [PATCH 07/14] vswitchd: Configuration of allowed OpenFlow versions

2012-11-15 Thread Simon Horman
On Fri, Nov 16, 2012 at 10:43:39AM +0900, Simon Horman wrote: > On Mon, Nov 12, 2012 at 10:23:00AM -0800, Ben Pfaff wrote: > > On Wed, Nov 07, 2012 at 05:03:05PM +0900, Simon Horman wrote: > > > Versions may be configured using a comma delimited list as > > > the value for 'openflow-versions' the '

Re: [ovs-dev] [PATCH 07/14] vswitchd: Configuration of allowed OpenFlow versions

2012-11-15 Thread Simon Horman
On Mon, Nov 12, 2012 at 10:23:00AM -0800, Ben Pfaff wrote: > On Wed, Nov 07, 2012 at 05:03:05PM +0900, Simon Horman wrote: > > Versions may be configured using a comma delimited list as > > the value for 'openflow-versions' the 'other-config' column > > of the Bridge table. > > > > Currently list

Re: [ovs-dev] [PATCH 06/14] connmgr: Use version of underlying rconn

2012-11-15 Thread Simon Horman
On Mon, Nov 12, 2012 at 10:20:26AM -0800, Ben Pfaff wrote: > On Wed, Nov 07, 2012 at 05:03:04PM +0900, Simon Horman wrote: > > Signed-off-by: Simon Horman > > It seems that OFPUTIL_P_NONE is not really a meaningful protocol enum > value. It just ends up being marked as NOT_REACHED() in every swi

Re: [ovs-dev] VXLAN source port hashing performance problems

2012-11-15 Thread Kyle Mestery (kmestery)
On Nov 15, 2012, at 3:13 PM, Kyle Mestery (kmestery) wrote: > On Nov 15, 2012, at 1:03 PM, Kyle Mestery (kmestery) > wrote: >> Jesse: >> >> I modified the source port hashing for the VXLAN patch I submitted a few >> days ago, >> but I've noticed when using the upstream source port hashing rout

Re: [ovs-dev] VXLAN source port hashing performance problems

2012-11-15 Thread Kyle Mestery (kmestery)
On Nov 15, 2012, at 1:03 PM, Kyle Mestery (kmestery) wrote: > Jesse: > > I modified the source port hashing for the VXLAN patch I submitted a few days > ago, > but I've noticed when using the upstream source port hashing routine, > performance > drops off by 3.5 times when using iperf between t

[ovs-dev] [PATCHv2] datapath: add skb mark matching and set action

2012-11-15 Thread Ansis Atteka
This patch adds support for skb mark matching and set action. Signed-off-by: Ansis Atteka --- datapath/actions.c |4 datapath/compat.h | 33 + datapath/datapath.c |7 +++ datapath/flow.c | 15

[ovs-dev] VXLAN source port hashing performance problems

2012-11-15 Thread Kyle Mestery (kmestery)
Jesse: I modified the source port hashing for the VXLAN patch I submitted a few days ago, but I've noticed when using the upstream source port hashing routine, performance drops off by 3.5 times when using iperf between two VMs. From what I can tell, it has to be that all skbuffs coming into th

Re: [ovs-dev] [PATCH 2/2] v3 odp-utils: Print human readable ipv4-tunnel-key flags

2012-11-15 Thread Pravin Shelar
Thanks, I pushed both patches to master and 1.9. On Wed, Nov 14, 2012 at 7:04 PM, Jesse Gross wrote: > On Wed, Nov 14, 2012 at 5:47 PM, Pravin B Shelar wrote: > >> Signed-off-by: Pravin B Shelar >> --- >> lib/odp-util.c | 43 --- >> tests/odp.at |

Re: [ovs-dev] [PATCH] datapath: add skb mark matching and set action

2012-11-15 Thread Jesse Gross
On Thu, Nov 15, 2012 at 9:02 AM, Ansis Atteka wrote: > On Wed, Nov 14, 2012 at 1:48 AM, Jesse Gross wrote: > > On Tue, Nov 13, 2012 at 9:52 AM, Ansis Atteka > wrote: > >> > >> diff --git a/datapath/actions.c b/datapath/actions.c > >> index 76c9823..5da4b74 100644 > >> --- a/datapath/actions.c >

Re: [ovs-dev] [PATCH] datapath: add skb mark matching and set action

2012-11-15 Thread Ansis Atteka
On Wed, Nov 14, 2012 at 1:48 AM, Jesse Gross wrote: > On Tue, Nov 13, 2012 at 9:52 AM, Ansis Atteka wrote: >> >> diff --git a/datapath/actions.c b/datapath/actions.c >> index 76c9823..5da4b74 100644 >> --- a/datapath/actions.c >> +++ b/datapath/actions.c >> @@ -435,6 +435,10 @@ static int execute

Re: [ovs-dev] [PATCH] ovs-ctl.in: increase the limit of fd

2012-11-15 Thread Ben Pfaff
On Wed, Nov 14, 2012 at 08:58:18PM +0800, Cong Wang wrote: > We can't create more than 248 bridges with the current limit 5000, > so increase it to 6000 so that at least 256+ bridges could be created. > > Cc: Ben Pfaff > Signed-off-by: Cong Wang I applied this to branch-1.[789]. ___

[ovs-dev] Administrador do Sistema

2012-11-15 Thread Web
Sua caixa de correio excedeu o limite de armazenamento de 2 GB, que é definido pelo administrador, 2.30GB atualmente em execução, você pode ser capaz de enviar ou receber novas mensagens Caixa de Entrada até que você validar seu postal.to revalidar sua caixa de correio. preenchimento próxima forma