[ovs-dev] [openvswitch:master 5/5] net/ipv6/exthdrs_core.c:188:27: error: 'OVS_IP6T_FH_F_SKIP_RH' undeclared

2012-11-09 Thread kbuild test robot
tree: git://git.kernel.org/pub/scm/linux/kernel/git/jesse/openvswitch.git master head: a5caca77cb46fb6e7055a5884c11c192a3bc3ae7 commit: a5caca77cb46fb6e7055a5884c11c192a3bc3ae7 [5/5] ipv6: improve ipv6_find_hdr() to skip empty routing headers config: make ARCH=x86_64 allyesconfig All error/w

Re: [ovs-dev] [PATCHv2 2/2] datapath: add ipv6 'set' action

2012-11-09 Thread Jesse Gross
I noticed a couple of minor things in the userspace code but it looks basically good to me. On Thu, Nov 8, 2012 at 5:14 AM, Ansis Atteka wrote: > diff --git a/lib/packets.c b/lib/packets.c > index 16f4fe6..6cb3a80 100644 > --- a/lib/packets.c > +++ b/lib/packets.c > +static bool > +packet_rh_pre

Re: [ovs-dev] [PATCHv2 2/2] datapath: add ipv6 'set' action

2012-11-09 Thread Jesse Gross
On Fri, Nov 9, 2012 at 3:40 AM, Ansis Atteka wrote: > On Fri, Nov 9, 2012 at 3:30 AM, Jesse Gross wrote: > > On Thu, Nov 8, 2012 at 5:14 AM, Ansis Atteka wrote: > >> > >> diff --git a/datapath/actions.c b/datapath/actions.c > >> index 8ec692d..317aa4a 100644 > >> --- a/datapath/actions.c > >> +

Re: [ovs-dev] is it unnecessary code line? datapath/flow.c #line 1303

2012-11-09 Thread Ben Pfaff
On Fri, Nov 09, 2012 at 01:34:30PM -0800, Jesse Gross wrote: > On Thu, Nov 8, 2012 at 1:06 AM, JieYue Ma wrote: > > > Hi, > > > > I am reading ovs code, while in function ovs_flow_to_nlattrs, we have > > > > ... > > if (swkey->eth.tci || swkey->eth.type == htons(ETH_P_8021Q)) { > > if

Re: [ovs-dev] is it unnecessary code line? datapath/flow.c #line 1303

2012-11-09 Thread Jesse Gross
On Thu, Nov 8, 2012 at 1:06 AM, JieYue Ma wrote: > Hi, > > I am reading ovs code, while in function ovs_flow_to_nlattrs, we have > > ... > if (swkey->eth.tci || swkey->eth.type == htons(ETH_P_8021Q)) { > if (nla_put_be16(skb, OVS_KEY_ATTR_ETHERTYPE, htons(ETH_P_8021Q)) > || >

Re: [ovs-dev] [PATCH] Prepare for 1.7.2.

2012-11-09 Thread Justin Pettit
On Nov 9, 2012, at 12:29 PM, Ben Pfaff wrote: > On Fri, Nov 09, 2012 at 12:27:48PM -0800, Justin Pettit wrote: >> Signed-off-by: Justin Pettit > > Looks good, thanks. Thanks. I pushed it. --Justin ___ dev mailing list dev@openvswitch.org http://

Re: [ovs-dev] [PATCH] Prepare for 1.7.2.

2012-11-09 Thread Ben Pfaff
On Fri, Nov 09, 2012 at 12:27:48PM -0800, Justin Pettit wrote: > Signed-off-by: Justin Pettit Looks good, thanks. ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

[ovs-dev] [PATCH] Prepare for 1.7.2.

2012-11-09 Thread Justin Pettit
Signed-off-by: Justin Pettit --- NEWS |4 configure.ac |2 +- debian/changelog |7 +++ 3 files changed, 12 insertions(+), 1 deletions(-) diff --git a/NEWS b/NEWS index 7cf5cd6..9e1e740 100644 --- a/NEWS +++ b/NEWS @@ -1,3 +1,7 @@ +v1.7.2 - 09 Nov 2012 +--

Re: [ovs-dev] [PATCH v3 4/9] net: openvswitch: use this_cpu_ptr per-cpu helper

2012-11-09 Thread Christoph Lameter
On Fri, 9 Nov 2012, Shan Wei wrote: > just use more faster this_cpu_ptr instead of per_cpu_ptr(p, > smp_processor_id()); Reviewed-by: Christoph Lameter ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

Re: [ovs-dev] [PATCH 01/14] ofp-util: Correct length of hello version bitmap

2012-11-09 Thread Ben Pfaff
On Wed, Nov 07, 2012 at 05:02:59PM +0900, Simon Horman wrote: > The length of the hello version bitmap is measured in bytes > so the return value of sizeof is sufficient. Dividing > this by CHAR_BIT (=8) seems to be an artifact of reworking > a previous version of this code. > > Signed-off-by: Sim

Re: [ovs-dev] [PATCHv2 2/2] datapath: add ipv6 'set' action

2012-11-09 Thread Ansis Atteka
On Fri, Nov 9, 2012 at 3:30 AM, Jesse Gross wrote: > On Thu, Nov 8, 2012 at 5:14 AM, Ansis Atteka wrote: >> >> diff --git a/datapath/actions.c b/datapath/actions.c >> index 8ec692d..317aa4a 100644 >> --- a/datapath/actions.c >> +++ b/datapath/actions.c >> +static void set_ipv6_addr(struct sk_buff