Re: [ovs-dev] [PATCH 1/3] ofp-actions: helper functions for of12 set-field action

2012-09-13 Thread Simon Horman
On Thu, Sep 13, 2012 at 09:28:50PM -0700, Ben Pfaff wrote: > On Fri, Sep 14, 2012 at 12:05:44PM +0900, Simon Horman wrote: > > On Thu, Sep 13, 2012 at 01:06:09PM -0700, Ben Pfaff wrote: > > > I get rejects on this against commit 307975da7 currently on master. > > > > > > As long as it needs a reba

Re: [ovs-dev] [PATCH 1/3] ofp-actions: helper functions for of12 set-field action

2012-09-13 Thread Ben Pfaff
On Fri, Sep 14, 2012 at 12:05:44PM +0900, Simon Horman wrote: > On Thu, Sep 13, 2012 at 01:06:09PM -0700, Ben Pfaff wrote: > > I get rejects on this against commit 307975da7 currently on master. > > > > As long as it needs a rebase anyhow, I see a few more changes I'd > > like: > > > > *

Re: [ovs-dev] [PATCH 1/3] ofp-actions: helper functions for of12 set-field action

2012-09-13 Thread Simon Horman
On Thu, Sep 13, 2012 at 01:06:09PM -0700, Ben Pfaff wrote: > I get rejects on this against commit 307975da7 currently on master. > > As long as it needs a rebase anyhow, I see a few more changes I'd > like: > > * The struct ofp12_action_set_field change looks good but the > line

Re: [ovs-dev] [PATCH 04/27] ofp-util: Allow decoding of Open Flow 1.1 & 1.2 Table Statistics Request Messages

2012-09-13 Thread Simon Horman
On Thu, Sep 13, 2012 at 08:00:20AM -0700, Ben Pfaff wrote: > On Thu, Sep 13, 2012 at 02:47:09PM +0900, Simon Horman wrote: > > On Tue, Sep 11, 2012 at 09:55:17PM -0700, Ben Pfaff wrote: > > > On Mon, Sep 10, 2012 at 10:47:52AM -0700, Ben Pfaff wrote: > > > > On Mon, Sep 10, 2012 at 09:59:28AM +0900

Re: [ovs-dev] brcompat question

2012-09-13 Thread Jesse Gross
On Thu, Sep 13, 2012 at 1:31 PM, christopher barry wrote: > On Thu, 2012-09-13 at 13:38 -0400, christopher barry wrote: >> On Thu, 2012-09-13 at 10:26 -0700, Jesse Gross wrote: >> > On Sep 13, 2012, at 10:10 AM, christopher barry >> > wrote: >> > >> > > On Thu, 2012-09-13 at 10:05 -0700, Jesse G

Re: [ovs-dev] [PATCH 1/3] ofp-actions: helper functions for of12 set-field action

2012-09-13 Thread Ben Pfaff
On Thu, Sep 13, 2012 at 01:06:09PM -0700, Ben Pfaff wrote: > * What's the "nast" in set_field_to_nast() stand for? nxast > stands for "Nicira eXtension Action Type", but > set-field isn't a Nicira extension. s//Sub/ I guess. ___

Re: [ovs-dev] brcompat question

2012-09-13 Thread christopher barry
On Thu, 2012-09-13 at 13:38 -0400, christopher barry wrote: > On Thu, 2012-09-13 at 10:26 -0700, Jesse Gross wrote: > > On Sep 13, 2012, at 10:10 AM, christopher barry > > wrote: > > > > > On Thu, 2012-09-13 at 10:05 -0700, Jesse Gross wrote: > > >> On Sep 13, 2012, at 9:55 AM, christopher barry

Re: [ovs-dev] [PATCH 1/3] ofp-actions: helper functions for of12 set-field action

2012-09-13 Thread Ben Pfaff
I get rejects on this against commit 307975da7 currently on master. As long as it needs a rebase anyhow, I see a few more changes I'd like: * The struct ofp12_action_set_field change looks good but the line "- Exactly oxm_len bytes containing a single OXM TLV, then" in

Re: [ovs-dev] brcompat question

2012-09-13 Thread Jesse Gross
On Sep 13, 2012, at 10:10 AM, christopher barry wrote: > On Thu, 2012-09-13 at 10:05 -0700, Jesse Gross wrote: >> On Sep 13, 2012, at 9:55 AM, christopher barry wrote: >> >>> greetings, >>> >>> I'm running kernel 3.5.1, and I need bridge compatibility for >>> opennebula. I tried building the m

Re: [ovs-dev] brcompat question

2012-09-13 Thread christopher barry
On Thu, 2012-09-13 at 10:05 -0700, Jesse Gross wrote: > On Sep 13, 2012, at 9:55 AM, christopher barry wrote: > > > greetings, > > > > I'm running kernel 3.5.1, and I need bridge compatibility for > > opennebula. I tried building the modules in 1.7.1, but it says can't > > build post-3.3. > > >

Re: [ovs-dev] brcompat question

2012-09-13 Thread Jesse Gross
On Sep 13, 2012, at 9:55 AM, christopher barry wrote: > greetings, > > I'm running kernel 3.5.1, and I need bridge compatibility for > opennebula. I tried building the modules in 1.7.1, but it says can't > build post-3.3. > > Am I doing something wrong? You need to use master from git if you w

[ovs-dev] brcompat question

2012-09-13 Thread christopher barry
greetings, I'm running kernel 3.5.1, and I need bridge compatibility for opennebula. I tried building the modules in 1.7.1, but it says can't build post-3.3. Am I doing something wrong? -C ___ dev mailing list dev@openvswitch.org http://openvswitch.or

Re: [ovs-dev] [PATCH 04/27] ofp-util: Allow decoding of Open Flow 1.1 & 1.2 Table Statistics Request Messages

2012-09-13 Thread Ben Pfaff
On Thu, Sep 13, 2012 at 02:47:09PM +0900, Simon Horman wrote: > On Tue, Sep 11, 2012 at 09:55:17PM -0700, Ben Pfaff wrote: > > On Mon, Sep 10, 2012 at 10:47:52AM -0700, Ben Pfaff wrote: > > > On Mon, Sep 10, 2012 at 09:59:28AM +0900, Simon Horman wrote: > > > > On Sat, Sep 08, 2012 at 12:15:53PM +0

[ovs-dev] Hello, My names are Miss Angelaaa Kami. I came across your email ID as i was browsing and have much interest on you as directed by my spirit.I really need us to be very close friends and wha

2012-09-13 Thread fgggg dg
___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

[ovs-dev] [PATCH 2/3] ofp-actions: plumb of12 actions support

2012-09-13 Thread Simon Horman
From: Isaku Yamahata Signed-off-by: Isaku Yamahata Signed-off-by: Simon Horman --- v6 * Add limited testss - Previously part of another patch which has otherwise been dropped v5 [Simon Horman] * No change v4 [Simon Horman] * Update call to ofpacts_pull_openflow11_instructions() in ofctl

[ovs-dev] [PATCH 1/3] ofp-actions: helper functions for of12 set-field action

2012-09-13 Thread Simon Horman
From: Isaku Yamahata Signed-off-by: Isaku Yamahata Signed-off-by: Simon Horman --- v6 [Simon Horman] * Change ofp12_action_set_field so that the last element is ovs_be32 dst rather than uint8_t field[4]. This avoids some casting when the field is used. * Use is_all_zeros() * Accept non-OX

[ovs-dev] [PATCH 3/3] ofp-actions: Add parsing of set_field actions

2012-09-13 Thread Simon Horman
Based heavily on work by Isaku Yamahata Cc: Isaku Yamahata Signed-off-by: Simon Horman --- lib/nx-match.c|7 +-- lib/ofp-actions.c | 12 lib/ofp-actions.h |3 +++ lib/ofp-parse.c | 46 +++--- lib/ofp-util.def |3 +-

[ovs-dev] [PATCH v6 0/3] set-field action preliminary support

2012-09-13 Thread Simon Horman
Hi, This series adds preliminary support for set-field actions. I have picked up this series from Yamahata-san on his request. It is based on the current master branch. Changes for each patch are noted inline. I believe this series addresses raised by Ben Pfaff in respect to v5 of this series. A