Re: [ovs-dev] [PATCH] Declare the version as "1.4.3".

2012-09-06 Thread Justin Pettit
Thanks. I pushed it. --Justin On Sep 6, 2012, at 7:28 PM, Ben Pfaff wrote: > Thanks, this looks fine. ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

Re: [ovs-dev] Reg: Using TSO capabilities of NIC

2012-09-06 Thread Jesse Gross
On Thu, Sep 6, 2012 at 7:59 PM, satish R wrote: > Could anyone please let me know if some special configuration has to be done > to enable TSO capability of the NIC. It's generally on by default. ___ dev mailing list dev@openvswitch.org http://openvswit

Re: [ovs-dev] [PATCH 1/1 V4] Add support for tun_key to OVS datapath

2012-09-06 Thread Jesse Gross
On Wed, Sep 5, 2012 at 2:58 PM, Kyle Mestery wrote: > This is a first pass at providing a tun_key which can be > used as the basis for flow-based tunnelling. The tun_key > includes and replaces the tun_id in both struct ovs_skb_cb > and struct sw_tun_key. > > This patch allows all existing tun_id

[ovs-dev] Reg: Using TSO capabilities of NIC

2012-09-06 Thread satish R
Could anyone please let me know if some special configuration has to be done to enable TSO capability of the NIC. ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

Re: [ovs-dev] [PATCH] Declare the version as "1.4.3".

2012-09-06 Thread Ben Pfaff
Thanks, this looks fine. ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

[ovs-dev] [PATCH] Declare the version as "1.4.3".

2012-09-06 Thread Justin Pettit
--- NEWS |4 configure.ac |2 +- debian/changelog |6 ++ 3 files changed, 11 insertions(+), 1 deletion(-) diff --git a/NEWS b/NEWS index e0fdd30..31e217e 100644 --- a/NEWS +++ b/NEWS @@ -1,3 +1,7 @@ +v1.4.3 - 06 Sep 2012 + +- Bug fi

Re: [ovs-dev] [PATCH 04/27] ofp-util: Allow decoding of Open Flow 1.1 & 1.2 Table Statistics Request Messages

2012-09-06 Thread Simon Horman
On Fri, Aug 31, 2012 at 05:42:48PM +0900, Simon Horman wrote: > On Thu, Aug 30, 2012 at 10:02:51AM +0900, Simon Horman wrote: > > On Wed, Aug 29, 2012 at 10:07:55AM -0700, Ben Pfaff wrote: > > > On Tue, Aug 21, 2012 at 01:55:36PM +0900, Simon Horman wrote: > > > > Signed-off-by: Simon Horman > > >

Re: [ovs-dev] [PATCH 2/5] lib/ofp-actions: make ofpact_reg_load.value mf_value from uint64_t

2012-09-06 Thread Simon Horman
On Thu, Sep 06, 2012 at 08:41:10AM -0700, Ben Pfaff wrote: > On Thu, Sep 06, 2012 at 04:14:30PM +0900, Simon Horman wrote: > > On Tue, Sep 04, 2012 at 02:12:49PM -0700, Ben Pfaff wrote: > > > On Tue, Sep 04, 2012 at 10:39:19AM +0900, Simon Horman wrote: > > > > On Thu, Aug 30, 2012 at 09:29:27PM -0

Re: [ovs-dev] [PATCH 3/3] jsonrpc: Treat receiving part of a message as activity.

2012-09-06 Thread Ansis Atteka
On Wed, Aug 8, 2012 at 4:14 PM, Ben Pfaff wrote: > Until now, the jsonrpc code has only counted receiving a full JSON-RPC > messages as activity. This could theoretically time out, then, while a > very long message is in transit or if a slow link is involved. This commit > changes this code to c

Re: [ovs-dev] [PATCH 2/3] jsonrpc: Treat draining data from send queue as activity.

2012-09-06 Thread Ansis Atteka
On Thu, Sep 6, 2012 at 7:49 AM, Ben Pfaff wrote: > On Wed, Sep 05, 2012 at 11:48:26PM -0700, Ansis Atteka wrote: >> On Wed, Aug 8, 2012 at 4:14 PM, Ben Pfaff wrote: >> > Until now, the jsonrpc module has used messages received from the >> > remote peer as the sole means to determine that the JSON

Re: [ovs-dev] [PATCH v3 01/17] hashtable: introduce a small and naive hashtable

2012-09-06 Thread Steven Rostedt
On Thu, 2012-09-06 at 18:21 +0200, Sasha Levin wrote: > On 09/06/2012 06:00 PM, Steven Rostedt wrote: > >> > I think that that code doesn't make sense. The users of hlist_for_each_* > >> > aren't > >> > supposed to be changing the loop cursor. > > I totally agree. Modifying the 'node' pointer is j

Re: [ovs-dev] [PATCH v3 01/17] hashtable: introduce a small and naive hashtable

2012-09-06 Thread Mathieu Desnoyers
* Sasha Levin (levinsasha...@gmail.com) wrote: > On 09/06/2012 06:50 PM, Mathieu Desnoyers wrote: > > * Sasha Levin (levinsasha...@gmail.com) wrote: > >> On 09/06/2012 06:00 PM, Steven Rostedt wrote: > > I think that that code doesn't make sense. The users of > > hlist_for_each_* aren't >

Re: [ovs-dev] [PATCH v3 01/17] hashtable: introduce a small and naive hashtable

2012-09-06 Thread Sasha Levin
On 09/06/2012 06:50 PM, Mathieu Desnoyers wrote: > * Sasha Levin (levinsasha...@gmail.com) wrote: >> On 09/06/2012 06:00 PM, Steven Rostedt wrote: > I think that that code doesn't make sense. The users of hlist_for_each_* > aren't > supposed to be changing the loop cursor. >>> I totall

Re: [ovs-dev] [PATCH v3 01/17] hashtable: introduce a small and naive hashtable

2012-09-06 Thread Mathieu Desnoyers
* Sasha Levin (levinsasha...@gmail.com) wrote: > On 09/06/2012 06:00 PM, Steven Rostedt wrote: > >> > I think that that code doesn't make sense. The users of hlist_for_each_* > >> > aren't > >> > supposed to be changing the loop cursor. > > I totally agree. Modifying the 'node' pointer is just ask

Re: [ovs-dev] [PATCH v3 01/17] hashtable: introduce a small and naive hashtable

2012-09-06 Thread Sasha Levin
On 09/06/2012 06:00 PM, Steven Rostedt wrote: >> > I think that that code doesn't make sense. The users of hlist_for_each_* >> > aren't >> > supposed to be changing the loop cursor. > I totally agree. Modifying the 'node' pointer is just asking for issues. > Yes that is error prone, but not due to

Re: [ovs-dev] [PATCH v3 01/17] hashtable: introduce a small and naive hashtable

2012-09-06 Thread Steven Rostedt
On Thu, 2012-09-06 at 17:49 +0200, Sasha Levin wrote: > > > Looks reasonable. However, it would break (or rather, not break) on > > code like this: > > > > hash_for_each_entry(...) { > > if (...) { > > foo(node); > > node = NULL; ug, I di

Re: [ovs-dev] [PATCH v3 01/17] hashtable: introduce a small and naive hashtable

2012-09-06 Thread Sasha Levin
On 09/06/2012 04:55 PM, Josh Triplett wrote: > On Thu, Sep 06, 2012 at 03:53:58PM +0200, Sasha Levin wrote: >> On 09/04/2012 07:01 PM, Mathieu Desnoyers wrote: #define do_for_each_ftrace_rec(pg, rec) \ > for (pg = ftrace_pages_start, r

Re: [ovs-dev] [PATCH 2/5] lib/ofp-actions: make ofpact_reg_load.value mf_value from uint64_t

2012-09-06 Thread Ben Pfaff
On Thu, Sep 06, 2012 at 04:14:30PM +0900, Simon Horman wrote: > On Tue, Sep 04, 2012 at 02:12:49PM -0700, Ben Pfaff wrote: > > On Tue, Sep 04, 2012 at 10:39:19AM +0900, Simon Horman wrote: > > > On Thu, Aug 30, 2012 at 09:29:27PM -0700, Ben Pfaff wrote: > > > > On Thu, Aug 30, 2012 at 10:40:24AM +0

Re: [ovs-dev] [PATCH v3 01/17] hashtable: introduce a small and naive hashtable

2012-09-06 Thread Steven Rostedt
On Thu, 2012-09-06 at 07:55 -0700, Josh Triplett wrote: > > My solution to making 'break' work in the iterator is: > > > > for (bkt = 0, node = NULL; bkt < HASH_SIZE(name) && node == NULL; bkt++) > > hlist_for_each_entry(obj, node, &name[bkt], member) > > > > Looks reasonable.

Re: [ovs-dev] [PATCH v3 01/17] hashtable: introduce a small and naive hashtable

2012-09-06 Thread Josh Triplett
On Thu, Sep 06, 2012 at 03:53:58PM +0200, Sasha Levin wrote: > On 09/04/2012 07:01 PM, Mathieu Desnoyers wrote: > >> #define do_for_each_ftrace_rec(pg, rec) > >> \ > >> > for (pg = ftrace_pages_start, rec = &pg->records[pg->index]; > >> >

Re: [ovs-dev] [PATCH 2/3] jsonrpc: Treat draining data from send queue as activity.

2012-09-06 Thread Ben Pfaff
On Wed, Sep 05, 2012 at 11:48:26PM -0700, Ansis Atteka wrote: > On Wed, Aug 8, 2012 at 4:14 PM, Ben Pfaff wrote: > > Until now, the jsonrpc module has used messages received from the > > remote peer as the sole means to determine that the JSON-RPC > > connection is up. This could in theory intera

Re: [ovs-dev] [PATCH v3 01/17] hashtable: introduce a small and naive hashtable

2012-09-06 Thread David Laight
> My solution to making 'break' work in the iterator is: > > for (bkt = 0, node = NULL; bkt < HASH_SIZE(name) && node == NULL; bkt++) > hlist_for_each_entry(obj, node, &name[bkt], member) I'd take a look at the generated code. Might come out a bit better if the condition is ch

Re: [ovs-dev] [PATCH v3 01/17] hashtable: introduce a small and naive hashtable

2012-09-06 Thread Mathieu Desnoyers
* Sasha Levin (levinsasha...@gmail.com) wrote: > On 09/04/2012 07:01 PM, Mathieu Desnoyers wrote: > >> #define do_for_each_ftrace_rec(pg, rec) > >> \ > >> > for (pg = ftrace_pages_start, rec = &pg->records[pg->index]; > >> > \ > >> >

Re: [ovs-dev] [PATCH v3 01/17] hashtable: introduce a small and naive hashtable

2012-09-06 Thread Pedro Alves
On 09/06/2012 02:53 PM, Sasha Levin wrote: > So I think that for the hash iterator it might actually be simpler. > > My solution to making 'break' work in the iterator is: > > for (bkt = 0, node = NULL; bkt < HASH_SIZE(name) && node == NULL; bkt++) > hlist_for_each_entry(obj,

Re: [ovs-dev] [PATCH v3 01/17] hashtable: introduce a small and naive hashtable

2012-09-06 Thread Sasha Levin
On 09/04/2012 07:01 PM, Mathieu Desnoyers wrote: >> #define do_for_each_ftrace_rec(pg, rec) >> \ >> > for (pg = ftrace_pages_start, rec = &pg->records[pg->index]; >> > \ >> > pg && rec == &pg->records[pg->index];

Re: [ovs-dev] [PATCH 2/5] lib/ofp-actions: make ofpact_reg_load.value mf_value from uint64_t

2012-09-06 Thread Simon Horman
On Tue, Sep 04, 2012 at 02:12:49PM -0700, Ben Pfaff wrote: > On Tue, Sep 04, 2012 at 10:39:19AM +0900, Simon Horman wrote: > > On Thu, Aug 30, 2012 at 09:29:27PM -0700, Ben Pfaff wrote: > > > On Thu, Aug 30, 2012 at 10:40:24AM +0900, Simon Horman wrote: > > > > From: Isaku Yamahata > > > > > > >