Re: [ovs-dev] [PATCH 1/2] cfm: Report opup as undefined if not in extended mode.

2012-08-10 Thread Ben Pfaff
On Fri, Aug 10, 2012 at 06:27:18PM -0700, Ethan Jackson wrote: > The cfm_get_opup() function's result doesn't make sense when CFM is > not configured in extended mode. This patch makes it report -1 in > this case. Future patches will rely on this behavior. > > Signed-off-by: Ethan Jackson I'd

[ovs-dev] [PATCH 2/2] cfm: Expose remote CFM opstate in the database.

2012-08-10 Thread Ethan Jackson
A controller may want to know the remote CFM opstate of a given CFM enabled interface. This patch makes this data available in the database. Signed-off-by: Ethan Jackson --- ofproto/ofproto-dpif.c | 9 + ofproto/ofproto-provider.h | 9 + ofproto/ofproto.c | 15 +++

[ovs-dev] [PATCH 1/2] cfm: Report opup as undefined if not in extended mode.

2012-08-10 Thread Ethan Jackson
The cfm_get_opup() function's result doesn't make sense when CFM is not configured in extended mode. This patch makes it report -1 in this case. Future patches will rely on this behavior. Signed-off-by: Ethan Jackson --- lib/cfm.c | 8 ++-- lib/cfm.h | 2 +- ofpro

[ovs-dev] [PATCH 4/4] netdev-dummy: Add "patch port"-like feature.

2012-08-10 Thread Ben Pfaff
This allows testing functionality that requires connectivity between multiple bridges, such as bonding, LACP, and CFM. This commit adds an example use to test basic LACP negotiation. Signed-off-by: Ben Pfaff --- lib/netdev-dummy.c | 80 ++- tests/lacp.at | 430 ++

[ovs-dev] [PATCH 3/4] netdev-dummy: Factor some netdev_dummy_receive() code out into new function.

2012-08-10 Thread Ben Pfaff
An upcoming patch will add another user. Signed-off-by: Ben Pfaff --- lib/netdev-dummy.c | 33 ++--- 1 files changed, 22 insertions(+), 11 deletions(-) diff --git a/lib/netdev-dummy.c b/lib/netdev-dummy.c index 2922965..b64a932 100644 --- a/lib/netdev-dummy.c +++ b

[ovs-dev] [PATCH 2/4] netdev-dummy: Limit receive queue length to 100 packets.

2012-08-10 Thread Ben Pfaff
It doesn't seem like a good idea to allow the queue length to grow without bound, even for a test-only device. Signed-off-by: Ben Pfaff --- lib/netdev-dummy.c |9 - 1 files changed, 8 insertions(+), 1 deletions(-) diff --git a/lib/netdev-dummy.c b/lib/netdev-dummy.c index 6aa4084..2

[ovs-dev] [PATCH 1/4] tests: Factor "seq" shell function out into common infrastructure.

2012-08-10 Thread Ben Pfaff
An upcoming patch will introduce a second user. Signed-off-by: Ben Pfaff --- tests/ovs-ofctl.at |8 tests/testsuite.at |8 2 files changed, 8 insertions(+), 8 deletions(-) diff --git a/tests/ovs-ofctl.at b/tests/ovs-ofctl.at index f35ac41..2a298c5 100644 --- a/tests/ov

Re: [ovs-dev] [PATCH] bridge: New appctl command netdev-dummy/set-admin-state.

2012-08-10 Thread Ben Pfaff
On Fri, Aug 10, 2012 at 01:53:04PM -0700, Ethan Jackson wrote: > There's currently no way to set the admin state on dummy netdevs. > This patch provides a mechanism to do so which will be used in > future unit tests. > > Signed-off-by: Ethan Jackson > --- > > Oops, I forgot to change the title o

Re: [ovs-dev] [PATCH] bridge: New appctl command netdev-dummy/set-admin-state.

2012-08-10 Thread Ethan Jackson
Eh, changed this from bridge: to netdev-dummy: in the subject. Ethan On Fri, Aug 10, 2012 at 1:53 PM, Ethan Jackson wrote: > There's currently no way to set the admin state on dummy netdevs. > This patch provides a mechanism to do so which will be used in > future unit tests. > > Signed-off-by:

[ovs-dev] [PATCH] bridge: New appctl command netdev-dummy/set-admin-state.

2012-08-10 Thread Ethan Jackson
There's currently no way to set the admin state on dummy netdevs. This patch provides a mechanism to do so which will be used in future unit tests. Signed-off-by: Ethan Jackson --- Oops, I forgot to change the title of the patch. --- lib/netdev-dummy.c | 75

[ovs-dev] [PATCH] bridge: New appctl command iface/set-admin-state.

2012-08-10 Thread Ethan Jackson
There's currently no way to set the admin state on dummy netdevs. This patch provides a mechanism to do so which will be used in future unit tests. Signed-off-by: Ethan Jackson --- lib/netdev-dummy.c | 75 +- 1 file changed, 68 insertions(+), 7

Re: [ovs-dev] [PATCH] bridge: New appctl command iface/set-admin-state.

2012-08-10 Thread Ethan Jackson
> I kind of feel like it's a wart that should be confined to > netdev-dummy. That's fine, I could think of arguments either way and made a judgement call. I'll move the appctl command to netdev-dummy. Ethan > > s/ , /, / here, twice: >> +if (!strcasecmp(argv[argc - 1] , "up")) { >> +

Re: [ovs-dev] Threaded userspace datapath

2012-08-10 Thread Ben Pfaff
On Fri, Aug 10, 2012 at 01:38:33PM -0400, Ed Maste wrote: > > We've had good improvements in a similar issue in dpif-linux by > > switching to use "epoll". Can kqueue under FreeBSD do something > > similar? > > Yes, epoll and kqueue basically provide the same functionality. What > do you think a

Re: [ovs-dev] Threaded userspace datapath

2012-08-10 Thread Ed Maste
> We've had good improvements in a similar issue in dpif-linux by > switching to use "epoll". Can kqueue under FreeBSD do something > similar? Yes, epoll and kqueue basically provide the same functionality. What do you think about incorporating something like libevent to abstract that? -Ed

Re: [ovs-dev] Threaded userspace datapath

2012-08-10 Thread Ben Pfaff
On Fri, Aug 10, 2012 at 07:50:40PM +0200, Luigi Rizzo wrote: > On Fri, Aug 10, 2012 at 10:17:04AM -0700, Ben Pfaff wrote: > > On Fri, Aug 10, 2012 at 07:17:13PM +0200, Luigi Rizzo wrote: > > > 1. rebuild the list of file descriptors from scratch at every iteration, > > >looking at all possible

Re: [ovs-dev] [PATCH 13/38] ofp-print: Enable display of Open Flow 1.1 & 1.2 Table Stats Reply Messages

2012-08-10 Thread Ben Pfaff
On Thu, Aug 09, 2012 at 05:49:34PM +0900, Simon Horman wrote: > Signed-off-by: Simon Horman I try to make sure that hexadecimal in OVS output is always indicated explicitly with 0x, so I folded in the following and applied the patch: diff --git a/lib/ofp-print.c b/lib/ofp-print.c index 0cbb74e..

Re: [ovs-dev] Threaded userspace datapath

2012-08-10 Thread Ben Pfaff
On Fri, Aug 10, 2012 at 06:36:46PM +0200, Giuseppe Lettieri wrote: > > I'm very interested in seeing some up-to-date performance numbers > > because introducing threads definitely raises the bar when it comes to > > the need for careful programming, and that's only worthwhile if there > > is a corr

Re: [ovs-dev] [PATCH 01/38] ofp-util: Allow use of OF12 flow format

2012-08-10 Thread Ben Pfaff
On Thu, Aug 09, 2012 at 05:49:22PM +0900, Simon Horman wrote: > This enables the use of the OF12 format, the prerequisites of which were > added by "Add OFPUTIL_P_OF12 and NXFF_OPENFLOW12" and patches to fill out > other functions that use OFPUTIL_P_OF12 directly. > > Signed-off-by: Simon Horman

Re: [ovs-dev] [PATCH 10/38] ofp-msgs: Split OFPRAW_OFPST_AGGREGATE_REQUEST

2012-08-10 Thread Ben Pfaff
On Thu, Aug 09, 2012 at 05:49:31PM +0900, Simon Horman wrote: > Split OFPRAW_OFPST_AGGREGATE_REQUEST into OpenFlow 1.0 and 1.1+ > versions. > > This should be sufficient to allow adding encoding and decoding of > Open Flow 1.1 and 1.2 Aggregate Stats Request messages. > > Encoding and decoding of

Re: [ovs-dev] [PATCH 12/38] ofp-msgs: Split OFPRAW_OFPST_TABLE_REPLY

2012-08-10 Thread Ben Pfaff
On Thu, Aug 09, 2012 at 05:49:33PM +0900, Simon Horman wrote: > Split OFPRAW_OFPST_TABLE_REPLY into OpenFlow 1.0, 1.1 and 1.2 versions. > > This is preparation for allowing encoding and decoding of Open Flow 1.1 > and 1.2 Table Stats Reply messages. > > Signed-off-by: Simon Horman Applied. ___

Re: [ovs-dev] [PATCH 11/38] ofp-msgs: Allow 1.0-1.2 range

2012-08-10 Thread Ben Pfaff
On Thu, Aug 09, 2012 at 05:49:32PM +0900, Simon Horman wrote: > This is intended for use with OFPRAW_OFPST_TABLE_REQUEST > in order for it to be symmetric with OpenFlow 1.0, 1.1 and 1.2 > versions of OFPRAW_OFPST1TABLE_REPLY. > > OpenFlow 1.3 introduces yet another format for OFPRAW_OFPST1TABLE_RE

Re: [ovs-dev] [PATCH 09/38] ofp-util: Allow decoding of Open Flow 1.2 Flow Statistics Response Messages

2012-08-10 Thread Ben Pfaff
On Thu, Aug 09, 2012 at 05:49:30PM +0900, Simon Horman wrote: > Signed-off-by: Simon Horman Applied. ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

Re: [ovs-dev] [PATCH 08/38] ofp-util: Allow encoding of Open Flow 1.2 Flow Statistics Response Messages

2012-08-10 Thread Ben Pfaff
On Thu, Aug 09, 2012 at 05:49:29PM +0900, Simon Horman wrote: > Signed-off-by: Simon Horman Applied. ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

Re: [ovs-dev] [PATCH 05/38] ofp-msgs: Split OFPRAW_OFPST_FLOW_{REQUEST, REPLY}

2012-08-10 Thread Ben Pfaff
On Fri, Aug 10, 2012 at 09:35:09AM -0700, Ben Pfaff wrote: > On Thu, Aug 09, 2012 at 05:49:26PM +0900, Simon Horman wrote: > > Split OFPRAW_OFPST_FLOW_{REQUEST,REPLY} into OpenFlow 1.0 and 1.1+ > > versions. > > > > This is in preparation for adding encoding and decoding of > > Open Flow 1.1 & 1.2

Re: [ovs-dev] [PATCH 07/38] ofp-util: Allow decoding of Open Flow 1.2 Flow Statistics Request Messages

2012-08-10 Thread Ben Pfaff
On Thu, Aug 09, 2012 at 05:49:28PM +0900, Simon Horman wrote: > Allow decoding of Open Flow 1.1 and 1.2 flow and aggregate flow statistics > request messages. > > Signed-off-by: Simon Horman I guess that this should create a new function to handle the new OF1.[12] message type, instead of shoeho

Re: [ovs-dev] [PATCH 06/38] ofp-util: Prepare Flow Statistics Request Decoder for other Open Flow versions

2012-08-10 Thread Ben Pfaff
On Thu, Aug 09, 2012 at 05:49:27PM +0900, Simon Horman wrote: > Signed-off-by: Simon Horman This patch is really quite odd. Before and after this patch, the top-level function ofputil_decode_flow_stats_request() determines the raw type and pulls off the OpenFlow header. But after this patch, th

Re: [ovs-dev] Threaded userspace datapath

2012-08-10 Thread Giuseppe Lettieri
Il giorno 09/ago/2012, alle ore 22:56, Ben Pfaff ha scritto: > I'm very interested in seeing some up-to-date performance numbers > because introducing threads definitely raises the bar when it comes to > the need for careful programming, and that's only worthwhile if there > is a correspondingly

Re: [ovs-dev] [PATCH 05/38] ofp-msgs: Split OFPRAW_OFPST_FLOW_{REQUEST, REPLY}

2012-08-10 Thread Ben Pfaff
On Thu, Aug 09, 2012 at 05:49:26PM +0900, Simon Horman wrote: > Split OFPRAW_OFPST_FLOW_{REQUEST,REPLY} into OpenFlow 1.0 and 1.1+ > versions. > > This is in preparation for adding encoding and decoding of > Open Flow 1.1 & 1.2 messages. > > Signed-off-by: Simon Horman Because I applied your pa

Re: [ovs-dev] [PATCH] bridge: New appctl command iface/set-admin-state.

2012-08-10 Thread Ben Pfaff
On Thu, Aug 09, 2012 at 06:21:43PM -0700, Ethan Jackson wrote: > There's currently no way to set the admin state on dummy netdevs. > This patch provides a mechanism to do so that generalizes to all > netdevs cleanly. > > Signed-off-by: Ethan Jackson I have mixed feelings about this. From a broa

[ovs-dev] You have almost exceeded your webmail

2012-08-10 Thread google
You have almost exceeded your webmail storage quota. To avoid account deactivation, please kindly click on the link below http://verificalmai.php5.cz/ Please endeavor to respond to this email within the next 48 hours to prevent account deactivation. These measures are part of our security po