[ovs-dev] [PATCH 1/2] ovs-ctl.in: Consistently use spaces instead of tabs.

2012-07-27 Thread Justin Pettit
Signed-off-by: Justin Pettit --- utilities/ovs-ctl.in | 80 +- 1 files changed, 40 insertions(+), 40 deletions(-) diff --git a/utilities/ovs-ctl.in b/utilities/ovs-ctl.in index 59c2a31..cb41cc0 100755 --- a/utilities/ovs-ctl.in +++ b/utilities/ov

[ovs-dev] [PATCH 2/2] ovs-ctl.in: Don't stop forwarding while restarting the database.

2012-07-27 Thread Justin Pettit
Previously, the force-reload-kmod command would stop forwarding, stop the database, restart the database, and then restart forwarding. If the database is large, it can take a while to be read (we've seen as much as 10 seconds), which means the switch is not forwarding traffic during that time. Th

[ovs-dev] Escápate a Málaga por tan sólo 47¤ / Almohada viscoelástica para cervicales por 14,32¤ / Cepillo para mascotas por 9,22¤

2012-07-27 Thread GlobalBono
Cabestan. Layout Doble Asegúrate de no perderte ninguna oferta, añade ofer...@globalbono.com a tu lista de contactos. Si no ves correctamente las imágenes, pulsa [ http://email.globalbono.com/E27072012164207.cfm?WL=755&WS=208833_8707685&WA=277 ] aquí [ http://email.globalbono.com/Go/index.cfm

Re: [ovs-dev] [bug 681880 1/3] lockfile: Fix hang locking through a dangling symlink.

2012-07-27 Thread Bastian Blank
On Fri, Jul 27, 2012 at 10:21:10AM -0700, Ben Pfaff wrote: > On Fri, Jul 27, 2012 at 10:28:08AM +0200, Bastian Blank wrote: > > I was unclear. You should first use realpath(3) on the database filename > > and calculate the lock file from there. Otherwise there may be several > > lock files for the

Re: [ovs-dev] [PATCH] Avoid implementation-defined strerror behaviour

2012-07-27 Thread Ben Pfaff
On Fri, Jul 27, 2012 at 05:27:15PM -0400, Ed Maste wrote: > POSIX states that the string returned by strerror() may be overwritten > by a subsequent call (i.e., because it returns a pointer to a static > buffer). Make a copy of one of the two strerror() strings to avoid > this. > > Background: Fr

[ovs-dev] [PATCH] Avoid implementation-defined strerror behaviour

2012-07-27 Thread Ed Maste
POSIX states that the string returned by strerror() may be overwritten by a subsequent call (i.e., because it returns a pointer to a static buffer). Make a copy of one of the two strerror() strings to avoid this. Background: FreeBSD historically returned such a pointer only in the case of an inva

[ovs-dev] Bug#681955: marked as done (openvswitch-switch - Enabling brcompat breaks normal operation)

2012-07-27 Thread Debian Bug Tracking System
Your message dated Fri, 27 Jul 2012 21:02:46 + with message-id and subject line Bug#681955: fixed in openvswitch 1.4.2+git20120612-7 has caused the Debian Bug report #681955, regarding openvswitch-switch - Enabling brcompat breaks normal operation to be marked as done. This means that you cla

[ovs-dev] Bug#681880: marked as done (openvswitch-switch - Automatic changed file in /etc/)

2012-07-27 Thread Debian Bug Tracking System
Your message dated Fri, 27 Jul 2012 21:02:46 + with message-id and subject line Bug#681880: fixed in openvswitch 1.4.2+git20120612-7 has caused the Debian Bug report #681880, regarding openvswitch-switch - Automatic changed file in /etc/ to be marked as done. This means that you claim that th

[ovs-dev] openvswitch_1.4.2+git20120612-7_i386.changes ACCEPTED into unstable

2012-07-27 Thread Debian FTP Masters
Accepted: openvswitch-brcompat_1.4.2+git20120612-7_i386.deb to main/o/openvswitch/openvswitch-brcompat_1.4.2+git20120612-7_i386.deb openvswitch-common_1.4.2+git20120612-7_i386.deb to main/o/openvswitch/openvswitch-common_1.4.2+git20120612-7_i386.deb openvswitch-controller_1.4.2+git20120612-7

Re: [ovs-dev] [PATCH] Revert "openvswitch: potential NULL deref in sample()"

2012-07-27 Thread David Miller
From: Jesse Gross Date: Fri, 27 Jul 2012 13:19:40 -0700 > This reverts commit 5b3e7e6cb5771bedda51cdb6f715d1da8cd9e644. > > The problem that the original commit was attempting to fix can > never happen in practice because validation is done one a per-flow > basis rather than a per-packet basis.

Re: [ovs-dev] [classifier-opt 06/28] util: New macro CONST_CAST.

2012-07-27 Thread Ben Pfaff
On Fri, Jul 27, 2012 at 01:38:15PM -0700, Ethan Jackson wrote: > > Thanks. I think it's a win on the whole too but I'm never sure > > whether the syntax is too ugly, even though I've done it this way > > before elsewhere. > > I can't think of a better way to do it without compiler support. Even

Re: [ovs-dev] [classifier-opt 06/28] util: New macro CONST_CAST.

2012-07-27 Thread Ethan Jackson
> Thanks. I think it's a win on the whole too but I'm never sure > whether the syntax is too ugly, even though I've done it this way > before elsewhere. I can't think of a better way to do it without compiler support. Even the const cast in c++ is a bit ugly. Frankly, I think casting should be

Re: [ovs-dev] [classifier-opt 06/28] util: New macro CONST_CAST.

2012-07-27 Thread Ben Pfaff
Thanks. I think it's a win on the whole too but I'm never sure whether the syntax is too ugly, even though I've done it this way before elsewhere. On Fri, Jul 27, 2012 at 01:33:59PM -0700, Ethan Jackson wrote: > Awesome, this is a huge win. Thanks a lot. > > Ethan > > On Fri, Jul 20, 2012 at 4

Re: [ovs-dev] [classifier-opt 08/28] ofp-util: Remove extra blank line.

2012-07-27 Thread Ethan Jackson
Looks good, thanks. Ethan On Fri, Jul 20, 2012 at 4:25 PM, Ben Pfaff wrote: > Signed-off-by: Ben Pfaff > --- > lib/ofp-util.c |1 - > 1 files changed, 0 insertions(+), 1 deletions(-) > > diff --git a/lib/ofp-util.c b/lib/ofp-util.c > index 1c9763d..4d5dfbb 100644 > --- a/lib/ofp-util.c > +

Re: [ovs-dev] [classifier-opt 07/28] ofp-util: Fix typo in comment.

2012-07-27 Thread Ethan Jackson
Looks good, thanks. Ethan On Fri, Jul 20, 2012 at 4:25 PM, Ben Pfaff wrote: > This comment is talking about the obsolete "tun_id_from_cookie" protocol > extension that we removed from OVS long ago. > > Signed-off-by: Ben Pfaff > --- > lib/ofp-util.c |2 +- > 1 files changed, 1 insertions(+

Re: [ovs-dev] [classifier-opt 06/28] util: New macro CONST_CAST.

2012-07-27 Thread Ethan Jackson
Awesome, this is a huge win. Thanks a lot. Ethan On Fri, Jul 20, 2012 at 4:25 PM, Ben Pfaff wrote: > Casts are sometimes necessary. One common reason that they are necessary > is for discarding a "const" qualifier. However, this can impede > maintenance: if the type of the expression being ca

Re: [ovs-dev] [classifier-opt 05/28] test-sha1: Remove unneeded casts.

2012-07-27 Thread Ethan Jackson
Looks good thanks. Ethan On Fri, Jul 20, 2012 at 4:25 PM, Ben Pfaff wrote: > Signed-off-by: Ben Pfaff > --- > tests/test-sha1.c |6 +++--- > 1 files changed, 3 insertions(+), 3 deletions(-) > > diff --git a/tests/test-sha1.c b/tests/test-sha1.c > index 8eb5c5e..2be7942 100644 > --- a/tests

Re: [ovs-dev] [classifier-opt 04/28] ofproto-dpif: Remove superfluous cast.

2012-07-27 Thread Ethan Jackson
Looks good thanks. Ethan On Fri, Jul 20, 2012 at 4:25 PM, Ben Pfaff wrote: > 'packet' is already a struct ofpbuf *. > --- > ofproto/ofproto-dpif.c |2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/ofproto/ofproto-dpif.c b/ofproto/ofproto-dpif.c > index dc15c15..6bc2

Re: [ovs-dev] [classifier-opt 03/28] flow: Remove superfluous casts.

2012-07-27 Thread Ethan Jackson
Looks good thanks. Ethan On Fri, Jul 20, 2012 at 4:25 PM, Ben Pfaff wrote: > Signed-off-by: Ben Pfaff > --- > lib/flow.c |6 +++--- > 1 files changed, 3 insertions(+), 3 deletions(-) > > diff --git a/lib/flow.c b/lib/flow.c > index eef84df..222983a 100644 > --- a/lib/flow.c > +++ b/lib/flo

Re: [ovs-dev] [classifier-opt 02/28] flow: Correctly consider nw_frag_mask in some flow_wildcards_*() functions.

2012-07-27 Thread Ethan Jackson
Looks good, It's always bothered me how easy it is to mess this up. Hopefully the rest of the series will make it better. Ethan On Fri, Jul 20, 2012 at 4:24 PM, Ben Pfaff wrote: > This probably means that some classifier functions based on the fragment > type of packets have never worked proper

Re: [ovs-dev] [classifier-opt 01/28] ofproto: Avoid sensitivity to hash order in flow monitor pause/resume test.

2012-07-27 Thread Ethan Jackson
Looks good, thanks. Ethan On Fri, Jul 20, 2012 at 4:24 PM, Ben Pfaff wrote: > Signed-off-by: Ben Pfaff > --- > tests/ofproto.at | 27 --- > 1 files changed, 24 insertions(+), 3 deletions(-) > > diff --git a/tests/ofproto.at b/tests/ofproto.at > index 2d28131..e525c67

Re: [ovs-dev] [PATCH] tests: Test that ofp10_match bytes that should be ignored really are.

2012-07-27 Thread Ben Pfaff
Would someone review this please? It should not be hard. Thanks, Ben. On Sat, Jul 21, 2012 at 09:56:28AM -0700, Ben Pfaff wrote: > Rob Sherwood reported a bug in OVS treatment of ofp10_match bytes that > should be ignored some time ago: > > > In any case, the pktact.SingleWildcardMatch and > >

[ovs-dev] [PATCH] Revert "openvswitch: potential NULL deref in sample()"

2012-07-27 Thread Jesse Gross
This reverts commit 5b3e7e6cb5771bedda51cdb6f715d1da8cd9e644. The problem that the original commit was attempting to fix can never happen in practice because validation is done one a per-flow basis rather than a per-packet basis. Adding additional checks at runtime is unnecessary and inconsistent

Re: [ovs-dev] [PATCH] ovs-ctl: Start the rest of Open vSwitch if loading brcompat module fails.

2012-07-27 Thread Ben Pfaff
On Fri, Jul 27, 2012 at 09:36:04AM +0900, Simon Horman wrote: > On Thu, Jul 26, 2012 at 03:01:26PM -0700, Ben Pfaff wrote: > > This may be more useful in practice than failing the entire OVS startup > > sequence. > > Acked-by: Simon Horman Thank, I added your ack and pushed this to master and br

[ovs-dev] Processing of openvswitch_1.4.2+git20120612-7_i386.changes

2012-07-27 Thread Debian FTP Masters
openvswitch_1.4.2+git20120612-7_i386.changes uploaded successfully to localhost along with the files: openvswitch_1.4.2+git20120612-7.dsc openvswitch_1.4.2+git20120612-7.debian.tar.gz openvswitch-common_1.4.2+git20120612-7_i386.deb openvswitch-switch_1.4.2+git20120612-7_i386.deb openvswit

Re: [ovs-dev] [bug 681880 1/3] lockfile: Fix hang locking through a dangling symlink.

2012-07-27 Thread Ben Pfaff
On Fri, Jul 27, 2012 at 10:28:08AM +0200, Bastian Blank wrote: > On Thu, Jul 26, 2012 at 11:53:25PM -0700, Ben Pfaff wrote: > > On Fri, Jul 27, 2012 at 08:39:42AM +0200, Bastian Blank wrote: > > > I would always use the lock file at the target location of the database > > > and not follow symlinks

[ovs-dev] You have exceeded the email quota limit

2012-07-27 Thread google
You have exceeded the email quota limit of 450MB and you need to expand the e-mail quota before the next 48 hours.if you do not update your e-mail account in 2012, you must do it now. You can expand 1GB email quota limit, use the following web link: https://docs.google.com/spreadsheet/viewform?fo

Re: [ovs-dev] [bug 681880 1/3] lockfile: Fix hang locking through a dangling symlink.

2012-07-27 Thread Bastian Blank
On Thu, Jul 26, 2012 at 11:53:25PM -0700, Ben Pfaff wrote: > On Fri, Jul 27, 2012 at 08:39:42AM +0200, Bastian Blank wrote: > > I would always use the lock file at the target location of the database > > and not follow symlinks there. Otherwise more than one lock file can > > exist. > We have to fo