Re: [ovs-dev] [RFC 0/6 v2] OXM VLAN VID and VLAN PCP

2012-07-09 Thread Simon Horman
On Mon, Jul 09, 2012 at 11:46:28PM -0700, Ben Pfaff wrote: > On Thu, Jul 05, 2012 at 05:27:26PM +0900, Simon Horman wrote: > > the purpose of this series is to: > > > > * Add encoding of the OXM VLAN VID and VLAN PCP matches and; > > * Correct the decoding of OXM VLAN VID and VLAN PCP matches > >

Re: [ovs-dev] [RFC 0/6 v2] OXM VLAN VID and VLAN PCP

2012-07-09 Thread Ben Pfaff
On Thu, Jul 05, 2012 at 05:27:26PM +0900, Simon Horman wrote: > the purpose of this series is to: > > * Add encoding of the OXM VLAN VID and VLAN PCP matches and; > * Correct the decoding of OXM VLAN VID and VLAN PCP matches > without breaking ovs-ofctl add-flows, which uses some of the > same

[ovs-dev] [ofp10_match test 2/2] tests: Add detailed test for OF1.0 match decoding and encoding.

2012-07-09 Thread Ben Pfaff
This follows the form of the OF1.1 match decoding and encoding test that I wrote a while back, which seems to be a good form to use. Signed-off-by: Ben Pfaff --- tests/ovs-ofctl.at| 207 + utilities/ovs-ofctl.c | 67 ++-- 2 files

[ovs-dev] [ofp10_match test 1/2] ofp-util: Wildcard VLAN PCP in OF1.0 matches when 802.1Q not present.

2012-07-09 Thread Ben Pfaff
When an output OF1.0 match uses OFP_VLAN_NONE to match only when the 802.1Q header is not present, it is somewhat contradictory to specify any value for the VLAN PCP, since none can be present without an 802.1Q header, but the match output by Open vSwitch did so. This fixes it. Signed-off-by: Ben

[ovs-dev] [ofp10_match test 0/2] better test ofp10_match decoding & encoding

2012-07-09 Thread Ben Pfaff
Last week, Simon Horman posted a patch series to implement the OXM VLAN VID and PCP matches, but I'm a little nervous about the possible effects it could have on the OF1.0 match support. At least, we need to know exactly what effects it has. This series, therefore, adds some more extensive unit t

Re: [ovs-dev] [PATCH] cfm: Remove sequence fault reason.

2012-07-09 Thread Ethan Jackson
Thanks for the review Ben, I've merged this. Ethan On Mon, Jul 9, 2012 at 7:43 PM, Ben Pfaff wrote: > On Mon, Jul 09, 2012 at 06:10:04PM -0700, Ethan Jackson wrote: >> Commit 2b540ecb (Added handling of previously ignored cfm faults.) >> made the CFM code trigger a fault when a packet is receive

Re: [ovs-dev] [PATCH] cfm: Remove sequence fault reason.

2012-07-09 Thread Ben Pfaff
On Mon, Jul 09, 2012 at 06:10:04PM -0700, Ethan Jackson wrote: > Commit 2b540ecb (Added handling of previously ignored cfm faults.) > made the CFM code trigger a fault when a packet is received with an > out of order sequence number. This means that if even one CFM > probe is dropped, a fault will

[ovs-dev] [PATCH] cfm: Remove sequence fault reason.

2012-07-09 Thread Ethan Jackson
Commit 2b540ecb (Added handling of previously ignored cfm faults.) made the CFM code trigger a fault when a packet is received with an out of order sequence number. This means that if even one CFM probe is dropped, a fault will be triggered because the next received probe's sequence would be two g

Re: [ovs-dev] [PATCH] netdev implementation for FreeBSD

2012-07-09 Thread Ben Pfaff
On Fri, Jul 06, 2012 at 09:51:12PM -0400, Ed Maste wrote: > A packet received by em0 is intercepted by BPF and delivered to Open > vSwitch via libpcap. Open vSwitch delivers it to the tap device, and > the stack then gets copies from both em0 and br0. This can be addressed > by a firewall rule to

[ovs-dev] [PATCH] ofp-actions: Add hex dump of bad actions to log message on error.

2012-07-09 Thread Ben Pfaff
This should make debugging easier in such cases. CC: Natasha Gude Signed-off-by: Ben Pfaff --- lib/ofp-actions.c | 11 +-- 1 files changed, 9 insertions(+), 2 deletions(-) diff --git a/lib/ofp-actions.c b/lib/ofp-actions.c index 2254f53..6b0363a 100644 --- a/lib/ofp-actions.c +++ b/l

Re: [ovs-dev] [flow monitor v2 11/12] ofproto: Add extra comments and checking for expiring a pending rule.

2012-07-09 Thread Justin Pettit
Looks good. --Justin On Jul 6, 2012, at 2:49 PM, Ben Pfaff wrote: > A given rule may only have one pending operation at a time, so when an > operation is pending we must not allow a flow expiration to be started on > that rule. > > This doesn't fix a user-visible bug in ofproto-dpif because of

Re: [ovs-dev] [flow monitor v2 10/12] ofproto: Represent flow cookie changes as operations too.

2012-07-09 Thread Justin Pettit
On Jul 6, 2012, at 2:49 PM, Ben Pfaff wrote: > -op->ofpacts_len = rule->ofpacts_len; > +op->ofpacts_len = op->ofpacts_len; Did you mean to do this? The previous way looks correct to me, and this looks like a no-op. Otherwise, looks good. --Justin __

Re: [ovs-dev] [PATCH] Code cleanup - In ovs-dpctl, ovs-ofctl command and dpif-netdev

2012-07-09 Thread Ben Pfaff
On Sun, Jul 08, 2012 at 04:38:36AM -0700, Arun Sharma wrote: > Rename do_* in ovs-dpctl and ovs-ofctl command with "dpctl_" or "ofctl_" > prefix. > > Rename add_flow with dp_netdev_flow_add in lib/dpif-netdev.c. > > Signed-off-by: Arun Sharma Thanks, applied to master. _

[ovs-dev] Google Corporation

2012-07-09 Thread Random Promotion Draw
VIEW ATTACHED DOCUMENT FOR MORE INFORMATION Google.co.za.rtf Description: RTF file ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

[ovs-dev] Processed: openvswitch: oops, closed the wrong bug.

2012-07-09 Thread Debian Bug Tracking System
Processing commands for cont...@bugs.debian.org: > # The upload of openvswitch 1.4.2+git20120612-3 fixed bug #680536 > # but the upload incorrectly closed #680537 instead. Fix it up. > reopen 680537 Bug #680537 {Done: Ben Pfaff } [openvswitch] openvswitch - Plays with iptables without consent 'r

[ovs-dev] Bug#680536: openvswitch: oops, closed the wrong bug.

2012-07-09 Thread Ben Pfaff
# The upload of openvswitch 1.4.2+git20120612-3 fixed bug #680536 # but the upload incorrectly closed #680537 instead. Fix it up. reopen 680537 notfixed 680537 1.4.2+git20120612-3 fixed 680536 1.4.2+git20120612-3 close 680536 thanks ___ dev mailing lis

[ovs-dev] Bug#680537: marked as done (openvswitch - Plays with iptables without consent)

2012-07-09 Thread Debian Bug Tracking System
Your message dated Mon, 09 Jul 2012 19:32:36 + with message-id and subject line Bug#680537: fixed in openvswitch 1.4.2+git20120612-3 has caused the Debian Bug report #680537, regarding openvswitch - Plays with iptables without consent to be marked as done. This means that you claim that the p

[ovs-dev] openvswitch_1.4.2+git20120612-3_i386.changes ACCEPTED into unstable

2012-07-09 Thread Debian FTP Masters
Accepted: openvswitch-brcompat_1.4.2+git20120612-3_i386.deb to main/o/openvswitch/openvswitch-brcompat_1.4.2+git20120612-3_i386.deb openvswitch-common_1.4.2+git20120612-3_i386.deb to main/o/openvswitch/openvswitch-common_1.4.2+git20120612-3_i386.deb openvswitch-controller_1.4.2+git20120612-3

[ovs-dev] Processing of openvswitch_1.4.2+git20120612-3_i386.changes

2012-07-09 Thread Debian FTP Masters
openvswitch_1.4.2+git20120612-3_i386.changes uploaded successfully to localhost along with the files: openvswitch_1.4.2+git20120612-3.dsc openvswitch_1.4.2+git20120612-3.debian.tar.gz openvswitch-common_1.4.2+git20120612-3_i386.deb openvswitch-switch_1.4.2+git20120612-3_i386.deb openvswit

[ovs-dev] [PATCH] Code cleanup - In ovs-dpctl, ovs-ofctl command and dpif-netdev

2012-07-09 Thread Arun Sharma
Rename do_* in ovs-dpctl and ovs-ofctl command with "dpctl_" or "ofctl_" prefix. Rename add_flow with dp_netdev_flow_add in lib/dpif-netdev.c. Signed-off-by: Arun Sharma --- lib/dpif-netdev.c |8 +- utilities/ovs-dpctl.c | 52 +++--- utilities/ovs-ofctl.c | 177 ++

Re: [ovs-dev] Bug#680537: Bug#680537: [PATCH] debian: Add "netbase" dependency for /etc/protocols.

2012-07-09 Thread Ben Pfaff
Thanks, I pushed this to all relevant branches. I'll do a Debian upload for this in a bit. On Fri, Jul 06, 2012 at 03:30:29PM -0700, Justin Pettit wrote: > Looks good. Thanks. > > --Justin > > > On Jul 6, 2012, at 3:08 PM, Ben Pfaff wrote: > > > ovs-ctl.in uses /etc/protocols, which is in th

Re: [ovs-dev] [PATCH] debian: Remove obsolete advice to edit /etc/default/openvswitch-switch.

2012-07-09 Thread Ben Pfaff
Thanks, I pushed this. On Fri, Jul 06, 2012 at 03:45:15PM -0700, Justin Pettit wrote: > Looks good. > > --Justin > > > On Jul 6, 2012, at 3:13 PM, Ben Pfaff wrote: > > > This hasn't been necessary for a long time. > > > > Signed-off-by: Ben Pfaff > > --- > > debian/openvswitch-switch.README.

[ovs-dev] 13/07 Banderazo para la renuncia de Pa$$arella

2012-07-09 Thread Hinchas y Socios de River Plate
Inviten a todos sus amigos a esta manifestación en contra de la dirigencia, para el bien de River, el bien de sus hinchas y el de toda su gente. Horario: 20:00 Dia: VIernes 13/07 Lugar: Cancha de River FACEBOOK: http://www.facebook.com/events/447751951909565/ TWITTER: @AndateDAP EL banderazo

[ovs-dev] [PATCH 2/2] OXM: Allow masking of IPv6 Flow Label

2012-07-09 Thread Simon Horman
Signed-off-by: Simon Horman --- lib/classifier.c | 13 ++--- lib/classifier.h | 1 + lib/flow.c | 13 + lib/flow.h | 12 ++-- lib/meta-flow.c| 20 lib/meta-flow.h| 1 + lib/nx-match.c | 6 ++ lib/ofp-util.c

[ovs-dev] [PATCH 1/2] NXM, OXM: Add Flow Label Tests

2012-07-09 Thread Simon Horman
Signed-off-by: Simon Horman --- tests/ovs-ofctl.at | 20 1 file changed, 20 insertions(+) diff --git a/tests/ovs-ofctl.at b/tests/ovs-ofctl.at index 491e0ab..e77d3fc 100644 --- a/tests/ovs-ofctl.at +++ b/tests/ovs-ofctl.at @@ -361,6 +361,11 @@ NXM_OF_ETH_TYPE(0800) NXM_NX_I

[ovs-dev] [PATCH 0/2] OXM: Allow masking of IPv6 Flow Label

2012-07-09 Thread Simon Horman
Hi, this short series adds: * Tests for the OXM and NXM IPv6 Flow Label matches * Masking of the OXM IPv6 Flow Label match Patches: [PATCH 1/2] NXM, OXM: Add Flow Label Tests [PATCH 2/2] OXM: Allow masking of IPv6 Flow Label Diffstat: lib/classifier.c | 13 ++--- lib/classifier.h