On Thu, Jul 05, 2012 at 12:59:15PM +0900, Atzm Watanabe wrote:
> Overwriting sequence number breaks replies (e.g. to brcompat).
>
> Signed-off-by: Atzm Watanabe
Thanks for the patch. I don't really like how it treats zero as a magic
number (as far as I know, zero isn't special for nlmsg_seq), a
Commit 7d7447 (netlink: Postpone choosing sequence numbers until send
time.) broke ovs-brcompatd because it prevented userspace replies to
kernel requests from using the correct sequence numbers. This commit fixes
it.
Atzm Watanabe found the root cause and provided an alternative patch to
avoid t
On Thu, Jul 05, 2012 at 12:53:37PM +0900, Isaku Yamahata wrote:
> The number 13, 14 aren't used.
>
> Signed-off-by: Isaku Yamahata
Thank you. I applied this to master.
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/de
Overwriting sequence number breaks replies (e.g. to brcompat).
Signed-off-by: Atzm Watanabe
---
lib/netlink-socket.c |4 +++-
1 files changed, 3 insertions(+), 1 deletions(-)
diff --git a/lib/netlink-socket.c b/lib/netlink-socket.c
index 713049a..6ecf24c 100644
--- a/lib/netlink-socket.c
++
Hi,
I've encountered a problem which is same as following issue on
OVS-1.7.90 and kernel-2.6.32 (CentOS 6.2).
http://openvswitch.org/pipermail/dev/2012-June/018213.html
It seems that problem is caused by changes at 7d7447 ...
brcompat cannot receive netlink reply because nl_sock_send__()
over
The number 13, 14 aren't used.
Signed-off-by: Isaku Yamahata
---
include/openflow/openflow-1.2.h |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/include/openflow/openflow-1.2.h b/include/openflow/openflow-1.2.h
index 9361a08..3125b07 100644
--- a/include/openflow/openfl
On Wed, Jul 04, 2012 at 03:06:25PM -0700, Ben Pfaff wrote:
> On Wed, Jul 04, 2012 at 05:50:43PM +0900, Simon Horman wrote:
> > Signed-off-by: Simon Horman
>
> This seems reasonable.
>
> I believe that we can test the behavior here by adding a few more lines
> to the "ovs-ofctl parse-nxm" and "ov
On Wed, Jul 04, 2012 at 05:49:30PM -0700, Ben Pfaff wrote:
> On Thu, Jul 05, 2012 at 09:47:29AM +0900, Simon Horman wrote:
> > On Wed, Jul 04, 2012 at 05:34:43PM -0700, Ben Pfaff wrote:
> > > On Thu, Jul 05, 2012 at 09:27:05AM +0900, Simon Horman wrote:
> > > > On Wed, Jul 04, 2012 at 02:55:52PM -0
On Thu, Jul 05, 2012 at 09:47:29AM +0900, Simon Horman wrote:
> On Wed, Jul 04, 2012 at 05:34:43PM -0700, Ben Pfaff wrote:
> > On Thu, Jul 05, 2012 at 09:27:05AM +0900, Simon Horman wrote:
> > > On Wed, Jul 04, 2012 at 02:55:52PM -0700, Ben Pfaff wrote:
> > > > On Wed, Jul 04, 2012 at 05:50:41PM +0
On Wed, Jul 04, 2012 at 05:34:43PM -0700, Ben Pfaff wrote:
> On Thu, Jul 05, 2012 at 09:27:05AM +0900, Simon Horman wrote:
> > On Wed, Jul 04, 2012 at 02:55:52PM -0700, Ben Pfaff wrote:
> > > On Wed, Jul 04, 2012 at 05:50:41PM +0900, Simon Horman wrote:
> > > > PCP depends on the presence of VID so
On Thu, Jul 05, 2012 at 09:27:05AM +0900, Simon Horman wrote:
> On Wed, Jul 04, 2012 at 02:55:52PM -0700, Ben Pfaff wrote:
> > On Wed, Jul 04, 2012 at 05:50:41PM +0900, Simon Horman wrote:
> > > PCP depends on the presence of VID so it seems to make sense
> > > to set the CFI bit as part of setting
On Wed, Jul 04, 2012 at 02:55:52PM -0700, Ben Pfaff wrote:
> On Wed, Jul 04, 2012 at 05:50:41PM +0900, Simon Horman wrote:
> > PCP depends on the presence of VID so it seems to make sense
> > to set the CFI bit as part of setting the VID rather than the PCP.
> >
> > Signed-off-by: Simon Horman
>
On Wed, Jul 04, 2012 at 05:50:44PM +0900, Simon Horman wrote:
> +ovs_be16 vid_and_cfi = flow->vlan_tci & htons(VLAN_PCP_MASK |
> VLAN_CFI);
This cannot be right, the variable name says VID but the expression says
PCP.
___
dev mailing list
dev@op
On Wed, Jul 04, 2012 at 05:50:43PM +0900, Simon Horman wrote:
> Signed-off-by: Simon Horman
This seems reasonable.
I believe that we can test the behavior here by adding a few more lines
to the "ovs-ofctl parse-nxm" and "ovs-ofctl parse-oxm" tests in
tests/ovs-ofctl.at. If you do that to valida
On Wed, Jul 04, 2012 at 05:50:42PM +0900, Simon Horman wrote:
> Signed-off-by: Simon Horman
This patch looks like it compounds the misunderstanding from the first,
so I didn't read further.
Thanks,
Ben.
___
dev mailing list
dev@openvswitch.org
http://
On Wed, Jul 04, 2012 at 05:50:41PM +0900, Simon Horman wrote:
> PCP depends on the presence of VID so it seems to make sense
> to set the CFI bit as part of setting the VID rather than the PCP.
>
> Signed-off-by: Simon Horman
The following change definitely can't be correct because OFP_VLAN_NONE
Thanks Ben.
I have tested this patch.
Arun
On 7/4/12 1:19 AM, "Ben Pfaff" wrote:
>On Fri, Jun 29, 2012 at 11:11:19AM -0700, Arun Sharma wrote:
>> ovs-ofctl will have --sort[=field]|--rsort[=field] option for
>>'dump-flows'.
>> Sort by field if specified else sort by default field 'priority'.
>
Your E- Mail Address have been chosen to receive This Years United Nations Cash
Grant of $450,000 USD
To begin your claim, send Full Names ,Address, Phone number,grant pin
#UNF/FBF-816-1119 G-900-94 (Mr. Nick Langraf) AT
nlang...@unitednationgrants.net.tc
Congratulations!!!
Best Regards,
Ch
Signed-off-by: Simon Horman
---
lib/classifier.c | 30 ++
lib/classifier.h | 1 +
lib/meta-flow.c | 5 -
3 files changed, 31 insertions(+), 5 deletions(-)
diff --git a/lib/classifier.c b/lib/classifier.c
index e74817e..964db25 100644
--- a/lib/classifier.c
+++
Hi,
the primary purpose of this series is to add encoding of the OXM
VLAN VID and VLAN PCP matches and the last patch of this series does that.
The first three patches fix what appear to me to be discrepancies between
the current implementation and the OpenFlow 1.2 specification. I am unsure
if t
PCP depends on the presence of VID so it seems to make sense
to set the CFI bit as part of setting the VID rather than the PCP.
Signed-off-by: Simon Horman
---
lib/classifier.c | 2 +-
lib/flow.c | 4 ++--
2 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/lib/classifier.c b/li
Signed-off-by: Simon Horman
---
lib/meta-flow.c | 8 +---
lib/meta-flow.h | 1 +
2 files changed, 6 insertions(+), 3 deletions(-)
diff --git a/lib/meta-flow.c b/lib/meta-flow.c
index 72ed108..a8b296a 100644
--- a/lib/meta-flow.c
+++ b/lib/meta-flow.c
@@ -149,9 +149,9 @@ static const struct m
Signed-off-by: Simon Horman
---
lib/nx-match.c | 28
1 file changed, 24 insertions(+), 4 deletions(-)
diff --git a/lib/nx-match.c b/lib/nx-match.c
index f7f3c88..dcdd0b4 100644
--- a/lib/nx-match.c
+++ b/lib/nx-match.c
@@ -516,10 +516,30 @@ nx_put_match(struct ofpbuf
23 matches
Mail list logo
