[ovs-dev] [of1.1 v4 5/5] ofp-util: Work on decoding OF1.1 flow_mods.

2012-07-03 Thread Ben Pfaff
Signed-off-by: Ben Pfaff --- v3->v4: Builds and passes unit tests. Somewhat incomplete, I think. --- include/openflow/openflow-1.1.h| 17 ++-- include/openflow/openflow-common.h | 10 ++ lib/ofp-errors.h |3 + lib/ofp-util.c | 181 ++

[ovs-dev] [of1.1 v4 4/5] openflow: Separate OF1.0, OF1.1 flow_mod constants and types.

2012-07-03 Thread Ben Pfaff
Signed-off-by: Ben Pfaff --- v3->v4: Builds, passes unit tests. --- include/openflow/nicira-ext.h |2 +- include/openflow/openflow-1.0.h| 19 --- include/openflow/openflow-common.h | 14 ++ lib/ofp-msgs.h |2 +- lib/ofp-print.c

[ovs-dev] [of1.1 v4 3/5] openflow: Rename OpenFlow 1.0 statistics messages with "10" infix.

2012-07-03 Thread Ben Pfaff
Reviewed-by: Simon Horman Signed-off-by: Ben Pfaff --- include/openflow/openflow-1.0.h| 57 +++- include/openflow/openflow-common.h | 23 ++ lib/ofp-msgs.c | 10 +++--- lib/ofp-msgs.h | 14 l

[ovs-dev] [of1.1 v4 2/5] nicira-ext: Drop nx_aggregate_stats_reply structure.

2012-07-03 Thread Ben Pfaff
It now duplicates ofp_aggregate_stats_reply except for alignment issues, so we might as well unify the code. Signed-off-by: Ben Pfaff --- include/openflow/nicira-ext.h | 15 +++ lib/ofp-msgs.h|2 +- lib/ofp-util.c| 57 +++---

[ovs-dev] [of1.1 v4 0/5] Next iteration of of1.1 series

2012-07-03 Thread Ben Pfaff
One major change in this revision is that some commits have been pushed to master, so the series shorter. Another major change is the first two patches, especially the first one, which has been extensively improved and revised versus the previous posting. This is also available at git://benpfaff.

Re: [ovs-dev] [PATCH 2/2] lib/ofp-actions: ofpacts_from_openflow11 doesn't put OFPACT_END

2012-07-03 Thread Ben Pfaff
On Thu, Jun 28, 2012 at 01:47:43PM +0900, Isaku Yamahata wrote: > The logic of ofpacts_from_openflow11() should be same to > ofpacts_from_openflow10(), so consolidate them. Thus the issue is fixed. > > Signed-off-by: Isaku Yamahata Hi Isaku. I believe that this commit should be unnecessary with

Re: [ovs-dev] [of1.1 v3 05/13] ofp-util: Remove unused functions.

2012-07-03 Thread Ben Pfaff
On Tue, Jun 26, 2012 at 11:53:48PM -0700, Ben Pfaff wrote: > Reviewed-by: Simon Horman > Signed-off-by: Ben Pfaff I squashed this into the previous commit. ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

Re: [ovs-dev] asking the example to use openflow protocol to limit the flow rate in openvswitch

2012-07-03 Thread trinh tri
Hi Mr Justin! I would like to ask about export the netflow from openvswitch to a remote ubuntu computer:               netflow  [ovs]=>[ubuntu-pc] Following the manual, I configure netflow exporter like this [ovs]:  $./ovs-vsctl -- set bridge br0 netflow=@nf -- --id=@nf create NetFlow ta

Re: [ovs-dev] [PATCH V2] ovs-ofctl: Ability to sort dump-flows by priority/other flow fields.

2012-07-03 Thread Ben Pfaff
On Fri, Jun 29, 2012 at 11:11:19AM -0700, Arun Sharma wrote: > ovs-ofctl will have --sort[=field]|--rsort[=field] option for 'dump-flows'. > Sort by field if specified else sort by default field 'priority'. > Option "--sort" to sort in ascending order and "--rsort" to sort in descending > order for

[ovs-dev] [sort 2/3] ovs-ofctl: Factor code out of read_flows_from_switch().

2012-07-03 Thread Ben Pfaff
I want to use this code in another function in an upcoming commit. Signed-off-by: Ben Pfaff --- utilities/ovs-ofctl.c | 123 +++-- 1 files changed, 68 insertions(+), 55 deletions(-) diff --git a/utilities/ovs-ofctl.c b/utilities/ovs-ofctl.c index 237

[ovs-dev] [sort 3/3] ovs-ofctl: Add --sort and --rsort options for "dump-flows" command.

2012-07-03 Thread Ben Pfaff
Signed-off-by: Arun Sharma [b...@nicira.com rewrote most of the code] Signed-off-by: Ben Pfaff --- NEWS |1 + lib/ofp-print.c | 80 +- lib/ofp-print.h |6 ++ tests/ovs-ofctl.at | 77 + utilities/ovs-o

[ovs-dev] [sort 1/3] ovs-ofctl: Use the prepared connection to dump flows in do_dump_flows__().

2012-07-03 Thread Ben Pfaff
The logic in do_dump_flows__() went to some trouble to open an OpenFlow connection and set the correct protocol, but then it allowed dump_stats_transaction() to create and use a completely different OpenFlow connection that hadn't been prepared that way. This commit fixes the problem. I don't thi

Re: [ovs-dev] [PATCH] ipsec gre: Do not reread ovs monitor ipsec pidfile in netdev vport so much

2012-07-03 Thread Ben Pfaff
On Mon, Jul 02, 2012 at 06:30:21PM -0700, Arun Sharma wrote: > Instead of rereading ovs-monitor-ipsec pidfile in netdev-vport so much. It's > probably only necessary to check once if ovs-monitor-ipsec is running, > and then cache the result. If the result is negative, then it may be > worthwhile

[ovs-dev] [PATCH] ipsec gre: Do not reread ovs monitor ipsec pidfile in netdev vport so much

2012-07-03 Thread Arun Sharma
Instead of rereading ovs-monitor-ipsec pidfile in netdev-vport so much. It's probably only necessary to check once if ovs-monitor-ipsec is running, and then cache the result. If the result is negative, then it may be worthwhile to try again the next time someone tries to configure an ipsec tunnel