I have made these changes.
Pushed to master.
Thanks Ben, Ravi.
On Tue, Jun 19, 2012 at 7:51 PM, Ben Pfaff wrote:
> On Tue, Jun 19, 2012 at 07:19:44PM -0700, Mehak Mahajan wrote:
> > In commit b2e18d(No need to restart DB / OVS on changing dscp value.),
> the
> > dscp value was wrongly set after
Thanks for the report.
Mehak found the problem:
http://openvswitch.org/pipermail/dev/2012-June/018145.html
and I expect that she will commit the fix soon.
On Tue, Jun 19, 2012 at 03:45:32PM -0700, ravi kerur wrote:
> this is all it has...
>
> root@:~/tmp_ovs/openvswitch# cat
> /usr/local
On Tue, Jun 19, 2012 at 07:19:44PM -0700, Mehak Mahajan wrote:
> In commit b2e18d(No need to restart DB / OVS on changing dscp value.), the
> dscp value was wrongly set after the reconnect.
>
> Signed-off-by: Mehak Mahajan
Thanks, Mehak.
Ravi reported this earlier today:
http://openvswi
In commit b2e18d(No need to restart DB / OVS on changing dscp value.), the
dscp value was wrongly set after the reconnect.
Signed-off-by: Mehak Mahajan
---
lib/jsonrpc.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/lib/jsonrpc.c b/lib/jsonrpc.c
index ce5d2b4..4870da8
Thanks,
Pushed to master.
On Tue, Jun 19, 2012 at 6:01 PM, Jesse Gross wrote:
> On Tue, Jun 19, 2012 at 5:48 PM, Pravin B Shelar wrote:
>> Signed-off-by: Pravin B Shelar
>> ---
>> datapath/datapath.c | 4 ++--
>> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> Acked-by: Jesse Gross
___
On Tue, Jun 19, 2012 at 5:48 PM, Pravin B Shelar wrote:
> Signed-off-by: Pravin B Shelar
> ---
> datapath/datapath.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
Acked-by: Jesse Gross
___
dev mailing list
dev@openvswitch.org
http://
Signed-off-by: Pravin B Shelar
---
datapath/datapath.c |4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/datapath/datapath.c b/datapath/datapath.c
index c2cb6b1..28e0573 100644
--- a/datapath/datapath.c
+++ b/datapath/datapath.c
@@ -61,8 +61,8 @@
#include "vport-internal
Thanks, Pushed to master.
On Tue, Jun 19, 2012 at 5:20 PM, Jesse Gross wrote:
> On Tue, Jun 19, 2012 at 5:12 PM, Pravin B Shelar wrote:
>> From kernel 3.4 netdevice structure has delayed_work in
>> net_device->pm_qos_req. delayed_work needs work_struct definition.
>> OVS has its own workq imple
On Tue, Jun 19, 2012 at 5:12 PM, Pravin B Shelar wrote:
> From kernel 3.4 netdevice structure has delayed_work in
> net_device->pm_qos_req. delayed_work needs work_struct definition.
> OVS has its own workq implementation which redefines work_struct.
> So we need to make it consistent with work_st
On Tue, Jun 19, 2012 at 05:08:41PM -0700, Justin Pettit wrote:
> +Q: How can I try Open vSwitch?
> +
> +A: Open vSwitch is as source code to be built on a Linux system. You
Missing word here?
> + can build and experiment with Open vSwitch on any Linux machine.
> + Packages for various Linux
>From kernel 3.4 netdevice structure has delayed_work in
net_device->pm_qos_req. delayed_work needs work_struct definition.
OVS has its own workq implementation which redefines work_struct.
So we need to make it consistent with work_struct defined
in kernel workqueue.h to have correct net_device de
Does some cleanup and adds entries that cover:
- OVS isn't Linux-specific.
- Point out PORTING guide.
- Explanation of LTS releases.
- Supported versions of OpenFlow.
- Missing features from userspace datapath and upstream kernel
module.
---
FAQ | 94 ++
The openvswitch.org web site has a FAQ. This commit integrates those
entries into the FAQ file.
Signed-off-by: Justin Pettit
---
FAQ | 101 +++
1 files changed, 101 insertions(+), 0 deletions(-)
diff --git a/FAQ b/FAQ
index 61bbb
this is all it has...
root@:~/tmp_ovs/openvswitch# cat
/usr/local/var/log/openvswitch/ovsdb-server.log
2012-06-19T22:39:22Z|1|vlog|INFO|opened log file
/usr/local/var/log/openvswitch/ovsdb-server.log
2012-06-19T22:39:32Z|2|memory|INFO|576 kB peak resident set size
after 10.0 seconds
2012-0
If you add --log-file to the ovsdb-server command line then you'll get
a log file in the log directory.
On Tue, Jun 19, 2012 at 03:14:49PM -0700, ravi kerur wrote:
> Odd about error seen by ovs-vsctl or ?
>
> I don't see log file anywhere in openvswitch and following directories
> and not in /usr
Odd about error seen by ovs-vsctl or ?
I don't see log file anywhere in openvswitch and following directories
and not in /usr/local/etc either, where is it located?
I started ovs-db-server with the options mentioned in INSTALL.Linux
On Tue, Jun 19, 2012 at 2:57 PM, Ben Pfaff wrote:
> How odd.
>
Your mail to 'discuss' with the subject
New Company concerning itself with the advertising
Is being held until the list moderator can review it for approval.
The reason it is being held:
SpamAssassin identified this message as possible spam (score 5.1)
Either the message will get poste
How odd.
What's in the ovsdb-server log?
On Tue, Jun 19, 2012 at 02:55:44PM -0700, ravi kerur wrote:
> root@:~/tmp_ovs/openvswitch# ovs-vsctl -vjsonrpc --no-wait init
> 2012-06-19T21:51:58Z|2|jsonrpc|DBG|unix:/usr/local/var/run/openvswitch/db.sock:
> send request, method="monitor",
> params=[
root@:~/tmp_ovs/openvswitch# ovs-vsctl -vjsonrpc --no-wait init
2012-06-19T21:51:58Z|2|jsonrpc|DBG|unix:/usr/local/var/run/openvswitch/db.sock:
send request, method="monitor",
params=["Open_vSwitch",null,{"Open_vSwitch":{"columns":[]}}], id=0
2012-06-19T21:51:58Z|3|jsonrpc|WARN|unix:/usr/lo
On Tue, Jun 19, 2012 at 02:40:59PM -0700, ravi kerur wrote:
> I am getting following errors when installing ovs on kernel 3.3 and
> Ubuntu 12.04, it works fine on kernel 3.0. I checked out latest git
> code and while installation get following errors. Installation on
> kernel 3.3 had worked perfect
I am getting following errors when installing ovs on kernel 3.3 and
Ubuntu 12.04, it works fine on kernel 3.0. I checked out latest git
code and while installation get following errors. Installation on
kernel 3.3 had worked perfectly before. Does ovs-vsctl need more
parameters now?
root@:~/tmp_ovs
On Thu, Jun 14, 2012 at 5:29 PM, ravi kerur wrote:
> On Thu, Jun 14, 2012 at 8:22 AM, Jesse Gross wrote:
>> On Jun 14, 2012, at 10:13 PM, ravi kerur wrote:
>>
>>> On Thu, Jun 14, 2012 at 3:58 AM, Jesse Gross wrote:
On Thu, Jun 14, 2012 at 1:24 PM, ravi kerur wrote:
> On Wed, Jun 13, 2
thanx!
I made the changes and pushed the patch to master.
On Tue, Jun 19, 2012 at 9:12 AM, Ben Pfaff wrote:
> On Fri, Jun 08, 2012 at 12:04:14PM -0700, Mehak Mahajan wrote:
> > With this change there is no need to restart the DB or OVS on
> configuring a
> > different value for the manager or co
Accepted:
openvswitch-brcompat_1.4.2+git20120612-2_i386.deb
to main/o/openvswitch/openvswitch-brcompat_1.4.2+git20120612-2_i386.deb
openvswitch-common_1.4.2+git20120612-2_i386.deb
to main/o/openvswitch/openvswitch-common_1.4.2+git20120612-2_i386.deb
openvswitch-controller_1.4.2+git20120612-2
openvswitch_1.4.2+git20120612-2_i386.changes uploaded successfully to localhost
along with the files:
openvswitch_1.4.2+git20120612-2.dsc
openvswitch_1.4.2+git20120612-2.debian.tar.gz
openvswitch-common_1.4.2+git20120612-2_i386.deb
openvswitch-switch_1.4.2+git20120612-2_i386.deb
openvswit
Thanks, I pushed this to master and branch-1.[4567] and I will soon
upload an updated package to Debian.
On Mon, Jun 18, 2012 at 10:17:26AM -0700, Justin Pettit wrote:
> FWIW, I don't know much about DKMS, but it looks reasonable from my
> quick web search.
>
> --Justin
>
>
> On Jun 18, 2012, a
On Fri, Jun 08, 2012 at 12:04:14PM -0700, Mehak Mahajan wrote:
> With this change there is no need to restart the DB or OVS on configuring a
> different value for the manager or controller connection respectively. On
> detecting a change in the dscp value on the socket, the previous socket is
> clo
I am unsure of the overall merit if this change,
but it does allow to avoid a small amount of code duplication.
Signed-off-by: Simon Horman
---
v3
* Initial post
---
include/openflow/nicira-ext.h | 10 --
lib/ofp-print.c | 19 ---
lib/ofp-util.c
Enable the decoding of some Open Flow 1.2 and 1.1 messages which
have the same wire-format and thus decoders as Open Flow 1.0.
Signed-off-by: Simon Horman
---
v3
* Enable decoding of stats messages
v3
* Initial post
---
lib/ofp-util.c | 70 +
Signed-off-by: Simon Horman
---
v3
* Initial post
---
lib/ofp-util.c| 26 --
lib/ofp-util.h| 3 ++-
ofproto/ofproto.c | 2 +-
3 files changed, 27 insertions(+), 4 deletions(-)
diff --git a/lib/ofp-util.c b/lib/ofp-util.c
index 10aac6a..1fcd012 100644
--- a/lib
Open Flow 1.0 uses a different alignment of members to
Open Flow 1.1 and 1.2. For this reason I would like to
add a struct ofp11_aggregate_stats_reply in a subsequent patch.
In preparation for that rename ofp_aggregate_stats_reply.
Signed-off-by: Simon Horman
---
v3
* Initial post
---
include/
Signed-off-by: Simon Horman
---
v3
* Differentiate versions using oh->version rather than relying
on a separate code for each version of the Packet Out message.
v2
* No change
---
lib/ofp-print.c | 4 ++--
lib/ofp-util.c| 35 +++
lib/ofp-util.h| 2
Signed-off-by: Simon Horman
---
v3
* Add protocol parameter to ofputil_encode_packet_in().
This allows packet_in_format to be ignored for Open Flow 1.2.
v2
* Update for new ofputil_put_match() implementation
---
lib/ofp-util.c| 76 +--
* request OFP12_VERSION
* Always send using OF1.2
* Reset ofconn to OF1.2
---
lib/ofp-util.c| 2 +-
lib/vconn.c | 12 ++--
ofproto/connmgr.c | 2 +-
3 files changed, 8 insertions(+), 8 deletions(-)
diff --git a/lib/ofp-util.c b/lib/ofp-util.c
index 4e8536b..8f2aecf 100644
---
Signed-off-by: Simon Horman
---
v3
* Initial post
---
include/openflow/openflow-1.1.h | 10 ++
lib/ofp-print.c | 18 --
lib/ofp-util.c | 19 ++-
3 files changed, 40 insertions(+), 7 deletions(-)
diff --git a/include/openf
Signed-off-by: Simon Horman
---
v3
* Initial post
---
lib/ofp-util.c | 49 +++--
1 file changed, 47 insertions(+), 2 deletions(-)
diff --git a/lib/ofp-util.c b/lib/ofp-util.c
index 1fcd012..20b288d 100644
--- a/lib/ofp-util.c
+++ b/lib/ofp-util.c
@@
Allow decoding of Open Flow 1.1 and 1.2 flow and aggregate flow statistics
request messages.
Signed-off-by: Simon Horman
---
v3
* Initial post
---
lib/ofp-util.c | 42 +++---
1 file changed, 35 insertions(+), 7 deletions(-)
diff --git a/lib/ofp-util.c b/lib
Signed-off-by: Simon Horman
---
v3
* Add protocol variable to do_probe().
Previously this was added by a separate patch.
v2
* No change
---
lib/learning-switch.c | 10 --
lib/ofp-util.c| 30 ++
lib/ofp-util.h| 3 ++-
utilities/ovs-ofctl.c
Signed-off-by: Simon Horman
---
v3
* Correct title: this patch relates to Packet Out not Packet In
* Correct decoding of buffer_id, it is 32bits wide not 16bits wide
* Add decoding of stats reply messages
v2
* No change
---
lib/ofp-util.c | 10 +-
1 file changed, 9 insertions(+), 1 del
Signed-off-by: Simon Horman
---
v3
* Add OF1.2 entry to to ofputil_msg_types
* Make OF1.2 the first option in the if statement in ofputil_decode_packet_in()
* Rename o11pi as opi, which is consistent with the style used elsewhere
* Rebase
v2
* No change
---
lib/ofp-util.c | 60
There are capabilities which are present in one, two and three
of Open Flow 1.0, 1.1 and 1.2. Update OFPC_COMMON to only include
capabilities that are prsent in all three Open Flow versions and
add ofputil_capabilities_mask() to return the mask of capabilities
for each version.
This does not cover
Signed-off-by: Simon Horman
---
v3
* Manual rebase
* Correct title: This patch relates to Packet Out not Packet In
* Use OFPT_PACKET_OUT instead of OFPT11_PACKET_OUT, it seems
easier to use a single code and differentiate using the version
in the ofp_header
* Return error value returned by o
Open Flow 1.2, like Open Flow 1.1, has OFPC11_GROUP_STATS.
All other Open Flow 1.2 capabilities are handled by
ofputil_capabilities_mask() which is used by both
ofputil_decode_switch_features() and ofputil_encode_switch_features().
No update to ofputil_encode_switch_features() is required
to supp
* OFPUTIL_C_ARP_MATCH_IP is not present in Open Flow 1.2.
* OFPUTIL_C_PORT_BLOCKED is new in Open Flow 1.2.
Otherwise the Open Flow 1.2 capabilities are the same as those of
Open Flow 1.1.
Signed-off-by: Simon Horman
---
v3
* No change
v2
* No change
---
lib/ofp-print.c | 1 +
lib/ofp-util.h
Signed-off-by: Simon Horman
---
v3
* No change
v2
* No change
---
lib/ofp-util.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/lib/ofp-util.c b/lib/ofp-util.c
index ddd51c6..a4735f2 100644
--- a/lib/ofp-util.c
+++ b/lib/ofp-util.c
@@ -823,6 +823,8 @@ static const struc
Signed-off-by: Simon Horman
---
v3
* No change
v2
* No change
---
lib/ofp-util.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lib/ofp-util.c b/lib/ofp-util.c
index dcd19a1..ddd51c6 100644
--- a/lib/ofp-util.c
+++ b/lib/ofp-util.c
@@ -3178,7 +3178,7 @@ ofputil_encode_port
Signed-off-by: Simon Horman
---
v3
* No change
v2
* Use ofputil_put_match()
---
lib/ofp-util.c | 18 ++
1 file changed, 18 insertions(+)
diff --git a/lib/ofp-util.c b/lib/ofp-util.c
index b6c7062..dcd19a1 100644
--- a/lib/ofp-util.c
+++ b/lib/ofp-util.c
@@ -1981,6 +1981,24 @@
This may be used by both ofputil_decode_flow_mod() and
ofputil_decode_packet_in()
Signed-off-by: Simon Horman
---
v3
* Do not pull ofpbuf_pull() in the case of a STANDARD match.
This simplifies things a little.
v2
* No change
---
lib/ofp-util.c | 47 -
Signed-off-by: Simon Horman
---
v3
* Open Flow 1.2 uses an 8bit command, previously 16 bits was used incorrectly
* Use Open Flow 1.2 action encoding, previously Open Flow 1.0 encoding
was used incorrectly
* ofp11_match_header is added by ofputil_put_match(),
previously it was incorectly adde
Signed-off-by: Simon Horman
---
v3
* No change
*v3
Initial post
---
lib/ofp-util.c | 28 +++-
1 file changed, 27 insertions(+), 1 deletion(-)
diff --git a/lib/ofp-util.c b/lib/ofp-util.c
index 6b29ad7..b6c7062 100644
--- a/lib/ofp-util.c
+++ b/lib/ofp-util.c
@@ -819,6
Signed-off-by: Simon Horman
---
v3
* No change
v2
* Use ofputil_put_match()
---
lib/ofp-util.c | 17 +
1 file changed, 17 insertions(+)
diff --git a/lib/ofp-util.c b/lib/ofp-util.c
index 95dbfed..6b29ad7 100644
--- a/lib/ofp-util.c
+++ b/lib/ofp-util.c
@@ -2340,6 +2340,23 @@ o
This wraps nx_put_match() to provide an extra header as necessary.
For Open Flow 1.0 + NXM extensions nx_put_match() is comprises
the entire match.
For Open Flow 1.2 a header is required before
the match supplied by x_put_match().
Signed-off-by: Simon Horman
---
v3
* Add "ofp-util:" prefix to
Reduce scope of per-protocol variables in ofputil_encode_flow_mod()
These variables are only needed in one of the cases covered by the switch
statement and will increase in number as more cases (protocols) are
supported.
Signed-off-by: Simon Horman
---
v3
* No change
v2
* No change
---
lib/o
Signed-off-by: Simon Horman
---
v3
* No change
v2
* No change
---
lib/ofp-util.c | 16 +++-
1 file changed, 15 insertions(+), 1 deletion(-)
diff --git a/lib/ofp-util.c b/lib/ofp-util.c
index 91505da..95dbfed 100644
--- a/lib/ofp-util.c
+++ b/lib/ofp-util.c
@@ -811,6 +811,18 @@ sta
Pass a protocol based on the prevailing protocol to ofputil_decode_flow_mod()
Note that ofputil_protocol_from_ofp_version() needs to be made
Open Flow 1.1 aware.
Signed-off-by: Simon Horman
---
v3
* No change
v2
* Actually pass calculated protocol to ofputil_decode_flow_mod()
---
lib/ofp-pri
Empirically it appears that process_packet_in() should call
ofputil_encode_flow_mod() with protocol rather than sw->protocol.
Signed-off-by: Simon Horman
---
v3
* Initial post
---
lib/learning-switch.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lib/learning-switch.c b/
This adds support for ofpacts_to_openflow11() to encode instructions
although at this point only the OFPIT11_APPLY_ACTIONS instruction
type is supported.
I am unsure if it would be better to use a new function that
wraps the existing ofpacts_to_openflow11(). But for now
I have simply modified ofpa
This is a local change to fix some compile errors in
Ben Pfaff's "ofp-util: Work on decoding OF1.1 flow_mods." patch.
It should either be rolled into those changes or dropped.
---
lib/ofp-util.c| 104 +++---
utilities/ovs-ofctl.c | 2 +-
2 fil
In the case of Open Flow 1.2, which is currently the only
time that OXM is be used, there is a 4 byte header before
the match which needs to be taken into account when calculating
the pad length.
This is not entirely pretty, but it does seem to be correct.
Signed-off-by: Simon Horman
---
v3
*
Hi Ben,
these patches are based on your of1.1 git branch
(21602cd6bdf056d24b2c6191d636bebcbb336ad9 "ofp-util: Work on decoding OF1.1
flow_mods.")
They are all compile tested only. I have also, using the last patch
which adds some hacks to allow ovs-vswtichd and ovs-controller to netogiate
an Open
Add OFPUTIL_P_OF12 and NXFF_OPENFLOW12 for Open Flow 1.2
OFPUTIL_P_OF12_TID and in turn OFPUTIL_P_OF12_ANY is not provided as
OFPUTIL_P_OF12 supports the use of table ids in modify flow messages.
Signed-off-by: Simon Horman
---
v3
* Don't add NXPIF_OPENFLOW12, it doesn't seem to be needed
v2
Signed-off-by: Simon Horman
---
v3
* Add "openflow: " prefix to title
v2
* No change
---
lib/ofp-print.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/lib/ofp-print.c b/lib/ofp-print.c
index 4cf4734..87b2978 100644
--- a/lib/ofp-print.c
+++ b/lib/ofp-print.c
@@ -1370,6 +1370,9 @@ ofp_
62 matches
Mail list logo
