Looks good, thanks.
Ethan
On Fri, May 25, 2012 at 2:36 PM, Ben Pfaff wrote:
> An initial attempt also replaced the 'uint32_t ready_mask' in struct
> dpif_linux by a 'bool ready' in each struct dpif_channel, but I wasn't
> happy with the result (the ready_mask bitmap works out really well) and so
Looks good, thanks.
Ethan
On Fri, May 25, 2012 at 2:36 PM, Ben Pfaff wrote:
> When a kernel-to-user Netlink buffer overflows, the kernel reports
> ENOBUFS without passing along an actual message. When it does this,
> we should immediately try again, because we know that there is a
> message wai
This has always annoyed me a bit, looks good.
Ethan
On Fri, May 25, 2012 at 2:36 PM, Ben Pfaff wrote:
> 120 messages per minute just isn't helpful.
>
> Signed-off-by: Ben Pfaff
> ---
> lib/poll-loop.c | 4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/lib/poll-loo
Thanks Jesse, I will check the code in vport-netdev.c file and get
back with the diffs. I did modify the code to get earlier version
working. Anyways will get back to you.
On Tue, May 29, 2012 at 3:32 PM, Jesse Gross wrote:
> On Tue, May 29, 2012 at 1:32 PM, ravi kerur wrote:
>> Thanks Jesse. Wh
On Tue, May 29, 2012 at 1:32 PM, ravi kerur wrote:
> Thanks Jesse. What I have tested is 2 Ubuntu 11.04 and 12.04 physical
> systems connected via a ethernet switch. I have tested scp downloads,
> iperf + netperf. Flows are setup such that MPLS tag is pushed for
> every outgoing TCP segments. I do
Jesse, Does this make sense?
Thanks,
Ravi
On Tue, May 29, 2012 at 1:32 PM, ravi kerur wrote:
> Thanks Jesse. What I have tested is 2 Ubuntu 11.04 and 12.04 physical
> systems connected via a ethernet switch. I have tested scp downloads,
> iperf + netperf. Flows are setup such that MPLS tag is pu
Looks like changes are not compatible with Xen, its in kernel code. I have only
tested against CentOS, Ubuntu on 2.6/3.0/3.3 kernel. I can send you an
incremental patch but I would highly prefer to send a complete patch for both
MPLS + QinQ as it has code review comments incorporated. Also note
Thanks Jesse. What I have tested is 2 Ubuntu 11.04 and 12.04 physical
systems connected via a ethernet switch. I have tested scp downloads,
iperf + netperf. Flows are setup such that MPLS tag is pushed for
every outgoing TCP segments. I do see via tcpdump that a jumbo packet
(~15K) is sent out by s
On Tue, May 29, 2012 at 12:12 PM, ravi kerur wrote:
> Additional changes are needed here esp. in NIC driver(looked into
> e1000e driver code from Intel) as it requires handling of new
> eth_types. For these changes I probably need to work with you and
> Jesse on how best we can incorporate them.
On 5/24/12 1:40 PM, ravi.ke...@telekom.com wrote:
Thanks Luiz, Please update on your test results.
I'm trying to compile it on the XenServer DDK release 6.0.2-53456p
(xenenterprise) and I'm getting a compilation error:
http://pastebin.com/0XhaAyB6
/* Handle VLAN-QinQ/MPLS, VLAN/MPLS e
Thanks Joe! I looked this over and fixed a couple of issues I
noticed. I'm appending the changes I made. I'll push this soon.
On Tue, May 29, 2012 at 12:38:21AM +1200, Joe Stringer wrote:
> There is currently two tests that this patch fails:-
>
> [Test 137] "ovs-ofctl dump-flows honors -F opti
On Tue, May 29, 2012 at 11:14 AM, Ben Pfaff wrote:
> Thanks so much for applying my comments. Will you please post the
> newest version of the MPLS patch? At this time it would be good to
> get your
> Signed-off-by: Ravi Kerur
> in the commit log, since it is getting closer. (You can re
On May 29, 2012, at 11:49 AM, Ben Pfaff wrote:
> On Tue, May 29, 2012 at 11:46:44AM -0700, Justin Pettit wrote:
>> Okay, combined with the previous comment, it now looks like this:
>>
>> .IP "\fBovs\-ofctl mod\-flows br0 cookie=1,action=normal\fR"
>> Change all flows' cookies to 1 and change thei
On Tue, May 29, 2012 at 11:46:44AM -0700, Justin Pettit wrote:
> Okay, combined with the previous comment, it now looks like this:
>
> .IP "\fBovs\-ofctl mod\-flows br0 cookie=1,action=normal\fR"
> Change all flows' cookies to 1 and change their actions to \fBnormal\fR.
> .IP "\fBovs\-ofctl mod\-f
On May 29, 2012, at 10:34 AM, Ben Pfaff wrote:
> On Fri, May 25, 2012 at 06:48:40PM -0700, Justin Pettit wrote:
>> Commit e72e793 (Add ability to restrict flow mods and flow stats
>> requests to cookies.) modified cookie handling. Some of its behavior
>> was unintuitive and there was at least one
Thanks so much for applying my comments. Will you please post the
newest version of the MPLS patch? At this time it would be good to
get your
Signed-off-by: Ravi Kerur
in the commit log, since it is getting closer. (You can read about
the purpose and meaning of this line in SubmittingPa
Hi Ben,
All your code review comments have been taken care for MPLS. I did
retest the code after incorporating code review comments. I also
modified the code for QinQ (common comments which apply to QinQ code
as well), added additional automation tests in odp.at for QinQ. In
addition, patch to sup
On Tue, May 29, 2012 at 12:38:11AM +1200, Joe Stringer wrote:
> With OpenFlow 1.1 requiring arbitrary ethernet match support, it simplifies
> other code if we have some extra helper functions. This patch adds
> eth_mask_is_exact(mask), eth_addr_bitand(src, mask, dst),
> eth_addr_equal_except(a, b,
On Fri, May 25, 2012 at 06:48:40PM -0700, Justin Pettit wrote:
> Commit e72e793 (Add ability to restrict flow mods and flow stats
> requests to cookies.) modified cookie handling. Some of its behavior
> was unintuitive and there was at least one bug (described below).
> Commit f66b87d (DESIGN: Doc
On Tue, May 29, 2012 at 10:48:10AM +0530, Naga Rohit wrote:
> Btw, is ovs 1.7.9 compatible with linux kernel 2.6.38-8 ?
Yes.
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
20 matches
Mail list logo
