Re: [ovs-dev] Is there a way to have a flow perform tbl_lookup twice?

2012-05-02 Thread Jesse Gross
On Wed, May 2, 2012 at 7:50 PM, YIMIN CHEN wrote: > Hi Jesse, > > I was looking at ovs dp code, and is looking at a correct way for a >  flow to traverse the table twice. The goal is like this: > > flow lookup => tbl_lookup() > perform actions => execute_actions() which changes the packet > flow l

[ovs-dev] Openvswitch support QoS across multiple route!

2012-05-02 Thread hung -cuncon
Hi all, I want setup openvswitch with QoS across two routes as follow: VM --> route 1 to net 1 with QoS1 (Queue, traffic limit ...) --> route 2 to net 2 with QoS2 EveryOne can help me? Thanks ___ dev mailing list dev@openvswitch.org http://openvsw

Re: [ovs-dev] Is there a way to have a flow perform tbl_lookup twice?

2012-05-02 Thread Ben Pfaff
It's documented in nicira-ext.h: /* Action structures for NXAST_RESUBMIT and NXAST_RESUBMIT_TABLE. * * These actions search one of the switch's flow tables: * *- For NXAST_RESUBMIT_TABLE only, if the 'table' member is not 255, then * it specifies the table to search. * *- Other

Re: [ovs-dev] Is there a way to have a flow perform tbl_lookup twice?

2012-05-02 Thread YIMIN CHEN
Hi Jesse, I was looking at ovs dp code, and is looking at a correct way for a flow to traverse the table twice. The goal is like this: flow lookup => tbl_lookup() perform actions => execute_actions() which changes the packet flow lookup using the new packet => tbl_lookup() perform actions on the

Re: [ovs-dev] Is there a way to have a flow perform tbl_lookup twice?

2012-05-02 Thread Jesse Gross
On Wed, May 2, 2012 at 6:54 PM, YIMIN CHEN wrote: > Hi Ben, > > Thank you for  your reply! I saw there is some code about resubmit > Nicira extension action, but that seems to be in userspace ofproto.c, > not in datapath, so I didn't know that is related. Could you help > clarify for me how does r

Re: [ovs-dev] Is there a way to have a flow perform tbl_lookup twice?

2012-05-02 Thread YIMIN CHEN
Hi Ben, Thank you for your reply! I saw there is some code about resubmit Nicira extension action, but that seems to be in userspace ofproto.c, not in datapath, so I didn't know that is related. Could you help clarify for me how does resubmit work? Thanks! Yimin On Wed, May 2, 2012 at 12:40 PM

Re: [ovs-dev] [PATCH] Global replace of Nicira Networks.

2012-05-02 Thread Ben Pfaff
On Wed, May 02, 2012 at 03:21:36PM -0700, Raju Subramanian wrote: > Replaced all instances of Nicira Networks(, Inc) to Nicira, Inc. > > Feature #10593 > Signed-off-by: Raju Subramanian Thanks, I pushed this to master. ___ dev mailing list dev@openvswi

Re: [ovs-dev] [PATCH] [RFC] datapath: tunnelling: Replace tun_id with tun_key

2012-05-02 Thread Kyle Mestery (kmestery)
On May 2, 2012, at 7:41 AM, Simon Horman wrote: > On Wed, May 02, 2012 at 06:19:58PM +0900, Simon Horman wrote: >> On Tue, May 01, 2012 at 04:50:49PM -0700, Jesse Gross wrote: >>> On Mon, Apr 30, 2012 at 5:13 PM, Simon Horman wrote: this is a first pass at providing a tun_key which can be use

Re: [ovs-dev] [PATCH] ovs-ctl: Add support for running daemons under valgrind or strace.

2012-05-02 Thread Ben Pfaff
On Wed, May 02, 2012 at 01:27:41PM -0700, Justin Pettit wrote: > On May 2, 2012, at 12:56 PM, Ben Pfaff wrote: > > > +\fIniceness\fR may also take one of the following special values. > > I understand that enabling these features are mutually exclusive > with setting the niceness, but it seems od

Re: [ovs-dev] [PATCH] Global replace of Nicira Networks.

2012-05-02 Thread Ben Pfaff
The test that fails converts a fixed OpenFlow message, expressed as hex bytes, into text. Your search-and-replace did not change the hex bytes that represent "Nicira Networks" but it did change the expected output. I suggest that you fix up the hex bytes so that they spell out the new expected ou

[ovs-dev] [PATCH] ovs-ofctl: Support all OFPPC_* flags in "mod-port" command.

2012-05-02 Thread Ben Pfaff
Signed-off-by: Ben Pfaff --- This is a revision of a patch I sent out long ago that was part of a series that rotted during review and eventually fell off the end of everyone's queue. NEWS |2 + utilities/ovs-ofctl.8.in | 58 ++---

Re: [ovs-dev] [PATCH] ovs-ctl: Add support for running daemons under valgrind or strace.

2012-05-02 Thread Justin Pettit
On May 2, 2012, at 12:56 PM, Ben Pfaff wrote: > +\fIniceness\fR may also take one of the following special values. I understand that enabling these features are mutually exclusive with setting the niceness, but it seems odd to overload the term since these programs have nothing to do with nicen

[ovs-dev] [PATCH] ovs-ctl: Add support for running daemons under valgrind or strace.

2012-05-02 Thread Ben Pfaff
This is occasionally useful for debugging. Signed-off-by: Ben Pfaff --- Not yet tested, but I'll be sure to test this before committing it. utilities/ovs-ctl.8 | 15 +++ utilities/ovs-lib.in | 14 +- 2 files changed, 28 insertions(+), 1 deletions(-) diff --git a/ut

Re: [ovs-dev] [PATCH] ofproto: Rate-limit STP status errors on non-existent ports.

2012-05-02 Thread Justin Pettit
On May 2, 2012, at 10:54 AM, Ben Pfaff wrote: > Looks good, thank you. Thanks. I pushed this to master. --Justin ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

Re: [ovs-dev] [PATCH branch-1.6] ofproto: Don't allow feature reply to overflow max OpenFlow message size.

2012-05-02 Thread Ben Pfaff
Actually OF1.3 fixes this by moving port descriptions to a stats reply. On Wed, May 02, 2012 at 10:53:40AM -0700, Ben Pfaff wrote: > Thanks, pushed to branch-1.6. > > Unfortunately most of the information about ports in the feature reply > doesn't appear in the port stats message, so just droppin

Re: [ovs-dev] [PATCH] ofproto: Rate-limit STP status errors on non-existent ports.

2012-05-02 Thread Ben Pfaff
On Wed, May 02, 2012 at 10:49:10AM -0700, Justin Pettit wrote: > As part of the bridge's main loop, it queries the STP status of all > ports. If the port doesn't exist, log files can become filled with > warning messages. This situation is very unusual, since system devices > do not normally disa

Re: [ovs-dev] [PATCH branch-1.6] ofproto: Don't allow feature reply to overflow max OpenFlow message size.

2012-05-02 Thread Ben Pfaff
Thanks, pushed to branch-1.6. Unfortunately most of the information about ports in the feature reply doesn't appear in the port stats message, so just dropping the ports would lose information. On Wed, May 02, 2012 at 10:48:51AM -0700, Justin Pettit wrote: > Looks good. > > We should probably lo

[ovs-dev] [PATCH] ofproto: Rate-limit STP status errors on non-existent ports.

2012-05-02 Thread Justin Pettit
As part of the bridge's main loop, it queries the STP status of all ports. If the port doesn't exist, log files can become filled with warning messages. This situation is very unusual, since system devices do not normally disappear, but it's easy enough to rate-limit these messages. Bug #10936

Re: [ovs-dev] [PATCH branch-1.6] ofproto: Don't allow feature reply to overflow max OpenFlow message size.

2012-05-02 Thread Justin Pettit
Looks good. We should probably look at addressing this in the OpenFlow spec, since my quick reading shows that the Features Reply has the same behavior in OpenFlow 1.2. I wonder if it would make sense to just not report on ports there, since the controller can get that information through a Po

[ovs-dev] [PATCH branch-1.6] ofproto: Don't allow feature reply to overflow max OpenFlow message size.

2012-05-02 Thread Ben Pfaff
An OpenFlow message is limited to 65535 bytes so if there are more than (65535 - sizeof(struct ofp_switch_features)) / sizeof(struct ofp_phy_port) == 1364 ports then the feature reply cannot hold them all. This commit prevents the feature reply from overflowing, at the cost of only reporting a ran

Re: [ovs-dev] [PATCH] Global replace of Nicira Networks.

2012-05-02 Thread Ben Pfaff
I'm appending the details of the failure. On Tue, May 01, 2012 at 10:52:51PM -0700, Raju Subramanian wrote: > I will take a look. > > On Tue, May 1, 2012 at 9:15 PM, Ben Pfaff wrote: > > > On Tue, May 01, 2012 at 04:54:18PM -0700, Raju Subramanian wrote: > > > Replaced all instances of Nicira N

Re: [ovs-dev] [PATCH] [RFC] datapath: tunnelling: Replace tun_id with tun_key

2012-05-02 Thread Simon Horman
On Wed, May 02, 2012 at 06:19:58PM +0900, Simon Horman wrote: > On Tue, May 01, 2012 at 04:50:49PM -0700, Jesse Gross wrote: > > On Mon, Apr 30, 2012 at 5:13 PM, Simon Horman wrote: > > > this is a first pass at providing a tun_key which can be used > > > as the basis for flow-based tunnelling. Th

Re: [ovs-dev] [PATCH] [RFC] datapath: tunnelling: Replace tun_id with tun_key

2012-05-02 Thread Simon Horman
On Tue, May 01, 2012 at 04:50:49PM -0700, Jesse Gross wrote: > On Mon, Apr 30, 2012 at 5:13 PM, Simon Horman wrote: > > this is a first pass at providing a tun_key which can be used > > as the basis for flow-based tunnelling. The tun_key includes and > > replaces the tun_id in both struct ovs_skb_