[ovs-dev] HALLO ...

2012-04-27 Thread Akpa Blessing
I have send a mail to you before but not yet heard from you. do you get my mail? I am still waiting for your urgent response. Yours alone, Akpa Blessing. Ich habe eine Mail an Sie vor, aber noch nicht von dir gehört. bekommst du meine E-Mails? Ich warte immer noch auf Ihre dringende Antwor

Re: [ovs-dev] [PATCH 1/2] ovs-bugtool: Add "ovs-appctl coverage/show" output to bugtool.

2012-04-27 Thread Gurucharan Shetty
Should this go to debian/openvswitch-common.install ? Even the other bugtool patch? Thanks, Guru On Fri, Apr 27, 2012 at 2:12 PM, Ben Pfaff wrote: > This can be useful for diagnosis. > > Signed-off-by: Ben Pfaff > --- > I haven't tested this yet. > >  utilities/bugtool/automake.mk              

Re: [ovs-dev] [PATCH 2/2] ovs-bugtool: Add "ovs-vsctl show" output to bugtool.

2012-04-27 Thread Gurucharan Shetty
On Fri, Apr 27, 2012 at 2:12 PM, Ben Pfaff wrote: > The information output by "ovs-vsctl show" is a subset of that available > elsewhere in bugtool output, but it is human-readable instead of needing > to be processed through ovsdb-server or ovsdb-tool, so it is much more > convenient for basic di

[ovs-dev] [PATCH] ovs-ctl: Make "force-reload-kmod" warn when DHCP clients must be restarted.

2012-04-27 Thread Ben Pfaff
This should make it more obvious when the admin needs to restart a DHCP client (or other daemon). Without this, unless the admin carefully reads the documentation, the first notice he gets about a need to restart the DHCP client can easily be when the lease expires and the machine drops off the ne

Re: [ovs-dev] [PATCH] xenserver: Update Open vSwitch post upgrade instructions.

2012-04-27 Thread Gurucharan Shetty
Thanks, Pushed this to master. On Fri, Apr 27, 2012 at 10:56 AM, Ben Pfaff wrote: > On Fri, Apr 27, 2012 at 09:52:29AM -0700, Gurucharan Shetty wrote: >> > Seems reasonable to me.  It seems to me that the new message could be >> > refined, but I don't have a specific wording to suggest. >> >> Doe

[ovs-dev] [PATCH 2/2] ovs-bugtool: Add "ovs-vsctl show" output to bugtool.

2012-04-27 Thread Ben Pfaff
The information output by "ovs-vsctl show" is a subset of that available elsewhere in bugtool output, but it is human-readable instead of needing to be processed through ovsdb-server or ovsdb-tool, so it is much more convenient for basic diagnosis. Signed-off-by: Ben Pfaff --- I haven't tested th

[ovs-dev] [PATCH 1/2] ovs-bugtool: Add "ovs-appctl coverage/show" output to bugtool.

2012-04-27 Thread Ben Pfaff
This can be useful for diagnosis. Signed-off-by: Ben Pfaff --- I haven't tested this yet. utilities/bugtool/automake.mk |1 + utilities/bugtool/ovs-bugtool-coverage-show| 19 +++ .../bugtool/plugins/network-status/openvswitch.xml |3 ++- 3

Re: [ovs-dev] [PATCH] ovs-bugtool: Add "ovs-appctl coverage/show" output to bugtool.

2012-04-27 Thread Ben Pfaff
On Fri, Apr 27, 2012 at 01:58:19PM -0700, Ben Pfaff wrote: > This can be useful for diagnosis. > > Signed-off-by: Ben Pfaff > --- > I haven't tested this yet. Disregard this patch. I'll send a fixed one. ___ dev mailing list dev@openvswitch.org http:/

[ovs-dev] [PATCH] ovs-bugtool: Add "ovs-appctl coverage/show" output to bugtool.

2012-04-27 Thread Ben Pfaff
This can be useful for diagnosis. Signed-off-by: Ben Pfaff --- I haven't tested this yet. utilities/bugtool/automake.mk |1 + .../bugtool/plugins/network-status/openvswitch.xml |3 ++- 2 files changed, 3 insertions(+), 1 deletions(-) diff --git a/utilities/bugtool/

Re: [ovs-dev] [openflow-discuss] vswitch-idl.c

2012-04-27 Thread Ben Pfaff
This is an OVS question and a development question and so it's odd to bring it to a list for discussing OpenFlow. I'm adding ovs-dev. On Fri, Apr 27, 2012 at 01:41:39PM -0700, kiran shastri wrote: > I was wondering why in this auto-generated file, we don't set the > member count to 0 , when a col

[ovs-dev] [PATCH 2/2] ofp-util: Treat a packet-out in_port of OFPP_CONTROLLER as OFPP_NONE.

2012-04-27 Thread Ben Pfaff
Some OpenFlow 1.0 controllers incorrectly use OPFP_CONTROLLER as the in_port in packet-out messages, when OFPP_NONE is their intent. Until now, Open vSwitch has rejected such requests with an error message. This commit makes Open vSwitch instead treat OFPP_CONTROLLER the same as OFPP_NONE for com

[ovs-dev] [PATCH 1/2] tests: Fix typo in comment.

2012-04-27 Thread Ben Pfaff
Signed-off-by: Ben Pfaff --- tests/ofproto.at |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/tests/ofproto.at b/tests/ofproto.at index 0f0fd1f..dbddea8 100644 --- a/tests/ofproto.at +++ b/tests/ofproto.at @@ -499,7 +499,7 @@ s/00:0.$/00:0x/' < monitor.log]], # It's a s

Re: [ovs-dev] [PATCH] meta-flow: Correctly set destination MAC in mf_set_flow_value().

2012-04-27 Thread Ben Pfaff
On Fri, Apr 27, 2012 at 12:04:14PM -0700, Ansis Atteka wrote: > On Fri, Apr 27, 2012 at 8:45 AM, Ben Pfaff wrote: > > > Signed-off-by: Ben Pfaff > Looks good to me. Thanks! Great, I pushed this to master and branch-1.[456]. ___ dev mailing list dev@op

Re: [ovs-dev] [PATCH] meta-flow: Correctly set destination MAC in mf_set_flow_value().

2012-04-27 Thread Ansis Atteka
On Fri, Apr 27, 2012 at 8:45 AM, Ben Pfaff wrote: > Signed-off-by: Ben Pfaff > --- > lib/meta-flow.c |2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/lib/meta-flow.c b/lib/meta-flow.c > index 3db528f..82e9e9b 100644 > --- a/lib/meta-flow.c > +++ b/lib/meta-flow.c >

Re: [ovs-dev] [PATCH] xenserver: Update Open vSwitch post upgrade instructions.

2012-04-27 Thread Ben Pfaff
On Fri, Apr 27, 2012 at 09:52:29AM -0700, Gurucharan Shetty wrote: > > Seems reasonable to me.  It seems to me that the new message could be > > refined, but I don't have a specific wording to suggest. > > Does the following wording sound better? > "To use the newly installed Open vSwitch kernel m

Re: [ovs-dev] [PATCH] xenserver: Update Open vSwitch post upgrade instructions.

2012-04-27 Thread Gurucharan Shetty
s/adminastration/administration On Fri, Apr 27, 2012 at 9:52 AM, Gurucharan Shetty wrote: >> Seems reasonable to me.  It seems to me that the new message could be >> refined, but I don't have a specific wording to suggest. > > Does the following wording sound better? > "To use the newly installed

Re: [ovs-dev] [PATCH] xenserver: Update Open vSwitch post upgrade instructions.

2012-04-27 Thread Gurucharan Shetty
> Seems reasonable to me.  It seems to me that the new message could be > refined, but I don't have a specific wording to suggest. Does the following wording sound better? "To use the newly installed Open vSwitch kernel module, you will either have to reboot the hypervisor or follow any workaround

[ovs-dev] [PATCH 4/4] ofproto-dpif: Accept OpenFlow-like flows in "ofproto/trace".

2012-04-27 Thread Ben Pfaff
Until now it has not been possible to directly trace flows that include register values and other concepts that are not in datapath flows, because "ofproto/trace" requires a flow in the format output by "ovs-dpctl dump-flows", which doesn't know anything about registers. This commit makes it possi

[ovs-dev] [PATCH 3/4] ofp-parse: New function parse_ofp_exact_flow().

2012-04-27 Thread Ben Pfaff
This function parses a flow rather than a cls_rule. It will be useful for "ofproto/trace", which currently requires an odp_flow and thus can't accept values for registers and other concepts that don't exist in the kernel. Signed-off-by: Ben Pfaff --- lib/meta-flow.c | 13 + lib/meta-f

[ovs-dev] [PATCH 2/4] ofp-util: Avoid ovs_fatal() in ofputil_parse_key_value().

2012-04-27 Thread Ben Pfaff
ofputil_parse_key_value() is safe to use from a process that must not abort except in one case: where the argument contains unbalanced parentheses. This commit eliminates that call to ovs_fatal(), instead just treating the end of the string as closing all nested parentheses. It would be better to

[ovs-dev] [PATCH 1/4] ofproto-dpif: Factor out VLAN splinter flow adjustment into new function.

2012-04-27 Thread Ben Pfaff
An upcoming commit will add a new user. Signed-off-by: Ben Pfaff --- ofproto/ofproto-dpif.c | 34 ++ 1 files changed, 26 insertions(+), 8 deletions(-) diff --git a/ofproto/ofproto-dpif.c b/ofproto/ofproto-dpif.c index 1c5d331..a9bf721 100644 --- a/ofproto/ofpro

[ovs-dev] [PATCH] meta-flow: Correctly set destination MAC in mf_set_flow_value().

2012-04-27 Thread Ben Pfaff
Signed-off-by: Ben Pfaff --- lib/meta-flow.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/lib/meta-flow.c b/lib/meta-flow.c index 3db528f..82e9e9b 100644 --- a/lib/meta-flow.c +++ b/lib/meta-flow.c @@ -1339,7 +1339,7 @@ mf_set_flow_value(const struct mf_field *mf,

Re: [ovs-dev] [PATCH] xenserver: Update Open vSwitch post upgrade instructions.

2012-04-27 Thread Ben Pfaff
On Thu, Apr 26, 2012 at 06:31:02PM -0700, Gurucharan Shetty wrote: > Currently, when we upgrade the userspace rpm for XenServer, > we print a message asking users to reboot the hypervisor. > This is not needed. The reboot of hypervisor is needed when > we upgrade the rpm containing the kernel modul