> We have? I normally use size_t for measuring the size of memory objects
> or array indexes. Usually for something to count from 0 to 50, as here,
> I'd just use an "int".
Ah well in bridge and ofproto we've tended to use size_t for this sort
of thing. The above reasoning sounds like a good ar
Thanks, sounds good.
Ethan
On Thu, Apr 26, 2012 at 14:07, Ben Pfaff wrote:
> On Wed, Apr 25, 2012 at 07:40:44PM -0700, Ben Pfaff wrote:
>> On Wed, Apr 25, 2012 at 06:43:12PM -0700, Ethan Jackson wrote:
>> > > I'd always assumed that the EWMA code here was sufficient rate-limiting,
>> > > but I a
I changed the comment to say it takes ownership of 'b'. Thanks for
the review, I'll push this.
Ethan
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
That makes sense, I've dropped this patch, thanks.
Ethan
On Thu, Apr 26, 2012 at 14:22, Ben Pfaff wrote:
> On Wed, Apr 25, 2012 at 09:16:32PM -0700, Ethan Jackson wrote:
>> Found by inspection.
>> Signed-off-by: Ethan Jackson
>
> I don't think this is a real bug. rconn_send()'s caller only ret
Currently, when we upgrade the userspace rpm for XenServer,
we print a message asking users to reboot the hypervisor.
This is not needed. The reboot of hypervisor is needed when
we upgrade the rpm containing the kernel module. This
reboot can sometimes be avoided by running a
"service openvswitch
Looks good to me.
--Justin
On Apr 26, 2012, at 3:55 PM, Ben Pfaff wrote:
> Before idle_age and hard_age were added, in the absence of timeouts there
> was a space between the statistics for a flow and the start of the flow
> match. This restores that space.
>
> Requested-by: Paul Ingram
> Si
On Apr 26, 2012, at 4:04 PM, Ben Pfaff wrote:
> +The provided bytes will be padded on the right by enough bytes with
> +value 0 to make the total number 6 more than a multiple of 8.
I think it might help to provide a brief explanation of why that happens. How
about something like the following?
Reported-by: Paul Ingram
Signed-off-by: Ben Pfaff
---
utilities/ovs-ofctl.8.in |2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/utilities/ovs-ofctl.8.in b/utilities/ovs-ofctl.8.in
index d1d82c5..1b364dc 100644
--- a/utilities/ovs-ofctl.8.in
+++ b/utilities/ovs-ofctl.8.in
Before idle_age and hard_age were added, in the absence of timeouts there
was a space between the statistics for a flow and the start of the flow
match. This restores that space.
Requested-by: Paul Ingram
Signed-off-by: Ben Pfaff
---
lib/ofp-print.c |8 +++---
tests/learn.at
Hallo
Mein Name ist Halima, sah ich Ihre E-Mail und Todey
Suche echten Freund suchen, wenn Sie mich akzeptieren
Bitte schicken Sie mir zurück, so dass ich Ihnen meine schöne
Bild
und Ihnen sagen, über mich.
Hoffnung,
von Ihnen bald zu hören.
Halima bilden.
Hello
My name
is Halima, I saw
your
On Thu, Apr 26, 2012 at 3:14 PM, Ben Pfaff wrote:
> On Wed, Apr 25, 2012 at 04:09:51PM -0700, Ansis Atteka wrote:
> > This commit adds support to specify a mask in CIDR format for
> > the nd_target field.
> >
> > Signed-off-by: Ansis Atteka
>
> Looks good to me, thank you.
>
Thanks, pushed to th
On Thu, Apr 26, 2012 at 11:08:44AM -0700, Ben Pfaff wrote:
> On Thu, Apr 26, 2012 at 09:44:32AM -0700, Ben Pfaff wrote:
> > On Thu, Apr 26, 2012 at 03:18:38PM +0200, Stéphane Glondu wrote:
> > > Is there anyone working on fixing openvswitch? Or can the dependency in
> > > xen-api be dropped, and re
On Wed, Apr 25, 2012 at 04:09:51PM -0700, Ansis Atteka wrote:
> This commit adds support to specify a mask in CIDR format for
> the nd_target field.
>
> Signed-off-by: Ansis Atteka
Looks good to me, thank you.
___
dev mailing list
dev@openvswitch.org
h
Accepted:
openvswitch-brcompat_1.4.0+git20120426-1_i386.deb
to main/o/openvswitch/openvswitch-brcompat_1.4.0+git20120426-1_i386.deb
openvswitch-common_1.4.0+git20120426-1_i386.deb
to main/o/openvswitch/openvswitch-common_1.4.0+git20120426-1_i386.deb
openvswitch-controller_1.4.0+git20120426-1
On Wed, Apr 25, 2012 at 09:16:33PM -0700, Ethan Jackson wrote:
> Before this patch, rconn_send() would delete 'b' on success, and
> not on error. This is confusing and error-prone. This patch
> causes rconn_send() to always delete 'b'.
>
> Signed-off-by: Ethan Jackson
> +/* Sends 'b' on 'rc'.
On Wed, Apr 25, 2012 at 09:16:32PM -0700, Ethan Jackson wrote:
> Found by inspection.
> Signed-off-by: Ethan Jackson
I don't think this is a real bug. rconn_send()'s caller only retains
ownership if there's no connection. There's always a connection here,
so rconn_send() takes ownership.
__
openvswitch_1.4.0+git20120426-1_i386.changes uploaded successfully to localhost
along with the files:
openvswitch_1.4.0+git20120426-1.dsc
openvswitch_1.4.0+git20120426.orig.tar.gz
openvswitch_1.4.0+git20120426-1.debian.tar.gz
openvswitch-common_1.4.0+git20120426-1_i386.deb
openvswitch-swi
Thanks, I'll push this series soon.
On Wed, Apr 25, 2012 at 07:04:16PM -0700, Ethan Jackson wrote:
> Looks good, thanks.
>
> Ethan
>
> On Fri, Apr 20, 2012 at 14:10, Ben Pfaff wrote:
> > I've had a few complaints that ovs-vswitchd logs its coverage counters
> > at WARN level, but this is mainly
On Wed, Apr 25, 2012 at 07:40:44PM -0700, Ben Pfaff wrote:
> On Wed, Apr 25, 2012 at 06:43:12PM -0700, Ethan Jackson wrote:
> > > I'd always assumed that the EWMA code here was sufficient rate-limiting,
> > > but I actually encountered a pathological case some time ago that forced
> > > this rusage
Thanks, I pushed this.
On Wed, Apr 25, 2012 at 06:22:21PM -0700, Ethan Jackson wrote:
> Looks good, thanks.
>
> Ethan
>
> On Fri, Apr 20, 2012 at 14:53, Ben Pfaff wrote:
> > Until now, fault status changes just log the new status. This means that
> > the administrator has to find two consecuti
Before this patch, rconn_send() would delete 'b' on success, and
not on error. This is confusing and error-prone. This patch
causes rconn_send() to always delete 'b'.
Signed-off-by: Ethan Jackson
---
lib/learning-switch.c |1 -
lib/rconn.c | 13 -
ofproto/connmgr.c
Found by inspection.
Signed-off-by: Ethan Jackson
---
lib/rconn.c |6 +-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/lib/rconn.c b/lib/rconn.c
index 56a7e19..759c0cb 100644
--- a/lib/rconn.c
+++ b/lib/rconn.c
@@ -433,6 +433,7 @@ static void
run_ACTIVE(struct rconn *rc)
On Thu, Apr 26, 2012 at 12:14:14PM -0700, Ansis Atteka wrote:
> On Thu, Apr 26, 2012 at 11:06 AM, Ben Pfaff wrote:
>
> > These tests had a hidden dependency on the hash function in use,
> > which yields different results on big-endian and little-endian
> > architectures. This commit fixes the pr
On Thu, Apr 26, 2012 at 11:06 AM, Ben Pfaff wrote:
> These tests had a hidden dependency on the hash function in use,
> which yields different results on big-endian and little-endian
> architectures. This commit fixes the problem by properly
> parameterizing the parts that can differ.
>
> Signed
On Thu, Apr 26, 2012 at 09:44:32AM -0700, Ben Pfaff wrote:
> On Thu, Apr 26, 2012 at 03:18:38PM +0200, Stéphane Glondu wrote:
> > Is there anyone working on fixing openvswitch? Or can the dependency in
> > xen-api be dropped, and reintroduced later, when openvswitch works and
> > has migrated to te
These tests had a hidden dependency on the hash function in use,
which yields different results on big-endian and little-endian
architectures. This commit fixes the problem by properly
parameterizing the parts that can differ.
Signed-off-by: Ben Pfaff
---
This should fix a bunch of Debian buildd
On Thu, Apr 26, 2012 at 03:18:38PM +0200, Stéphane Glondu wrote:
> Is there anyone working on fixing openvswitch? Or can the dependency in
> xen-api be dropped, and reintroduced later, when openvswitch works and
> has migrated to testing?
I hadn't noticed that Open vSwitch had FTBFS (it seems that
On Apr 26, 2012, at 11:13 AM, Jesse Gross wrote:
> On Thu, Apr 26, 2012 at 12:13 AM, Simon Horman wrote:
>> On Wed, Apr 25, 2012 at 10:17:25AM -0700, Jesse Gross wrote:
>>> On Wed, Apr 25, 2012 at 1:39 AM, Simon Horman wrote:
Hi Kyle,
the component that is of most interest
On Thu, Apr 26, 2012 at 12:13 AM, Simon Horman wrote:
> On Wed, Apr 25, 2012 at 10:17:25AM -0700, Jesse Gross wrote:
>> On Wed, Apr 25, 2012 at 1:39 AM, Simon Horman wrote:
>> >
>> > Hi Kyle,
>> >
>> > the component that is of most interest to me is enabling OVS to use in-tree
>> > tunnelling cod
On Thu, Apr 26, 2012 at 03:18:38PM +0200, Stéphane Glondu wrote:
> Hello,
>
> Currently, react (19 days old), xmlm (17 days) and xen-api (11 days) are
> stuck in unstable. One reason is the following: xen-api depends on xmlm
> and they must go together, and xen-api depends on (a new binary package
Hello,
Currently, react (19 days old), xmlm (17 days) and xen-api (11 days) are
stuck in unstable. One reason is the following: xen-api depends on xmlm
and they must go together, and xen-api depends on (a new binary package
of) openvswitch, which FTBFS (and has been for > 32 days).
Is there anyon
On Wed, Apr 25, 2012 at 10:17:25AM -0700, Jesse Gross wrote:
> On Wed, Apr 25, 2012 at 1:39 AM, Simon Horman wrote:
> >
> > Hi Kyle,
> >
> > the component that is of most interest to me is enabling OVS to use in-tree
> > tunnelling code - as it seems that makes most sense for an implementation
> >
32 matches
Mail list logo
