Add oxm_name and oxm_header elements to struct mf_field
and populate those entries for fields that are present
in both NXM and the OXM basic class.
This implementation was suggested by Ben Pfaff.
This does not address any possible differences in the NXM and
OXM basic class fields, for instance di
These oxm_type definitions values will may be used
when parsing serialising OXM TLVs.
Signed-off-by: Simon Horman
---
v3
* As pointed out by Ben Pfaff
- Fix widths of OXM_OF_IPV6_FLABEL and OXM_OF_IPV6_ND_TLL.
(What was I thinking???)
v2
* As suggested by Ben Pfaff
- Drop BASIC from ma
This corrects errors that appear to have been included
by me in the original version.
Signed-off-by: Simon Horman
---
include/openflow/openflow-1.2.h |4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/include/openflow/openflow-1.2.h b/include/openflow/openflow-1.2.h
index
Hi,
the first patch in this series corrects the definitions of
OFPXMC12_{OPENFLOW_BASIC,EXPERIMENTER}.
The second patch adds OXM_OF_* definitions.
And the third patch adds OXM data to mf_fields.
Collectively they incrementally add a basis for implementing OXM,
the match format specified in Open
On Tue, Apr 24, 2012 at 05:44:19PM -0700, Ethan Jackson wrote:
> According to the mailing list archives, this patch wasn't delivered
> for some reason. I pulled it from your local repository and reviewed
> it. It looks fine to me. Thanks,
Argh. It got delivered to my own inbox just fine. Than
Thanks, I pushed this to master. When I get a clean build from the
autobuilder I'll cherry-pick to branch-1.6.
On Tue, Apr 24, 2012 at 05:52:00PM -0700, Ethan Jackson wrote:
> Much cleaner, looks good, thanks.
>
> Assuming patch 6/7 is the one I sent out to the list, I consider this
> series rev
Much cleaner, looks good, thanks.
Assuming patch 6/7 is the one I sent out to the list, I consider this
series reviewed.
Ethan
On Tue, Apr 24, 2012 at 17:08, Ben Pfaff wrote:
> iface_create() did its work in an order that meant it had to do a lot more
> cleanup on error paths than is otherwise
From: Ben Pfaff
Commit bae7208e91a0 (bridge: Refactor bridge_reconfigure().) introduced
a regression in bridge reconfiguration. Previously, reconfiguration would
update the configuration of each bridge port, so that if the controller
(or the admin) changed a port's options, then that change woul
This is fine considering the function is refactored later in the series, thanks.
Ethan
On Tue, Apr 24, 2012 at 17:06, Ben Pfaff wrote:
> This is the minimal change that gets the job done. There are much nicer
> ways to do this, but I'll leave that refactoring for later in the series.
>
> The re
Looks good, thanks.
Ethan
On Tue, Apr 24, 2012 at 17:06, Ben Pfaff wrote:
> An upcoming patch will need the same code in another function.
>
> Signed-off-by: Ben Pfaff
> ---
> vswitchd/bridge.c | 35 ---
> 1 files changed, 24 insertions(+), 11 deletions(-)
>
>
On Tue, Apr 24, 2012 at 09:14:40AM -0700, Ben Pfaff wrote:
> On Tue, Apr 24, 2012 at 10:32:55AM +0900, Simon Horman wrote:
> > Add oxm_name and oxm_header elements to struct mf_field
> > and populate those entries for fields that are present
> > in both NXM and the OXM basic class.
> >
> > This im
Looks good, thanks.
Ethan
On Tue, Apr 24, 2012 at 17:06, Ben Pfaff wrote:
> The calculation that this function does will need to be used in a
> context where no "struct iface" is available in an upcoming commit.
>
> Signed-off-by: Ben Pfaff
> ---
> vswitchd/bridge.c | 29 +---
On Tue, Apr 24, 2012 at 09:11:53AM -0700, Ben Pfaff wrote:
> On Tue, Apr 24, 2012 at 10:32:54AM +0900, Simon Horman wrote:
> > These oxm_type definitions values will may be used
> > when parsing serialising OXM TLVs.
> >
> > Signed-off-by: Simon Horman
>
> How did you generate this? Comparing i
Looks good.
Ethan
On Tue, Apr 24, 2012 at 17:06, Ben Pfaff wrote:
> It's no longer useful.
>
> Signed-off-by: Ben Pfaff
> ---
> vswitchd/bridge.c | 7 ++-
> 1 files changed, 2 insertions(+), 5 deletions(-)
>
> diff --git a/vswitchd/bridge.c b/vswitchd/bridge.c
> index 0039708..01ea177 1
On Tue, Apr 24, 2012 at 08:57:18AM -0700, Ben Pfaff wrote:
> On Tue, Apr 24, 2012 at 10:02:25AM +0900, Simon Horman wrote:
> > On Mon, Apr 23, 2012 at 08:34:45AM +0900, Simon Horman wrote:
> > > On Fri, Apr 20, 2012 at 08:36:57AM -0700, Ben Pfaff wrote:
> > > > On Fri, Apr 20, 2012 at 09:24:05AM +0
Looks good, thanks.
Ethan
On Tue, Apr 24, 2012 at 17:06, Ben Pfaff wrote:
> Just a tiny code cleanup.
>
> Signed-off-by: Ben Pfaff
> ---
> vswitchd/bridge.c | 5 -
> 1 files changed, 4 insertions(+), 1 deletions(-)
>
> diff --git a/vswitchd/bridge.c b/vswitchd/bridge.c
> index 833973a..
Thanks for doing this Ben, I'll review it now.
Ethan
On Tue, Apr 24, 2012 at 17:06, Ben Pfaff wrote:
> Commit bae7208e9 introduced a regression in configuration: if a port's
> configuration changes in the database, then that change is not
> propagated to the datapath. This series of commits fix
iface_create() did its work in an order that meant it had to do a lot more
cleanup on error paths than is otherwise needed. This commit reorders the
work to avoid this extra cleanup.
bridge_ofproto_port_del() is no longer used after the refactoring so this
commit deletes it.
Signed-off-by: Ben P
This is the minimal change that gets the job done. There are much nicer
ways to do this, but I'll leave that refactoring for later in the series.
The return value will have its first user in an upcoming commit.
Signed-off-by: Ben Pfaff
---
vswitchd/bridge.c | 22 +++---
1 fil
An upcoming patch will need the same code in another function.
Signed-off-by: Ben Pfaff
---
vswitchd/bridge.c | 35 ---
1 files changed, 24 insertions(+), 11 deletions(-)
diff --git a/vswitchd/bridge.c b/vswitchd/bridge.c
index 99bd534..a66052c 100644
--- a/vsw
The calculation that this function does will need to be used in a
context where no "struct iface" is available in an upcoming commit.
Signed-off-by: Ben Pfaff
---
vswitchd/bridge.c | 29 +
1 files changed, 17 insertions(+), 12 deletions(-)
diff --git a/vswitchd/bri
It's no longer useful.
Signed-off-by: Ben Pfaff
---
vswitchd/bridge.c |7 ++-
1 files changed, 2 insertions(+), 5 deletions(-)
diff --git a/vswitchd/bridge.c b/vswitchd/bridge.c
index 0039708..01ea177 100644
--- a/vswitchd/bridge.c
+++ b/vswitchd/bridge.c
@@ -87,7 +87,6 @@ struct iface
Just a tiny code cleanup.
Signed-off-by: Ben Pfaff
---
vswitchd/bridge.c |5 -
1 files changed, 4 insertions(+), 1 deletions(-)
diff --git a/vswitchd/bridge.c b/vswitchd/bridge.c
index 833973a..0039708 100644
--- a/vswitchd/bridge.c
+++ b/vswitchd/bridge.c
@@ -1236,7 +1236,6 @@ bridge_r
Commit bae7208e9 introduced a regression in configuration: if a port's
configuration changes in the database, then that change is not
propagated to the datapath. This series of commits fixes the problem.
The first 5 commits are small cleanups and refactoring. Commit 6
fixes the problem. Commit
Hello my dearest.
How are you doing?
I hope you are fine and your family,
I just want to say hello to you and to hear from you
Take good care of yourself i Waiting to hear from you
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/li
Yes, I agree.
On Tue, Apr 24, 2012 at 02:03:16PM -0700, Ethan Jackson wrote:
> Just to be clear I think this patch is now obsolete so I don't intend
> to review it.
>
> Ethan
>
> On Fri, Apr 20, 2012 at 10:38, Ben Pfaff wrote:
> > The "cur_cfg" column in the database is supposed to reflect the
Just to be clear I think this patch is now obsolete so I don't intend
to review it.
Ethan
On Fri, Apr 20, 2012 at 10:38, Ben Pfaff wrote:
> The "cur_cfg" column in the database is supposed to reflect the latest
> complete (re)configuration of the system. For a long time, any call to
> bridge_re
This patch fixes the leak for me and looks good, thanks.
Ethan
On Mon, Apr 23, 2012 at 13:24, Ben Pfaff wrote:
> [adding ovs-dev]
>
> On Mon, Apr 23, 2012 at 11:07:28AM -0700, Ethan Jackson wrote:
>> I'm doing 200 ports in a single transaction and seeing quite a bit of
>> "definitely lost" here
Thanks merged.
Ethan
On Tue, Apr 24, 2012 at 12:53, Ben Pfaff wrote:
> On Mon, Apr 23, 2012 at 09:26:40AM -0700, Ethan Jackson wrote:
>> This issue has been around for quite some time. It doesn't really
>> cause problems beyond some spurious warnings.
>>
>> Signed-off-by: Ethan Jackson
>
> Loo
On Mon, Apr 23, 2012 at 09:26:40AM -0700, Ethan Jackson wrote:
> This issue has been around for quite some time. It doesn't really
> cause problems beyond some spurious warnings.
>
> Signed-off-by: Ethan Jackson
Looks good, thank you.
___
dev mailing
This issue has been around for quite some time. It doesn't really
cause problems beyond some spurious warnings.
Signed-off-by: Ethan Jackson
---
vswitchd/bridge.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/vswitchd/bridge.c b/vswitchd/bridge.c
index 077d9ee..037a4cb
Thanks, pushed to master, branch-1.6.
On Tue, Apr 24, 2012 at 11:01:08AM -0700, Ethan Jackson wrote:
> Looks good to me, thanks.
>
> Ethan
>
> On Tue, Apr 24, 2012 at 10:53, Ben Pfaff wrote:
> > On Tue, Apr 24, 2012 at 05:52:28PM +, Kyle Mestery (kmestery) wrote:
> >> On Apr 24, 2012, at 12
Looks good to me, thanks.
Ethan
On Tue, Apr 24, 2012 at 10:53, Ben Pfaff wrote:
> On Tue, Apr 24, 2012 at 05:52:28PM +, Kyle Mestery (kmestery) wrote:
>> On Apr 24, 2012, at 12:44 PM, Ben Pfaff wrote:
>>
>> > CC: Ethan Jackson
>> > Signed-off-by: Ben Pfaff
>> > ---
>> > vswitchd/bridge.c |
On Tue, Apr 24, 2012 at 05:52:28PM +, Kyle Mestery (kmestery) wrote:
> On Apr 24, 2012, at 12:44 PM, Ben Pfaff wrote:
>
> > CC: Ethan Jackson
> > Signed-off-by: Ben Pfaff
> > ---
> > vswitchd/bridge.c |2 +-
> > 1 files changed, 1 insertions(+), 1 deletions(-)
> >
> > diff --git a/vswitc
On Apr 24, 2012, at 12:44 PM, Ben Pfaff wrote:
> CC: Ethan Jackson
> Signed-off-by: Ben Pfaff
> ---
> vswitchd/bridge.c |2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/vswitchd/bridge.c b/vswitchd/bridge.c
> index 077d9ee..833973a 100644
> --- a/vswitchd/bridge.c
>
CC: Ethan Jackson
Signed-off-by: Ben Pfaff
---
vswitchd/bridge.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/vswitchd/bridge.c b/vswitchd/bridge.c
index 077d9ee..833973a 100644
--- a/vswitchd/bridge.c
+++ b/vswitchd/bridge.c
@@ -1306,7 +1306,7 @@ iface_create(struct
On Tue, Apr 24, 2012 at 05:11:14PM +, Kyle Mestery (kmestery) wrote:
> On Apr 24, 2012, at 12:08 PM, Ben Pfaff wrote:
> > This has been implemented for a long time but we forgot to document it.
> >
> > Signed-off-by: Ben Pfaff
>
>
> Looks good to me, nice explanation Ben!
Thanks for lookin
On Tue, Apr 24, 2012 at 10:11:39AM -0700, Justin Pettit wrote:
> On Apr 24, 2012, at 8:57 AM, Ben Pfaff wrote:
>
> > Someone on the team here (Ansis?) is already working on
> > OXM_OF_IPV6_FLABEL maskability because one of our customers has a use
> > case.
>
> Actually, he's working on making NXM
On Apr 24, 2012, at 8:57 AM, Ben Pfaff wrote:
> Someone on the team here (Ansis?) is already working on
> OXM_OF_IPV6_FLABEL maskability because one of our customers has a use
> case.
Actually, he's working on making NXM_NX_ND_TARGET maskable. I don't know of
any plans to make the flow label ma
On Apr 24, 2012, at 12:08 PM, Ben Pfaff wrote:
> This has been implemented for a long time but we forgot to document it.
>
> Signed-off-by: Ben Pfaff
Looks good to me, nice explanation Ben!
Kyle
___
dev mailing list
dev@openvswitch.org
http://openvsw
This has been implemented for a long time but we forgot to document it.
Signed-off-by: Ben Pfaff
---
vswitchd/vswitch.xml | 26 ++
1 files changed, 26 insertions(+), 0 deletions(-)
diff --git a/vswitchd/vswitch.xml b/vswitchd/vswitch.xml
index 13dd314..b0f6be8 100644
-
On Apr 24, 2012, at 11:13 AM, Stephen Hemminger wrote:
> On Tue, 24 Apr 2012 16:02:41 +
> "Kyle Mestery (kmestery)" wrote:
>
>> On Apr 23, 2012, at 9:25 PM, Simon Horman wrote:
>>> On Mon, Apr 23, 2012 at 03:59:24PM -0700, Jesse Gross wrote:
On Mon, Apr 23, 2012 at 3:32 PM, Simon Horman
On Tue, Apr 24, 2012 at 10:32:55AM +0900, Simon Horman wrote:
> Add oxm_name and oxm_header elements to struct mf_field
> and populate those entries for fields that are present
> in both NXM and the OXM basic class.
>
> This implementation was suggested by Ben Pfaff.
>
> This does not address any
On Tue, 24 Apr 2012 16:02:41 +
"Kyle Mestery (kmestery)" wrote:
> On Apr 23, 2012, at 9:25 PM, Simon Horman wrote:
> > On Mon, Apr 23, 2012 at 03:59:24PM -0700, Jesse Gross wrote:
> >> On Mon, Apr 23, 2012 at 3:32 PM, Simon Horman wrote:
> >>> On Mon, Apr 23, 2012 at 02:38:07PM -0700, Jesse
On Tue, Apr 24, 2012 at 10:32:54AM +0900, Simon Horman wrote:
> These oxm_type definitions values will may be used
> when parsing serialising OXM TLVs.
>
> Signed-off-by: Simon Horman
How did you generate this? Comparing it visually against the output
of:
grep '#define OXM_OF_' include
On Apr 23, 2012, at 9:25 PM, Simon Horman wrote:
> On Mon, Apr 23, 2012 at 03:59:24PM -0700, Jesse Gross wrote:
>> On Mon, Apr 23, 2012 at 3:32 PM, Simon Horman wrote:
>>> On Mon, Apr 23, 2012 at 02:38:07PM -0700, Jesse Gross wrote:
On Mon, Apr 23, 2012 at 2:08 PM, David Miller wrote:
>
On Tue, Apr 24, 2012 at 10:02:25AM +0900, Simon Horman wrote:
> On Mon, Apr 23, 2012 at 08:34:45AM +0900, Simon Horman wrote:
> > On Fri, Apr 20, 2012 at 08:36:57AM -0700, Ben Pfaff wrote:
> > > On Fri, Apr 20, 2012 at 09:24:05AM +0900, Simon Horman wrote:
> > > > This may be used in a similar way
On Apr 24, 2012, at 1:25 AM, Girish Kumar Yerra wrote:
> Thanks for your quick response. When I do not specify switch. It is working
> good.
>
> But, I tried to connect to a remote switch also, Then, I get the same error.
If you want to connect ovs-ofctl remotely, you need to tell ovs-vswitchd
Hi Justin,
Thanks for your quick response. When I do not specify switch. It is working
good.
But, I tried to connect to a remote switch also, Then, I get the same
error. By the way can you please let me know how the ovs-ofctl connects to
the switch. I just want to know the complete path involved.
You should only need to specify the switch if it's not local. Those commands
should know how to connect to the switch locally. What happens if you just run
the commands like this?
ovs-vsctl set-controller br0
ovs-ofctl show
--Justin
On Apr 24, 2012, at 12:27 AM, Girish Kuma
Hi All,
I am working on openVSwitch with Open flow controllers. I got struck in
understanding the flow of how the ovs-ofctl utility works. I am not quiet
clear about how it uses the connection details(tcp::port). What
details we need to mention here. The man page says, it connects to OpenFlow
swi
51 matches
Mail list logo
