[ovs-dev] theresasony...@yahoo.com

2012-04-20 Thread theresa aron
Hello! I'm Theresa I found your contact while surfing the Internet and I picked interest in getting incontact with you so as to know you better. I wish to be in relationship with you and may be discover ourselves as real friends/partners. If you're interested then write me back here ( theresasony..

[ovs-dev] [PATCH] cfm: Log fault status changes more informatively.

2012-04-20 Thread Ben Pfaff
Until now, fault status changes just log the new status. This means that the administrator has to find two consecutive status change messages to see what actually changed. This commit changes the log message format to prefix new faults with '+' and faults that disappeared with '-'. Existing faul

[ovs-dev] [PATCH] DESIGN: Describe principles of in-band control.

2012-04-20 Thread Ben Pfaff
These principles are drawn from an email I sent to the openflow-spec list long ago. Signed-off-by: Ben Pfaff --- DESIGN | 160 +-- 1 files changed, 144 insertions(+), 16 deletions(-) diff --git a/DESIGN b/DESIGN index ec29e39..11b052c

Re: [ovs-dev] [coverage 1/3] timeval: Rate-limit logging rusage information.

2012-04-20 Thread Ben Pfaff
On Fri, Apr 20, 2012 at 02:10:18PM -0700, Ben Pfaff wrote: > I'd always assumed that the EWMA code here was sufficient rate-limiting, > but I actually encountered a pathological case some time ago that forced > this rusage information to print once a second or so, which seems too > often. > > Sign

[ovs-dev] [coverage 3/3] coverage: Make ovs-appctl command more useful and less alarming.

2012-04-20 Thread Ben Pfaff
I've had a few complaints that ovs-vswitchd logs its coverage counters at WARN level, but this is mainly wrong: ovs-vswitchd only logs coverage counters at WARN level when the "coverage/log" command is used through ovs-appctl. This was even documented. The reason to log at such a high level was t

[ovs-dev] [coverage 2/3] coverage: Rate-limit logging coverage information.

2012-04-20 Thread Ben Pfaff
I'd always assumed that the EWMA code in timeval was enough rate-limiting, but I actually encountered a pathological case some time ago that forced this coverage information to print once a second or so, which seems too often. Signed-off-by: Ben Pfaff --- lib/coverage.c |5 - 1 files cha

[ovs-dev] [coverage 1/3] timeval: Rate-limit logging rusage information.

2012-04-20 Thread Ben Pfaff
I'd always assumed that the EWMA code here was sufficient rate-limiting, but I actually encountered a pathological case some time ago that forced this rusage information to print once a second or so, which seems too often. Signed-off-by: Ben Pfaff --- lib/timeval.c | 65 +++

Re: [ovs-dev] [PATCH 2/2] [RFC] tunnelling: stt: Prototype Implementation

2012-04-20 Thread Jesse Gross
On Thu, Apr 19, 2012 at 7:39 PM, Simon Horman wrote: > On Thu, Apr 19, 2012 at 03:53:35PM -0700, Jesse Gross wrote: >> On Wed, Apr 18, 2012 at 9:50 PM, Simon Horman wrote: >> > This is a not yet well exercised implementation of STT intended for review, >> > I am sure there are numerous areas that

Re: [ovs-dev] [PATCH 0/2 v3] [RFC] tunnelling: stt: Prototype Implementation

2012-04-20 Thread Jesse Gross
On Thu, Apr 19, 2012 at 6:47 PM, Simon Horman wrote: > On Thu, Apr 19, 2012 at 05:55:28PM -0700, Jesse Gross wrote: >> On Thu, Apr 19, 2012 at 5:13 PM, Simon Horman wrote: >> > On Thu, Apr 19, 2012 at 01:29:08PM -0700, Jesse Gross wrote: >> >> On Wed, Apr 18, 2012 at 9:50 PM, Simon Horman wrote:

Re: [ovs-dev] [PATCH 2/2] [RFC] tunnelling: stt: Prototype Implementation

2012-04-20 Thread Jesse Gross
On Thu, Apr 19, 2012 at 7:39 PM, Simon Horman wrote: > On Tue, Apr 17, 2012 at 07:58:33PM -0700, Jesse Gross wrote: >>  * It should always be possible to encapsulate any Ethernet frame. >> Things that don't have explicit support like QinQ can still be sent >> they just won't get the benefit of off

Re: [ovs-dev] [PATCH] vswitchd: Make "cfm_fault_status" column ephemeral.

2012-04-20 Thread Ethan Jackson
Thanks. Ethan On Fri, Apr 20, 2012 at 11:13, Ben Pfaff wrote: > On Fri, Apr 20, 2012 at 11:07:36AM -0700, Ethan Jackson wrote: >> >>        "cfm_health": { >> >>          "type": {"key": {"type": "integer", >> >>                           "minInteger": 0, >> >> >> I don't have the code in front

Re: [ovs-dev] [PATCH] vswitchd: Make "cfm_fault_status" column ephemeral.

2012-04-20 Thread Ben Pfaff
On Fri, Apr 20, 2012 at 11:07:36AM -0700, Ethan Jackson wrote: > >>        "cfm_health": { > >>          "type": {"key": {"type": "integer", > >>                           "minInteger": 0, > > > I don't have the code in front of me. Could you make sure cfm_health > is ephemeral too before mergin

Re: [ovs-dev] [PATCH] vswitchd: Make "cfm_fault_status" column ephemeral.

2012-04-20 Thread Ethan Jackson
>>        "cfm_health": { >>          "type": {"key": {"type": "integer", >>                           "minInteger": 0, I don't have the code in front of me. Could you make sure cfm_health is ephemeral too before merging? Ethan >> -- >> 1.7.2.5 >> >> ___

Re: [ovs-dev] [PATCH] vswitchd: Make "cfm_fault_status" column ephemeral.

2012-04-20 Thread Ben Pfaff
Thanks, I'll push this soon. On Fri, Apr 20, 2012 at 11:04:46AM -0700, Ethan Jackson wrote: > Looks good, thanks. > > Ethan > > On Fri, Apr 20, 2012 at 11:03, Ben Pfaff wrote: > > There's no need to log this to the on-disk database. > > > > Spotted while examining "ovsdb-tool show-log" output.

Re: [ovs-dev] [PATCH] vswitchd: Make "cfm_fault_status" column ephemeral.

2012-04-20 Thread Ethan Jackson
Looks good, thanks. Ethan On Fri, Apr 20, 2012 at 11:03, Ben Pfaff wrote: > There's no need to log this to the on-disk database. > > Spotted while examining "ovsdb-tool show-log" output. > > Signed-off-by: Ben Pfaff > --- >  vswitchd/vswitch.ovsschema |    8 +--- >  1 files changed, 5 inser

[ovs-dev] [PATCH] vswitchd: Make "cfm_fault_status" column ephemeral.

2012-04-20 Thread Ben Pfaff
There's no need to log this to the on-disk database. Spotted while examining "ovsdb-tool show-log" output. Signed-off-by: Ben Pfaff --- vswitchd/vswitch.ovsschema |8 +--- 1 files changed, 5 insertions(+), 3 deletions(-) diff --git a/vswitchd/vswitch.ovsschema b/vswitchd/vswitch.ovssch

Re: [ovs-dev] [PATCH] automake: ofp-errors.[c|inc] are actually inside srcdir

2012-04-20 Thread Ansis Atteka
On Fri, Apr 20, 2012 at 10:18 AM, Ben Pfaff wrote: > On Fri, Apr 20, 2012 at 10:08:01AM -0700, Ansis Atteka wrote: > > On Fri, Apr 20, 2012 at 9:45 AM, Ben Pfaff wrote: > > > > > On Thu, Apr 19, 2012 at 12:54:16PM -0700, Ansis Atteka wrote: > > > > This patch fixes a build error when OVS is buil

[ovs-dev] [PATCH] ovs-vswitchd: Notify db clients only when reconfiguration is really done.

2012-04-20 Thread Ben Pfaff
The "cur_cfg" column in the database is supposed to reflect the latest complete (re)configuration of the system. For a long time, any call to bridge_reconfigure() always ensured this. However, commit c7e7bb21ff made it possible that bridge_reconfigure() only does part of the necessary work, but s

Re: [ovs-dev] [PATCH] automake: ofp-errors.[c|inc] are actually inside srcdir

2012-04-20 Thread Ben Pfaff
On Fri, Apr 20, 2012 at 10:08:01AM -0700, Ansis Atteka wrote: > On Fri, Apr 20, 2012 at 9:45 AM, Ben Pfaff wrote: > > > On Thu, Apr 19, 2012 at 12:54:16PM -0700, Ansis Atteka wrote: > > > This patch fixes a build error when OVS is built inside > > > "./_debian" directory. > > > > > > To reproduce

Re: [ovs-dev] [PATCH] automake: ofp-errors.[c|inc] are actually inside srcdir

2012-04-20 Thread Ansis Atteka
On Fri, Apr 20, 2012 at 9:45 AM, Ben Pfaff wrote: > On Thu, Apr 19, 2012 at 12:54:16PM -0700, Ansis Atteka wrote: > > This patch fixes a build error when OVS is built inside > > "./_debian" directory. > > > > To reproduce this issue run "fakeroot debian/rules binary" > > or "debuild binary" insid

Re: [ovs-dev] [PATCH] automake: ofp-errors.[c|inc] are actually inside srcdir

2012-04-20 Thread Ben Pfaff
On Thu, Apr 19, 2012 at 12:54:16PM -0700, Ansis Atteka wrote: > This patch fixes a build error when OVS is built inside > "./_debian" directory. > > To reproduce this issue run "fakeroot debian/rules binary" > or "debuild binary" inside the git root directory. > > Signed-off-by: Ansis Atteka I

Re: [ovs-dev] [PATCH 0/3] [RFC] Preliminary OXM support for Open vSwtich

2012-04-20 Thread Ben Pfaff
On Fri, Apr 20, 2012 at 09:24:02AM +0900, Simon Horman wrote: > definitions to Open vSwtich which may be used as a basis for an > implementation of OXM. > > The code is based heavily on the existing NXM implementation which makes > use of the same format with different field and TLV values. Thank

Re: [ovs-dev] [PATCH 3/3] [RFC] Add oxm_mf_fields

2012-04-20 Thread Ben Pfaff
On Fri, Apr 20, 2012 at 09:24:05AM +0900, Simon Horman wrote: > This may be used in a similar way to nxm_mf_fields > to handle parsing and serialisation of OXM TLVs. > > Signed-off-by: Simon Horman My own thought for how to do OXM was to just add a new 'oxm_header' member (and possibly 'oxm_name

Re: [ovs-dev] [PATCH 1/3] [RFC] Add OXM_OF_* definitions

2012-04-20 Thread Ben Pfaff
On Fri, Apr 20, 2012 at 09:24:03AM +0900, Simon Horman wrote: > These oxm_type definitions values will may be used > when parsing serialising OXM TLVs. > > Signed-off-by: Simon Horman This defines but does not use OXM_HEADER_W, and uses but does not define OXM_BASIC_HEADER_W. I think I'd probab