Re: [ovs-dev] How dpif-linux query the flow table, and where it maintain the flow table?

2012-04-06 Thread Ben Pfaff
dpif-linux composes a request to query the kernel flow table, in the form of a Netlink message, sends the message to the kernel, receives the response also in the form of a Netlink message, translates that into the format expected by the caller, and returns it. On Fri, Apr 06, 2012 at 10:58:10PM +

[ovs-dev] [PATCH 3/3] datapath: Release rtnl_lock if ovs_vport_cmd_build_info() failed

2012-04-06 Thread Ansis Atteka
This patch fixes a possible lock-up bug where rtnl_lock might not get released. Signed-off-by: Ansis Atteka --- datapath/datapath.c |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/datapath/datapath.c b/datapath/datapath.c index 2fe6fdd..76f7a2c 100644 --- a/datapath/da

[ovs-dev] [PATCH 2/3] vswitchd: Remove port from datapath if it becomes non-operational

2012-04-06 Thread Ansis Atteka
If kernel module rejects config changes then vswitchd sets the ofport column to -1, but does not remove the non-operational port from the datapath. This patch fixes this problem. ovs-vsctl add-br ovsbr ovs-vsctl add-port ovsbr p1 ovs-vsctl add-port ovsbr p2 ovs-vsctl set Interface p1 options:remot

[ovs-dev] [PATCH 1/3] datapath: Do not send notification if ovs_vport_set_options() failed

2012-04-06 Thread Ansis Atteka
There is no need to send a notification if ovs_vport_set_options() failed and ovs_vport_cmd_set() did not change anything. Issue#10285 Signed-off-by: Ansis Atteka --- datapath/datapath.c |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/datapath/datapath.c b/datapath/dat

Re: [ovs-dev] How dpif-linux query the flow table, and where it maintain the flow table?

2012-04-06 Thread LIU Binghan
Yes, I really try to read it , but there is not any code about hash table which likes in datapath. I think this function is used to process the request from datapath, and send back new flow information to expand the flow table in the datapath, right? so where is the information about flow tables

Re: [ovs-dev] [PATCH v2] util: New function set_program_name_version().

2012-04-06 Thread Ben Pfaff
On Fri, Apr 06, 2012 at 11:48:31AM -0700, Ethan Jackson wrote: > With this function, users of the Open vSwitch libraries which > should not have the same version as Open vSwitch will have their > version displayed in unixctl and at the command line. > > Signed-off-by: Ethan Jackson > --- > > Her

[ovs-dev] [PATCH v2] util: New function set_program_name_version().

2012-04-06 Thread Ethan Jackson
With this function, users of the Open vSwitch libraries which should not have the same version as Open vSwitch will have their version displayed in unixctl and at the command line. Signed-off-by: Ethan Jackson --- Here's another version. --- lib/util.c | 22 ++ lib/util.

Re: [ovs-dev] [PATCH 2/3] [RFC] datapath: tunnelling: Pass l4_offset to update_header callback

2012-04-06 Thread Jesse Gross
On Thu, Apr 5, 2012 at 7:10 PM, Simon Horman wrote: > On Thu, Apr 05, 2012 at 05:34:21PM -0700, Jesse Gross wrote: >> On Tue, Apr 3, 2012 at 10:14 PM, Simon Horman wrote: >> > The STT protocol's header includes a field for the offset >> > to the start of the l4 header. It seems that this >> > is

Re: [ovs-dev] [PATCH] util: New function set_program_name_version().

2012-04-06 Thread Ben Pfaff
On Sun, Apr 01, 2012 at 04:04:40PM -0700, Ethan Jackson wrote: > With this function, users of the Open vSwitch libraries which > should not have the same version as Open vSwitch can manually set a > version number. > > Signed-off-by: Ethan Jackson Hmm, although this looks OK we could alternative

Re: [ovs-dev] [PATCH v2] debian: Remove unused directory.

2012-04-06 Thread Ben Pfaff
On Fri, Apr 06, 2012 at 09:12:11AM -0700, Gurucharan Shetty wrote: > Installing the openvswitch-switch package creates a directory > 'openvswitch-switch' in /etc. It is not used for any purpose. > > Bug #10623. > Reported-by: Eric Lopez > Signed-off-by: Gurucharan Shetty Thank you, this looks g

Re: [ovs-dev] [PATCH] Added handling of previously ignored cfm faults.

2012-04-06 Thread Ben Pfaff
On Thu, Apr 05, 2012 at 05:57:57PM -0700, Mehak Mahajan wrote: > The CFM packets that are out of sequence or contain invalid cfm_interval were > previously not ignored. The behavior is changed with this patch to not > process those CFM frames. > > Signed-off-by: Mehak Mahajan Please put a space

[ovs-dev] [PATCH v2] debian: Remove unused directory.

2012-04-06 Thread Gurucharan Shetty
Installing the openvswitch-switch package creates a directory 'openvswitch-switch' in /etc. It is not used for any purpose. Bug #10623. Reported-by: Eric Lopez Signed-off-by: Gurucharan Shetty --- AUTHORS|1 + debian/openvswitch-switch.dirs |1 - 2 files changed,

Re: [ovs-dev] what functions should be implemented of the netdev-provider interface

2012-04-06 Thread Ben Pfaff
On Fri, Apr 06, 2012 at 03:48:41PM +0800, Min Chen wrote: > I've been reading the source code for a while. Although the PORTING manual > is quite clear, but still I have no idea how to port this to switching > ASICs. For example, on writing the netdev provider, it reads in the manual: > > > *

Re: [ovs-dev] [PATCH] debian: Remove unused directory.

2012-04-06 Thread Ben Pfaff
On Fri, Apr 06, 2012 at 08:36:03AM -0700, Gurucharan Shetty wrote: > Installing the openvswitch-switch package creates a directory > 'openvswitch-switch' in /etc. It is not used for any purpose. > > Bug #10623. > Reported-by: Eric Lopez > Signed-off-by: Gurucharan Shetty I think that Eric's nam

[ovs-dev] [PATCH] debian: Remove unused directory.

2012-04-06 Thread Gurucharan Shetty
Installing the openvswitch-switch package creates a directory 'openvswitch-switch' in /etc. It is not used for any purpose. Bug #10623. Reported-by: Eric Lopez Signed-off-by: Gurucharan Shetty --- AUTHORS|1 + debian/openvswitch-switch.dirs |1 - 2 files changed,

[ovs-dev] what functions should be implemented of the netdev-provider interface

2012-04-06 Thread Min Chen
Thanks Ben for your reply. On Tue, Apr 3, 2012 at 12:18 AM, Ben Pfaff wrote: > On Sat, Mar 31, 2012 at 04:37:41PM +0800, Min Chen wrote: > > I am reading source code of Open vSwitch 1.4.0. I have a question on > > updating ports immediately upon ofproto_port_add > > This is a strange question.