Glanced at python, seems good
On Tue, Mar 27, 2012 at 5:00 PM, Ben Pfaff wrote:
> The previous interface was just bizarre.
>
> Signed-off-by: Ben Pfaff
> ---
> tests/test-ovsdb.py | 14 ++
>
>
> diff --git a/tests/test-ovsdb.py b/tests/test-ovsdb.py
> index b0e42a3..77b3a2c 1
This is a first pass at adding include/openflow/openflow-1.2.h to
include enum and struct definitions for Open Flow 1.2 that
are not already covered by Open Flow 1.1.
Signed-off-by: Simon Horman
---
v2
As suggested by Ben Pfaff
* Use ovs_be{16,32,64} in place of uint_{16,32,64}
* Only include i
Signed-off-by: Simon Horman
---
include/openflow/openflow-1.1.h | 564 +++
1 files changed, 564 insertions(+), 0 deletions(-)
diff --git a/include/openflow/openflow-1.1.h b/include/openflow/openflow-1.1.h
index d02ece3..cdcfbd0 100644
--- a/include/openflow/o
Signed-off-by: Simon Horman
---
include/openflow/openflow-1.0.h | 31 +++
1 files changed, 31 insertions(+), 0 deletions(-)
diff --git a/include/openflow/openflow-1.0.h b/include/openflow/openflow-1.0.h
index 5844a96..2394cdb 100644
--- a/include/openflow/openflow-1
Hi,
this short series adds enum and struct definitions for Open Flow 1.2
to Open vSwitch. Some missing Open Flow 1.0 and 1.1 definitions have
also been added. None of the definitions added by this series are used yet,
rather this is preliminary work that an implementation could be based on.
The o
Signed-off-by: Simon Horman
---
include/openflow/openflow-common.h | 31 +++
1 files changed, 31 insertions(+), 0 deletions(-)
diff --git a/include/openflow/openflow-common.h
b/include/openflow/openflow-common.h
index 89c191b..43414f4 100644
--- a/include/openflow/
Signed-off-by: Ben Pfaff
---
lib/ovsdb-idl.c | 126 --
lib/ovsdb-idl.h | 51 -
python/ovs/db/idl.py | 116 ++---
3 files changed, 280 insertions(+), 13 deletions(-)
diff --gi
The previous interface was just bizarre.
Signed-off-by: Ben Pfaff
---
lib/ovsdb-idl.c | 41 -
lib/ovsdb-idl.h |5 +++--
python/ovs/db/idl.py | 41 +++--
tests/ovsdb-idl.at|4 ++--
tests/test-
Originally the IDL transaction state machine had a return value
TXN_TRY_AGAIN to signal the client to wait for a change in the database and
then retry its transaction. However, this logic was incomplete, because
it was possible for the database to change before the reply to the
transaction RPC was
This does not fix an actual bug in ovs-monitor-ipsec because it does not
ever commit any changes to the database.
Signed-off-by: Ben Pfaff
---
debian/ovs-monitor-ipsec |7 +--
1 files changed, 5 insertions(+), 2 deletions(-)
diff --git a/debian/ovs-monitor-ipsec b/debian/ovs-monitor-ips
I guess I'm the only one really comfortable with the IDL. I hope
this helps.
Ben Pfaff (4):
ovs-monitor-ipsec: Use same pattern as ovs-xapi-sync.
ovsdb-idl: Simplify transaction retry.
ovsdb-idl: Improve ovsdb_idl_txn_increment() interface.
ovsdb-idl: Improve documentation.
debian/ovs-m
I didn't try it either ;-)
I don't think the other files have corresponding issues.
On Tue, Mar 27, 2012 at 04:07:42PM -0700, Justin Pettit wrote:
> I didn't try it, but looks reasonable to me. Should we be deleting
> some of the other generated files? Such as ".ann" and ".ovsidl"?
>
> --Justi
On Tue, Mar 27, 2012 at 09:20:42AM -0700, Ben Pfaff wrote:
> On Tue, Mar 27, 2012 at 10:23:38AM +0900, Simon Horman wrote:
> > On Mon, Mar 26, 2012 at 01:59:20PM -0700, Ben Pfaff wrote:
> > > From: Simon Horman
> > >
> > > * Where Open Flow 1.2 breaks apart error codes defined
> > > in previous
I didn't try it, but looks reasonable to me. Should we be deleting some of the
other generated files? Such as ".ann" and ".ovsidl"?
--Justin
On Mar 27, 2012, at 3:59 PM, Ben Pfaff wrote:
> Codes that uses #include "vswitch-idl.h" can get an older version of this
> header, because this header
Codes that uses #include "vswitch-idl.h" can get an older version of this
header, because this header file moved from vswitchd/ to lib/ and the
older generated file might still be present.
This helps out two ways:
* "make clean" will delete the generated files from their old
locations
> What if we do both that and write #include "lib/vswitch-idl.h" instead
> of plain #include "vswitch-idl.h" for a while? I often don't run "make
> clean" when switching branches and, really, I shouldn't have to.
Sounds reasonable to me. Do you mind handling it?
Thanks!
--Justin
_
On Tue, Mar 27, 2012 at 10:24:30AM -0700, Jesse Gross wrote:
> On Tue, Mar 27, 2012 at 10:20 AM, Ben Pfaff wrote:
> > TCP flags fit in 8 bits so this type seems more appropriate.
> >
> > Fixes the following "sparse" warnings introduced by commit 734ec5ec1349
> > (packet: Add additional TCP flags e
On Tue, Mar 27, 2012 at 10:20 AM, Ben Pfaff wrote:
> TCP flags fit in 8 bits so this type seems more appropriate.
>
> Fixes the following "sparse" warnings introduced by commit 734ec5ec1349
> (packet: Add additional TCP flags extraction on IPv6.):
>
> dpif-netdev.c:630: warning: incorrect type in
TCP flags fit in 8 bits so this type seems more appropriate.
Fixes the following "sparse" warnings introduced by commit 734ec5ec1349
(packet: Add additional TCP flags extraction on IPv6.):
dpif-netdev.c:630: warning: incorrect type in assignment (different base types)
dpif-netdev.c:630:expect
On Tue, Mar 27, 2012 at 10:23:38AM +0900, Simon Horman wrote:
> On Mon, Mar 26, 2012 at 01:59:20PM -0700, Ben Pfaff wrote:
> > From: Simon Horman
> >
> > * Where Open Flow 1.2 breaks apart error codes defined
> > in previous versions, provide all new definitions to
> > previous versions and m
On Mon, Mar 26, 2012 at 02:36:31PM +0900, Simon Horman wrote:
> On Wed, Mar 21, 2012 at 12:09:09PM -0700, Jesse Gross wrote:
> > On Wed, Mar 21, 2012 at 1:52 AM, Simon Horman wrote:
> > > Hi Jesse, Hi all,
> > >
> > > I am currently investigating how STT[1] may be implemented for Open
> > > vSwti
21 matches
Mail list logo
