On Mon, Mar 19, 2012 at 02:31:36PM -0700, Ben Pfaff wrote:
> On Mon, Mar 19, 2012 at 09:54:43AM +0900, Simon Horman wrote:
> > Signed-off-by: Simon Horman
>
> This looks good to me with a few comments.
>
> The meanings of the little abbreviations we use for OpenFlow versions
> are starting to ge
This prevents potential race conditions when updating database
tables.
Signed-off-by: Ethan Jackson
---
.../usr_share_openvswitch_scripts_ovs-xapi-sync|3 +++
1 file changed, 3 insertions(+)
diff --git a/xenserver/usr_share_openvswitch_scripts_ovs-xapi-sync
b/xenserver/usr_share_openvs
On Mon, Mar 19, 2012 at 2:14 PM, wrote:
> When kernel >= 2.6.37 and vlan_tpid = 0x88a8, in function netdev_send,
> __vlan_put_tag present in OVS tree is not executed since
> dev_supports_vlan_tx returns true. It goes through the path of
> dev_queue_xmit which eventually calls __vlan_put_tag prese
On Tue, Mar 20, 2012 at 07:11:33AM +0900, Simon Horman wrote:
> On Mon, Mar 19, 2012 at 11:16:32AM -0700, Ben Pfaff wrote:
> > On Fri, Mar 16, 2012 at 03:49:13PM -0700, Ben Pfaff wrote:
> > > On Sat, Mar 17, 2012 at 07:16:04AM +0900, Simon Horman wrote:
> > > > On Fri, Mar 16, 2012 at 02:19:31PM -0
On Mon, Mar 19, 2012 at 11:18:10AM -0700, Ben Pfaff wrote:
> When I apply this patch I get:
>
> ../ovsdb/ovsdb-server.c:128:32: warning: incorrect type in argument 1
> (different modifiers)
> ../ovsdb/ovsdb-server.c:128:32:expected char **argv
> ../ovsdb/ovsdb-server.c:128:32:got char con
On Mon, Mar 19, 2012 at 11:16:32AM -0700, Ben Pfaff wrote:
> On Fri, Mar 16, 2012 at 03:49:13PM -0700, Ben Pfaff wrote:
> > On Sat, Mar 17, 2012 at 07:16:04AM +0900, Simon Horman wrote:
> > > On Fri, Mar 16, 2012 at 02:19:31PM -0700, Ben Pfaff wrote:
> > > > On Thu, Mar 15, 2012 at 09:30:24AM +0900
Sure.
On Mon, Mar 19, 2012 at 14:57, Ben Pfaff wrote:
> On Mon, Mar 19, 2012 at 01:57:43PM -0700, Ethan Jackson wrote:
>> > netdev_linux_iterate_queues()?
>>
>> netdev_linux_for_each_queue() maybe.
>
> Either version is fine with me. I like for_each_queue a little
> better. Do you want to write
On Mon, Mar 19, 2012 at 01:57:43PM -0700, Ethan Jackson wrote:
> > netdev_linux_iterate_queues()?
>
> netdev_linux_for_each_queue() maybe.
Either version is fine with me. I like for_each_queue a little
better. Do you want to write a patch?
Thanks,
Ben.
On Mon, Mar 19, 2012 at 09:54:43AM +0900, Simon Horman wrote:
> Signed-off-by: Simon Horman
This looks good to me with a few comments.
The meanings of the little abbreviations we use for OpenFlow versions
are starting to get a bit more complex, so it's probably a good idea
to include a "key" in
> netdev_linux_iterate_queues()?
netdev_linux_for_each_queue() maybe.
Ethan
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
> What's a better name?
netdev_linux_iterate_queues()?
Ethan
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
On Mon, Mar 19, 2012 at 01:45:21PM -0700, Ethan Jackson wrote:
> > + HMAP_FOR_EACH_SAFE (queue, next_queue, hmap_node,
> > &netdev_dev->tc->queues) {
>
> This line is one character too long.
It seems that my editor window was one character too wide.
Thanks, I fixed this.
> This looks good t
> + HMAP_FOR_EACH_SAFE (queue, next_queue, hmap_node,
> &netdev_dev->tc->queues) {
This line is one character too long.
This looks good to me. netdev_linux_dump_queues() has kind of a funny
name considering that it really is a generic queue iterator. I don't
think this is the patch to fix i
iface_configure_qos() passes a callback to netdev_dump_queues() that can
delete queues. The netdev-linux implementation of this function was
unprepared for the callback to delete queues, so this could cause a
use-after-free. This fixes the problem in netdev_linux_dump_queues() and
documents that
When I apply this patch I get:
../ovsdb/ovsdb-server.c:128:32: warning: incorrect type in argument 1
(different modifiers)
../ovsdb/ovsdb-server.c:128:32:expected char **argv
../ovsdb/ovsdb-server.c:128:32:got char const **
../ovsdb/ovsdb-server.c: In function ‘main’:
../ovsdb/ovsdb-serve
On Fri, Mar 16, 2012 at 03:49:13PM -0700, Ben Pfaff wrote:
> On Sat, Mar 17, 2012 at 07:16:04AM +0900, Simon Horman wrote:
> > On Fri, Mar 16, 2012 at 02:19:31PM -0700, Ben Pfaff wrote:
> > > On Thu, Mar 15, 2012 at 09:30:24AM +0900, Simon Horman wrote:
> > > > On Wed, Mar 14, 2012 at 02:49:08PM -0
On Sat, Mar 17, 2012 at 01:16:53PM +0800, Thomas Goirand wrote:
> On 03/17/2012 06:57 AM, Simon Horman wrote:
> > Understood, in that case I agree that backporting makes sense.
>
> I agree that "backporting" fixes makes sense. I'd like also to highlight
> that you'd be backporting a forwarded-port
On Mon, Mar 19, 2012 at 11:01:42AM -0700, Ethan Jackson wrote:
> Here's an incremental.
Looks good to me, thanks.
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
Here's an incremental.
---
lib/cfm.c|7 +--
lib/cfm.h|4 +++-
vswitchd/bridge.c|4 ++--
vswitchd/vswitch.xml |4 ++--
4 files changed, 12 insertions(+), 7 deletions(-)
diff --git a/lib/cfm.c b/lib/cfm.c
index 10a9428..8b9e5bc 100644
--- a/lib/cfm.c
Passes so I'll merge this now.
Ethan
On Mon, Mar 19, 2012 at 10:03, Ben Pfaff wrote:
> On Thu, Mar 15, 2012 at 05:14:42PM -0700, Ethan Jackson wrote:
>> This is cleaner then having multiple programs build the idl
>> independently.
>>
>> Signed-off-by: Ethan Jackson
>
> Assuming it passes "make
On Fri, Mar 16, 2012 at 04:17:35PM -0700, Chris Wright wrote:
> * Ben Pfaff (b...@nicira.com) wrote:
> > >From early days, Nicira used the --with-build-number option to configure to
> > stamp our internal builds. We've since switched to another scheme, so
> > this option is obsolete.
>
> Looks go
On Thu, Mar 15, 2012 at 05:14:42PM -0700, Ethan Jackson wrote:
> This is cleaner then having multiple programs build the idl
> independently.
>
> Signed-off-by: Ethan Jackson
Assuming it passes "make distcheck" this looks good to me.
___
dev mailing li
On Fri, Mar 16, 2012 at 06:05:21PM -0700, Ethan Jackson wrote:
> CCM PDUs may take a different path through the network depending on
> the VLAN tag they carry. In order to exercise these paths, it
> may be advantageous to use a random VLAN tag.
>
> Signed-off-by: Ethan Jackson
What a weird feat
23 matches
Mail list logo
