This adds ability to do:
./configure --disable-brcompat
to disable building userspace and kernel module associated with
providing linux bridge compatibility.
Signed-off-by: Chris Wright
---
configure.ac|1 +
datapath/Makefile.am|2 ++
datapath/linux/Kb
This creates a linux/Module-openvswitch.mk and a linux/Module-brcompat.mk
out of linux/Modules.mk. This makes it easier to subsequently disable
building the brcompat module. It's split rather than adding conditionals
to the single Modules.mk file because it is used both in automake and
build stag
This short series adds ability to disable building brcompat user and
kernel space bits. I've done some light testing to verify it's doing
what I expected, but may have missed some subtleties of the build
system.
thanks,
-chris
Chris Wright (2):
datapath: split out linux/Modules.mk
configure:
On Fri, Mar 9, 2012 at 4:22 PM, Ben Pfaff wrote:
> Reported-by: Gurucharan Shetty
> Signed-off-by: Ben Pfaff
> ---
> utilities/ovs-pki.in | 7 ++-
> 1 files changed, 6 insertions(+), 1 deletions(-)
>
> diff --git a/utilities/ovs-pki.in b/utilities/ovs-pki.in
> index 0255251..ac1de33 1007
Narrow Python can't handle Unicode characters outside the BMP, so skip the
test.
Reported-by: Michael Shigorin
Signed-off-by: Ben Pfaff
---
tests/ovsdb-data.at |7 ++-
tests/ovsdb.at | 10 +-
2 files changed, 11 insertions(+), 6 deletions(-)
diff --git a/tests/ovsdb-data
Reported-by: Gurucharan Shetty
Signed-off-by: Ben Pfaff
---
utilities/ovs-pki.in |7 ++-
1 files changed, 6 insertions(+), 1 deletions(-)
diff --git a/utilities/ovs-pki.in b/utilities/ovs-pki.in
index 0255251..ac1de33 100755
--- a/utilities/ovs-pki.in
+++ b/utilities/ovs-pki.in
@@ -1,6
Simon, will you review these patches?
Thanks,
Ben.
On Fri, Mar 09, 2012 at 03:40:10PM -0800, Ethan Jackson wrote:
> Who would be the best person to review this Ben? I'm happy to do so,
> though I know nothing about debian so am unlikely to be very helpful.
>
> Ethan
>
> On Fri, Mar 9, 2012 at
Who would be the best person to review this Ben? I'm happy to do so,
though I know nothing about debian so am unlikely to be very helpful.
Ethan
On Fri, Mar 9, 2012 at 15:17, Ben Pfaff wrote:
> Thomas Goirand passed along a number of lintian warnings, plus
> fixes (which is very much appreciated
On Fri, Mar 09, 2012 at 04:50:32AM +0800, Thomas Goirand wrote:
> On 03/09/2012 03:22 AM, Ben Pfaff wrote:
> > On Fri, Mar 09, 2012 at 01:47:45AM +0800, Thomas Goirand wrote:
> >> As I understand, you are also upstream for openvswitch. If that is the
> >> case, then best would be to have the man pa
On Fri, Mar 09, 2012 at 03:18:07PM -0800, Ben Pfaff wrote:
> Found by lintian.
>
> Reported-by: Thomas Goirand
> Signed-off-by: Ben Pfaff
This patch is wrong. Please ignore this one. I will revise it.
The rest of the series remains relevant.
___
de
On Fri, Mar 09, 2012 at 12:06:03AM +0800, Thomas Goirand wrote:
> >> E: openvswitch-datapath-dkms: python-script-but-no-python-dep
> >> usr/src/openvswitch-1.4.0/build-aux/check-structs
> >> E: openvswitch-datapath-dkms: python-script-but-no-python-dep
> >> usr/src/openvswitch-1.4.0/build-aux/ext
On Fri, Mar 09, 2012 at 01:47:45AM +0800, Thomas Goirand wrote:
> At the end, I did work on the packaging of openvswitch.
Thank you very much!
I converted your patches to a series of commits and sent them out to
ovs-dev for review. I believe that you are CCed on most of them, but
you can view th
ovs-vswitchd.conf.db.5 has autogenerated text "at least -1" in one place.
This '-' should be a minus sign, but ovsdb-doc was generating it as a
hyphen.
Found by lintian.
Reported-by: Thomas Goirand
Signed-off-by: Ben Pfaff
---
ovsdb/ovsdb-doc.in |9 ++---
python/ovs/db/types.py |
ovs-vswitchd.conf.db.5 contains the following sentence:
If the interface cannot be added then Open vSwitch sets this column
to -1.
The '-' in "-1" should be a minus sign, not a hyphen, but the heuristic
in ovsdb-doc wasn't smart enough. This commit improves the heuristic and
fixes the prob
This makes the manpage indexable by standard system tools.
Found by lintian.
Reported-by: Thomas Goirand
Signed-off-by: Ben Pfaff
---
ovsdb/ovsdb-doc.in |6 +++---
1 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/ovsdb/ovsdb-doc.in b/ovsdb/ovsdb-doc.in
index 8f725d7..5ae6706
The configure option --with-build-number=0 is interpreted differently in
different places. The configure script itself accepts 0 as an actual
build number and puts '#define BUILDNR "+build0"' into config.h. The
code in python/automake.mk treats 0 as "no build number" and puts
'BUILDNR = ""' into
Found by lintian.
Reported-by: Thomas Goirand
Signed-off-by: Ben Pfaff
---
debian/rules |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/debian/rules b/debian/rules
index 1953ee5..c88afde 100755
--- a/debian/rules
+++ b/debian/rules
@@ -128,8 +128,8 @@ binary-common:
From: Thomas Goirand
Found by lintian.
Reported-by: Thomas Goirand
Signed-off-by: Ben Pfaff
---
lib/stress-unixctl.man |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/lib/stress-unixctl.man b/lib/stress-unixctl.man
index ad265ee..d2716a9 100644
--- a/lib/stress-unixc
From: Thomas Goirand
No other changes necessary.
Signed-off-by: Thomas Goirand
Signed-off-by: Ben Pfaff
---
debian/control |4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/debian/control b/debian/control
index 0cc526e..6c509fd 100644
--- a/debian/control
+++ b/debia
From: Thomas Goirand
This commit removes useless files from the dkms package that caused
lintian warnings.
(Many of the other files in the dkms package are also useless but do not
cause lintian warnings so they are less important.)
Signed-off-by: Thomas Goirand
Signed-off-by: Ben Pfaff
---
d
From: Thomas Goirand
Signed-off-by: Thomas Goirand
Signed-off-by: Ben Pfaff
---
debian/rules |1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/debian/rules b/debian/rules
index c8b6c63..b65c460 100755
--- a/debian/rules
+++ b/debian/rules
@@ -72,6 +72,7 @@ clean:
From: Thomas Goirand
Open vSwitch no longer uses Debconf at all, for some time now.
Signed-off-by: Thomas Goirand
Signed-off-by: Ben Pfaff
---
debian/control |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/debian/control b/debian/control
index fac3280..0cc526e 100644
From: Thomas Goirand
Open vSwitch should support all Python versions in the distribution. This
is the way to do it.
Signed-off-by: Thomas Goirand
Signed-off-by: Ben Pfaff
---
debian/control |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/debian/control b/debian/cont
From: Thomas Goirand
Signed-off-by: Thomas Goirand
Signed-off-by: Ben Pfaff
---
debian/control |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/debian/control b/debian/control
index 7666c82..c85d449 100644
--- a/debian/control
+++ b/debian/control
@@ -215,7 +215,7 @@ D
From: Thomas Goirand
Signed-off-by: Thomas Goirand
Signed-off-by: Ben Pfaff
---
debian/control | 114 +++-
1 files changed, 96 insertions(+), 18 deletions(-)
diff --git a/debian/control b/debian/control
index 1d6859e..7666c82 100644
--- a/d
From: Thomas Goirand
Signed-off-by: Thomas Goirand
Signed-off-by: Ben Pfaff
---
debian/compat |2 +-
debian/control |2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/debian/compat b/debian/compat
index 7f8f011..45a4fb7 100644
--- a/debian/compat
+++ b/debian/compat
From: Thomas Goirand
Signed-off-by: Thomas Goirand
Signed-off-by: Ben Pfaff
---
AUTHORS|1 +
debian/openvswitch-controller.init |2 ++
debian/openvswitch-ipsec.init |2 ++
debian/openvswitch-switch.init |2 ++
4 files changed, 7 insertions(+
Thomas Goirand passed along a number of lintian warnings, plus
fixes (which is very much appreciated!). This series is his
collection of fixes, plus a few of my own, broken up into multiple
commits.
See http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=663051 for
Thomas's full original report.
Be
There is no need to refresh status and stats for existing devices
if the device mtu is zero as it will be done periodically by
vswitchd.
Signed-off-by: Pravin B Shelar
---
vswitchd/bridge.c |5 -
1 files changed, 4 insertions(+), 1 deletions(-)
diff --git a/vswitchd/bridge.c b/vswitchd/
Internal device mtu does not influence mtu of other internal devices.
So skip MTU setting completely when internal device mtu is changed.
Signed-off-by: Pravin B Shelar
---
ofproto/ofproto.c | 40 +---
1 files changed, 21 insertions(+), 19 deletions(-)
diff
Thanks I've merged this.
Ethan
On Fri, Mar 9, 2012 at 14:07, Ben Pfaff wrote:
> On Thu, Mar 08, 2012 at 02:49:11PM -0800, Ethan Jackson wrote:
>> A developer may have Open vSwitch installed, in which case many of
>> the Python files which are tested will be in both the development
>> tree and th
On Thu, Mar 08, 2012 at 02:49:11PM -0800, Ethan Jackson wrote:
> A developer may have Open vSwitch installed, in which case many of
> the Python files which are tested will be in both the development
> tree and the system Python library. When running unit tests, we
> want to test the development t
Thanks, I've merged this.
Ethan
On Fri, Mar 9, 2012 at 13:34, Ben Pfaff wrote:
> On Fri, Mar 09, 2012 at 01:06:35PM -0800, Ethan Jackson wrote:
>> Requested-by: Amar Padmanabhan
>> Signed-off-by: Ethan Jackson
>
> Looks good to me, thanks Ethan.
___
On Fri, Mar 09, 2012 at 01:54:29PM -0800, Ethan Jackson wrote:
> Without this patch sparse gives me warnings. At any rate, it's
> cleaner to be consistent.
>
> Signed-off-by: Ethan Jackson
Looks good, thank you.
___
dev mailing list
dev@openvswitch.or
Without this patch sparse gives me warnings. At any rate, it's
cleaner to be consistent.
Signed-off-by: Ethan Jackson
---
lib/netdev-linux.c | 18 ++
lib/netdev.c |3 ++-
2 files changed, 12 insertions(+), 9 deletions(-)
diff --git a/lib/netdev-linux.c b/lib/netdev-
On Fri, Mar 09, 2012 at 01:06:35PM -0800, Ethan Jackson wrote:
> Requested-by: Amar Padmanabhan
> Signed-off-by: Ethan Jackson
Looks good to me, thanks Ethan.
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
On Fri, Mar 09, 2012 at 01:23:57PM -0800, Chris Wright wrote:
> * Ben Pfaff (b...@nicira.com) wrote:
> > Fixes an error during module-assistant build step:
> >
> > install: cannot stat `openvswitch/datapath/linux/*_mod.ko': No such
> > file or directory
> >
> > This was (understandably) o
* Ben Pfaff (b...@nicira.com) wrote:
> Fixes an error during module-assistant build step:
>
> install: cannot stat `openvswitch/datapath/linux/*_mod.ko': No such
> file or directory
>
> This was (understandably) overlooked as part of commit 9b80f761be
> (datapath: omit _mod from module na
Looks good, thanks.
Ethan
On Fri, Mar 9, 2012 at 13:21, Ben Pfaff wrote:
> Fixes an error during module-assistant build step:
>
> install: cannot stat `openvswitch/datapath/linux/*_mod.ko': No such
> file or directory
>
> This was (understandably) overlooked as part of commit 9b80f761be
>
> /etc/init.d/openvswitch needs to use flush-cache instead of force-run.
Didn't try out the new version's init script yet. I'll change it and
verify it works before merging.
Ethan
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/
Fixes an error during module-assistant build step:
install: cannot stat `openvswitch/datapath/linux/*_mod.ko': No such
file or directory
This was (understandably) overlooked as part of commit 9b80f761be
(datapath: omit _mod from module names).
CC: Chris Wright
Signed-off-by: Ben Pfaff
Fine with me, I've changed it in both patches.
Ethan
On Fri, Mar 9, 2012 at 12:20, Ben Pfaff wrote:
> On Thu, Mar 08, 2012 at 03:53:23PM -0800, Ethan Jackson wrote:
>> iface_ids = {} # Map from xs-vif-uuid to iface-id
>> vm_ids = {} # Map from xs-vm-uuid to
Requested-by: Amar Padmanabhan
Signed-off-by: Ethan Jackson
---
This patch makes "nicira-ext: Add a 6th NXM register." obsolete, so it no
longer needs review.
---
NEWS |1 +
include/openflow/nicira-ext.h |6 +++
lib/classifier.c |4 +-
lib/flow
On Fri, Mar 9, 2012 at 9:55 AM, Chris Wright wrote:
> This renames the datapath modules:
>
> openvswitch_mod -> openvswitch
> brcompat_mod -> brcompat
>
> The first makes the module name consistent with upstream, and the latter
> is just for internal consistency. This makes tools, and documenta
On Fri, Mar 09, 2012 at 12:03:06PM -0800, Pravin B Shelar wrote:
> v1-3:
> - Use change->ifi_index to update ifindex.
>
> Signed-off-by: Pravin B Shelar
Looks good to me, thank you.
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/m
On Fri, Mar 09, 2012 at 12:02:53PM -0800, Pravin B Shelar wrote:
> v2-v3:
> No change.
>
> v1-v2:
> - changed VALID_FEATURES.
> - Dont define netdev_get_features operation for internal device.
>
> --8<--cut here-->8--
>
> Following
On Fri, Mar 09, 2012 at 12:02:38PM -0800, Pravin B Shelar wrote:
> Fixed according to comments from Ben.
> v2-v3:
> - Only cache ENODEV error code from set-policing.
> v1-v2:
> - Changed name from netdev_policy_error to netdev_policing_error.
>
> --8<--cut here---
On Fri, Mar 09, 2012 at 12:02:31PM -0800, Pravin B Shelar wrote:
> Fixed according to comments from Ben.
> v2-v3:
> - Only cache ENODEV error code from set etheraddr.
> - Fixed comment in netdev_linux_get_etheraddr().
> - Fixed rtnetlink_link_parse().
>
> v1-v2:
> - Changed che
On Fri, Mar 09, 2012 at 12:02:23PM -0800, Pravin B Shelar wrote:
> Fixed according to comments from Ben.
> v2-v3:
> - Only cache ENODEV from set-mtu ioctl.
>
> v1-v2:
> - Fixed check for MTU in notifier so that mtu is not set to zero.
> - Changed check for VALID_MTU.
>
> --8<--
On Fri, Mar 09, 2012 at 12:02:16PM -0800, Pravin B Shelar wrote:
> Fixed according to comments from Ben.
> v2-v3:
> - Dont issue ETHTOOL_GDRVINFO for internal devices.
> - Discard drv-info on RTM_DELLINK event.
> v1-v2:
> - Added comment for netdev_internal_open.
> - Removed get
On Thu, Mar 08, 2012 at 03:53:22PM -0800, Ethan Jackson wrote:
> Communicating with xapi from Python can be quite expensive so it
> makes sense to cache this data if convenient.
>
> Signed-off-by: Ethan Jackson
This looks good, thank you.
I made additional comments on patches 3 and 4. I'm done
On Thu, Mar 08, 2012 at 03:53:24PM -0800, Ethan Jackson wrote:
> Typically Open vSwitch communicates with running processes using
> unixctl. This patch converts ovs-xapi-sync to the strategy for
> consistency.
>
> Signed-off-by: Ethan Jackson
/etc/init.d/openvswitch needs to use flush-cache ins
On Thu, Mar 08, 2012 at 03:53:23PM -0800, Ethan Jackson wrote:
> iface_ids = {} # Map from xs-vif-uuid to iface-id
> vm_ids = {} # Map from xs-vm-uuid to vm-id
> seqno = idl.change_seqno# Sequence number when we last processed the
> db
> -while T
v1-3:
- Use change->ifi_index to update ifindex.
Signed-off-by: Pravin B Shelar
---
lib/netdev-linux.c | 19 +++
1 files changed, 15 insertions(+), 4 deletions(-)
diff --git a/lib/netdev-linux.c b/lib/netdev-linux.c
index 70d1e78..8a30d74 100644
--- a/lib/netdev-linux.c
+
v2-v3:
No change.
v1-v2:
- changed VALID_FEATURES.
- Dont define netdev_get_features operation for internal device.
--8<--cut here-->8--
Following patch adds support for caching error code from ETHTOOL_GSET
call. Since internal devi
Fixed according to comments from Ben.
v2-v3:
- Only cache ENODEV error code from set-policing.
v1-v2:
- Changed name from netdev_policy_error to netdev_policing_error.
--8<--cut here-->8--
Signed-off-by: Pravin B Shelar
---
lib/netdev-li
Fixed according to comments from Ben.
v2-v3:
- Only cache ENODEV error code from set etheraddr.
- Fixed comment in netdev_linux_get_etheraddr().
- Fixed rtnetlink_link_parse().
v1-v2:
- Changed check for VALID_ETHERADDR.
- Using notifier msg to update device ether addr.
Fixed according to comments from Ben.
v2-v3:
- Only cache ENODEV from set-mtu ioctl.
v1-v2:
- Fixed check for MTU in notifier so that mtu is not set to zero.
- Changed check for VALID_MTU.
--8<--cut here-->8--
netdev linux devices use
Fixed according to comments from Ben.
v2-v3:
- Dont issue ETHTOOL_GDRVINFO for internal devices.
- Discard drv-info on RTM_DELLINK event.
v1-v2:
- Added comment for netdev_internal_open.
- Removed get-stat call from status check.
--8<--cut here--
Here are my additional comments that point out less-important issues.
include/openflow/nicira-ext.h
-
The "format' in the definition of mpls_label isn't entirely clear to
me:
+/* The mpls_label in MPLS shim header.
+ *
+ * Prereqs: NXM_OF_ETH_TYPE must be
Thank you for the patch! I have some comments. I'm dividing them
into two groups. The first group, in this email, is comments that
point out likely bugs. The second group, which I will send
separately, is comments that point out less important issues.
I didn't review the kernel code. That wil
This renames the datapath modules:
openvswitch_mod -> openvswitch
brcompat_mod -> brcompat
The first makes the module name consistent with upstream, and the latter
is just for internal consistency. This makes tools, and documentation
refer to a common module name regardless if it's coming fr
62 matches
Mail list logo
