On Fri, Mar 02, 2012 at 07:07:17PM -0800, Ethan Jackson wrote:
> The Python unixctl tests introduced a transient build failure that
> can't be debugged until more information is collected. Skipping
> these tests for now until it's possible to debug them.
>
> Signed-off-by: Ethan Jackson
Seems r
The Python unixctl tests introduced a transient build failure that
can't be debugged until more information is collected. Skipping
these tests for now until it's possible to debug them.
Signed-off-by: Ethan Jackson
---
tests/unixctl-py.at |6 ++
1 file changed, 6 insertions(+)
diff --g
* Ansis Atteka (aatt...@nicira.com) wrote:
> On Thu, Mar 1, 2012 at 9:28 PM, Chris Wright wrote:
> > insert_openvswitch_mod_if_required () {
> > -# If openvswitch_mod is already loaded then we're done.
> > -test -e /sys/module/openvswitch_mod && return 0
> > +# If @OVSKMOD@ is already
Thanks, pushed to master, 1.5, 1.6.
On Fri, Mar 02, 2012 at 02:37:53PM -0800, Ethan Jackson wrote:
> Looks good,
>
> Ethan
>
> On Fri, Mar 2, 2012 at 14:10, Ben Pfaff wrote:
> > I only tested this feature with service controllers.
> >
> > Bug #9964.
> > Reported-by: James Schmidt
> > Signed-of
Thanks, pushed to master, branch-1.[3456]. (branch-1.2 doesn't have a
set_mtu function.)
On Fri, Mar 02, 2012 at 02:37:19PM -0800, Ethan Jackson wrote:
> Looks good.
>
> Ethan
>
> On Fri, Mar 2, 2012 at 14:18, Ben Pfaff wrote:
> > Found by inspection.
> >
> > Signed-off-by: Ben Pfaff
> > ---
Looks good,
Ethan
On Fri, Mar 2, 2012 at 14:10, Ben Pfaff wrote:
> I only tested this feature with service controllers.
>
> Bug #9964.
> Reported-by: James Schmidt
> Signed-off-by: Ben Pfaff
> ---
> AUTHORS | 1 +
> ofproto/connmgr.c | 1 +
> 2 files changed, 2 insertions(+),
Looks good.
Ethan
On Fri, Mar 2, 2012 at 14:18, Ben Pfaff wrote:
> Found by inspection.
>
> Signed-off-by: Ben Pfaff
> ---
> lib/netdev.c | 4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/lib/netdev.c b/lib/netdev.c
> index eff6e4c..64dfda5 100644
> --- a/lib/net
This patch shouldn't actually affect the behavior of LACP bonds
because the bond module won't choose to send traffic out a slave
whose carrier is down.
Signed-off-by: Ethan Jackson
---
lib/lacp.c | 10 ++
ofproto/ofproto-dpif.c |7 +++
2 files changed, 13 insertions
Found by inspection.
Signed-off-by: Ben Pfaff
---
lib/netdev.c |4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/lib/netdev.c b/lib/netdev.c
index eff6e4c..64dfda5 100644
--- a/lib/netdev.c
+++ b/lib/netdev.c
@@ -1,5 +1,5 @@
/*
- * Copyright (c) 2008, 2009, 2010, 2011
I only tested this feature with service controllers.
Bug #9964.
Reported-by: James Schmidt
Signed-off-by: Ben Pfaff
---
AUTHORS |1 +
ofproto/connmgr.c |1 +
2 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/AUTHORS b/AUTHORS
index 6a83514..cdf6ce6 100644
--- a/AU
This patch created on earlier patch "v2 netdev-linux: Use get-stats
to check status on linux devices."
--8<--cut here-->8-
netdev linux devices uses SIOCGIFMTU ioctl to read MTU for a device.
By caching error code from ioctl we can reduce number of
Thanks, I've merged this.
On Fri, Mar 2, 2012 at 13:47, Ben Pfaff wrote:
> On Fri, Mar 02, 2012 at 01:40:48PM -0800, Ethan Jackson wrote:
>> Good Idea, how about something like this?
>
> Sure, that seems fine.
___
dev mailing list
dev@openvswitch.org
ht
On Fri, Mar 02, 2012 at 01:40:48PM -0800, Ethan Jackson wrote:
> Good Idea, how about something like this?
Sure, that seems fine.
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
Good Idea, how about something like this?
---
python/ovs/db/idl.py |7 +--
1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/python/ovs/db/idl.py b/python/ovs/db/idl.py
index 57495f5..b33d9f8 100644
--- a/python/ovs/db/idl.py
+++ b/python/ovs/db/idl.py
@@ -1092,10 +1092,13 @@
On Fri, Mar 02, 2012 at 01:30:02PM -0800, Ethan Jackson wrote:
> > Will you convert the existing Idl clients in the tree to use this new
> > class?
>
> Sure, do you mind if I do it a bit later as I convert the python
> daemons to using the new unixctl library. That way I only have to
> test them
> Will you convert the existing Idl clients in the tree to use this new
> class?
Sure, do you mind if I do it a bit later as I convert the python
daemons to using the new unixctl library. That way I only have to
test them once.
> Should we continue to support the older form?
I don't feel strong
On Fri, Mar 02, 2012 at 01:23:05PM -0800, Ethan Jackson wrote:
> Thanks for the reviews. Here's an incremental.
Looks good, thank you.
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
The reconfiguration code only deleted unwanted ports for bridges that had
been created in previous (re)configurations. In fact, we should run this
step even for bridges that are newly added, e.g. to delete ports that
were added by a previous run of ovs-vswitchd and deleted from the database
betwee
Thanks for the reviews. Here's an incremental.
---
python/ovs/unixctl.py | 42 --
tests/unixctl-py.at |4 ++--
2 files changed, 30 insertions(+), 16 deletions(-)
diff --git a/python/ovs/unixctl.py b/python/ovs/unixctl.py
index c36eae2..8921ba8 100
On Thu, Mar 1, 2012 at 9:28 PM, Chris Wright wrote:
> This is just an RFC, partly because it ignores datapath/ so you could
> build a module that the runtime can't install. Now that the ovs datapath
> is upstream and named simply openvswitch, tools like ovs-ctl fail to
> function w/ the native d
On Fri, Mar 02, 2012 at 12:44:12PM -0800, Ethan Jackson wrote:
> > I noticed that there's some code that insists on "string" objects in
> > various places, which makes me a little nervous because "string" and
> > "unicode" objects in Python seem almost interchangeable but they are
> > not the same
> I noticed that there's some code that insists on "string" objects in
> various places, which makes me a little nervous because "string" and
> "unicode" objects in Python seem almost interchangeable but they are
> not the same and a test for one will not accept the other. There's a
> lot of "if t
* Ben Pfaff (b...@nicira.com) wrote:
> On Fri, Mar 02, 2012 at 11:31:44AM -0800, Chris Wright wrote:
> > * Ben Pfaff (b...@nicira.com) wrote:
> > > I wonder whether we should just drop the "_mod" from our out-of-tree
> > > module names. Seems simpler and less confusing in the long run.
> > >
> >
On Fri, Mar 02, 2012 at 11:31:44AM -0800, Chris Wright wrote:
> * Ben Pfaff (b...@nicira.com) wrote:
> > On Thu, Mar 01, 2012 at 09:28:50PM -0800, Chris Wright wrote:
> > > This is just an RFC, partly because it ignores datapath/ so you could
> > > build a module that the runtime can't install. No
* Ben Pfaff (b...@nicira.com) wrote:
> On Thu, Mar 01, 2012 at 09:28:50PM -0800, Chris Wright wrote:
> > This is just an RFC, partly because it ignores datapath/ so you could
> > build a module that the runtime can't install. Now that the ovs datapath
> > is upstream and named simply openvswitch,
* Ben Pfaff (b...@nicira.com) wrote:
> On Thu, Mar 01, 2012 at 11:09:07PM -0800, Chris Wright wrote:
> > I'm pondering adding a way to disable brcompat. This would keep from
> > building it and strip it from config templates, init scripts, ovs-ctl,
> > etc... Here's a quick hack to give an idea.
The body from the message "Re: [ovs-dev] [PATCH] xenserver: Fix rule for
generating
xenserver/openvswitch-xen.spec.", originally sent to you by
dev-boun...@openvswitch.org (dev-boun...@openvswitch.org), has been forwarded
to you from the Microsoft Forefront Server Security Quarantine ar
On Thu, Mar 01, 2012 at 06:55:27PM -0800, Ethan Jackson wrote:
> The new SchemaHelper class makes it easier to prune database
> schemas intended for the Python IDL.
>
> Signed-off-by: Ethan Jackson
Will you convert the existing Idl clients in the tree to use this new
class?
Should we continue t
On Thu, Mar 01, 2012 at 09:28:50PM -0800, Chris Wright wrote:
> This is just an RFC, partly because it ignores datapath/ so you could
> build a module that the runtime can't install. Now that the ovs datapath
> is upstream and named simply openvswitch, tools like ovs-ctl fail to
> function w/ the
On Thu, Mar 01, 2012 at 11:09:07PM -0800, Chris Wright wrote:
> I'm pondering adding a way to disable brcompat. This would keep from
> building it and strip it from config templates, init scripts, ovs-ctl,
> etc... Here's a quick hack to give an idea.
>
> Any thoughts whether this is worth pursu
On Thu, Mar 01, 2012 at 09:14:56PM -0800, Chris Wright wrote:
> s/ovsdmonitor/ovsdbmonitor/
>
> Signed-off-by: Chris Wright
Thank you. I applied this to master and branch-1.[23456].
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailm
On Thu, Mar 01, 2012 at 09:13:36PM -0800, Chris Wright wrote:
> Needed for Fedora builds, might as well share it.
>
> Signed-off-by: Chris Wright
Thanks, I applied this to master.
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/
Thanks, pushed to master, branch-1.6.
On Fri, Mar 02, 2012 at 09:56:38AM -0800, Justin Pettit wrote:
> Looks good to me.
>
> --Justin
>
>
> On Mar 2, 2012, at 9:25 AM, Ben Pfaff wrote:
>
> > Commands in Makefiles have to begin with a hard tab, otherwise they are
> > ignored, which is what happ
On Thu, Mar 01, 2012 at 04:30:38PM -0800, Ethan Jackson wrote:
> Many of the currently implemented Python daemons, and likely many
> daemons to be implemented in the future, could benefit from unixctl
> support even if only to implement "exit" and "version" commands.
> This patch implements unixctl
I had chat with with Ben and I changed patch accordingly.
v1-v2:
- always cache driver-info.
--8<--cut here-->8-
Rather than using ETHTOOL_GDRVINFO to check status, use get-stats from
ovs since it is more consistent.
Signed-off-by: Pravin
Looks good to me.
--Justin
On Mar 2, 2012, at 9:25 AM, Ben Pfaff wrote:
> Commands in Makefiles have to begin with a hard tab, otherwise they are
> ignored, which is what happened here.
>
> Fixes "make distcheck".
>
> Signed-off-by: Ben Pfaff
> ---
> xenserver/automake.mk |6 +++---
> 1 f
Commands in Makefiles have to begin with a hard tab, otherwise they are
ignored, which is what happened here.
Fixes "make distcheck".
Signed-off-by: Ben Pfaff
---
xenserver/automake.mk |6 +++---
1 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/xenserver/automake.mk b/xenserve
37 matches
Mail list logo
