[ovs-dev] 2012 (WCSEHTFL) Conference Invitation on World Congress against Sex Exploitat..

Dear Colleagues, It is a great pleasure to invite you to the World Congress against Sex Exploitation, Human Trafficking and Forced Labour (WCSEHTFL)2012. The theme of this conference is: New Dimensions of Commercial Sexual Exploitation of Children (CSEC) and Combating Human and Sex Trafficking

Re: [ovs-dev] [PATCH] ovs-ofctl: Fix "snoop" command.

Thanks for fixing this Ben. I think some places in the documentation may mention that the the preferred packet_in format applies to snoop as well. I broke this, so I'll think about writing a unit test which at least does a sanity check on the snoop command, shouldn't be too hard. Ethan On Thu,

[ovs-dev] [PATCH] ovs-ofctl: Fix "snoop" command.

The vconn that "snoop" opens does not process and reply to requests, so sending a request to set the packet-in format will hang forever, which means that "snoop" never actually prints any of the traffic that it receives. Bug #9346. Reported-by: Alan Shieh Signed-off-by: Ben Pfaff --- AUTHORS

Re: [ovs-dev] [PATCH] odp-util: Describe invalid keys and actions in more detail.

Thanks, I pushed it to master. On Thu, Jan 26, 2012 at 04:53:51PM -0800, Ethan Jackson wrote: > Looks good. > > Ethan > > On Thu, Jan 26, 2012 at 16:22, Ben Pfaff wrote: > > I have an outstanding bug report that has tons of "***56 leftover bytes***" > > messages with no way to guess what the pr

Re: [ovs-dev] [PATCH] odp-util: Describe invalid keys and actions in more detail.

Looks good. Ethan On Thu, Jan 26, 2012 at 16:22, Ben Pfaff wrote: > I have an outstanding bug report that has tons of "***56 leftover bytes***" > messages with no way to guess what the problem is.  I hope this makes > debugging possible. > > Bug #9346. > Signed-off-by: Ben Pfaff > --- >  lib/od

[ovs-dev] [PATCH] odp-util: Describe invalid keys and actions in more detail.

I have an outstanding bug report that has tons of "***56 leftover bytes***" messages with no way to guess what the problem is. I hope this makes debugging possible. Bug #9346. Signed-off-by: Ben Pfaff --- lib/odp-util.c | 16 ++-- 1 files changed, 14 insertions(+), 2 deletions(-)

Re: [ovs-dev] [PATCH] nicira-ext: Remove duplicative error codes.

Thanks, I pushed this to master. On Thu, Jan 26, 2012 at 04:02:28PM -0800, Ethan Jackson wrote: > Looks good, thanks. > > Ethan > > On Thu, Jan 26, 2012 at 15:50, Ben Pfaff wrote: > > The information here duplicates the information in ofp-errors.h, so remove > > it from here. > > > > Signed-off

Re: [ovs-dev] [PATCH] ovs-ofctl: Fix typo in comment.

Thanks, I pushed this to master. On Thu, Jan 26, 2012 at 04:01:22PM -0800, Ethan Jackson wrote: > Looks good, thanks. > > Ethan > > On Thu, Jan 26, 2012 at 15:51, Ben Pfaff wrote: > > Signed-off-by: Ben Pfaff > > --- > >  utilities/ovs-ofctl.c |    2 +- > >  1 files changed, 1 insertions(+), 1

Re: [ovs-dev] [PATCH] ofproto: Fix typo in handle_nxt_set_packet_in_format().

Yeah, I was just reading code. I pushed this, thanks. On Thu, Jan 26, 2012 at 04:04:31PM -0800, Ethan Jackson wrote: > Good catch thanks. Howd you notice this, just happened to be reading the > code? > > Ethan > > On Thu, Jan 26, 2012 at 15:51, Ben Pfaff wrote: > > NXFF_OPENFLOW10 and NXPIF_

Re: [ovs-dev] [PATCH] ofproto: Fix typo in handle_nxt_set_packet_in_format().

Good catch thanks. Howd you notice this, just happened to be reading the code? Ethan On Thu, Jan 26, 2012 at 15:51, Ben Pfaff wrote: > NXFF_OPENFLOW10 and NXPIF_OPENFLOW10 have the same value (both zero), so > this doesn't fix an actual bug. > > Signed-off-by: Ben Pfaff > --- >  ofproto/ofprot

Re: [ovs-dev] [PATCH] ovs-ctl: Restore ability to create 256 bridges.

Thanks, I pushed this to master, branch-1.4, branch-1.5. On Thu, Jan 26, 2012 at 04:00:38PM -0800, Ethan Jackson wrote: > Looks good, thanks. > > Ethan > > On Thu, Jan 26, 2012 at 15:58, Ben Pfaff wrote: > > OVS is supposed to support at least 256 bridges simultaneously, but the > > file descri

Re: [ovs-dev] [PATCH] nicira-ext: Remove duplicative error codes.

Looks good, thanks. Ethan On Thu, Jan 26, 2012 at 15:50, Ben Pfaff wrote: > The information here duplicates the information in ofp-errors.h, so remove > it from here. > > Signed-off-by: Ben Pfaff > --- >  include/openflow/nicira-ext.h |   58 > - >  1 fil

Re: [ovs-dev] [PATCH] ovs-ofctl: Fix typo in comment.

Looks good, thanks. Ethan On Thu, Jan 26, 2012 at 15:51, Ben Pfaff wrote: > Signed-off-by: Ben Pfaff > --- >  utilities/ovs-ofctl.c |    2 +- >  1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/utilities/ovs-ofctl.c b/utilities/ovs-ofctl.c > index 4164aa0..c3ffed8 100644 > ---

Re: [ovs-dev] [PATCH] ovs-ctl: Restore ability to create 256 bridges.

Looks good, thanks. Ethan On Thu, Jan 26, 2012 at 15:58, Ben Pfaff wrote: > OVS is supposed to support at least 256 bridges simultaneously, but the > file descriptor count was a little too low for that. > > Bug #8218. > Reported-by: Luca Giraudo > Signed-off-by: Ben Pfaff > --- >  utilities/ov

[ovs-dev] [PATCH] ovs-ctl: Restore ability to create 256 bridges.

OVS is supposed to support at least 256 bridges simultaneously, but the file descriptor count was a little too low for that. Bug #8218. Reported-by: Luca Giraudo Signed-off-by: Ben Pfaff --- utilities/ovs-ctl.in |9 + 1 files changed, 5 insertions(+), 4 deletions(-) diff --git a/ut

[ovs-dev] [async-msgs 13/13] vswitchd: Add "enable-async-messages" setting for controllers.

An OpenFlow connection can start receiving asynchronous messages such as "packet-ins" immediately at connect time. If there is a lot of traffic on the network then this can swamp the controller before it gets a chance to set up an initial flow table. This setting overrides this OpenFlow behavior,

[ovs-dev] [async-msgs 12/13] ofproto: Implement OpenFlow extension to allow control over async messages.

Until now, the rules that cover the asynchronous messages that Open vSwitch sends to a controller have been ad hoc. The new NXT_SET_ASYNC_CONFIG message provides systematic, precise control. Feature #7086. Signed-off-by: Ben Pfaff --- DESIGN| 50 +- NEWS

[ovs-dev] [async-msgs 11/13] ovs-ofctl: New "ofctl/barrier" unixctl command.

This will be useful in upcoming unit tests for ensuring that all asynchronous messages due to previous actions have arrived. Signed-off-by: Ben Pfaff --- utilities/ovs-ofctl.8.in |5 + utilities/ovs-ofctl.c| 42 ++ 2 files changed, 47 inserti

[ovs-dev] [async-msgs 10/13] ofp-util: New function ofputil_encode_barrier_request().

This new function will acquire a new user in an upcoming commit. Signed-off-by: Ben Pfaff --- lib/ofp-util.c |9 + lib/ofp-util.h |2 ++ lib/vconn.c|4 ++-- 3 files changed, 13 insertions(+), 2 deletions(-) diff --git a/lib/ofp-util.c b/lib/ofp-util.c index 8bfaddf..fc57

[ovs-dev] [async-msgs 09/13] ovs-ofctl: New "ofctl/set-output-file" unixctl command.

This will be useful in unit tests, to allow switching output to a new file during "ovs-ofctl monitor" runtime. Signed-off-by: Ben Pfaff --- utilities/ovs-ofctl.8.in |5 + utilities/ovs-ofctl.c| 21 + 2 files changed, 26 insertions(+), 0 deletions(-) diff --git

[ovs-dev] [async-msgs 08/13] ovs-ofctl: New "ofctl/send" unixctl command.

I intend to use this in upcoming unit tests. Signed-off-by: Ben Pfaff --- utilities/ovs-ofctl.8.in | 15 +++-- utilities/ovs-ofctl.c| 75 +- 2 files changed, 85 insertions(+), 5 deletions(-) diff --git a/utilities/ovs-ofctl.8.in b/utilitie

[ovs-dev] [async-msgs 07/13] ovs-ofctl: Add "packet-out" command.

I don't expect this to be widely useful. An upcoming commit will add a use in unit tests. Signed-off-by: Ben Pfaff --- lib/learn.c | 23 ++- lib/ofp-parse.c | 13 + lib/ofp-parse.h |5 - utilities/ovs-ofctl.8.in |9 +

[ovs-dev] [async-msgs 06/13] Add support for parsing and printing OFPFF_* flags.

I intend to use OFPFF_SEND_FLOW_REM in upcoming unit tests. I threw in OFPFF_CHECK_OVERLAP also because it didn't cost me anything. I omitted parsing support for OFPFF_EMERG because we opposed its inclusion from the start and it was removed from OpenFlow 1.2. Signed-off-by: Ben Pfaff --- lib/o

[ovs-dev] [async-msgs 05/13] ofp-util: Add struct ofputil_packet_out, helper functions, and use it all.

This makes the ofp-util support for packet_out better match the support that ofp-util has for other OpenFlow messages. It also prepares for an upcoming patch that adds a new piece of code that generates packet_out messages. Signed-off-by: Ben Pfaff --- include/openflow/openflow.h | 10 ++-- l

[ovs-dev] [async-msgs 04/13] connmgr: Do not persist OpenFlow settings from one session to another.

Each OpenFlow session should begin fresh, with settings that are the default for OpenFlow, but the connection manager was mistakenly persisting them from one session to the next for "primary" controllers. This is a bug, but it is a long-standing one. I found the problem by inspection, not through

[ovs-dev] [async-msgs 03/13] ovs-ofctl: Allow priority and timeout to be specified on mod-flows.

These options do have an effect if the mod-flows command creates a new flow. Signed-off-by: Ben Pfaff --- lib/ofp-parse.c |4 ++-- utilities/ovs-ofctl.8.in | 21 ++--- 2 files changed, 16 insertions(+), 9 deletions(-) diff --git a/lib/ofp-parse.c b/lib/ofp-parse.c

[ovs-dev] [async-msgs 02/13] DESIGN: Document the properties of flow_mods.

I'm tired of trying to figure these out all over again each time I think about it. Signed-off-by: Ben Pfaff --- DESIGN | 71 1 files changed, 71 insertions(+), 0 deletions(-) diff --git a/DESIGN b/DESIGN index c53a8ea..13f3e9f 1

[ovs-dev] [async-msgs 00/13] allow better control over asynchronous messages

OpenFlow has a number of "asynchronous" messages that switches generate and send to controllers. Until now, control over these has been ad-hoc. This series makes it more systematic. Ben Pfaff (13): ofproto: Allow service controllers to become masters and slaves. DESIGN: Document the propertie

[ovs-dev] [async-msgs 01/13] ofproto: Allow service controllers to become masters and slaves.

I don't remember why we disallow this. It seems reasonable to me to enable it. A test in a upcoming commit relies upon the ability. Signed-off-by: Ben Pfaff --- ofproto/ofproto.c |4 1 files changed, 0 insertions(+), 4 deletions(-) diff --git a/ofproto/ofproto.c b/ofproto/ofproto.c i

[ovs-dev] [PATCH] ovs-ofctl: Fix typo in comment.

Signed-off-by: Ben Pfaff --- utilities/ovs-ofctl.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/utilities/ovs-ofctl.c b/utilities/ovs-ofctl.c index 4164aa0..c3ffed8 100644 --- a/utilities/ovs-ofctl.c +++ b/utilities/ovs-ofctl.c @@ -61,7 +61,7 @@ VLOG_DEFINE_THIS_MODUL

[ovs-dev] [PATCH] ofproto: Fix typo in handle_nxt_set_packet_in_format().

NXFF_OPENFLOW10 and NXPIF_OPENFLOW10 have the same value (both zero), so this doesn't fix an actual bug. Signed-off-by: Ben Pfaff --- ofproto/ofproto.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/ofproto/ofproto.c b/ofproto/ofproto.c index 0504026..7fa4eac 100644 --

[ovs-dev] [PATCH] nicira-ext: Add size check for struct nx_role_request.

We try to have such a size check every protocol structure. Signed-off-by: Ben Pfaff --- include/openflow/nicira-ext.h |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/include/openflow/nicira-ext.h b/include/openflow/nicira-ext.h index 6921803..62180a7 100644 --- a/include

[ovs-dev] [PATCH] tests: Run ovs-ofctl under valgrind too, with the "check-valgrind" target.

I think that this was just an oversight. Signed-off-by: Ben Pfaff --- tests/automake.mk |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/tests/automake.mk b/tests/automake.mk index 9ae4c5c..bb03dd4 100644 --- a/tests/automake.mk +++ b/tests/automake.mk @@ -69,6 +69,7 @@

[ovs-dev] [PATCH] ovs-ofctl: Update usage message.

Some commands weren't mentioned. The "invalid_ttl" option to "monitor" was missing. Signed-off-by: Ben Pfaff --- utilities/ovs-ofctl.c |5 - 1 files changed, 4 insertions(+), 1 deletions(-) diff --git a/utilities/ovs-ofctl.c b/utilities/ovs-ofctl.c index 8a8b8b2..4164aa0 100644 --- a/u

[ovs-dev] [PATCH] vswitch.xml: More readably indent one section.

--- vswitchd/vswitch.xml | 40 +++- 1 files changed, 23 insertions(+), 17 deletions(-) diff --git a/vswitchd/vswitch.xml b/vswitchd/vswitch.xml index 8c506e4..4b99b99 100644 --- a/vswitchd/vswitch.xml +++ b/vswitchd/vswitch.xml @@ -2338,23 +2338,29 @@

[ovs-dev] [PATCH] nicira-ext: Remove duplicative error codes.

The information here duplicates the information in ofp-errors.h, so remove it from here. Signed-off-by: Ben Pfaff --- include/openflow/nicira-ext.h | 58 - 1 files changed, 0 insertions(+), 58 deletions(-) diff --git a/include/openflow/nicira-ext.h b/in

Re: [ovs-dev] [PATCH] bond: Allow users to disable rebalancing.

On Wed, Jan 25, 2012 at 06:12:25PM -0800, Ethan Jackson wrote: > Bond rebalances come with a risk of packet reordering which some > users may find unacceptable. > > Requested-by: Ben Basler > Signed-off-by: Ethan Jackson Add a NEWS item? s/an load balanced/a load balanced/ in vswitch.xml I ha