Thanks,
I fixed and pushed patch to master.
--Pravin.
On Fri, Jan 13, 2012 at 5:17 PM, Ben Pfaff wrote:
> In the new documentation, invalid_ttl should be bold instead of
> italic, because it is a literal string. If you fix that, then this
> looks good. Thank you!
>
> On Fri, Jan 13, 2012 at 05
On Fri, Jan 13, 2012 at 5:18 PM, Ben Pfaff wrote:
> On Fri, Jan 13, 2012 at 05:17:06PM -0800, Jesse Gross wrote:
>> We support Linux 3.2 and all of its patch levels but the current
>> check only allows for 3.2.0.
>>
>> Reported-by: Justin Pettit
>> Signed-off-by: Jesse Gross
>
> Looks good to me
On Fri, Jan 13, 2012 at 05:17:06PM -0800, Jesse Gross wrote:
> We support Linux 3.2 and all of its patch levels but the current
> check only allows for 3.2.0.
>
> Reported-by: Justin Pettit
> Signed-off-by: Jesse Gross
Looks good to me.
___
dev mailin
We support Linux 3.2 and all of its patch levels but the current
check only allows for 3.2.0.
Reported-by: Justin Pettit
Signed-off-by: Jesse Gross
---
datapath/datapath.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/datapath/datapath.c b/datapath/datapath.c
index 9
In the new documentation, invalid_ttl should be bold instead of
italic, because it is a literal string. If you fix that, then this
looks good. Thank you!
On Fri, Jan 13, 2012 at 05:13:48PM -0800, Pravin B Shelar wrote:
> Fixed according to comments from Ben.
>
> v2-v3:
> - Updated ovs-o
Fixed according to comments from Ben.
v2-v3:
- Updated ovs-ofctl monitor documentation.
v1-v2:
- Fixed man page
- Added invalid-ttl arg for ofctl-monitor.
- Added invalid-ttl packet-in test case.
--8<--cut here-->8-
F
Signed-off-by: Ben Pfaff
---
lib/automake.mk|4 +-
lib/heap.c | 216 ++
lib/heap.h | 163 +
tests/.gitignore |1 +
tests/automake.mk |7 +
tests/heap.at | 13 ++
tests/test-heap.c | 504 +
This will allow the upcoming flow table eviction policy code to determine
which flows will expire soon.
Signed-off-by: Ben Pfaff
---
NEWS |3 +++
ofproto/ofproto-dpif.c | 15 +--
ofproto/ofproto-provider.h |6 --
ofproto/ofproto.c |
This is our customary way to implement a "destroy" function. It allows
a minor simplification in ofoperation_complete().
Signed-off-by: Ben Pfaff
---
ofproto/ofproto.c | 10 +-
1 files changed, 5 insertions(+), 5 deletions(-)
diff --git a/ofproto/ofproto.c b/ofproto/ofproto.c
index c
Nothing uses op->victim following this assignment, so it is not
needed.
Signed-off-by: Ben Pfaff
---
ofproto/ofproto.c |1 -
1 files changed, 0 insertions(+), 1 deletions(-)
diff --git a/ofproto/ofproto.c b/ofproto/ofproto.c
index ff356f4..cc309b3 100644
--- a/ofproto/ofproto.c
+++ b/ofprot
A "hidden" table is one that OpenFlow operations affect only if the
table_id is explicitly specified, that is, operations that affect
all tables ignore it.
A "read-only" table is one that OpenFlow operations are not allowed
to modify.
I intend to use these flags in an upcoming commit for implemen
If the ->construct() function initializes the OpenFlow tables itself,
then it can conveniently do implementation-specific configuration of
those tables afterward. There isn't any such configuration to do yet;
an upcoming commit will add some.
Signed-off-by: Ben Pfaff
---
ofproto/ofproto-dpif.c
So far, each OpenFlow table has just been a classifier. Upcoming
commits will add more data for each OpenFlow table, so this commit
encapsulates the struct classifier in a higher-level structure
to provide a good place to keep that data.
Some of the new functions introduced in this commit are tri
An upcoming commit has a new use for the time at which OVS started up, so
this moves this functionality to a common location.
Signed-off-by: Ben Pfaff
---
lib/timeval.c | 20 +++-
lib/timeval.h |4 +++-
lib/vlog.c|8 ++--
3 files changed, 20 insertions(+), 12 de
Signed-off-by: Ben Pfaff
---
lib/util.c | 46 +-
lib/util.h |4 +++-
2 files changed, 48 insertions(+), 2 deletions(-)
diff --git a/lib/util.c b/lib/util.c
index 7114d9f..e52c526 100644
--- a/lib/util.c
+++ b/lib/util.c
@@ -1,5 +1,5 @@
/*
- * Co
bitwise_copy() is generally useful so make it a general utility function.
Also add a comment.
Upcoming commits will introduce users for the new functions.
---
lib/nx-match.c | 54 +
lib/util.c | 106
lib/u
This series adds support for limiting the size of a flow table,
with optional intelligent eviction of flows when the maximum size
is exceeded.
Ben Pfaff (12):
util: Move bitwise_copy() here, add new bitwise functions.
util: New function bitwise_zero().
meta-flow: New "subfield" data structur
Looks like this will be pretty useful.
In facet_check_consistency()
Is facet_revalidate the appropriate coverage counter to increment?
When rule != facet->rule we don't initialize the dynamic string.
I think the code only warns when installable facets aren't installed,
not when un-installable face
You're right. Thanks, I fixed that and pushed.
On Fri, Jan 13, 2012 at 03:30:40PM -0800, Ansis Atteka wrote:
> Looks, good but given example expands to "other-config=0=x
> other-config=1=y" instead of "other-config=0=x other-config=0=y" , right?
>
>
> On Fri, Jan 13, 2012 at 3:10 PM, Ben Pfaff
Looks, good but given example expands to "other-config=0=x
other-config=1=y" instead of "other-config=0=x other-config=0=y" , right?
On Fri, Jan 13, 2012 at 3:10 PM, Ben Pfaff wrote:
> Signed-off-by: Ben Pfaff
> ---
> utilities/ovs-vsctl.8.in |6 --
> 1 files changed, 4 insertions(+),
Signed-off-by: Ben Pfaff
---
utilities/ovs-vsctl.8.in |6 --
1 files changed, 4 insertions(+), 2 deletions(-)
diff --git a/utilities/ovs-vsctl.8.in b/utilities/ovs-vsctl.8.in
index a4a6766..d3d8849 100644
--- a/utilities/ovs-vsctl.8.in
+++ b/utilities/ovs-vsctl.8.in
@@ -558,8 +558,10 @@
Looks good.
Ethan
On Tue, Dec 27, 2011 at 13:28, Ben Pfaff wrote:
> It's redundant to pass both a facet or subfacet and an ofproto_dpif,
> because the latter can be derived from the former.
>
> Signed-off-by: Ben Pfaff
> ---
> ofproto/ofproto-dpif.c | 138
> +-
That patch was already committed a month ago.
Thanks,
Ben.
On Fri, Jan 13, 2012 at 01:46:09PM -0800, Ethan Jackson wrote:
> Looks good to me.
>
> Ethan
>
> On Mon, Dec 12, 2011 at 09:43, Ben Pfaff wrote:
> > sFlow licensing information was omitted from debian/copyright due to an
> > oversight
Looks good to me.
Ethan
On Mon, Dec 12, 2011 at 09:43, Ben Pfaff wrote:
> sFlow licensing information was omitted from debian/copyright due to an
> oversight. This commit adds it.
>
> Reported-by: Chris Wright
> Signed-off-by: Ben Pfaff
> ---
> debian/copyright.in | 508
> +
Looks good.
Ethan
On Fri, Jan 13, 2012 at 13:31, Ben Pfaff wrote:
> Found by valgrind.
>
> Signed-off-by: Ben Pfaff
> ---
> lib/netdev-dummy.c | 6 --
> 1 files changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/lib/netdev-dummy.c b/lib/netdev-dummy.c
> index 94dea76..d94af41 100
Found by valgrind.
Signed-off-by: Ben Pfaff
---
lib/netdev-dummy.c |6 --
1 files changed, 4 insertions(+), 2 deletions(-)
diff --git a/lib/netdev-dummy.c b/lib/netdev-dummy.c
index 94dea76..d94af41 100644
--- a/lib/netdev-dummy.c
+++ b/lib/netdev-dummy.c
@@ -1,5 +1,5 @@
/*
- * Copyrig
Here's a version which incorporates your suggestions.
---
As promised, post version 1.4 the default bond_mode is changing to
active-backup with this commit.
Signed-off-by: Ethan Jackson
---
NEWS |3 +++
tests/lacp.at|1 -
vswitchd/bridge.c| 10 +-
v
Here's the original version of the patch that I'd written. I had remvoed the
LACP_CONFIGURED enum because I don't think it's strictly necessary. The same
behavior can be achieved by dropping all traffic on non-enabled slaves in the
admissibility function. However, I think this patch is *much* ea
This will make Debian upgrade consistent with Xenserver
and RH where user must manually run force-reload-kmod
command after the upgrade.
Issue: 9128
Signed-off-by: Ansis Atteka
Reported-by: Michael Kruze
---
debian/openvswitch-switch.postinst |6 ++
debian/rules |
On Thu, Jan 12, 2012 at 06:04:47PM -0800, Pravin B Shelar wrote:
> Fixed according to comments from Ben.
>
> v1-v2:
> - Fixed man page
> - Added invalid-ttl arg for ofctl-monitor.
> - Added invalid-ttl packet-in test case.
It looks good. The only additional comment I have
30 matches
Mail list logo
