Re: [ovs-dev] [PATCH] docs: New 'man-pdf' Makefile target to generate PDF versions of manpages.

2012-01-10 Thread Romain Lenglet
Why do you use a custom target instead of the standard "pdf" target? http://www.gnu.org/prep/standards/standards.html#Standard-Targets The standard place to install PDF documentation (only by the standard "install-pdf" target, not the general "install") is $(pdfdir), which by default correspond

[ovs-dev] aki as fotos do reveillon

2012-01-10 Thread Juliana
Title: %ID% Corpo da mensagemEi so agora tive tempoEstou lhe enviando as fotos que estavam na camera..Fotos.040013Link verificado por GoogleSeguança ™ Link SEGURO ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/d

[ovs-dev] [PATCH] ofproto-dpif: Honor statistics in packet_out().

2012-01-10 Thread Ethan Jackson
Reported-by: Jesse Gross Signed-off-by: Ethan Jackson --- Jesse tested this, I've only compiled it. --- ofproto/ofproto-dpif.c | 12 +--- 1 files changed, 9 insertions(+), 3 deletions(-) diff --git a/ofproto/ofproto-dpif.c b/ofproto/ofproto-dpif.c index f5280ff..bcdb1d3 100644 --- a

Re: [ovs-dev] [PATCH] ovsdb-tool: Use typical db and schema install locations as defaults.

2012-01-10 Thread Ethan Jackson
Looks good. Ethan On Wed, Nov 30, 2011 at 14:09, Ben Pfaff wrote: > This makes ovsdb-tool easier to use in the common case. > > Requested-by: Reid Price > Feature #7756. > --- >  NEWS                  |    3 +- >  ovsdb/ovsdb-tool.1.in |   28 ++- >  ovsdb/ovsdb-tool.c    |  129 > +

Re: [ovs-dev] [PATCH] news: Mention NXM_PACKET_IN.

2012-01-10 Thread Ethan Jackson
Thanks, I've pushed this. Ethan On Tue, Jan 10, 2012 at 18:02, Ben Pfaff wrote: > On Tue, Jan 10, 2012 at 05:27:24PM -0800, Ethan Jackson wrote: >> Signed-off-by: Ethan Jackson > > Looks good, thank you. ___ dev mailing list dev@openvswitch.org http:/

Re: [ovs-dev] [PATCH] news: Mention NXM_PACKET_IN.

2012-01-10 Thread Ben Pfaff
On Tue, Jan 10, 2012 at 05:27:24PM -0800, Ethan Jackson wrote: > Signed-off-by: Ethan Jackson Looks good, thank you. ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

Re: [ovs-dev] [PATCH 2/2] ovs-vsctl: Add set relational operators to "find" command.

2012-01-10 Thread Ethan Jackson
Looks good. In the tests I think it would be a good idea to add a comment explaining why there are so many blank lines in the "database commands -- conditions" test. Someone is going to think it's a mistake and delete some. Ethan On Wed, Nov 30, 2011 at 10:45, Ben Pfaff wrote: > Requested-by:

Re: [ovs-dev] [PATCH 1/2] ovsdb-data: Short-circuit ovsdb_datum_includes_all() in trivial case.

2012-01-10 Thread Ethan Jackson
Looks good, I'm assuming that the same element can't be in 'a' twice. What prompted this? Was it causing a performance problem, or did you notice it by inspection? Ethan On Wed, Nov 30, 2011 at 10:45, Ben Pfaff wrote: > --- >  lib/ovsdb-data.c |    3 +++ >  1 files changed, 3 insertions(+), 0

[ovs-dev] [PATCH] news: Mention NXM_PACKET_IN.

2012-01-10 Thread Ethan Jackson
Signed-off-by: Ethan Jackson --- NEWS |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/NEWS b/NEWS index 332d740..5b26810 100644 --- a/NEWS +++ b/NEWS @@ -3,6 +3,7 @@ port-v1.4.0 - OpenFlow: - Added support for querying, modifying, and deleting flows

Re: [ovs-dev] [PATCH] docs: New 'man-pdf' Makefile target to generate PDF versions of manpages.

2012-01-10 Thread Ethan Jackson
Looks good. Ethan On Mon, Nov 28, 2011 at 15:26, Ben Pfaff wrote: > It might be nice to actually install these, but there's no standard place > to install them.  Nevertheless, it's nice to have the target around > because it shows how to generate PDFs.  It should make it easier for me to > regen

Re: [ovs-dev] [PATCH] datapath: Fix multipart datapath dumps.

2012-01-10 Thread Jesse Gross
On Tue, Jan 10, 2012 at 4:52 PM, Ben Pfaff wrote: > The logic to split up the list of datapaths into multiple Netlink messages > was simply wrong, causing the list to be terminated after the first part. > Only about the first 50 datapaths would be dumped.  This fixes the > problem. > > Bug #9124.

Re: [ovs-dev] [PATCH] ofproto-dpif: Restore optimization for no-actions case (without leak).

2012-01-10 Thread Ethan Jackson
The memory management in this function is a bit confusing so I had to think about it a bit, but this looks correct to me. Ethan On Tue, Jan 10, 2012 at 15:39, Ben Pfaff wrote: > Commit 968131c1809 (ofproto-dpif: Omit "execute" operation entirely when > there are no actions.) introduced an optimi

[ovs-dev] [PATCH] datapath: Fix multipart datapath dumps.

2012-01-10 Thread Ben Pfaff
The logic to split up the list of datapaths into multiple Netlink messages was simply wrong, causing the list to be terminated after the first part. Only about the first 50 datapaths would be dumped. This fixes the problem. Bug #9124. Reported-by: Paul Ingram Signed-off-by: Ben Pfaff --- datap

[ovs-dev] [PATCH] ofproto-dpif: Restore optimization for no-actions case (without leak).

2012-01-10 Thread Ben Pfaff
Commit 968131c1809 (ofproto-dpif: Omit "execute" operation entirely when there are no actions.) introduced an optimization for the case where a flow translated to ODP actions had no actions at all (i.e. the packet is to be dropped). It also introduced a memory leak (the packet was not freed). Com

Re: [ovs-dev] [packet_in v2 18/18] openflow: New Nicira Extended PACKET_IN format.

2012-01-10 Thread Ethan Jackson
Thanks for the reviews. I'll merge this. Ethan On Tue, Jan 10, 2012 at 11:43, Ben Pfaff wrote: > On Tue, Jan 10, 2012 at 11:40:31AM -0800, Ethan Jackson wrote: >> Here's an incremental. > > Thanks. > > In the new paragraph in the manpage, please bold the uses of "snoop" > and "monitor" since th

Re: [ovs-dev] [packet_in v2 18/18] openflow: New Nicira Extended PACKET_IN format.

2012-01-10 Thread Ben Pfaff
On Tue, Jan 10, 2012 at 11:40:31AM -0800, Ethan Jackson wrote: > Here's an incremental. Thanks. In the new paragraph in the manpage, please bold the uses of "snoop" and "monitor" since they are literal text. Otherwise this looks good. ___ dev mailing l

Re: [ovs-dev] [packet_in v2 18/18] openflow: New Nicira Extended PACKET_IN format.

2012-01-10 Thread Ethan Jackson
Here's an incremental. Ethan --- include/openflow/nicira-ext.h |5 ++--- lib/ofp-util.c| 37 +++-- tests/ofp-print.at| 30 ++ tests/ofproto-dpif.at |8 utilities/ovs-ofctl.8.in

Re: [ovs-dev] [PATCH] debian: Look in /lib/modules instead of /usr/src for DKMS kernel sources.

2012-01-10 Thread Ben Pfaff
Thanks. I'm going to wait a little while in the hope that Alban will confirm that this fixes the problem he reported. On Tue, Jan 10, 2012 at 10:40:20AM -0800, Ethan Jackson wrote: > I know nothing about DKMS but this looks fine to me. > > Ethan > > On Tue, Jan 10, 2012 at 10:30, Ben Pfaff wro

Re: [ovs-dev] [PATCH] debian: Ignore temporary files for openvswitch-test package too.

2012-01-10 Thread Ben Pfaff
Thanks, pushed. On Tue, Jan 10, 2012 at 10:39:03AM -0800, Ethan Jackson wrote: > Looks good. > > Ethan > > On Tue, Jan 10, 2012 at 10:31, Ben Pfaff wrote: > > Signed-off-by: Ben Pfaff > > --- > > ?debian/.gitignore | ? ?1 + > > ?1 files changed, 1 insertions(+), 0 deletions(-) > > > > diff --g

Re: [ovs-dev] [PATCH] debian: Look in /lib/modules instead of /usr/src for DKMS kernel sources.

2012-01-10 Thread Ethan Jackson
I know nothing about DKMS but this looks fine to me. Ethan On Tue, Jan 10, 2012 at 10:30, Ben Pfaff wrote: > DKMS packages usually look in /lib/modules for kernel sources, since that > is the "standard" location, but our packages was looking directly in > /usr/src.  This fixes the problem. > > R

Re: [ovs-dev] [PATCH] debian: Ignore temporary files for openvswitch-test package too.

2012-01-10 Thread Ethan Jackson
Looks good. Ethan On Tue, Jan 10, 2012 at 10:31, Ben Pfaff wrote: > Signed-off-by: Ben Pfaff > --- >  debian/.gitignore |    1 + >  1 files changed, 1 insertions(+), 0 deletions(-) > > diff --git a/debian/.gitignore b/debian/.gitignore > index 7e6d656..3e1373a 100644 > --- a/debian/.gitignore >

[ovs-dev] [PATCH] debian: Ignore temporary files for openvswitch-test package too.

2012-01-10 Thread Ben Pfaff
Signed-off-by: Ben Pfaff --- debian/.gitignore |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/debian/.gitignore b/debian/.gitignore index 7e6d656..3e1373a 100644 --- a/debian/.gitignore +++ b/debian/.gitignore @@ -17,6 +17,7 @@ /openvswitch-pki /openvswitch-switch /op

[ovs-dev] [PATCH] debian: Look in /lib/modules instead of /usr/src for DKMS kernel sources.

2012-01-10 Thread Ben Pfaff
DKMS packages usually look in /lib/modules for kernel sources, since that is the "standard" location, but our packages was looking directly in /usr/src. This fixes the problem. Reported-by: Alban Browaeys --- debian/dkms.conf.in |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff

Re: [ovs-dev] [PATCH] ovs-monitor-ipsec: Don't reconfigure cert-based authentication as often.

2012-01-10 Thread Justin Pettit
On Jan 10, 2012, at 9:45 AM, Ben Pfaff wrote: > On Mon, Jan 09, 2012 at 06:54:34PM -0800, Justin Pettit wrote: >> ovs-monitor-ipsec wakes up when the Interface table is modified. To >> prevent needless reconfiguration, it maintains a dictionary of the >> currently implemented configuration and co

Re: [ovs-dev] [PATCH] ovs-monitor-ipsec: Don't reconfigure cert-based authentication as often.

2012-01-10 Thread Ben Pfaff
On Mon, Jan 09, 2012 at 06:54:34PM -0800, Justin Pettit wrote: > ovs-monitor-ipsec wakes up when the Interface table is modified. To > prevent needless reconfiguration, it maintains a dictionary of the > currently implemented configuration and compares it to any new changes. > Unfortunately, for c