On Thu, Dec 8, 2011 at 10:48 AM, Pravin B Shelar wrote:
> diff --git a/datapath/datapath.c b/datapath/datapath.c
> index c86c20b..50fd00e 100644
> --- a/datapath/datapath.c
> +++ b/datapath/datapath.c
> +static void __rehash_flow_table(void)
> +{
> + struct datapath *dp;
> +
> + list_f
Looks good to me.
> + if (packet->size < ETH_HEADER_LEN) {
In theory, I think we would want ETH_TOTAL_MIN here. However, that
could potentially be annoying for it's only user ofproto/trace. So I
think it's fine.
Ethan
___
dev mailing list
dev@open
This looks like a huge win in terms of code cleanup. Comments below.
Why are min and max args 'int's instead of 'size_t's or 'unsigned'?
In ofproto/trace, you have a case which expects argc == 6, but you
only allow a maximum of 4 (+ 1 = 5) arguments when you register. It
looks like you are leav
Thank you, pushed to master, branch-1.4.
On Tue, Dec 13, 2011 at 02:52:49PM -0800, Justin Pettit wrote:
> Looks good. Thanks.
>
> --Justin
>
>
> On Dec 13, 2011, at 2:42 PM, Ben Pfaff wrote:
>
> > Not every port has an associated bundle, so we must not unconditionally
> > dereference ofport->
Looks good. Thanks.
--Justin
On Dec 13, 2011, at 2:42 PM, Ben Pfaff wrote:
> Not every port has an associated bundle, so we must not unconditionally
> dereference ofport->bundle without first checking that it is nonnull.
>
> (One example of a port without a bundle is a VLAN splinter port.)
>
Not every port has an associated bundle, so we must not unconditionally
dereference ofport->bundle without first checking that it is nonnull.
(One example of a port without a bundle is a VLAN splinter port.)
Bug #8671.
Reported-by: Michael Mao
Signed-off-by: Ben Pfaff
---
ofproto/ofproto-dpif.
Thanks, I added a sign-off and pushed.
On Tue, Dec 13, 2011 at 02:18:40PM -0800, Ethan Jackson wrote:
> Needs a Signed-off-by (I think). Otherwise looks good, thanks.
>
> Ethan
>
> On Tue, Dec 13, 2011 at 14:15, Ben Pfaff wrote:
> > Suggested-by: Ethan Jackson
> > ---
> > ?SubmittingPatches |
> It's already there.
Oops, I was looking at an old version. Thanks.
Ethan
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
Needs a Signed-off-by (I think). Otherwise looks good, thanks.
Ethan
On Tue, Dec 13, 2011 at 14:15, Ben Pfaff wrote:
> Suggested-by: Ethan Jackson
> ---
> SubmittingPatches | 4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/SubmittingPatches b/SubmittingPatches
>
On Tue, Dec 13, 2011 at 01:44:38PM -0800, Ethan Jackson wrote:
> Could you please update SubmittingPatches it references the old style.
OK, I sent a patch.
> Also it might make sense to note that we require Signed-off-by there
> as well.
It's already there.
_
Suggested-by: Ethan Jackson
---
SubmittingPatches |4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/SubmittingPatches b/SubmittingPatches
index f454c3a..c16673f 100644
--- a/SubmittingPatches
+++ b/SubmittingPatches
@@ -87,8 +87,8 @@ reader can see it for himself.
If
Looks good.
Ethan
On Thu, Dec 8, 2011 at 14:01, Ben Pfaff wrote:
> The "listen" system call doesn't work and isn't necessary for UDP, but
> inet_open_passive() would still try to call it (and fail).
>
> This doesn't fix a real bug because the two existing callers both use
> inet_open_passive() t
Looks good.
Ethan
On Thu, Dec 8, 2011 at 14:01, Ben Pfaff wrote:
> Found by inspection.
> ---
> lib/netdev-linux.c | 7 +--
> lib/netdev-provider.h | 3 +++
> 2 files changed, 8 insertions(+), 2 deletions(-)
>
> diff --git a/lib/netdev-linux.c b/lib/netdev-linux.c
> index 9ff286e..
> Kernel style seems to favor parentheses, which is why I've switched.
> Also, trailing periods in commit subjects look less odd in parentheses
> than in quotes.
Good enough for me. I'll switch too.
Could you please update SubmittingPatches it references the old style.
Also it might make sense
The policy has changed since you've originally submitted this series.
Please add a Signed-off-by: to each commit before merging.
Thanks,
Ethan
On Thu, Dec 8, 2011 at 14:01, Ben Pfaff wrote:
> The first patch in this series fixes flow statistics that were broken
> a while back.
>
> The rest culm
On Tue, Dec 13, 2011 at 1:24 PM, Jesse Gross wrote:
> On Tue, Dec 13, 2011 at 1:16 PM, Pravin Shelar wrote:
>> On Mon, Dec 12, 2011 at 9:58 PM, Jesse Gross wrote:
>>> On Mon, Nov 28, 2011 at 7:11 PM, Pravin B Shelar wrote:
diff --git a/datapath/linux/compat/include/net/netns/generic.h
>>>
On Tue, Dec 13, 2011 at 01:40:00PM -0800, Ethan Jackson wrote:
> Looks good.
>
> > Commit 501f8d1fd75 (ofproto-dpif: Batch interacting with the dpif on flow
> > miss operations.) caused packets handled manually in userspace not to be
>
> Looking through the logs, typically we've encased commit me
Looks good.
Ethan
On Thu, Dec 8, 2011 at 14:01, Ben Pfaff wrote:
> ---
> lib/netdev-linux.c | 4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/lib/netdev-linux.c b/lib/netdev-linux.c
> index a100898..9ff286e 100644
> --- a/lib/netdev-linux.c
> +++ b/lib/netdev-linu
Looks good.
> Commit 501f8d1fd75 (ofproto-dpif: Batch interacting with the dpif on flow
> miss operations.) caused packets handled manually in userspace not to be
Looking through the logs, typically we've encased commit message
titles in quotes instead of parenthesis. However, there are examples
On Tue, Dec 13, 2011 at 1:16 PM, Pravin Shelar wrote:
> On Mon, Dec 12, 2011 at 9:58 PM, Jesse Gross wrote:
>> On Mon, Nov 28, 2011 at 7:11 PM, Pravin B Shelar wrote:
>>> diff --git a/datapath/linux/compat/include/net/netns/generic.h
>>> b/datapath/linux/compat/include/net/netns/generic.h
>>> n
On Mon, Dec 12, 2011 at 9:58 PM, Jesse Gross wrote:
> On Mon, Nov 28, 2011 at 7:11 PM, Pravin B Shelar wrote:
>> diff --git a/datapath/datapath.c b/datapath/datapath.c
>> index 4d95e04..831318d 100644
>> --- a/datapath/datapath.c
>> +++ b/datapath/datapath.c
>> @@ -1384,6 +1386,8 @@ static int ov
> It seems reasonable to me. Ethan knows more about LACP than the rest
> of us. Ethan, do you see any problems implementing this?
It seems reasonable to me as well. Implementation should be pretty
straight forward. You will have to begin storing LACP PDU tx and rx
counters, which probably make
On Mon, Dec 12, 2011 at 08:46:25PM -0800, Neil Mckee wrote:
> The sFlow standard will soon include an option to report LACP state
> along with the periodic counter-push. It would be great for the
> Open vSwitch to include this. It is important when aggregating
> sFlow data to estimate totals, so
Hie, Hello nice to reach you..! How are you doing hope you are doing pretty
well. I'm Emily Waiser from Boston in the USA I work with YMCA as
programmer and reporter of YMCA here in Pennsylvania developing countries
of the world , i have no kids I'm 25 years of age, i just saw your profile
and it i
24 matches
Mail list logo
