Re: [ovs-dev] [PATCH] datapath: Support for network namespace.

2011-12-12 Thread Jesse Gross
On Mon, Nov 28, 2011 at 7:11 PM, Pravin B Shelar wrote: > diff --git a/datapath/datapath.c b/datapath/datapath.c > index 4d95e04..831318d 100644 > --- a/datapath/datapath.c > +++ b/datapath/datapath.c > @@ -1384,6 +1386,8 @@ static int ovs_dp_cmd_new(struct sk_buff *skb, struct > genl_info *info)

[ovs-dev] LACP and sFlow export

2011-12-12 Thread Neil Mckee
The sFlow standard will soon include an option to report LACP state along with the periodic counter-push. It would be great for the Open vSwitch to include this. It is important when aggregating sFlow data to estimate totals, so it's fundamental information to know accurately right up to th

[ovs-dev] Bug#651798: Bug#651798: Bug#651798: Fails to build against Linux 3.1

2011-12-12 Thread Simon Horman
On Mon, Dec 12, 2011 at 11:57:29AM -0800, Jesse Gross wrote: > On Mon, Dec 12, 2011 at 12:26 AM, Simon Horman wrote: > > On Mon, Dec 12, 2011 at 08:00:25AM +, Ben Hutchings wrote: > >> Since a version of Open vSwitch has been accepted for inclusion in > >> mainline Linux 3.3, perhaps it could

Re: [ovs-dev] [PATCH] dpif-linux: Avoid valgrind warning in epoll_ctl() call.

2011-12-12 Thread Ben Pfaff
Thanks, I pushed this to master. On Mon, Dec 12, 2011 at 12:55:21PM -0800, Justin Pettit wrote: > Looks good. > > --Justin > > > On Dec 9, 2011, at 3:59 PM, Ben Pfaff wrote: > > > Valgrind points out correctly that there are uninitialized bytes in the > > 'event' structure. That's OK, but it

Re: [ovs-dev] [PATCH] bridge: Enable support for access and native VLAN ports on bonds.

2011-12-12 Thread Ben Pfaff
And "branch-1.3" now that I remember that native VLANs are supported there too. On Mon, Dec 12, 2011 at 02:45:18PM -0800, Ben Pfaff wrote: > Thanks, I pushed this to "master" and "branch-1.4". > > On Mon, Dec 12, 2011 at 01:09:02PM -0800, Justin Pettit wrote: > > Looks good. > > > > --Justin > >

Re: [ovs-dev] [PATCH] bridge: Enable support for access and native VLAN ports on bonds.

2011-12-12 Thread Ben Pfaff
Thanks, I pushed this to "master" and "branch-1.4". On Mon, Dec 12, 2011 at 01:09:02PM -0800, Justin Pettit wrote: > Looks good. > > --Justin > > > On Dec 12, 2011, at 11:10 AM, Ben Pfaff wrote: > > > Since Open vSwitch's inception we've disabled the use of bonds as access > > ports, for no pa

Re: [ovs-dev] [PATCH] bridge: Enable support for access and native VLAN ports on bonds.

2011-12-12 Thread Justin Pettit
Looks good. --Justin On Dec 12, 2011, at 11:10 AM, Ben Pfaff wrote: > Since Open vSwitch's inception we've disabled the use of bonds as access > ports, for no particularly good reason. This also unintentionally > prevented bonds from being used as native VLAN ports. > > This commit removes th

Re: [ovs-dev] [PATCH] dpif-linux: Avoid valgrind warning in epoll_ctl() call.

2011-12-12 Thread Justin Pettit
Looks good. --Justin On Dec 9, 2011, at 3:59 PM, Ben Pfaff wrote: > Valgrind points out correctly that there are uninitialized bytes in the > 'event' structure. That's OK, but it doesn't hurt to suppress the warning > by zeroing all of the bytes. > > This doesn't fix a real bug. > > Signed-o

[ovs-dev] Bug#651798: Bug#651798: Bug#651798: Fails to build against Linux 3.1

2011-12-12 Thread Jesse Gross
On Mon, Dec 12, 2011 at 12:26 AM, Simon Horman wrote: > On Mon, Dec 12, 2011 at 08:00:25AM +, Ben Hutchings wrote: >> Since a version of Open vSwitch has been accepted for inclusion in >> mainline Linux 3.3, perhaps it could be included in Debian kernel >> packages starting with Linux 3.2 and

[ovs-dev] [PATCH] bridge: Enable support for access and native VLAN ports on bonds.

2011-12-12 Thread Ben Pfaff
Since Open vSwitch's inception we've disabled the use of bonds as access ports, for no particularly good reason. This also unintentionally prevented bonds from being used as native VLAN ports. This commit removes the code that prevented using bonds these ways Reported-by: "Michael A. Collins" S

Re: [ovs-dev] [PATCH 1/2] debian: Correct licensing information for user/kernel shared header files.

2011-12-12 Thread Ben Pfaff
On Mon, Dec 12, 2011 at 10:06:43AM -0800, Justin Pettit wrote: > On Dec 12, 2011, at 9:43 AM, Ben Pfaff wrote: > > > * The following components are dual-licensed under the > > - GNU General Public Licence version 3 and the Apache Licence Version 2.0. > > + GNU General Public Licence version 2 an

Re: [ovs-dev] [PATCH 1/2] debian: Correct licensing information for user/kernel shared header files.

2011-12-12 Thread Justin Pettit
On Dec 12, 2011, at 9:43 AM, Ben Pfaff wrote: > * The following components are dual-licensed under the > - GNU General Public Licence version 3 and the Apache Licence Version 2.0. > + GNU General Public Licence version 2 and the Apache Licence Version 2.0. This is very minor but we have a spri

[ovs-dev] Bug#651798: Bug#651798: Fails to build against Linux 3.1

2011-12-12 Thread Ben Pfaff
On Mon, Dec 12, 2011 at 08:00:25AM +, Ben Hutchings wrote: > Package: openvswitch-datapath-source > Version: 1.2.2-2 > Severity: grave > > This module fails to build against Linux 3.1: The correct solution is just to upgrade the Debian package to Open vSwitch 1.3.0, which does support Linux 3

Re: [ovs-dev] Statistics Collection Performance Impact

2011-12-12 Thread Ben Pfaff
On Sun, Dec 11, 2011 at 11:20:50AM +0900, Simon Horman wrote: > sorry for the long delay. I finally had a stab at implementing this idea > but as yet it does not seem to be working. > > My implementation simply keeps track of a static struct dpif_flow_dump dump > in update_stats() and resets it as

[ovs-dev] [PATCH 2/2] debian: Add sFlow license information and text to copyright.in.

2011-12-12 Thread Ben Pfaff
sFlow licensing information was omitted from debian/copyright due to an oversight. This commit adds it. Reported-by: Chris Wright Signed-off-by: Ben Pfaff --- debian/copyright.in | 508 +++ 1 files changed, 508 insertions(+), 0 deletions(-) dif

[ovs-dev] [PATCH 1/2] debian: Correct licensing information for user/kernel shared header files.

2011-12-12 Thread Ben Pfaff
The intent is to license all shared user/kernel header files under both GPLv2 and Apache v2. The license statement here said GPLv3 instead of GPLv2, so this commit fixes that problem. Also, include/openvswitch used to be where all the shared user/kernel header files were located, but this is no l

[ovs-dev] Bug#651798: Bug#651798: Fails to build against Linux 3.1

2011-12-12 Thread Simon Horman
On Mon, Dec 12, 2011 at 08:00:25AM +, Ben Hutchings wrote: > Package: openvswitch-datapath-source > Version: 1.2.2-2 > Severity: grave > > This module fails to build against Linux 3.1: > > make[3]: Entering directory `/usr/src/linux-headers-3.1.0-1-amd64' > /usr/src/linux-headers-3.1.0-1-comm

[ovs-dev] Bug#651798: Fails to build against Linux 3.1

2011-12-12 Thread Ben Hutchings
Package: openvswitch-datapath-source Version: 1.2.2-2 Severity: grave This module fails to build against Linux 3.1: make[3]: Entering directory `/usr/src/linux-headers-3.1.0-1-amd64' /usr/src/linux-headers-3.1.0-1-common/arch/x86/Makefile:81: stack protector enabled but no compiler support CC