The commit 0993b66 (man: pic failed to run during manpage-check) worked
around the manpage-check warning generated by groff. Using "-T ascii"
rather "-T utf8" was enough to silence the warning because the man page
has this condition in it:
.if !'\*[.T]'ascii'
However, rpmlint generates the sam
This is in repsonse to the following rpmlint warnings:
W: non-conffile-in-etc
/etc/openvswitch/bugtool-plugins/system-configuration/openvswitch.xml
W: non-conffile-in-etc
/etc/openvswitch/bugtool-plugins/system-logs/openvswitch.xml
W: non-conffile-in-etc
/etc/openvswitch/bugtool-plugins/syst
Rename this helper script to simply ovs-lib, since it's primarily
a library of helper functions.
Signed-off-by: Chris Wright
---
debian/openvswitch-switch.init |2 +-
debian/openvswitch-switch.install |2 +-
rhel/etc_init.d_openvswitch |2 +-
rhel/openvswit
Currently, ovs-lib.sh is installed as an executable. It's meant to be
sourced by external scripts, so install as data. Fixes rpmlint error:
E: script-without-shebang /usr/share/openvswitch/scripts/ovs-lib.sh
Could drop the .sh suffix in another commit.
Signed-off-by: Chris Wright
---
Makefi
Fixes rpmlint warning:
W: spurious-executable-perm /etc/logrotate.d/openvswitch
W: non-conffile-in-etc /etc/logrotate.d/openvswitch
E: script-without-shebang /usr/share/openvswitch/scripts/sysconfig.template
Define rhel_cp() shell func and include file mode on install.
Signed-off-by: Chris Wr
This quiets the rpmlint errors:
E: incorrect-fsf-address
/etc/openvswitch/bugtool-plugins/system-configuration/openvswitch.xml
E: incorrect-fsf-address
/etc/openvswitch/bugtool-plugins/system-logs/openvswitch.xml
E: incorrect-fsf-address
/etc/openvswitch/bugtool-plugins/system-configuration.x
Here's a short series of small cleanups that have come from packaging
openvswitch for Fedora. Nothing terribly exciting here, the last two
may not be to everyone's taste. I'm happy to rework if needed.
Chris Wright (7):
Update FSF address in LGPL notices in bugtool plugins.
rhel: openvswitch
Fix this rpmlint warning:
W: spurious-executable-perm /usr/share/doc/openvswitch-1.4.0/README.RHEL
by specifying mode on install.
Signed-off-by: Chris Wright
---
rhel/openvswitch.spec.in |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/rhel/openvswitch.spec.in b/rhel/
CONTACT FOR A LOAN WITH AMOUNT NEEDED AND DURATION___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
There is a typo in function workqueue_barrier() where it inserts wrong
'work' to workq.
Thanks,
Pravin.
On Thu, Dec 8, 2011 at 10:48 AM, Pravin B Shelar wrote:
> Fixed according to comments from Jesse.
> v1-v2:
> - uses genl_mutex to protect flow-hash-table.
> - adds REHASH cmd to
These tests would have caught the flow statistics bug introduced by commit
501f8d1fd75 (ofproto-dpif: Batch interacting with the dpif on flow miss
operations.)
---
tests/automake.mk |4 +
tests/ofproto-dpif.at | 128 +++
tests/test-netflow.c | 323 +++
An upcoming commit will introduce code outside of ofproto/netflow.c that
works with NetFlow packets, so we need the protocol definitions in a common
location.
---
lib/automake.mk |1 +
lib/netflow.h | 80 +
ofproto/netflow.c | 57 +-
It's convenient to pass commands for ovs-vsctl directly to
OVS_VSWITCHD_START, but until now those commands could have no output
because that would cause a test failure. This commit adds an optional
argument to supply ovs-vsctl expected output, and adjusts some test
cases to use it instead of call
Commit 579a77e024 (tests: Allow unit tests to run as root.) means that
ovs-vswitchd doesn't output either of these log messages anymore when
the unit tests run, so there's no need to ignore them anymore.
---
tests/ofproto-macros.at |2 --
1 files changed, 0 insertions(+), 2 deletions(-)
diff
This makes flow_extract() happier with TCP packets that this function
produces.
---
lib/flow.c|3 +++
lib/packets.h |1 +
2 files changed, 4 insertions(+), 0 deletions(-)
diff --git a/lib/flow.c b/lib/flow.c
index a491aff..a352f07 100644
--- a/lib/flow.c
+++ b/lib/flow.c
@@ -1020,6 +1
---
lib/dummy.h |3 ++-
lib/timeval.c | 54 ++
2 files changed, 56 insertions(+), 1 deletions(-)
diff --git a/lib/dummy.h b/lib/dummy.h
index fe15087..efc1696 100644
--- a/lib/dummy.h
+++ b/lib/dummy.h
@@ -1,5 +1,5 @@
/*
- * Copyright (
This is a necessary prerequisite for allowing time to be "fast forwarded"
in unit tests, to keep tests that depend on the passage of time from
running in real time. Without this change, a code sequence like this:
poll_timer_wait(1000);
...fast forward time 5 seconds...
pol
This paves the way to allow unit tests to test the whole switch
on an end-to-end basis.
---
lib/dummy.c|3 +-
lib/netdev-dummy.c | 161
2 files changed, 152 insertions(+), 12 deletions(-)
diff --git a/lib/dummy.c b/lib/dummy.c
inde
An upcoming commit will add another user.
---
lib/packets.c | 25 +
lib/packets.h |2 ++
ofproto/ofproto-dpif.c | 12
3 files changed, 31 insertions(+), 8 deletions(-)
diff --git a/lib/packets.c b/lib/packets.c
index 46a44bd..b9f37bb
The protocol used by ovs-appctl has a long-standing bug that there
is no way to distinguish "ovs-appctl a b c" from "ovs-appctl 'a b c'".
This isn't a big deal because none of the current commands really
want to accept arguments that include spaces, but it's kind of a silly
limitation.
At the same
The "listen" system call doesn't work and isn't necessary for UDP, but
inet_open_passive() would still try to call it (and fail).
This doesn't fix a real bug because the two existing callers both use
inet_open_passive() to listen for TCP connections.
---
lib/socket-util.c |2 +-
1 files chang
Found by inspection.
---
lib/netdev-linux.c|7 +--
lib/netdev-provider.h |3 +++
2 files changed, 8 insertions(+), 2 deletions(-)
diff --git a/lib/netdev-linux.c b/lib/netdev-linux.c
index 9ff286e..27a123c 100644
--- a/lib/netdev-linux.c
+++ b/lib/netdev-linux.c
@@ -802,8 +802,11
---
lib/netdev-linux.c |4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/lib/netdev-linux.c b/lib/netdev-linux.c
index a100898..9ff286e 100644
--- a/lib/netdev-linux.c
+++ b/lib/netdev-linux.c
@@ -1244,8 +1244,8 @@ get_stats_via_vport(const struct netdev *netdev_,
Commit 501f8d1fd75 (ofproto-dpif: Batch interacting with the dpif on flow
miss operations.) caused packets handled manually in userspace not to be
counted in flow statistics. This patch fixes the problem.
---
ofproto/ofproto-dpif.c |8
1 files changed, 8 insertions(+), 0 deletions(-)
The first patch in this series fixes flow statistics that were broken
a while back.
The rest culminates in adding basic unit tests for NetFlow, which is
the context in which the incorrect flow statistics was first noticed.
Ben Pfaff (14):
ofproto-dpif: Include datapath flow misses in flow stati
Thanks,
I pushed this series to master.
On Thu, Dec 8, 2011 at 1:18 PM, Ben Pfaff wrote:
> Looks good, thanks.
>
> On Thu, Dec 08, 2011 at 01:17:56PM -0800, Pravin B Shelar wrote:
>> Here's incremental patch.
>> ---
>> ofproto/ofproto-dpif.c | 1 +
>> 1 files changed, 1 insertions(+), 0 dele
Signed-off-by: Jesse Gross
---
I applied this patch directly.
---
datapath/linux/Modules.mk |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/datapath/linux/Modules.mk b/datapath/linux/Modules.mk
index fdd952e..f6cb88e 100644
--- a/datapath/linux/Modules.mk
+++ b/datapath/
On Dec 6, 2011, at 2:18 PM, Luca Giraudo wrote:
> Hi Neil,
> replies in-line.
>
> On Tue, Dec 6, 2011 at 1:43 PM, Neil Mckee wrote:
> Hi Luca,
>
> Just checking does this mean that the sFlow-agent-address might change
> just because the first collector in the list changed? Or because th
Looks good, thanks.
On Thu, Dec 08, 2011 at 01:17:56PM -0800, Pravin B Shelar wrote:
> Here's incremental patch.
> ---
> ofproto/ofproto-dpif.c |1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/ofproto/ofproto-dpif.c b/ofproto/ofproto-dpif.c
> index 14cdeee..1b654fd 1
Here's incremental patch.
---
ofproto/ofproto-dpif.c |1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/ofproto/ofproto-dpif.c b/ofproto/ofproto-dpif.c
index 14cdeee..1b654fd 100644
--- a/ofproto/ofproto-dpif.c
+++ b/ofproto/ofproto-dpif.c
@@ -670,6 +670,7 @@ construct(struct
On Thu, Dec 08, 2011 at 12:53:45PM -0800, Pravin B Shelar wrote:
> Fixed according to comments from Ben.
> v1-v2:
> - removed netdev and odp_port from struct dpif_sflow_port.
Thank you, this looks good to me.
___
dev mailing list
dev@openvswitch.
On Thu, Dec 08, 2011 at 12:53:33PM -0800, Pravin B Shelar wrote:
> Fixed according to comments from Ben.
> v1-v2:
> - updated comments
> - added UINT64_MAX check before updating stats
> - removed memset from ofproto_port_get_stats()
Looking again, I think you also need to z
Fixed according to comments from Ben.
v1-v2:
- removed netdev and odp_port from struct dpif_sflow_port.
--8<--cut here-->8--
---
ofproto/ofproto-dpif-sflow.c | 46 +++--
ofproto/ofproto-dpif-sflow.h |
Fixed according to comments from Ben.
v1-v2:
- updated comments
- added UINT64_MAX check before updating stats
- removed memset from ofproto_port_get_stats()
--8<--cut here-->8--
Following patch account packets consumed and c
On Thu, Dec 8, 2011 at 11:34 AM, Ben Pfaff wrote:
> On Thu, Dec 08, 2011 at 11:30:27AM -0800, Pravin Shelar wrote:
>> On Fri, Dec 2, 2011 at 2:38 PM, Ben Pfaff wrote:
>> > On Fri, Dec 02, 2011 at 02:17:04PM -0800, Pravin B Shelar wrote:
>> >> Following patch account packets consumed and composed
On Thu, Dec 08, 2011 at 11:30:27AM -0800, Pravin Shelar wrote:
> On Fri, Dec 2, 2011 at 2:38 PM, Ben Pfaff wrote:
> > On Fri, Dec 02, 2011 at 02:17:04PM -0800, Pravin B Shelar wrote:
> >> Following patch account packets consumed and composed in userspace
> >> as received on and transmitted from lo
On Fri, Dec 2, 2011 at 2:38 PM, Ben Pfaff wrote:
> On Fri, Dec 02, 2011 at 02:17:04PM -0800, Pravin B Shelar wrote:
>> Following patch account packets consumed and composed in userspace
>> as received on and transmitted from local port.
>
> It looks good to me, I only have two small comments.
>
>
Fixed according to comments from Jesse.
v1-v2:
- uses genl_mutex to protect flow-hash-table.
- adds REHASH cmd to dp_datapath_genl_ops so that we can
rehash flow-table holding genl_mutex.
--8<--cut here-->8--
Following patc
38 matches
Mail list logo
