Re: [ovs-dev] [PATCH] Better abstract OpenFlow error codes.

2011-12-07 Thread Reid Price
On Wed, Dec 7, 2011 at 8:19 PM, Ben Pfaff wrote: > On Tue, Nov 29, 2011 at 10:36:35PM -0800, Ben Pfaff wrote: > > This commit switches from using the actual protocol values of error codes > > internally in Open vSwitch, to using abstract values that are translated > to > > and from protocol value

[ovs-dev] Call for assistance: OpenFlow 1.1 and 1.2 support in Open vSwitch

2011-12-07 Thread Ben Pfaff
OpenFlow 1.1 was released about 9 months ago. Open vSwitch doesn't yet have support for this protocol version. Furthermore, OpenFlow 1.2 will likely be released by the end of 2011. We would love to work with the OpenFlow community to make sure OVS supports current and future versions of OpenFlow

Re: [ovs-dev] [PATCH] Better abstract OpenFlow error codes.

2011-12-07 Thread Ben Pfaff
On Tue, Nov 29, 2011 at 10:36:35PM -0800, Ben Pfaff wrote: > This commit switches from using the actual protocol values of error codes > internally in Open vSwitch, to using abstract values that are translated to > and from protocol values at message parsing and serialization time. I > believe tha

Re: [ovs-dev] [PATCH] nicira-ext: Rename "struct nxt_*" to "struct nx_*".

2011-12-07 Thread Ben Pfaff
On Fri, Dec 02, 2011 at 09:47:18PM -0800, Ben Pfaff wrote: > Most structures in this file have an "nx_" prefix, so this makes naming > more consistent. This patch is now included in the new "of1.1 draft" series: http://openvswitch.org/pipermail/dev/2011-December/013586.html ___

[ovs-dev] [of1.1 draft 09/10] Break OFPT_* constants into common value and 1.0- and 1.1-specific values.

2011-12-07 Thread Ben Pfaff
--- include/openflow/openflow-1.0.h| 41 ++- include/openflow/openflow-1.1.h| 23 +++- include/openflow/openflow-common.h | 22 +++ lib/ofp-print.c| 18 lib/ofp-util.c

[ovs-dev] [of1.1 draft 08/10] ofp-util: Add functions for working with OpenFlow 1.1 port numbers.

2011-12-07 Thread Ben Pfaff
OpenFlow 1.1 extends port numbers to 32 bits. Initially we plan to support only port numbers in the 16-bit range in Open vSwitch. However the OF1.1 reserved ports have high-valued fixed numbers that require translation to high fixed values in the 16-bit range for OF1.0. These new functions provi

[ovs-dev] [of1.1 draft 07/10] Begin breaking openflow-1.0.h into common and version-specific definitions.

2011-12-07 Thread Ben Pfaff
The intention is that, as each OpenFlow 1.1 feature is added to Open vSwitch, the corresponding protocol definitions will be broken up this way: - Definitions that are the same in OF1.0 and OF1.1 will retain the "OFP" or "ofp" prefix and move to openflow-common.h. - Definitions that are s

[ovs-dev] [of1.1 draft 06/10] Move content of openflow.h into openflow-1.0.h.

2011-12-07 Thread Ben Pfaff
This prepares for a gradual introduction of definitions from OpenFlow 1.1 and later, by making it clearer that the current definitions are specific to OpenFlow 1.0. --- build-aux/check-structs | 51 +- include/openflow/automake.mk| 26 +- include/ope

[ovs-dev] [of1.1 draft 04/10] util: Move bitwise_copy() here.

2011-12-07 Thread Ben Pfaff
Upcoming commits will add new users. --- lib/nx-match.c | 54 +- lib/util.c | 52 lib/util.h |3 +++ 3 files changed, 56 insertions(+), 53 deletions(-) diff --git a/lib/nx-matc

[ovs-dev] [of1.1 draft 01/10] nicira-ext: Rename "struct nxt_*" to "struct nx_*".

2011-12-07 Thread Ben Pfaff
Most structures in this file have an "nx_" prefix, so this makes naming more consistent. --- include/openflow/nicira-ext.h | 10 +- lib/ofp-print.c |4 ++-- lib/ofp-util.c|8 ofproto/ofproto.c |8 4 files changed, 15

[ovs-dev] [of1.1 draft 00/10] work toward OF1.1/OF1.2 support

2011-12-07 Thread Ben Pfaff
This series of patches works in the direction of OF1.1 support. OF1.2 will be a set of incremental changes over OF1.1, so this is also helpful toward OF1.2 support. These patches do not implement complete OF1.1 support; much additional work is needed. Many of the individual patches need some work

Re: [ovs-dev] [PATCH v2] datapath: Fix build on RHEL 5.5

2011-12-07 Thread Jesse Gross
On Wed, Dec 7, 2011 at 3:49 PM, Pravin B Shelar wrote: > Fixed according to comments from Jesse. > > --8<--cut here-->8-- > > Signed-off-by: Pravin B Shelar Acked-by: Jesse Gross ___ dev mailing list dev

[ovs-dev] [PATCH v2] datapath: Fix build on RHEL 5.5

2011-12-07 Thread Pravin B Shelar
Fixed according to comments from Jesse. --8<--cut here-->8-- Signed-off-by: Pravin B Shelar --- datapath/linux/Modules.mk |1 + datapath/linux/compat/include/linux/ipv6.h|8 datapath/linux/compat/include/li

[ovs-dev] Hello Dear

2011-12-07 Thread Nancy Donald
Hello Dear, I am Nancy, a female. I am a nice loving and good looking young lady, however, am interested in knowing you in person. Can we be friends?, write me on my private email so that i can send my photos to you as well as introducing myself properly to you. Yours Nancy...___

Re: [ovs-dev] [PATCH] socket-util: Correctly return negative values for errors.

2011-12-07 Thread Ben Pfaff
Thanks, I'll push this soon, with backports. On Tue, Dec 06, 2011 at 11:46:00PM -0800, Justin Pettit wrote: > Nice catch. Looks good. > > --Justin > > > On Dec 6, 2011, at 3:55 PM, Ben Pfaff wrote: > > > The comment on this function says that negative values indicate errors, and > > the calle

Re: [ovs-dev] [PATCH] nicira-ext: Improve comment.

2011-12-07 Thread Ben Pfaff
Thanks. Pushed. On Tue, Dec 06, 2011 at 11:35:57PM -0800, Justin Pettit wrote: > Looks good. > > --Justin > > > On Dec 6, 2011, at 10:40 PM, Ben Pfaff wrote: > > > --- > > include/openflow/nicira-ext.h |2 +- > > 1 files changed, 1 insertions(+), 1 deletions(-) > > > > diff --git a/includ

Re: [ovs-dev] [PATCH] socket-util: Correctly return negative values for errors.

2011-12-07 Thread Chris Wright
* Brian Haley (brian.ha...@hp.com) wrote: > On 12/06/2011 06:55 PM, Ben Pfaff wrote: > > The comment on this function says that negative values indicate errors, and > > the callers assume that too, but in fact it was returning positive errno > > values, which are indistinguishable from valid fd num

Re: [ovs-dev] [PATCH] socket-util: Correctly return negative values for errors.

2011-12-07 Thread Ben Pfaff
On Wed, Dec 07, 2011 at 09:19:41AM -0500, Brian Haley wrote: > On 12/06/2011 06:55 PM, Ben Pfaff wrote: > > The comment on this function says that negative values indicate errors, and > > the callers assume that too, but in fact it was returning positive errno > > values, which are indistinguishabl

Re: [ovs-dev] [PATCH] socket-util: Correctly return negative values for errors.

2011-12-07 Thread Brian Haley
On 12/06/2011 06:55 PM, Ben Pfaff wrote: > The comment on this function says that negative values indicate errors, and > the callers assume that too, but in fact it was returning positive errno > values, which are indistinguishable from valid fd numbers. > @@ -716,6 +716,7 @@ inet_open_passive(int

[ovs-dev] Good Day Beneficiary!

2011-12-07 Thread Ronald C. Foster
Good Day Beneficiary! I write to inform you that we have been given the mandate to transfer your full compensation payment of $1,500,000.00 USD via western union by this government. We tried to give you the Western Union Instructions through phone, but we could not locate your numbers in our data