Nice catch. Looks good.
--Justin
On Dec 6, 2011, at 3:55 PM, Ben Pfaff wrote:
> The comment on this function says that negative values indicate errors, and
> the callers assume that too, but in fact it was returning positive errno
> values, which are indistinguishable from valid fd numbers.
>
Looks good.
--Justin
On Dec 6, 2011, at 10:40 PM, Ben Pfaff wrote:
> ---
> include/openflow/nicira-ext.h |2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/include/openflow/nicira-ext.h b/include/openflow/nicira-ext.h
> index d63d9d6..90505c5 100644
> --- a/include/o
---
include/openflow/nicira-ext.h |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/include/openflow/nicira-ext.h b/include/openflow/nicira-ext.h
index d63d9d6..90505c5 100644
--- a/include/openflow/nicira-ext.h
+++ b/include/openflow/nicira-ext.h
@@ -978,7 +978,7 @@ struct
The comment on this function says that negative values indicate errors, and
the callers assume that too, but in fact it was returning positive errno
values, which are indistinguishable from valid fd numbers.
It really seems to me that this should have been found pretty quickly in
the field, since
* Pravin Shelar (pshe...@nicira.com) wrote:
> On Tue, Dec 6, 2011 at 2:29 PM, Jesse Gross wrote:
> > On Tue, Dec 6, 2011 at 12:45 PM, Pravin B Shelar wrote:
> >> diff --git a/datapath/linux/compat/include/linux/jiffies.h
> >> b/datapath/linux/compat/include/linux/jiffies.h
> >> index a64f226..77
i am single, i am nice, good looking, caring, honest, faithful,
understanding and God fearing young girl. i am interested in having a
sincere friendship or love relationship with you, it is all about faith,
honest and trust in any relationship.here is my direct email id
(sallianma...@hotmail.co
On Tue, Dec 6, 2011 at 2:29 PM, Jesse Gross wrote:
> On Tue, Dec 6, 2011 at 12:45 PM, Pravin B Shelar wrote:
>> Signed-off-by: Pravin B Shelar
>> ---
>> datapath/linux/compat/include/linux/ipv6.h | 8
>> datapath/linux/compat/include/linux/jiffies.h | 2 ++
>> datapath/linux/c
On Tue, Dec 6, 2011 at 12:45 PM, Pravin B Shelar wrote:
> Signed-off-by: Pravin B Shelar
> ---
> datapath/linux/compat/include/linux/ipv6.h | 8
> datapath/linux/compat/include/linux/jiffies.h | 2 ++
> datapath/linux/compat/include/net/ipv6.h | 13 +
> 3 fil
* Ben Pfaff (b...@nicira.com) wrote:
> On Tue, Dec 06, 2011 at 12:17:34PM -0800, Chris Wright wrote:
> > * Ben Pfaff (b...@nicira.com) wrote:
> > > On Tue, Dec 06, 2011 at 03:32:12PM +, selsinork wrote:
> > > > If I pull the userspace utils from git, which ones are best to use
> > > > with the
Hi Neil,
replies in-line.
On Tue, Dec 6, 2011 at 1:43 PM, Neil Mckee wrote:
> Hi Luca,
>
> Just checking does this mean that the sFlow-agent-address might
> change just because the first collector in the list changed? Or because
> there was a routing change and the packet path to the colle
The unit tests feed a lot of flows through the ofproto-dpif "trace"
command, which means that they need to know the port numbers of the ports
that they create. Until now, they've had to actually query those port
numbers from the database, which is a bit of unnecessary overhead for unit
tests.
Thi
Hi Luca,
Just checking does this mean that the sFlow-agent-address might change
just because the first collector in the list changed? Or because there was a
routing change and the packet path to the collector went out a different
interface?
The primary purpose of the sflow-agent-address
Thanks for testing. I pushed this to master.
On Tue, Dec 06, 2011 at 01:38:16PM -0800, Luca Giraudo wrote:
> It seems to work properly. No differences from the my patch.
>
> Luca
>
> On Tue, Dec 6, 2011 at 1:02 PM, Ben Pfaff wrote:
>
> > From: Luca Giraudo
> >
> > Bug #2407.
> > ---
> > Hi L
It seems to work properly. No differences from the my patch.
Luca
On Tue, Dec 6, 2011 at 1:02 PM, Ben Pfaff wrote:
> From: Luca Giraudo
>
> Bug #2407.
> ---
> Hi Luca, here's a version of your patch that I tweaked a bit.
> I assume that you have a test case for this feature? Will you
> please
From: Luca Giraudo
Bug #2407.
---
Hi Luca, here's a version of your patch that I tweaked a bit.
I assume that you have a test case for this feature? Will you
please try this version of the patch out to verify that I did
not break it?
Thanks,
Ben.
diff --git a/AUTHORS b/AUTHORS
index 994fc46..
Signed-off-by: Pravin B Shelar
---
datapath/linux/compat/include/linux/ipv6.h|8
datapath/linux/compat/include/linux/jiffies.h |2 ++
datapath/linux/compat/include/net/ipv6.h | 13 +
3 files changed, 15 insertions(+), 8 deletions(-)
create mode 100644 data
---
NEWS |3 ++
lib/netdev.c | 21 +++
lib/netdev.h |1 +
ofproto/ofproto-dpif-sflow.c | 56 +++--
vswitchd/vswitch.xml |4 ++-
5 files changed, 70 insertions(+), 15 dele
On Tue, Dec 06, 2011 at 12:17:34PM -0800, Chris Wright wrote:
> * Ben Pfaff (b...@nicira.com) wrote:
> > On Tue, Dec 06, 2011 at 03:32:12PM +, selsinork wrote:
> > > If I pull the userspace utils from git, which ones are best to use
> > > with the code that's making it's way upstream, branch-1.
* Ben Pfaff (b...@nicira.com) wrote:
> On Tue, Dec 06, 2011 at 03:32:12PM +, selsinork wrote:
> > If I pull the userspace utils from git, which ones are best to use
> > with the code that's making it's way upstream, branch-1.3, branch-1.4,
> > master ?
>
> Either branch-1.4 or master should be
You are receiving this email because we wish you to use our digital photo
editing services.
Digital Photo Editing Services :
We are a China based Imaging Professionals. We offer basic and advanced digital
photo Editing services and solutions like photo Cutout, morphological photo
Editing, phot
From: Jesse Gross
Date: Tue, 6 Dec 2011 09:32:13 -0800
> On Mon, Dec 5, 2011 at 10:27 PM, Dan Carpenter
> wrote:
>> We're unlikely to hit this leak, but the static checkers complain if we
>> don't take care of it.
>>
>> Signed-off-by: Dan Carpenter
>
> Acked-by: Jesse Gross
Applied, thanks.
On Mon, Dec 5, 2011 at 10:27 PM, Dan Carpenter wrote:
> We're unlikely to hit this leak, but the static checkers complain if we
> don't take care of it.
>
> Signed-off-by: Dan Carpenter
Acked-by: Jesse Gross
Thanks Dan.
___
dev mailing list
dev@openv
Thanks a lot for verifying that.
I pushed this change to master, branch-1.3, branch-1.4. (It's not
strictly a bugfix so I wouldn't ordinarily backport it, but based on
the fact that you guys sent it I think it must be important to you.)
Thanks,
Ben.
On Tue, Dec 06, 2011 at 09:36:29AM +, Ro
On Tue, Dec 06, 2011 at 03:32:12PM +, selsinork wrote:
> I've patched a vanilla 3.1 kernel with the v3 patchset that DaveM
> recently pulled, have built the kernel and loaded the openvswitch
> module. So far so good..
>
> Using the 1.2.2 userspace, which the web page suggests is the current
>
So I was wanting to try openvswitch as it seems to be making it's way upstream.
I've patched a vanilla 3.1 kernel with the v3 patchset that DaveM
recently pulled, have built the kernel and loaded the openvswitch
module. So far so good..
Using the 1.2.2 userspace, which the web page suggests is th
Hi Ben,
The get_all_records_where functions are indeed not very well documented,
probably because the way to use them is a little awkward. I think we should at
some point introduce new APIs to selectively query the database and discourage
the use of get_all (because it does not scale). Currentl
26 matches
Mail list logo
