[ovs-dev] [PATCH 3/3] datapath: Don't drop packets with partial vlan tags.

2011-11-01 Thread Jesse Gross
In the future it is likely that our vlan support will expand to include multiply tagged packets. When this happens, we would ideally like for it to be consistent with our current tagging. Currently, if we receive a packet with a partial VLAN tag we will automatically drop it in the kernel, which

[ovs-dev] [PATCH 2/3] datapath: Drop useless WARN_ON_ONCE during flow conversion.

2011-11-01 Thread Jesse Gross
This checks whether key_len is not zero but we set the key length at the beginning of the function, so I don't see this as a useful check. Signed-off-by: Jesse Gross --- datapath/flow.c |1 - 1 files changed, 0 insertions(+), 1 deletions(-) diff --git a/datapath/flow.c b/datapath/flow.c ind

[ovs-dev] [PATCH 1/3] datapath: Add IPv6 to list of parsed EtherTypes.

2011-11-01 Thread Jesse Gross
The kernel can parse IPv6, so if it receives a flow with an IPv6 EtherType then it expects to get IPv6 information as well. Signed-off-by: Jesse Gross --- datapath/flow.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/datapath/flow.c b/datapath/flow.c index 0084ca2..952

Re: [ovs-dev] [error reporting 2/6] ofp-util: New function ofputil_decode_msg_type_partial().

2011-11-01 Thread Ethan Jackson
Looks good to me. Ethan On Thu, Oct 27, 2011 at 13:00, Ben Pfaff wrote: > Here's a revised version of this patch now that I've dropped 1/6. > > Please look it over.  Thank you > > --8<--cut here-->8-- > > From: Ben Pfaff > Date: Thu, 27 Oct 2011 1

Re: [ovs-dev] [PATCH] openvswitch.h: Add missing words in comment.

2011-11-01 Thread Ben Pfaff
On Tue, Nov 01, 2011 at 02:14:37PM -0700, Jesse Gross wrote: > On Nov 1, 2011, at 1:34 PM, Ben Pfaff wrote: > > --- > > include/linux/openvswitch.h |3 ++- > > 1 files changed, 2 insertions(+), 1 deletions(-) > > Looks good if you add a signed-off-by line. > > Acked-by: Jesse Gross Thanks,

Re: [ovs-dev] [PATCH] openvswitch.h: Add missing words in comment.

2011-11-01 Thread Jesse Gross
On Nov 1, 2011, at 1:34 PM, Ben Pfaff wrote: > --- > include/linux/openvswitch.h |3 ++- > 1 files changed, 2 insertions(+), 1 deletions(-) Looks good if you add a signed-off-by line. Acked-by: Jesse Gross ___ dev mailing list dev@openvswitch.org h

Re: [ovs-dev] [PATCH] datapath: Make port numbers for UDP-based tunnels userspace configurable.

2011-11-01 Thread Jesse Gross
On Nov 1, 2011, at 1:19 PM, Ben Pfaff wrote: > On Fri, Oct 28, 2011 at 06:37:42PM -0700, Jesse Gross wrote: >> On Fri, Oct 28, 2011 at 11:29 AM, Ben Pfaff wrote: >>> On Thu, Oct 27, 2011 at 04:38:39PM -0700, Jesse Gross wrote: On Wed, Oct 26, 2011 at 3:27 PM, Ben Pfaff wrote: > diff --

[ovs-dev] [PATCH] openvswitch.h: Add missing words in comment.

2011-11-01 Thread Ben Pfaff
--- include/linux/openvswitch.h |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/include/linux/openvswitch.h b/include/linux/openvswitch.h index 087655c..d14c53a 100644 --- a/include/linux/openvswitch.h +++ b/include/linux/openvswitch.h @@ -366,7 +366,8 @@ struct ovs_key_

Re: [ovs-dev] [PATCH 2/2] ovs-appctl: Add fdb/flush command

2011-11-01 Thread Ben Pfaff
On Tue, Nov 01, 2011 at 01:24:30PM -0700, Ansis Atteka wrote: > Added a new command that will allow to flush particular bridge's > MAC learning table. > > Issue #7819 Looks good, thank you. ___ dev mailing list dev@openvswitch.org http://openvswitch.org

Re: [ovs-dev] [PATCH 1/2] packaging: dpkg --purge command fails on Ubuntu 11.04

2011-11-01 Thread Ben Pfaff
On Tue, Nov 01, 2011 at 01:24:29PM -0700, Ansis Atteka wrote: > The problem is that postrm script is unable to remove > contents of /var/log/openvswitch/ directory in case if > it contains any other directories. Steps to reproduce > on Ubuntu 11.04: > 1. apt-get install openvswitch-switch > 2. dpkg

[ovs-dev] [PATCH 2/2] ovs-appctl: Add fdb/flush command

2011-11-01 Thread Ansis Atteka
Added a new command that will allow to flush particular bridge's MAC learning table. Issue #7819 --- NEWS |2 ++ ofproto/ofproto-dpif.c | 18 ++ vswitchd/ovs-vswitchd.8.in |2 ++ 3 files changed, 22 insertions(+), 0 deletions(-) diff --git a/NE

[ovs-dev] [PATCH 1/2] packaging: dpkg --purge command fails on Ubuntu 11.04

2011-11-01 Thread Ansis Atteka
The problem is that postrm script is unable to remove contents of /var/log/openvswitch/ directory in case if it contains any other directories. Steps to reproduce on Ubuntu 11.04: 1. apt-get install openvswitch-switch 2. dpkg --purge openvswitch-switch 3. observe that purge failed, because of an em

Re: [ovs-dev] [PATCH] datapath: Make port numbers for UDP-based tunnels userspace configurable.

2011-11-01 Thread Ben Pfaff
On Fri, Oct 28, 2011 at 06:37:42PM -0700, Jesse Gross wrote: > On Fri, Oct 28, 2011 at 11:29 AM, Ben Pfaff wrote: > > On Thu, Oct 27, 2011 at 04:38:39PM -0700, Jesse Gross wrote: > >> On Wed, Oct 26, 2011 at 3:27 PM, Ben Pfaff wrote: > >> > diff --git a/datapath/tunnel.c b/datapath/tunnel.c > >>

Re: [ovs-dev] [PATCH] ovs-test: A new tool that allows to diagnose connectivity and performance issues

2011-11-01 Thread Ben Pfaff
On Mon, Oct 31, 2011 at 05:00:34PM -0700, Ansis Atteka wrote: > Some areas where I would like to get other expertise: > >1. Does the wildcard star in python-openvswitch.install file really >work? Because compat directory was not present in python-openvswitch >package anyway. Maybe ther

Re: [ovs-dev] [PATCH] ovs-test: A new tool that allows to diagnose connectivity and performance issues

2011-11-01 Thread Ben Pfaff
On Mon, Oct 31, 2011 at 04:38:51PM -0700, Ansis Atteka wrote: > This tool will be a replacement for the current ovs-vlan-test > utility. Besides from connectivity issues it will also be able > to detect performance related issues in Open vSwitch setups. > Currently it uses UDP and TCP protocols for

Re: [ovs-dev] [PATCH v3] datapath: Convert kernel priority actions into match/set.

2011-11-01 Thread Pravin Shelar
On Mon, Oct 31, 2011 at 10:20 PM, Jesse Gross wrote: > On Mon, Oct 31, 2011 at 7:45 PM, Pravin B Shelar wrote: >> diff --git a/ofproto/ofproto-dpif.c b/ofproto/ofproto-dpif.c >> index d0a5e00..9ff2534 100644 >> --- a/ofproto/ofproto-dpif.c >> +++ b/ofproto/ofproto-dpif.c >> @@ -5258,18 +5256,20 @

[ovs-dev] (no subject)

2011-11-01 Thread Lyman Jenifeer
Do you need a loan?.If yes reply us for more details. Thanks___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev