On Wed, Oct 26, 2011 at 3:27 PM, Ben Pfaff wrote:
> diff --git a/datapath/tunnel.c b/datapath/tunnel.c
> index 372d90e..047961f 100644
> --- a/datapath/tunnel.c
> +++ b/datapath/tunnel.c
> @@ -1347,29 +1438,57 @@ static int tnl_set_config(struct nlattr *options,
> const struct tnl_ops *tnl_ops,
>
Postel's law is fine by me, especially since I end up parsing this stuff ;)
On Thu, Oct 27, 2011 at 6:34 PM, Ethan Jackson wrote:
> No, Jeremy brought this up off-list as well. The command never
> prints with brackets, it's a bit counter intuitive.
>
> Ethan
>
> On Thu, Oct 27, 2011 at 18:33,
No, Jeremy brought this up off-list as well. The command never
prints with brackets, it's a bit counter intuitive.
Ethan
On Thu, Oct 27, 2011 at 18:33, Reid Price wrote:
> On Thu, Oct 27, 2011 at 5:05 PM, Ethan Jackson wrote:
>>
>> This patch fixes the issue and adds a test which would have c
On Thu, Oct 27, 2011 at 5:05 PM, Ethan Jackson wrote:
> This patch fixes the issue and adds a test which would have caught
> it.
>
> Reported-by: Michael Mao
> Bug #8045.
@@ -50,6 +51,7 @@ NXT_FLOW_MOD: ADD table:255
> actions=bundle(symmetric_l4,60,hrw,ofport,slaves:)
> NXT_FLOW_MOD: ADD
On Thu, Oct 27, 2011 at 05:05:33PM -0700, Ethan Jackson wrote:
> This patch fixes the issue and adds a test which would have caught
> it.
>
> Reported-by: Michael Mao
> Bug #8045.
Looks good to me.
___
dev mailing list
dev@openvswitch.org
http://openvs
This patch fixes the issue and adds a test which would have caught
it.
Reported-by: Michael Mao
Bug #8045.
---
lib/bundle.c |2 +-
tests/ovs-ofctl.at |2 ++
2 files changed, 3 insertions(+), 1 deletions(-)
diff --git a/lib/bundle.c b/lib/bundle.c
index ac0bade..af1be63 100644
---
On Wed, Oct 26, 2011 at 3:27 PM, Ben Pfaff wrote:
> diff --git a/datapath/tunnel.c b/datapath/tunnel.c
> index 372d90e..047961f 100644
> --- a/datapath/tunnel.c
> +++ b/datapath/tunnel.c
> +static int tnl_sock_bind(const struct tnl_ops *tnl_ops, struct
> tnl_mutable_config *mutable)
> +{
> +#if L
Looks good, thank you.
On Thu, Oct 27, 2011 at 01:33:07PM -0700, Ethan Jackson wrote:
> ---
> include/openflow/nicira-ext.h |2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/include/openflow/nicira-ext.h b/include/openflow/nicira-ext.h
> index ad6dd11..7621bca 100644
---
include/openflow/nicira-ext.h |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/include/openflow/nicira-ext.h b/include/openflow/nicira-ext.h
index ad6dd11..7621bca 100644
--- a/include/openflow/nicira-ext.h
+++ b/include/openflow/nicira-ext.h
@@ -970,7 +970,7 @@ struct
> I think this patch isn't necessary right now. I'm dropping it.
Sounds good, I was wondering about it as I reviewed it which is why I
asked you to explain it in the commit message. Dropping it is fine
too though.
Ethan
>
> The second patch will need to be revised, stand by.
>
> On Fri, Oct 21
It's not a huge deal if we skip looping; I'd rather have that happen
than abort().
Thanks,
Ben.
On Fri, Oct 21, 2011 at 06:11:40PM -0700, Ethan Jackson wrote:
> This looks fine to me.
>
> If FOR_EACH_MATCHING_TABLE is given an invalid TABLE_ID it simply
> skips looping. Would it make sense to
Here's a revised version of this patch now that I've dropped 1/6.
Please look it over. Thank you
--8<--cut here-->8--
From: Ben Pfaff
Date: Thu, 27 Oct 2011 12:54:44 -0700
Subject: [PATCH] ofp-util: New function ofputil_decode_msg_type_partial().
I think this patch isn't necessary right now. I'm dropping it.
The second patch will need to be revised, stand by.
On Fri, Oct 21, 2011 at 02:34:50PM -0700, Ethan Jackson wrote:
> Looks good to me.
>
> I think it would be useful to explain why this was done in the commit message.
>
> I think t
Thanks, I pushed this.
On Fri, Oct 21, 2011 at 06:55:56PM -0700, Ethan Jackson wrote:
> Looks good.
>
> Ethan
>
> On Fri, Sep 30, 2011 at 11:01, Ben Pfaff wrote:
> > This function was only pretty-printing "bad request" error payloads. ?I
> > don't know why. ?It makes sense to pretty-print all o
Thanks, I pushed this.
On Wed, Oct 26, 2011 at 04:46:05PM -0700, Ethan Jackson wrote:
> Looks good to me.
>
> I didn't check that everywhere that needs to change did in-fact change.
>
> In the next couple of days, I'm going to write a patch which removes
> all of the synthetic checks from the br
On Wed, Oct 26, 2011 at 08:17:21PM -0700, Jesse Gross wrote:
> Ben, what do you think of this approach of zeroing out the priority
> (or any other comments)?
I'm a bit nervous about it. Really I was expecting this commit to
reduce the number of special cases, but it adds a new suite of special
ca
Thanks, I pushed this.
On Thu, Oct 27, 2011 at 09:41:32AM -0700, Ethan Jackson wrote:
> Looks good.
>
> Ethan
>
>
> On Thu, Oct 27, 2011 at 09:39, Ben Pfaff wrote:
> > The version of groff on RHEL 5 doesn't include the .SY, .OP, or .YS macros
> > that ovs-benchmark.1 uses, so the manpage-check
Looks good.
Ethan
On Thu, Oct 27, 2011 at 09:39, Ben Pfaff wrote:
> The version of groff on RHEL 5 doesn't include the .SY, .OP, or .YS macros
> that ovs-benchmark.1 uses, so the manpage-check target fails on that
> platform. This commit adds the groff definitions of those macros to a
> file a
The version of groff on RHEL 5 doesn't include the .SY, .OP, or .YS macros
that ovs-benchmark.1 uses, so the manpage-check target fails on that
platform. This commit adds the groff definitions of those macros to a
file and includes it into ovs-benchmark.1.
I tested that this allows RHEL 5 to pass
Did a Justin Petbot post get misdirected?
On Wed, Oct 26, 2011 at 11:28:01PM -0700, Justin Pettit wrote:
> I'm not square. Go for it, man!
>
> --Justin
>
>
> On Oct 26, 2011, at 10:09 AM, Ben Pfaff wrote:
>
> > I like the _3way suffix convention. It makes the interpretation of the
> > return
This week only (until Friday Oct 28) $199 for all healthcare lists below
For more info and samples please reply to jennifer.clus...@gmx.us
ALL USA data, 100% optin, Excel format (separate file for each state),
Unlimited use rights
Comprehensive Physicians Listing USA (34 major medical specia
21 matches
Mail list logo
