Re: [ovs-dev] [PATCH 2/2] datapath: Cleanup openvswitch.h formatting.

2011-10-22 Thread Ben Pfaff
On Sat, Oct 22, 2011 at 07:56:26PM -0700, Jesse Gross wrote: > The userspace/kernel interface file had acquired a mixture of userspace > and kernel style, so this makes it use kernel style consistently. > > Signed-off-by: Jesse Gross Acked-by: Ben Pfaff _

Re: [ovs-dev] [PATCH 1/2] datapath: Define constants for versions of GENL families.

2011-10-22 Thread Ben Pfaff
On Sat, Oct 22, 2011 at 07:56:25PM -0700, Jesse Gross wrote: > Currently we hard code the versions of our GENL families to 1 but it's > nicer to have symbolic constants. > > Signed-off-by: Jesse Gross I'm not sure of the reason for 0x1 instead of 1, but it doesn't make a functional difference of

Re: [ovs-dev] [PATCH 0/5] VXLAN v2

2011-10-22 Thread Jesse Gross
On Tue, Oct 18, 2011 at 5:01 PM, Ben Pfaff wrote: > This fixes a problem that Jesse pointed out, whereby as I sent it > out before VXLAN and VXLAN-over-IPsec weren't both supported to a > single host simultaneously. > > This patch series takes advantage of patches that Justin wrote > earlier for a

Re: [ovs-dev] [PATCH 2/5] vxlan: Add support for VXLAN-over-IPsec.

2011-10-22 Thread Jesse Gross
On Tue, Oct 18, 2011 at 5:01 PM, Ben Pfaff wrote: > From: Justin Pettit > > This makes it possible to automatically set up IPsec encrypted VXLAN > tunnels through the OVS database. > > Signed-off-by: Justin Pettit > Signed-off-by: Jesse Gross > [Ben modified this commit for VXLAN, added unit te

[ovs-dev] [PATCH 2/2] datapath: Cleanup openvswitch.h formatting.

2011-10-22 Thread Jesse Gross
The userspace/kernel interface file had acquired a mixture of userspace and kernel style, so this makes it use kernel style consistently. Signed-off-by: Jesse Gross --- include/linux/openvswitch.h | 85 +++ 1 files changed, 45 insertions(+), 40 deletions

[ovs-dev] [PATCH 1/2] datapath: Define constants for versions of GENL families.

2011-10-22 Thread Jesse Gross
Currently we hard code the versions of our GENL families to 1 but it's nicer to have symbolic constants. Signed-off-by: Jesse Gross --- datapath/datapath.c |8 include/linux/openvswitch.h |4 lib/dpif-linux.c|9 + 3 files changed, 13 insertio

[ovs-dev] [PATCH] ofproto-dpif: Use send_packet() instead of netdev_send().

2011-10-22 Thread Jesse Gross
netdev_send() directly sends a packet using Linux mechanisms, skipping our kernel module. Several upper layer abstractions are built on top of the kernel module, so this means that we loose stats, sFlow, etc. on these packets. This changes bonding, LACP, and STP to use send_packet() as CFM does, wh

Re: [ovs-dev] [STP 9/9] ovs-vswitchd: Add support for 802.1D STP.

2011-10-22 Thread Justin Pettit
On Oct 21, 2011, at 4:35 PM, Ben Pfaff wrote: > On Fri, Oct 21, 2011 at 04:20:43PM -0700, Justin Pettit wrote: >> On Oct 18, 2011, at 1:23 PM, Ben Pfaff wrote: >> diff --git a/ofproto/ofproto-dpif.c b/ofproto/ofproto-dpif.c >> index 025cc5b..065acf0 100644 >> --- a/ofproto/ofproto-dpif.c >> +++ b/