Pychecker considers it bad style.
---
The original version of this patch that I sent out broke the unit tests.
Please review this version.
---
python/ovs/daemon.py | 24
1 files changed, 12 insertions(+), 12 deletions(-)
diff --git a/python/ovs/daemon.py b/python/ovs/
dpif_sflow_odp_port_to_ifindex() expects odp_port number as sFlow
maintains ODP-port to ifindex mapping.
Signed-off-by: Pravin Shelar
---
ofproto/ofproto-dpif-sflow.c |4 +++-
1 files changed, 3 insertions(+), 1 deletions(-)
diff --git a/ofproto/ofproto-dpif-sflow.c b/ofproto/ofproto-dpi
Pychecker complains about __read_pidfile() having too may returns.
I personally think the function is fine, but it's easy enough to
reduce them.
python/ovs/daemon.py:395: Function (__read_pidfile) has too many
returns (12)
---
python/ovs/daemon.py |8 +---
1 files changed, 5 insertions(+)
Pychecker considers it bad style.
---
python/ovs/daemon.py | 20 ++--
1 files changed, 10 insertions(+), 10 deletions(-)
diff --git a/python/ovs/daemon.py b/python/ovs/daemon.py
index a14be82..b793d6e 100644
--- a/python/ovs/daemon.py
+++ b/python/ovs/daemon.py
@@ -141,18 +141,1
The python style guide requires two newlines between top level
definitions. This patch also removes some trailing whitespace.
---
python/ovs/daemon.py | 34 +-
1 files changed, 29 insertions(+), 5 deletions(-)
diff --git a/python/ovs/daemon.py b/python/ovs/daemo
By convention, unused arguments should be named "_" and top level
definitions should be separated by two spaces.
---
tests/test-daemon.py |5 -
1 files changed, 4 insertions(+), 1 deletions(-)
diff --git a/tests/test-daemon.py b/tests/test-daemon.py
index 350b8f7..816304f 100644
--- a/tes
Looks good
Ethan
On Fri, Aug 26, 2011 at 13:19, Ben Pfaff wrote:
> ---
> lib/bitmap.c | 21 -
> lib/bitmap.h | 2 ++
> 2 files changed, 22 insertions(+), 1 deletions(-)
>
> diff --git a/lib/bitmap.c b/lib/bitmap.c
> index df3c4eb..76a667a 100644
> --- a/lib/bitmap.c
> +
Looks good,
Ethan
On Fri, Aug 26, 2011 at 13:19, Ben Pfaff wrote:
> These tests would have caught the bug fixed in the previous commit
> "ofproto-dpif: Fix behavior when a subset of VLANs is trunked."
> ---
> tests/ofproto-dpif.at | 79
> +++
> t
Thanks for the view.
I'll merge this shortly
Ethan
On Fri, Sep 16, 2011 at 12:45, Ben Pfaff wrote:
> On Fri, Sep 16, 2011 at 11:46:16AM -0700, Ethan Jackson wrote:
>> +
>> +
>> + When CFM is properly configured, Open vSwitch will occasionally
>> + receive CCM broadcasts. T
On Fri, Sep 16, 2011 at 01:02:19PM -0700, Jesse Gross wrote:
> On Fri, Sep 16, 2011 at 9:42 AM, Ben Pfaff wrote:
> > 'dp_ifindex' is never used in the fast path, only in Netlink handling
> > and in the slow path that sends packets that miss up to userspace. ??We
> > could get rid of dp_ifindex, re
On Fri, Sep 16, 2011 at 9:42 AM, Ben Pfaff wrote:
> On Thu, Sep 15, 2011 at 05:50:16PM -0700, Jesse Gross wrote:
>> It's possible to start receiving packets on a datapath as soon as
>> the internal device is created. It's therefore important that the
>> datapath be fully initialized before this,
On Fri, Sep 16, 2011 at 11:46:16AM -0700, Ethan Jackson wrote:
> +
> +
> +When CFM is properly configured, Open vSwitch will occasionally
> +receive CCM broadcasts. These broadcasts contain the MPID of the
> +sending Maintenance Point. The list of MPIDs which this
w
---
vswitchd/vswitch.xml |8
1 files changed, 8 insertions(+), 0 deletions(-)
diff --git a/vswitchd/vswitch.xml b/vswitchd/vswitch.xml
index 7d9bb0b..1227dc3 100644
--- a/vswitchd/vswitch.xml
+++ b/vswitchd/vswitch.xml
@@ -1392,6 +1392,14 @@
case arises when a CCM is recei
On Thu, Sep 15, 2011 at 05:56:15PM -0700, Ethan Jackson wrote:
> The nl_lookup_genl_mcgroup() function can fail on older kernels
> which do not support the required netlink interface. Before this
> patch, dpif-linux would refuse to create a datapath when this
> happened. With this patch, it attem
On Thu, Sep 15, 2011 at 05:50:16PM -0700, Jesse Gross wrote:
> It's possible to start receiving packets on a datapath as soon as
> the internal device is created. It's therefore important that the
> datapath be fully initialized before this, which it currently isn't.
> In particularly, the fact th
FYI: The status of the openvswitch source package
in Debian's testing distribution has changed.
Previous version: 1.2.1-2
Current version: 1.2.1-3
--
This email is automatically generated once a day. As the installation of
new packages into testing happens multiple times a day you will rec
Reply if you need a business or personal loan
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
Thanks, I pushed this patch to master and branch-1.2.
Patch 1 has already been committed as part of another series.
Patches 3, 4, and 5 still need review.
On Thu, Sep 15, 2011 at 04:09:05PM -0700, Ethan Jackson wrote:
> Looks good,
>
> Ethan
>
> On Fri, Aug 26, 2011 at 13:19, Ben Pfaff wrote:
On Fri, Aug 26, 2011 at 01:19:36PM -0700, Ben Pfaff wrote:
> I've always intended this to work, but either I never tested it or the
> support rotted.
>
> This will soon be used in some tests that I will add.
This patch and patch 2 have been committed and so don't need review.
Patch 3, 4, and 5 st
Hi my name is Ruth Akoli from liberia , please i need your help , you will know
more about the help you,Bye
Merhaba benim adım Ruth Akoli Liberya, ben sizin yardımınıza ihtiyacımız var
lütfenH___
dev mailing list
dev@openvswitch.org
http://ope
20 matches
Mail list logo
