On Thu, Sep 08, 2011 at 02:39:45AM -0700, Jesse Gross wrote:
> From: Valient Gough
>
> Add tunnel key support to CAPWAP vport. Uses the optional WSI field in a
> CAPWAP header to store a 64bit key. It can also be used without keys, in
> which
> case it is backward compatible with the old code.
On Debian there is a need for the init scripts to die gracefully
if module insertion fails. In such a case it is desirable to print
some sort of informative message.
By adding the load-kmod sub-command to ovs-ctl init scripts
may try to load modules and take appropriate action on failure
or then t
By registering an error-handler for the init script used
in openvswitch-switch.postinst and detecting if module insertion fails,
it is possible to avoid failure to install in the case where the
openvswitch_mod module is not available.
This is done without altering the behaviour that the start targ
Hi,
this series is comprised of an updated version of the changes I made for
the 1.2.1-3 upload to Debian. The changes avoid install of the
openvswitch-switch package failing in the case where the openvswtich_mod
kernel module can't be loaded.
Changes since v1 are indicated in the change log of e
---
debian/changelog | 11 +++
1 files changed, 11 insertions(+), 0 deletions(-)
diff --git a/debian/changelog b/debian/changelog
index 3940891..1f510f8 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -1,3 +1,14 @@
+openvswitch (1.2.1-3) unstable; urgency=low
+
+ * Allow the op
On Thu, Sep 8, 2011 at 4:04 PM, Jesse Gross wrote:
> On Wed, Sep 7, 2011 at 5:50 PM, Pravin Shelar wrote:
>> Currently the kernel vlan actions mirror those used by OpenFlow 1.0.
>> i.e. MODIFY and STRIP. More flexible approach is to have an action to push a
>> tag and pop a tag off, so that it ca
On Fri, Sep 9, 2011 at 11:22 AM, Jesse Gross wrote:
> On Thu, Sep 8, 2011 at 7:35 PM, Pravin Shelar wrote:
>> I missed this in last vport iflink patch.
>> As IFLA_LINK is not be passed in netlink msg there is no need to
>> allocate space for it.
>>
>> Signed-off-by: Pravin B Shelar
>
> Good c
On Fri, Sep 9, 2011 at 3:46 PM, Jesse Gross wrote:
> On Fri, Sep 9, 2011 at 2:34 PM, Pravin Shelar wrote:
>>>
+ cancel_delayed_work_sync(&cache_cleaner_wq);
>>>
>>> This should have been stopped when the last port is removed, right?
>>>
>> I did it as it can cancel cache clearer in cas
I think in general this patch would be cleaner if we required the void *
parameters to be properly aligned. I don't think that should block it though,
we can always change it later.
I'm also wondering if it's possible to generate a lot of this code. At any
rate, this is a step in the right direc
> +/* Optimized flow revalidation.
> + *
> + * It's a difficult problem, in general, to tell which facets need to have
> + * their actions recalculated whenever the OpenFlow flow table changes. We
> + * don't try to solve that general problem: for most kinds of OpenFlow flow
> + * table changes, w
Thanks, I pushed this.
On Fri, Sep 09, 2011 at 03:38:48PM -0700, Ethan Jackson wrote:
> Looks good,
>
> Ethan
>
> On Fri, Sep 9, 2011 at 10:21, Ben Pfaff wrote:
> > Commit e408762f "netlink-socket: New function nl_lookup_genl_mcgroup()"
> > modified do_lookup_genl_family() to return the Netlink
Thanks, I pushed this.
On Fri, Sep 09, 2011 at 01:28:26PM -0700, Ethan Jackson wrote:
> Looks good,
>
> Ethan
>
> On Fri, Sep 9, 2011 at 10:10, Ben Pfaff wrote:
> > Commit 3a48ace3 "bridge: Make bridge_pick_local_hw_addr() easier to reason"
> > didn't initialize 'ea' before trying to compare ag
> +/* Number of implemented OpenFlow tables. Must be between 1 and 255. */
> +enum { N_TABLES = 255 };
Does it make sense to use BUILD_ASSERT to enforce the allowed range?
Looks good,
Ethan
___
dev mailing list
dev@openvswitch.org
http://openvswitch.or
On Fri, Sep 9, 2011 at 2:34 PM, Pravin Shelar wrote:
>>
>>> + cancel_delayed_work_sync(&cache_cleaner_wq);
>>
>> This should have been stopped when the last port is removed, right?
>>
> I did it as it can cancel cache clearer in case of bug related port not
> deleted.
It seems like there i
I'm not going to update the code unless it causes trouble for some
implementation.
Thanks.
On Fri, Sep 09, 2011 at 03:40:13PM -0700, Ethan Jackson wrote:
> Looks good,
>
> Out of curiosity, are you planning to update the code, or is the
> current implementation fine?
>
> Ethan
>
> On Thu, Sep
I would consider having this assert fail on FLOW_WC_SEQ.
Seems fine otherwise,
Ethan
On Fri, Aug 19, 2011 at 15:28, Ben Pfaff wrote:
> This will be used in an upcoming commit.
> ---
> lib/flow.c | 26 ++
> lib/flow.h | 1 +
> 2 files changed, 27 insertions(+), 0 del
Looks good,
Ethan
On Fri, Aug 19, 2011 at 15:28, Ben Pfaff wrote:
> This function will soon be used elsewhere. As it doesn't inherently have
> anything to with the classifier, move it to flow.c.
> ---
> lib/classifier.c | 63 +
> lib/flow.c
Looks good,
Out of curiosity, are you planning to update the code, or is the
current implementation fine?
Ethan
On Thu, Sep 8, 2011 at 16:27, Ben Pfaff wrote:
> This documented what I intended to implement and what I thought I had
> implemented, but not what the code actually did. It is a litt
Looks good,
Ethan
On Fri, Sep 9, 2011 at 10:21, Ben Pfaff wrote:
> Commit e408762f "netlink-socket: New function nl_lookup_genl_mcgroup()"
> modified do_lookup_genl_family() to return the Netlink attributes to the
> caller, but it still freed the Netlink message itself, which meant that
> the at
I get the following compiler warning:
lib/learn.c: In function 'learn_format':
lib/learn.c:463:32: error: variable 'src_field' set but not used
[-Werror=unused-but-set-variable]
> ovs-vsctl del-controller br0
> ovs-ofctl del-flows br0
> ovs-ofctl add-flow br0 "table=0 actions=learn(ta
Moving this back on-list.
On Fri, Sep 9, 2011 at 3:13 PM, Pravin Shelar wrote:
>>> diff --git a/datapath/vport-internal_dev.c b/datapath/vport-internal_dev.c
>>> index f777637..492bef7 100644
>>> --- a/datapath/vport-internal_dev.c
>>> +++ b/datapath/vport-internal_dev.c
>>> -static int internal_
On Thu, Sep 8, 2011 at 8:03 PM, Pravin Shelar wrote:
> diff --git a/datapath/datapath.c b/datapath/datapath.c
> index b92c198..aa33f63 100644
> --- a/datapath/datapath.c
> +++ b/datapath/datapath.c
> @@ -130,7 +130,6 @@ static inline size_t br_nlmsg_size(void)
> + nla_total_size(IFNA
>
>> + cancel_delayed_work_sync(&cache_cleaner_wq);
>
> This should have been stopped when the last port is removed, right?
>
I did it as it can cancel cache clearer in case of bug related port not deleted.
>> + for (i = 0; i < PORT_TABLE_SIZE; i++) {
>> + hash_head = &po
On Thu, Sep 8, 2011 at 5:08 PM, Pravin Shelar wrote:
> Currently OVS uses its own hashing implmentation for hash tables
> which has some problems, e.g. error case on deletion code.
> Following patch replaces that with hlist based hash table which is
> consistent with other kernel hash tables. As
Thanks for the reviews,
I've folded this change in and will merge shortly.
Ethan
On Fri, Sep 9, 2011 at 13:39, Ben Pfaff wrote:
> On Fri, Sep 09, 2011 at 01:37:42PM -0700, Ethan Jackson wrote:
>> > 1 and 2 are both in the range [1, 8191], so they would be allowed.
>> >
>> > The only disallowed
On Fri, Sep 09, 2011 at 01:37:42PM -0700, Ethan Jackson wrote:
> > 1 and 2 are both in the range [1, 8191], so they would be allowed.
> >
> > The only disallowed values would be 0 and [8192, UINT16_MAX].
>
> That still feels a bit arbitrary to me. However, I realized that I
> should probably rest
> 1 and 2 are both in the range [1, 8191], so they would be allowed.
>
> The only disallowed values would be 0 and [8192, UINT16_MAX].
That still feels a bit arbitrary to me. However, I realized that I
should probably restrict "0" as a valid mpid in extended mode. How
about I change cfm_is_valid
Looks good,
Ethan
On Fri, Sep 9, 2011 at 10:10, Ben Pfaff wrote:
> Commit 3a48ace3 "bridge: Make bridge_pick_local_hw_addr() easier to reason"
> didn't initialize 'ea' before trying to compare against it. We need to
> check that an address has been found.
> ---
> vswitchd/bridge.c | 2 +-
>
[adding ovs-dev back]
On Fri, Sep 09, 2011 at 01:23:58PM -0700, Ben Pfaff wrote:
> On Fri, Sep 09, 2011 at 01:14:44PM -0700, Ethan Jackson wrote:
> > > I'd be tempted to say that mpids must be in either range [1, 8191] or
> > > [UINT16_MAX + 1, UINT64_MAX], which would allow cfm_is_valid_mpid() to
> cfm_destroy() should free ->rmps.
good catch.
Thanks for the review,
On Fri, Sep 9, 2011 at 11:39, Ben Pfaff wrote:
> On Thu, Sep 08, 2011 at 06:59:53PM -0700, Ethan Jackson wrote:
>> A controller may want to know which MPIDs are reachable from an
>> interface configured with CFM. This patch
On Fri, Sep 09, 2011 at 12:58:36PM -0700, Ethan Jackson wrote:
> > Also, am I reading the code correctly that too many RMPs triggers an
> > unexpected_recv fault? ?Is that what we want?
>
> This is an edge case I suppose. I made a judgement call that it
> should but I'd like to here another opini
Sounds good, I wrote a helper function and folded it into the patch.
Ethan
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
Thanks, I pushed these to master.
On Fri, Sep 09, 2011 at 12:53:43PM -0700, Hao Zheng wrote:
> Looks good.
>
> On Fri, Sep 9, 2011 at 12:46 PM, Ben Pfaff wrote:
>
> > Hao pointed out out-of-band that this version still wasn't right.
> > Third time's the charm?
> >
> > Additional incremental:
>
Looks good.
On Fri, Sep 9, 2011 at 12:46 PM, Ben Pfaff wrote:
> Hao pointed out out-of-band that this version still wasn't right.
> Third time's the charm?
>
> Additional incremental:
>
> diff --git a/ofproto/ofproto.c b/ofproto/ofproto.c
> index c0b3474..15bcd13 100644
> --- a/ofproto/ofproto.c
Hao pointed out out-of-band that this version still wasn't right.
Third time's the charm?
Additional incremental:
diff --git a/ofproto/ofproto.c b/ofproto/ofproto.c
index c0b3474..15bcd13 100644
--- a/ofproto/ofproto.c
+++ b/ofproto/ofproto.c
@@ -2844,8 +2844,7 @@ ofoperation_destroy(struct ofope
E-mail vítaz.
Plaza Norte,
2449, Madrid, Španielsko.
Pozor: Vítaz.
Sme radi, že Vás informovat, že e-mailovú adresu sa objavili vítaz kategórie B
štyristo pätdesiat tisíc eur (450,000.00 Euro) v Grand ponúka skupine Award.
Tento e-mailom lotérie propagacné program je urcený na podporu inter
On Fri, Sep 09, 2011 at 11:45:56AM -0700, Ethan Jackson wrote:
> This patch no longer rate limits database updates due to CFM
> changes. Due to recent changes, the fault status of CFM only
> changes once per 3.5 tx_interval seconds. There doesn't seem to be
> a good reason to add an additional ra
This patch no longer rate limits database updates due to CFM
changes. Due to recent changes, the fault status of CFM only
changes once per 3.5 tx_interval seconds. There doesn't seem to be
a good reason to add an additional rate limit on top of this.
---
vswitchd/bridge.c | 46
On Thu, Sep 08, 2011 at 06:59:53PM -0700, Ethan Jackson wrote:
> A controller may want to know which MPIDs are reachable from an
> interface configured with CFM. This patch regularly writes this
> information to the database.
>
> Bug #7014.
I think it would be nice if ofproto_port_get_cfm_remote
On Thu, Sep 08, 2011 at 06:59:52PM -0700, Ethan Jackson wrote:
> 802.1ag only allows for MPIDs in the range [1, 8191]. This is
> restrictive enough to make assignment of MPIDs to instances of OVS
> awkward. This patch allows six byte MPIDs when running in extended
> mode.
s/six/eight/ above.
I'
On Thu, Sep 08, 2011 at 06:59:51PM -0700, Ethan Jackson wrote:
> The standard CFM protocol only allows a handful of transmission
> rates. This is particularly problematic if you want to support a
> transmission rate slower than 100 ms and faster than 1000 ms.
>
> This patch allows arbitrary trans
On Thu, Sep 8, 2011 at 7:35 PM, Pravin Shelar wrote:
> I missed this in last vport iflink patch.
> As IFLA_LINK is not be passed in netlink msg there is no need to
> allocate space for it.
>
> Signed-off-by: Pravin B Shelar
Good catch.
Acked-by: Jesse Gross
_
On Thu, Sep 08, 2011 at 06:59:50PM -0700, Ethan Jackson wrote:
> The new extended mode introduced in this patch will be used for
> features which break wire compatibility with 802.1ag compliant
> implementations.
>
> Bug #7014.
The expression "cfm->extended ? eth_addr_ccm_x : eth_addr_ccm" appear
On Thu, Sep 08, 2011 at 06:59:49PM -0700, Ethan Jackson wrote:
> According to the 802.1ag specification, users should be able to
> configure the CFM module with a list of remote endpoints with which
> the local endpoint should have connectivity. Commit 93b8df3853
> "cfm: Remove Maintenance_Point a
Looks good, thank you.
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
Looks good, thank you.
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
On Thu, Sep 08, 2011 at 06:59:46PM -0700, Ethan Jackson wrote:
> This patch no longer rate limits database updates due to CFM
> changes. Due to recent changes, the fault status of CFM only
> changes once per 3.5 tx_interval seconds. There doesn't seem to be
> a good reason to add an additional ra
On Thu, Sep 08, 2011 at 06:59:45PM -0700, Ethan Jackson wrote:
> The bridge owns the lacp_current and cfm_fault columns and should
> not be alerted when they change.
Looks good, thank you.
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/m
Commit e408762f "netlink-socket: New function nl_lookup_genl_mcgroup()"
modified do_lookup_genl_family() to return the Netlink attributes to the
caller, but it still freed the Netlink message itself, which meant that
the attributes pointed into freed memory. This commit fixes the problem.
This co
Commit 3a48ace3 "bridge: Make bridge_pick_local_hw_addr() easier to reason"
didn't initialize 'ea' before trying to compare against it. We need to
check that an address has been found.
---
vswitchd/bridge.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/vswitchd/bridge.
On Thu, Sep 08, 2011 at 04:53:47PM -0700, Hao Zheng wrote:
> > + * - If 'op' is an "add flow" operation, ofproto removes the new rule or
> > + * restores the original rule. ofoperation_complete() performs steps
> > 5, 6,
> > + * and 7 for the new rule, most notably by calling its
> > ->r
No.
A new OpenFlow flow goes into the classifier.
A packet with field values not yet seen goes into the datapath flow
table (e.g. dp_netdev or dpif-linux).
On Fri, Sep 09, 2011 at 10:04:46AM +0500, Bibrak Qamar wrote:
> So that means when a new flow comes its written in both classifier and
> net
52 matches
Mail list logo
