Re: [ovs-dev] [PATCH] lacp: Clarify documentation.

2011-08-31 Thread Justin Pettit
You're taking away the one bit of control that ovs-vswitchd could use at its own discretion? Looks good. --Justin On Aug 31, 2011, at 3:22 PM, Ethan Jackson wrote: > Requested-by: Dan Wendlandt > --- > vswitchd/vswitch.xml |4 ++-- > 1 files changed, 2 insertions(+), 2 deletions(-) > > d

Re: [ovs-dev] [genl 5/6] datapath: genl_notify() on port disappearances.

2011-08-31 Thread Jesse Gross
On Wed, Aug 31, 2011 at 6:42 PM, Ethan Jackson wrote: >> In the error case you should call netlink_set_err(), otherwise >> userspace won't know that it potentially missed a notification.  This >> isn't done in some other places because we allocate the message before >> actually performing the acti

Re: [ovs-dev] [genl 5/6] datapath: genl_notify() on port disappearances.

2011-08-31 Thread Ethan Jackson
> In the error case you should call netlink_set_err(), otherwise > userspace won't know that it potentially missed a notification.  This > isn't done in some other places because we allocate the message before > actually performing the action and don't do it if the allocation > fails.  In this case

Re: [ovs-dev] [genl 5/6] datapath: genl_notify() on port disappearances.

2011-08-31 Thread Jesse Gross
On Thu, Aug 25, 2011 at 4:28 PM, Ethan Jackson wrote: > diff --git a/datapath/dp_notify.c b/datapath/dp_notify.c > index 94d671d..bbfd242 100644 > --- a/datapath/dp_notify.c > +++ b/datapath/dp_notify.c > @@ -33,8 +34,19 @@ static int dp_device_event(struct notifier_block *unused, > unsigned long

Re: [ovs-dev] [PATCH] rhel: Poke iptables hole for gre in init scripts.

2011-08-31 Thread Ethan Jackson
Thanks, pushed. Ethan On Wed, Aug 31, 2011 at 18:21, Justin Pettit wrote: > Oh, don't forget to delete the "iptables" rule that was already there. > > --Justin > > > On Aug 31, 2011, at 6:05 PM, Justin Pettit wrote: > >> Looks good to me. >> >> --Justin >> >> >> On Aug 31, 2011, at 5:56 PM, Etha

Re: [ovs-dev] [PATCH] rhel: Poke iptables hole for gre in init scripts.

2011-08-31 Thread Justin Pettit
Oh, don't forget to delete the "iptables" rule that was already there. --Justin On Aug 31, 2011, at 6:05 PM, Justin Pettit wrote: > Looks good to me. > > --Justin > > > On Aug 31, 2011, at 5:56 PM, Ethan Jackson wrote: > >> --- >> rhel/etc_init.d_openvswitch |2 ++ >> 1 files changed, 2

Re: [ovs-dev] [PATCH] rhel: Poke iptables hole for gre in init scripts.

2011-08-31 Thread Justin Pettit
Looks good to me. --Justin On Aug 31, 2011, at 5:56 PM, Ethan Jackson wrote: > --- > rhel/etc_init.d_openvswitch |2 ++ > 1 files changed, 2 insertions(+), 0 deletions(-) > > diff --git a/rhel/etc_init.d_openvswitch b/rhel/etc_init.d_openvswitch > index 6f7fe69..82eaeb1 100755 > --- a/rhel/

[ovs-dev] [PATCH] rhel: Poke iptables hole for gre in init scripts.

2011-08-31 Thread Ethan Jackson
--- rhel/etc_init.d_openvswitch |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/rhel/etc_init.d_openvswitch b/rhel/etc_init.d_openvswitch index 6f7fe69..82eaeb1 100755 --- a/rhel/etc_init.d_openvswitch +++ b/rhel/etc_init.d_openvswitch @@ -50,6 +50,8 @@ start () { fi

Re: [ovs-dev] [PATCH 1/2] rhel: Don't delete bridges on boot.

2011-08-31 Thread Ethan Jackson
Summary of an offline discussion: Did some research and we decided to just remove it. I'm going to push this series now. Ethan On Wed, Aug 31, 2011 at 17:15, Ethan Jackson wrote: > I'm not sure if that's some sort of rhel requirement so I wanted to be > safe.  If you think it's ok I'll remove

Re: [ovs-dev] [PATCH 1/2] rhel: Don't delete bridges on boot.

2011-08-31 Thread Ethan Jackson
I'm not sure if that's some sort of rhel requirement so I wanted to be safe. If you think it's ok I'll remove it. Ethan On Wed, Aug 31, 2011 at 17:13, Justin Pettit wrote: > I think you can get rid of the "/var/run/openvswitch.booted" stuff > surrounding it. > > --Justin > > > On Aug 31, 2011,

Re: [ovs-dev] [PATCH 2/2] rhel: Add ovs-pki to rpm.

2011-08-31 Thread Justin Pettit
Looks good. --Justin On Aug 31, 2011, at 5:11 PM, Ethan Jackson wrote: > --- > rhel/openvswitch.spec.in |4 ++-- > 1 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/rhel/openvswitch.spec.in b/rhel/openvswitch.spec.in > index 1305990..9bd6b58 100644 > --- a/rhel/openvswitch.s

Re: [ovs-dev] [PATCH 1/2] rhel: Don't delete bridges on boot.

2011-08-31 Thread Justin Pettit
I think you can get rid of the "/var/run/openvswitch.booted" stuff surrounding it. --Justin On Aug 31, 2011, at 5:11 PM, Ethan Jackson wrote: > Before this patch, the RHEL init scripts would remove all bridges > configured on the system at boot. > --- > rhel/etc_init.d_openvswitch |1 - > 1

[ovs-dev] [PATCH 2/2] rhel: Add ovs-pki to rpm.

2011-08-31 Thread Ethan Jackson
--- rhel/openvswitch.spec.in |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/rhel/openvswitch.spec.in b/rhel/openvswitch.spec.in index 1305990..9bd6b58 100644 --- a/rhel/openvswitch.spec.in +++ b/rhel/openvswitch.spec.in @@ -51,9 +51,7 @@ install xenserver/uuid.py $RPM

[ovs-dev] [PATCH 1/2] rhel: Don't delete bridges on boot.

2011-08-31 Thread Ethan Jackson
Before this patch, the RHEL init scripts would remove all bridges configured on the system at boot. --- rhel/etc_init.d_openvswitch |1 - 1 files changed, 0 insertions(+), 1 deletions(-) diff --git a/rhel/etc_init.d_openvswitch b/rhel/etc_init.d_openvswitch index c7543cc..c4af816 100755 --- a

[ovs-dev] [PATCH] lacp: Clarify documentation.

2011-08-31 Thread Ethan Jackson
Requested-by: Dan Wendlandt --- vswitchd/vswitch.xml |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/vswitchd/vswitch.xml b/vswitchd/vswitch.xml index 6082256..4edc101 100644 --- a/vswitchd/vswitch.xml +++ b/vswitchd/vswitch.xml @@ -635,8 +635,8 @@ connected

Re: [ovs-dev] asking about flow rate limiting feature

2011-08-31 Thread Justin Pettit
I doubt FlowVisor speaks Open vSwitch's configuration protocol, but that would be a question better suited to the FlowVisor mailing list: http://mailman.stanford.edu/mailman/listinfo/flowvisor-users If you just want to make those changes remotely, you can use ovs-vsctl over TCP/SSL. Yo

Re: [ovs-dev] all countries

2011-08-31 Thread Marcos Fink
. .. . .. .

Re: [ovs-dev] asking about flow rate limiting feature

2011-08-31 Thread Trinh Minh Tri
Dear Mr Justin! I followed your suggestion and can set the qos for each flow but completely on openflow switch. Now I want to periodically change the rate provide to each queue. I mean if I have a program that can calculate the best rate providing to each queue and base on that program result I wa

Re: [ovs-dev] asking about flow rate limiting feature

2011-08-31 Thread Trinh Minh Tri
Dear Mr Justin! I followed your suggestion and can set the qos for each flow but completely on openflow switch. Now I want to periodically change the rate provide to each queue. I mean if I have a program that can calculate the best rate providing to each queue and base on that program result I wa

Re: [ovs-dev] all countries

2011-08-31 Thread Royal Rios
.. . . . . . .