Re: [ovs-dev] [PATCH] Simplify kernel sFlow implementation

2011-08-09 Thread Ben Pfaff
On Wed, Aug 10, 2011 at 01:18:35PM +0800, Jesse Gross wrote: > The rough goal that I was thinking of (although certainly without all > of the details fleshed out) is to have a sample action which takes a > probability and sublist of actions which is executed according to the > probability. The exi

Re: [ovs-dev] [PATCH] Simplify kernel sFlow implementation

2011-08-09 Thread Jesse Gross
On Wed, Aug 10, 2011 at 12:42 PM, Ben Pfaff wrote: > On Tue, Aug 09, 2011 at 10:46:38AM -0700, pravin shelar wrote: >>  This patch is first step toward generic/simple sampling >>  action which will be completely independent of sflow. >>  Following patch cleanup sampling upcall by striping it down

Re: [ovs-dev] [PATCH] Simplify kernel sFlow implementation

2011-08-09 Thread Ben Pfaff
On Tue, Aug 09, 2011 at 10:46:38AM -0700, pravin shelar wrote: > This patch is first step toward generic/simple sampling > action which will be completely independent of sflow. > Following patch cleanup sampling upcall by striping it down to > minimum essential data that userspace can not figur

[ovs-dev] [PATCH] Simplify kernel sFlow implementation

2011-08-09 Thread pravin shelar
This patch is first step toward generic/simple sampling action which will be completely independent of sflow. Following patch cleanup sampling upcall by striping it down to minimum essential data that userspace can not figure out for itself. Signed-off by: Pravin Shelar --- datapath/action

Re: [ovs-dev] branch-1.2 commits

2011-08-09 Thread Ben Pfaff
On Tue, Aug 09, 2011 at 01:35:08PM -0700, Ben Pfaff wrote: > e89993f ovs-ofctl: Fix reading flows from file for "replace-flows", > "diff-flows". > 8402c74 Option to forward BPDU (Ethernet control class) frames > 298fd6d debian: Ensure that /var/run/openvswitch exists in controller init > script.

Re: [ovs-dev] [PATCH] nicira-ext: Fix NXM example.

2011-08-09 Thread Ben Pfaff
Thanks, I pushed this. On Tue, Aug 09, 2011 at 01:56:34PM -0700, Justin Pettit wrote: > Looks good. > > --Justin > > > On Aug 9, 2011, at 1:46 PM, Ben Pfaff wrote: > > > The code and the specification say that nxm_length includes both value > > and mask, but this example showed nxm_length only

Re: [ovs-dev] [PATCH] nicira-ext: Fix NXM example.

2011-08-09 Thread Justin Pettit
Looks good. --Justin On Aug 9, 2011, at 1:46 PM, Ben Pfaff wrote: > The code and the specification say that nxm_length includes both value > and mask, but this example showed nxm_length only including the value. > This commit fixes it. > > Reported-by: Justin Pettit > --- > include/openflow/n

[ovs-dev] [PATCH 1/2] ofp-util: Rename struct flow_mod to struct ofputil_flow_mod.

2011-08-09 Thread Ben Pfaff
Most of the structs in ofp-util.h have the ofputil_ prefix. Rename this one for consistency. --- lib/ofp-parse.c |7 --- lib/ofp-parse.h |4 ++-- lib/ofp-print.c |2 +- lib/ofp-util.c|6 +++--- lib/ofp-util.h|8 ofproto/ofproto.c

[ovs-dev] [PATCH 2/2] ofp-util: Rename struct flow_stats_request with ofputil_ prefix.

2011-08-09 Thread Ben Pfaff
Most of the structs in ofp-util.h have the ofputil_ prefix. Rename this one for consistency. --- lib/ofp-parse.c |2 +- lib/ofp-parse.h |4 ++-- lib/ofp-print.c |2 +- lib/ofp-util.c|8 lib/ofp-util.h|6 +++--- ofproto/ofproto.c |

[ovs-dev] [PATCH] nicira-ext: Fix NXM example.

2011-08-09 Thread Ben Pfaff
The code and the specification say that nxm_length includes both value and mask, but this example showed nxm_length only including the value. This commit fixes it. Reported-by: Justin Pettit --- include/openflow/nicira-ext.h |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git

[ovs-dev] branch-1.2 commits

2011-08-09 Thread Ben Pfaff
I have the following commits from "master" queued for branch-1.2. Does anyone think any commits should be added or removed from the list? Thanks, Ben. e89993f ovs-ofctl: Fix reading flows from file for "replace-flows", "diff-flows". 8402c74 Option to forward BPDU (Ethernet control class) frames

Re: [ovs-dev] [PATCH] ovs-ofctl: Fix reading flows from file for "replace-flows", "diff-flows".

2011-08-09 Thread Ben Pfaff
Thanks. I pushed this and queued it for branch-1.2. On Tue, Aug 09, 2011 at 01:22:15PM -0700, Ethan Jackson wrote: > Looks good. > > Ethan > > On Tue, Aug 9, 2011 at 13:00, Ben Pfaff wrote: > > Commit c821124b25e "ovs-ofctl: Accept only valid flow_mod and > > flow_stats_request fields" caused

Re: [ovs-dev] [PATCH] ovs-ofctl: Fix reading flows from file for "replace-flows", "diff-flows".

2011-08-09 Thread Ethan Jackson
Looks good. Ethan On Tue, Aug 9, 2011 at 13:00, Ben Pfaff wrote: > Commit c821124b25e "ovs-ofctl: Accept only valid flow_mod and > flow_stats_request fields" caused actions read by read_flows_from_file() > to be ignored and treated as "drop".  This fixes the problem. > --- >  utilities/ovs-ofctl

[ovs-dev] [PATCH] ovs-ofctl: Fix reading flows from file for "replace-flows", "diff-flows".

2011-08-09 Thread Ben Pfaff
Commit c821124b25e "ovs-ofctl: Accept only valid flow_mod and flow_stats_request fields" caused actions read by read_flows_from_file() to be ignored and treated as "drop". This fixes the problem. --- utilities/ovs-ofctl.c |6 ++ 1 files changed, 2 insertions(+), 4 deletions(-) diff --git

Re: [ovs-dev] [PATCH] Option to forward BPDU (Ethernet control class) frames

2011-08-09 Thread Ben Pfaff
On Tue, Aug 09, 2011 at 11:08:27AM -0700, Sanjay Sane wrote: > Currently, a NORMAL action bridge drops reserved-multicast-mac addresses; > 01-80-c2-00-00-[f0:ff]. A node that does not implement STP should have an > option to forward such frames. > > This commit proposes to have a configuration opt

Re: [ovs-dev] [multiple tables 8/8] New action NXAST_RESUBMIT_TABLE.

2011-08-09 Thread Ben Pfaff
On Tue, Aug 09, 2011 at 10:57:50AM -0700, Ethan Jackson wrote: > > I decided to further add: > > > > ? ? ? ?Tables 128 and above are reserved for use by the switch > > ? ? ? ?itself; please use only tables 0 through 127. > > > > I'd like to document this somewhere else in the tree but it's not > >

[ovs-dev] [PATCH] Option to forward BPDU (Ethernet control class) frames

2011-08-09 Thread Sanjay Sane
Currently, a NORMAL action bridge drops reserved-multicast-mac addresses; 01-80-c2-00-00-[f0:ff]. A node that does not implement STP should have an option to forward such frames. This commit proposes to have a configuration option to allow forwarding of BPDU class frames. To ensure backward compa

Re: [ovs-dev] [multiple tables 8/8] New action NXAST_RESUBMIT_TABLE.

2011-08-09 Thread Ethan Jackson
> I decided to further add: > >        Tables 128 and above are reserved for use by the switch >        itself; please use only tables 0 through 127. > > I'd like to document this somewhere else in the tree but it's not > clear where. Are we planning to enforce this? Ethan > > On Tue, Aug 09,

Re: [ovs-dev] [multiple tables 8/8] New action NXAST_RESUBMIT_TABLE.

2011-08-09 Thread Ben Pfaff
That's a good thought, thank you. On Tue, Aug 09, 2011 at 09:37:05AM -0700, Justin Pettit wrote: > What about "DESIGN"? > > --Justin > > > On Aug 9, 2011, at 9:24 AM, Ben Pfaff wrote: > > > I decided to further add: > > > > Tables 128 and above are reserved for use by the switch > >

Re: [ovs-dev] [multiple tables 8/8] New action NXAST_RESUBMIT_TABLE.

2011-08-09 Thread Justin Pettit
What about "DESIGN"? --Justin On Aug 9, 2011, at 9:24 AM, Ben Pfaff wrote: > I decided to further add: > > Tables 128 and above are reserved for use by the switch >itself; please use only tables 0 through 127. > > I'd like to document this somewhere else in the tree but it's not

Re: [ovs-dev] [multiple tables 8/8] New action NXAST_RESUBMIT_TABLE.

2011-08-09 Thread Ben Pfaff
I decided to further add: Tables 128 and above are reserved for use by the switch itself; please use only tables 0 through 127. I'd like to document this somewhere else in the tree but it's not clear where. On Tue, Aug 09, 2011 at 09:22:29AM -0700, Ben Pfaff wrote: > Good idea.

Re: [ovs-dev] [multiple tables 8/8] New action NXAST_RESUBMIT_TABLE.

2011-08-09 Thread Ben Pfaff
Good idea. I added: - ovs-vswitchd: - The software switch now supports 255 OpenFlow tables, instead of just one. By default, only table 0 is consulted, but the new NXAST_RESUBMIT_TABLE action can look up in additional tables. I'll push this soon. On Mon, Aug 0

Re: [ovs-dev] [PATCH] Option to forward BPDU (Ethernet control class) frames

2011-08-09 Thread Ben Pfaff
On Mon, Aug 08, 2011 at 08:11:48PM -0700, Sanjay Sane wrote: > Currently, a NORMAL action bridge drops reserved-multicast-mac addresses; > 01-80-c2-00-00-[f0:ff]. A node that does not implement STP should have an > option to forward such frames. > > This commit proposes to have a configuration opt

[ovs-dev] Mr PETERS WALTERS sent you a link from St. Charles Patch - 2011 Riverfest Schedule of Events

2011-08-09 Thread St. Charles Patch
Mr PETERS WALTERS (ebohinvestm...@gmail.com) thought you would be interested in this: 2011 Riverfest Schedule of Events (http://stcharles.patch.com/articles/2011-riverfest-schedule-of-events) Visit Patch.c