[ovs-dev] [PATCH] xenserver: Merge changes to scripts from XenServer 5.6.100.

2011-02-10 Thread Andrew Evans
Citrix have made modifications to the various interface configuration scripts that OVS replaces, so at present those modifications are lost when OVS is installed on e.g. XenServer 5.6.100. This commit applies those changes while preserving OVS-specific modifications that have been made in the inter

Re: [ovs-dev] [PATCH] vswitchd: Fix broken load rebalancing with balance-tcp.

2011-02-10 Thread Ethan Jackson
Hopefully I caught all of them this time. Ethan On Thu, Feb 10, 2011 at 5:01 PM, Ben Pfaff wrote: > On Thu, Feb 10, 2011 at 04:49:54PM -0800, Ethan Jackson wrote: >> Load rebalancing was not working in balance-tcp mode due to >> mistaken balance-slb only assumptions leftover in the bridge code.

Re: [ovs-dev] [PATCH] vswitchd: Fix broken load rebalancing with balance-tcp.

2011-02-10 Thread Ben Pfaff
On Thu, Feb 10, 2011 at 04:49:54PM -0800, Ethan Jackson wrote: > Load rebalancing was not working in balance-tcp mode due to > mistaken balance-slb only assumptions leftover in the bridge code. Looks good to me, thank you. I didn't look through the code for any other assumptions needing correctio

[ovs-dev] [PATCH] vswitchd: Fix broken load rebalancing with balance-tcp.

2011-02-10 Thread Ethan Jackson
Load rebalancing was not working in balance-tcp mode due to mistaken balance-slb only assumptions leftover in the bridge code. --- vswitchd/bridge.c |6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git a/vswitchd/bridge.c b/vswitchd/bridge.c index 9c614fb..e92dd62 100644 ---

Re: [ovs-dev] [PATCH] docs: Consistently suggest /etc/openvswitch/conf.db as location for db.

2011-02-10 Thread Ben Pfaff
On Thu, Feb 10, 2011 at 11:38:43AM -0800, Ethan Jackson wrote: > Looks Good. > > > > > - ? ? ?% ovsdb-tool create /usr/local/etc/ovs-vswitchd.conf.db > > vswitchd/vswitch.ovsschema > > + ? ? ?% mkdir /usr/local/etc/openvswitch > > We might consider doing mkdir -p as not all distributions have >

Re: [ovs-dev] [PATCH] docs: Consistently suggest /etc/openvswitch/conf.db as location for db.

2011-02-10 Thread Ethan Jackson
Looks Good. > > -      % ovsdb-tool create /usr/local/etc/ovs-vswitchd.conf.db > vswitchd/vswitch.ovsschema > +      % mkdir /usr/local/etc/openvswitch We might consider doing mkdir -p as not all distributions have /usr/loca/etc created by default. __

[ovs-dev] [PATCH] docs: Consistently suggest /etc/openvswitch/conf.db as location for db.

2011-02-10 Thread Ben Pfaff
Our Debian and XenServer packages use /etc/openvswitch/conf.db as the location for the database but some of the docs suggested /etc/ovs-vswitchd.conf.db. This settles on the former consistently. The manpage is still ovs-vswitchd.conf.db but I don't know what to do about that. --- INSTALL.Linux |

Re: [ovs-dev] [db-backup 1/5] ovs-vsctl: Improve documentation and --help output.

2011-02-10 Thread Ben Pfaff
On Wed, Feb 09, 2011 at 12:29:12PM -0800, Ethan Jackson wrote: > Looks good. Couple of minor comments. > > > -\fBca\-cert\fR > > +\fica-cert\fR > > ?Specifies a PEM file containing the CA certificate used to verify that > > ?the virtual switch is connected to a trustworthy controller. > > ?.PP >