Re: [PR] pre-commit(mixed-line-ending): autofix some idl files [openoffice]

Pilot-Pirx merged PR #316: URL: https://github.com/apache/openoffice/pull/316 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@openoffice

Re: [PR] pre-commit(trailing-whitespace): autofix xdl files [openoffice]

Pilot-Pirx merged PR #315: URL: https://github.com/apache/openoffice/pull/315 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@openoffice

[PR] pre-commit(end-of-file-fixer): autofix more cxx files in main [openoffice]

jbampton opened a new pull request, #321: URL: https://github.com/apache/openoffice/pull/321 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-

Re: [PR] pre-commit: add two more official hooks [openoffice]

jbampton commented on code in PR #322: URL: https://github.com/apache/openoffice/pull/322#discussion_r1976719141 ## .pre-commit-config.yaml: ## @@ -32,8 +32,11 @@ repos: - id: check-illegal-windows-names - id: check-merge-conflict - id: check-vcs-permalinks

Re: [PR] pre-commit: add two more official hooks [openoffice]

jbampton commented on PR #322: URL: https://github.com/apache/openoffice/pull/322#issuecomment-2692884291 Hi @dave2wave I think the AWS check/hook would fail if it finds AWS credentials in the repo. So then for us it would be like a security check locally to warn when AWS credenti

[PR] pre-commit(end-of-file-fixer): autofix xsl files [openoffice]

jbampton opened a new pull request, #326: URL: https://github.com/apache/openoffice/pull/326 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-

[PR] pre-commit(end-of-file-fixer): autofix more cxx files in main [openoffice]

jbampton opened a new pull request, #314: URL: https://github.com/apache/openoffice/pull/314 Let me know if this PR has too many changes/files ? I can make smaller PRs. Thanks -- This is an automated message from the Apache Git Service. To respond to the message, please log o

[PR] pre-commit: add two more official hooks [openoffice]

jbampton opened a new pull request, #322: URL: https://github.com/apache/openoffice/pull/322 https://github.com/pre-commit/pre-commit-hooks#detect-aws-credentials https://github.com/pre-commit/pre-commit-hooks#fix-byte-order-marker Both checks/hooks/tests already pass. Good to

[PR] Create .gitattributes [openoffice]

BaseMax opened a new pull request, #323: URL: https://github.com/apache/openoffice/pull/323 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-m

Re: [PR] pre-commit(trailing-whitespace): autofix rc and xsd files [openoffice]

Pilot-Pirx merged PR #318: URL: https://github.com/apache/openoffice/pull/318 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@openoffice

Re: [PR] pre-commit: add two more official hooks [openoffice]

dave2wave commented on PR #322: URL: https://github.com/apache/openoffice/pull/322#issuecomment-2692906697 https://github.com/pre-commit/pre-commit-hooks/blob/main/pre_commit_hooks/detect_aws_credentials.py It looks like this is more about the environment that the precook is running

Re: [PR] pre-commit: add official hook fix-byte-order-marker [openoffice]

Pilot-Pirx merged PR #322: URL: https://github.com/apache/openoffice/pull/322 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@openoffice

[PR] pre-commit(end-of-file-fixer): autofix more cxx files in main [openoffice]

jbampton opened a new pull request, #312: URL: https://github.com/apache/openoffice/pull/312 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-

[PR] pre-commit(trailing-whitespace): autofix xdl files [openoffice]

jbampton opened a new pull request, #315: URL: https://github.com/apache/openoffice/pull/315 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-

Re: [PR] pre-commit(end-of-file-fixer): autofix more cxx files in main [openoffice]

Pilot-Pirx merged PR #312: URL: https://github.com/apache/openoffice/pull/312 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@openoffice

[PR] pre-commit(end-of-file-fixer): autofix more cxx files in main [openoffice]

jbampton opened a new pull request, #313: URL: https://github.com/apache/openoffice/pull/313 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-

Re: [PR] pre-commit(mixed-line-ending): autofix more files; ini, pl, pm [openoffice]

Pilot-Pirx merged PR #324: URL: https://github.com/apache/openoffice/pull/324 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@openoffice

[PR] pre-commit(end-of-file-fixer): autofix more cxx files in main [openoffice]

jbampton opened a new pull request, #317: URL: https://github.com/apache/openoffice/pull/317 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-

Re: [PR] pre-commit(end-of-file-fixer): autofix more cxx files in main [openoffice]

Pilot-Pirx merged PR #314: URL: https://github.com/apache/openoffice/pull/314 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@openoffice

[PR] pre-commit(trailing-whitespace): autofix rc and xsd files [openoffice]

jbampton opened a new pull request, #318: URL: https://github.com/apache/openoffice/pull/318 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-

Re: [PR] Fix up(mixed-line-ending): run `pre-commit run --all-files` [openoffice]

Pilot-Pirx merged PR #319: URL: https://github.com/apache/openoffice/pull/319 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@openoffice

[PR] pre-commit(mixed-line-ending): autofix more files; ini, pl, pm [openoffice]

jbampton opened a new pull request, #324: URL: https://github.com/apache/openoffice/pull/324 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-

Re: [PR] pre-commit: add two more official hooks [openoffice]

dave2wave commented on PR #322: URL: https://github.com/apache/openoffice/pull/322#issuecomment-2692879585 I don't think we have any use of aws cli. How is the detect-aws-credentials check helpful for us? Is there a better check that is similar? -- This is an automated message from the Ap

Re: [PR] pre-commit: add two more official hooks [openoffice]

Pilot-Pirx commented on PR #322: URL: https://github.com/apache/openoffice/pull/322#issuecomment-2692862241 Definitely! I did all that "by hand" ;-) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to g

Re: [PR] pre-commit: add two more official hooks [openoffice]

Pilot-Pirx commented on PR #322: URL: https://github.com/apache/openoffice/pull/322#issuecomment-2692858879 Regarding BOM: I think I removed all of them (hopefully) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use th

Re: [PR] pre-commit: add two more official hooks [openoffice]

jbampton commented on PR #322: URL: https://github.com/apache/openoffice/pull/322#issuecomment-2692861064 Yes the `fix-byte-order-marker` hook passed. I think it is still good to have this check so that we don't regress backwards. The run still takes about two minutes. -- Th

Re: [PR] Fix spelling [openoffice]

Pilot-Pirx merged PR #320: URL: https://github.com/apache/openoffice/pull/320 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@openoffice

Re: [PR] pre-commit(end-of-file-fixer): autofix xsl files [openoffice]

Pilot-Pirx merged PR #326: URL: https://github.com/apache/openoffice/pull/326 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@openoffice

python and newer MSVC versions

Hi; As a follow up to my comments on python and MSVC versions, I think a starting point to fix the build problem correctly would be to add something like this in main/python/makefile.mk (around line 127) # Requires adapting for according to the MSVC compiler version.# Normally PCBuild will carry

Re: [PR] pre-commit(end-of-file-fixer): autofix more cxx files in main [openoffice]

Pilot-Pirx merged PR #311: URL: https://github.com/apache/openoffice/pull/311 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@openoffice

Re: [PR] pre-commit(end-of-file-fixer): autofix more cxx files in main [openoffice]

Pilot-Pirx merged PR #317: URL: https://github.com/apache/openoffice/pull/317 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@openoffice

[PR] pre-commit(mixed-line-ending): autofix some idl files [openoffice]

jbampton opened a new pull request, #316: URL: https://github.com/apache/openoffice/pull/316 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-

Re: [PR] pre-commit(end-of-file-fixer): autofix more cxx files in main [openoffice]

Pilot-Pirx commented on PR #314: URL: https://github.com/apache/openoffice/pull/314#issuecomment-2692782572 The end-of-file fixes are no problem! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

[PR] Fix spelling [openoffice]

jbampton opened a new pull request, #320: URL: https://github.com/apache/openoffice/pull/320 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-

Re: [PR] pre-commit(mixed-line-ending): autofix dxp, h, mk, rc files [openoffice]

Pilot-Pirx merged PR #325: URL: https://github.com/apache/openoffice/pull/325 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@openoffice

Re: [PR] pre-commit(end-of-file-fixer): autofix more cxx files in main [openoffice]

Pilot-Pirx merged PR #313: URL: https://github.com/apache/openoffice/pull/313 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@openoffice

[PR] Fix up: run `pre-commit run --all-files` [openoffice]

jbampton opened a new pull request, #319: URL: https://github.com/apache/openoffice/pull/319 Only idl files were autofixed locally. `args: [--fix=lf]` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

Re: [PR] pre-commit(end-of-file-fixer): autofix more cxx files in main [openoffice]

Pilot-Pirx merged PR #321: URL: https://github.com/apache/openoffice/pull/321 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@openoffice

[PR] pre-commit(mixed-line-ending): autofix dxp, h, mk, rc files [openoffice]

jbampton opened a new pull request, #325: URL: https://github.com/apache/openoffice/pull/325 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-